* [PATCH 0/2] Fix UBSAN warning in hdcp_info @ 2024-03-27 4:44 Suraj Kandpal 2024-03-27 4:44 ` [PATCH 1/2] drm/i915/display: Initialize capability variables Suraj Kandpal ` (3 more replies) 0 siblings, 4 replies; 8+ messages in thread From: Suraj Kandpal @ 2024-03-27 4:44 UTC (permalink / raw) To: intel-gfx; +Cc: chaitanya.kumar.borah, Suraj Kandpal This patch series fixes the UBSAN warning which gets called when hdcp_info is invoked accompanied by some other logical fixes required in the hdcp capability function. Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com> Suraj Kandpal (2): drm/i915/display: Initialize capability variables drm/i915/hdcp: Fix get remote hdcp capability function drivers/gpu/drm/i915/display/intel_display_debugfs.c | 2 +- drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 9 ++++----- 2 files changed, 5 insertions(+), 6 deletions(-) -- 2.43.2 ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 1/2] drm/i915/display: Initialize capability variables 2024-03-27 4:44 [PATCH 0/2] Fix UBSAN warning in hdcp_info Suraj Kandpal @ 2024-03-27 4:44 ` Suraj Kandpal 2024-03-28 10:22 ` Borah, Chaitanya Kumar 2024-03-27 4:44 ` [PATCH 2/2] drm/i915/hdcp: Fix get remote hdcp capability function Suraj Kandpal ` (2 subsequent siblings) 3 siblings, 1 reply; 8+ messages in thread From: Suraj Kandpal @ 2024-03-27 4:44 UTC (permalink / raw) To: intel-gfx; +Cc: chaitanya.kumar.borah, Suraj Kandpal Initialize HDCP capability variables to false to avoid UBSAN warning in boolean value. --v2 -Fix Typo [Chaitanya] Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com> --- drivers/gpu/drm/i915/display/intel_display_debugfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_display_debugfs.c b/drivers/gpu/drm/i915/display/intel_display_debugfs.c index b99c024b0934..95d14dab089e 100644 --- a/drivers/gpu/drm/i915/display/intel_display_debugfs.c +++ b/drivers/gpu/drm/i915/display/intel_display_debugfs.c @@ -191,7 +191,7 @@ static void intel_hdcp_info(struct seq_file *m, struct intel_connector *intel_connector, bool remote_req) { - bool hdcp_cap, hdcp2_cap; + bool hdcp_cap = false, hdcp2_cap = false; if (!intel_connector->hdcp.shim) { seq_puts(m, "No Connector Support"); -- 2.43.2 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* RE: [PATCH 1/2] drm/i915/display: Initialize capability variables 2024-03-27 4:44 ` [PATCH 1/2] drm/i915/display: Initialize capability variables Suraj Kandpal @ 2024-03-28 10:22 ` Borah, Chaitanya Kumar 0 siblings, 0 replies; 8+ messages in thread From: Borah, Chaitanya Kumar @ 2024-03-28 10:22 UTC (permalink / raw) To: Kandpal, Suraj, intel-gfx Hello > -----Original Message----- > From: Kandpal, Suraj <suraj.kandpal@intel.com> > Sent: Wednesday, March 27, 2024 10:14 AM > To: intel-gfx@lists.freedesktop.org > Cc: Borah, Chaitanya Kumar <chaitanya.kumar.borah@intel.com>; Kandpal, > Suraj <suraj.kandpal@intel.com> > Subject: [PATCH 1/2] drm/i915/display: Initialize capability variables > > Initialize HDCP capability variables to false to avoid UBSAN warning in > boolean value. > Nit: I would add the fact that we need this change because the functions filling up these Booleans may return without actually assigning values to them. Otherwise, LGTM. Reviewed-by: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com> > --v2 > -Fix Typo [Chaitanya] > > Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com> > --- > drivers/gpu/drm/i915/display/intel_display_debugfs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_display_debugfs.c > b/drivers/gpu/drm/i915/display/intel_display_debugfs.c > index b99c024b0934..95d14dab089e 100644 > --- a/drivers/gpu/drm/i915/display/intel_display_debugfs.c > +++ b/drivers/gpu/drm/i915/display/intel_display_debugfs.c > @@ -191,7 +191,7 @@ static void intel_hdcp_info(struct seq_file *m, > struct intel_connector *intel_connector, > bool remote_req) > { > - bool hdcp_cap, hdcp2_cap; > + bool hdcp_cap = false, hdcp2_cap = false; > > if (!intel_connector->hdcp.shim) { > seq_puts(m, "No Connector Support"); > -- > 2.43.2 ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 2/2] drm/i915/hdcp: Fix get remote hdcp capability function 2024-03-27 4:44 [PATCH 0/2] Fix UBSAN warning in hdcp_info Suraj Kandpal 2024-03-27 4:44 ` [PATCH 1/2] drm/i915/display: Initialize capability variables Suraj Kandpal @ 2024-03-27 4:44 ` Suraj Kandpal 2024-03-28 10:26 ` Borah, Chaitanya Kumar 2024-03-27 5:52 ` ✗ Fi.CI.SPARSE: warning for Fix UBSAN warning in hdcp_info Patchwork 2024-03-27 6:05 ` ✗ Fi.CI.BAT: failure " Patchwork 3 siblings, 1 reply; 8+ messages in thread From: Suraj Kandpal @ 2024-03-27 4:44 UTC (permalink / raw) To: intel-gfx; +Cc: chaitanya.kumar.borah, Suraj Kandpal HDCP 1.x capability needs to be checked even if setup is not HDCP 2.x capable. Fixes: 813cca96e4ac ("drm/i915/hdcp: Add new remote capability check shim function") Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com> --- drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_dp_hdcp.c b/drivers/gpu/drm/i915/display/intel_dp_hdcp.c index b98a87883fef..7f52043b0f9f 100644 --- a/drivers/gpu/drm/i915/display/intel_dp_hdcp.c +++ b/drivers/gpu/drm/i915/display/intel_dp_hdcp.c @@ -688,7 +688,7 @@ int intel_dp_hdcp_get_remote_capability(struct intel_connector *connector, { struct drm_i915_private *i915 = to_i915(connector->base.dev); struct drm_dp_aux *aux = &connector->port->aux; - u8 bcaps; + u8 bcaps = 0; int ret; if (!intel_encoder_is_mst(connector->encoder)) @@ -696,15 +696,14 @@ int intel_dp_hdcp_get_remote_capability(struct intel_connector *connector, ret = _intel_dp_hdcp2_get_capability(aux, hdcp2_capable); if (ret) - return ret; + drm_dbg_kms(&i915->drm, + "HDCP2 DPCD capability read failed err: %d\n", ret); ret = intel_dp_hdcp_read_bcaps(aux, i915, &bcaps); - if (ret) - return ret; *hdcp_capable = bcaps & DP_BCAPS_HDCP_CAPABLE; - return 0; + return ret; } static const struct intel_hdcp_shim intel_dp_hdcp_shim = { -- 2.43.2 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* RE: [PATCH 2/2] drm/i915/hdcp: Fix get remote hdcp capability function 2024-03-27 4:44 ` [PATCH 2/2] drm/i915/hdcp: Fix get remote hdcp capability function Suraj Kandpal @ 2024-03-28 10:26 ` Borah, Chaitanya Kumar 2024-03-28 10:51 ` Borah, Chaitanya Kumar 0 siblings, 1 reply; 8+ messages in thread From: Borah, Chaitanya Kumar @ 2024-03-28 10:26 UTC (permalink / raw) To: Kandpal, Suraj, intel-gfx Hello, > -----Original Message----- > From: Kandpal, Suraj <suraj.kandpal@intel.com> > Sent: Wednesday, March 27, 2024 10:14 AM > To: intel-gfx@lists.freedesktop.org > Cc: Borah, Chaitanya Kumar <chaitanya.kumar.borah@intel.com>; Kandpal, > Suraj <suraj.kandpal@intel.com> > Subject: [PATCH 2/2] drm/i915/hdcp: Fix get remote hdcp capability function > > HDCP 1.x capability needs to be checked even if setup is not HDCP 2.x capable. > > Fixes: 813cca96e4ac ("drm/i915/hdcp: Add new remote capability check shim > function") > Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com> > --- > drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_dp_hdcp.c > b/drivers/gpu/drm/i915/display/intel_dp_hdcp.c > index b98a87883fef..7f52043b0f9f 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp_hdcp.c > +++ b/drivers/gpu/drm/i915/display/intel_dp_hdcp.c > @@ -688,7 +688,7 @@ int intel_dp_hdcp_get_remote_capability(struct > intel_connector *connector, { > struct drm_i915_private *i915 = to_i915(connector->base.dev); > struct drm_dp_aux *aux = &connector->port->aux; > - u8 bcaps; > + u8 bcaps = 0; > int ret; > > if (!intel_encoder_is_mst(connector->encoder)) > @@ -696,15 +696,14 @@ int intel_dp_hdcp_get_remote_capability(struct > intel_connector *connector, > > ret = _intel_dp_hdcp2_get_capability(aux, hdcp2_capable); > if (ret) > - return ret; > + drm_dbg_kms(&i915->drm, > + "HDCP2 DPCD capability read failed err: %d\n", ret); > > ret = intel_dp_hdcp_read_bcaps(aux, i915, &bcaps); > - if (ret) > - return ret; > > *hdcp_capable = bcaps & DP_BCAPS_HDCP_CAPABLE; > Let's keep the behavior same for both hdcp_capable and hdcp2_capable in case of failure. Either assign both of them as false, or not assign anything. Regards Chaitanya > - return 0; > + return ret; > } > > static const struct intel_hdcp_shim intel_dp_hdcp_shim = { > -- > 2.43.2 ^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [PATCH 2/2] drm/i915/hdcp: Fix get remote hdcp capability function 2024-03-28 10:26 ` Borah, Chaitanya Kumar @ 2024-03-28 10:51 ` Borah, Chaitanya Kumar 0 siblings, 0 replies; 8+ messages in thread From: Borah, Chaitanya Kumar @ 2024-03-28 10:51 UTC (permalink / raw) To: Kandpal, Suraj, intel-gfx > -----Original Message----- > From: Borah, Chaitanya Kumar > Sent: Thursday, March 28, 2024 3:56 PM > To: Kandpal, Suraj <suraj.kandpal@intel.com>; intel-gfx@lists.freedesktop.org > Subject: RE: [PATCH 2/2] drm/i915/hdcp: Fix get remote hdcp capability > function > > Hello, > > > -----Original Message----- > > From: Kandpal, Suraj <suraj.kandpal@intel.com> > > Sent: Wednesday, March 27, 2024 10:14 AM > > To: intel-gfx@lists.freedesktop.org > > Cc: Borah, Chaitanya Kumar <chaitanya.kumar.borah@intel.com>; Kandpal, > > Suraj <suraj.kandpal@intel.com> > > Subject: [PATCH 2/2] drm/i915/hdcp: Fix get remote hdcp capability > > function > > > > HDCP 1.x capability needs to be checked even if setup is not HDCP 2.x > capable. > > > > Fixes: 813cca96e4ac ("drm/i915/hdcp: Add new remote capability check > > shim > > function") > > Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com> > > --- > > drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 9 ++++----- > > 1 file changed, 4 insertions(+), 5 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/display/intel_dp_hdcp.c > > b/drivers/gpu/drm/i915/display/intel_dp_hdcp.c > > index b98a87883fef..7f52043b0f9f 100644 > > --- a/drivers/gpu/drm/i915/display/intel_dp_hdcp.c > > +++ b/drivers/gpu/drm/i915/display/intel_dp_hdcp.c > > @@ -688,7 +688,7 @@ int intel_dp_hdcp_get_remote_capability(struct > > intel_connector *connector, { > > struct drm_i915_private *i915 = to_i915(connector->base.dev); > > struct drm_dp_aux *aux = &connector->port->aux; > > - u8 bcaps; > > + u8 bcaps = 0; > > int ret; > > > > if (!intel_encoder_is_mst(connector->encoder)) > > @@ -696,15 +696,14 @@ int intel_dp_hdcp_get_remote_capability(struct > > intel_connector *connector, > > > > ret = _intel_dp_hdcp2_get_capability(aux, hdcp2_capable); > > if (ret) > > - return ret; > > + drm_dbg_kms(&i915->drm, > > + "HDCP2 DPCD capability read failed err: %d\n", ret); > > > > ret = intel_dp_hdcp_read_bcaps(aux, i915, &bcaps); > > - if (ret) > > - return ret; > > > > *hdcp_capable = bcaps & DP_BCAPS_HDCP_CAPABLE; > > > > Let's keep the behavior same for both hdcp_capable and hdcp2_capable in > case of failure. > > Either assign both of them as false, or not assign anything. > IMO, assigning them false could be a better approach if you don't see any harm in it. It is not great to be dependent on the semantics of them being initialized first. > Regards > > Chaitanya > > > > > - return 0; > > + return ret; > > } > > > > static const struct intel_hdcp_shim intel_dp_hdcp_shim = { > > -- > > 2.43.2 ^ permalink raw reply [flat|nested] 8+ messages in thread
* ✗ Fi.CI.SPARSE: warning for Fix UBSAN warning in hdcp_info 2024-03-27 4:44 [PATCH 0/2] Fix UBSAN warning in hdcp_info Suraj Kandpal 2024-03-27 4:44 ` [PATCH 1/2] drm/i915/display: Initialize capability variables Suraj Kandpal 2024-03-27 4:44 ` [PATCH 2/2] drm/i915/hdcp: Fix get remote hdcp capability function Suraj Kandpal @ 2024-03-27 5:52 ` Patchwork 2024-03-27 6:05 ` ✗ Fi.CI.BAT: failure " Patchwork 3 siblings, 0 replies; 8+ messages in thread From: Patchwork @ 2024-03-27 5:52 UTC (permalink / raw) To: Suraj Kandpal; +Cc: intel-gfx == Series Details == Series: Fix UBSAN warning in hdcp_info URL : https://patchwork.freedesktop.org/series/131673/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:179:35: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:181:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:181:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:185:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:187:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:191:35: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:194:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:194:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:236:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:238:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:66:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:92:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:100:17: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:100:23: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:100:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:105:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:107:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:108:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:109:9: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:111:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:111:14: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:111:20: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:112:17: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:112:23: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:112:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:121:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:128:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:166:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:168:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:169:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:170:9: warning: unreplaced symbol 'val' +./include/asm-generic/bitops/generic-non-atomic.h:172:19: warning: unreplaced symbol 'val' +./include/asm-generic/bitops/generic-non-atomic.h:172:25: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:172:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:28:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:30:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:31:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:33:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:33:16: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:37:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:39:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:40:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:42:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:42:16: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:55:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:57:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:58:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:60:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:60:15: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:73:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:75:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:76:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:77:9: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:79:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:79:14: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:79:20: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:80:17: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:80:23: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:80:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:93:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:95:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:96:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:97:9: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:99:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:99:14: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:99:21: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/instrumented-non-atomic.h:100:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:112:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:115:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:127:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:130:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:139:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:142:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:26:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:42:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:58:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:97:1: warning: unreplaced symbol 'return' ^ permalink raw reply [flat|nested] 8+ messages in thread
* ✗ Fi.CI.BAT: failure for Fix UBSAN warning in hdcp_info 2024-03-27 4:44 [PATCH 0/2] Fix UBSAN warning in hdcp_info Suraj Kandpal ` (2 preceding siblings ...) 2024-03-27 5:52 ` ✗ Fi.CI.SPARSE: warning for Fix UBSAN warning in hdcp_info Patchwork @ 2024-03-27 6:05 ` Patchwork 3 siblings, 0 replies; 8+ messages in thread From: Patchwork @ 2024-03-27 6:05 UTC (permalink / raw) To: Suraj Kandpal; +Cc: intel-gfx [-- Attachment #1: Type: text/plain, Size: 12818 bytes --] == Series Details == Series: Fix UBSAN warning in hdcp_info URL : https://patchwork.freedesktop.org/series/131673/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14489 -> Patchwork_131673v1 ==================================================== Summary ------- **FAILURE** Serious unknown changes coming with Patchwork_131673v1 absolutely need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in Patchwork_131673v1, please notify your bug team (I915-ci-infra@lists.freedesktop.org) to allow them to document this new failure mode, which will reduce false positives in CI. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_131673v1/index.html Participating hosts (38 -> 36) ------------------------------ Additional (2): bat-dg1-7 fi-kbl-8809g Missing (4): bat-arls-4 bat-mtlp-8 bat-kbl-2 fi-snb-2520m Possible new issues ------------------- Here are the unknown changes that may have been introduced in Patchwork_131673v1: ### IGT changes ### #### Possible regressions #### * igt@i915_selftest@live@sanitycheck: - bat-atsm-1: [PASS][1] -> [INCOMPLETE][2] [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14489/bat-atsm-1/igt@i915_selftest@live@sanitycheck.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_131673v1/bat-atsm-1/igt@i915_selftest@live@sanitycheck.html Known issues ------------ Here are the changes found in Patchwork_131673v1 that come from known issues: ### CI changes ### #### Issues hit #### * boot: - bat-arls-3: [PASS][3] -> [FAIL][4] ([i915#10234]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14489/bat-arls-3/boot.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_131673v1/bat-arls-3/boot.html #### Possible fixes #### * boot: - bat-dg2-11: [FAIL][5] ([i915#10491]) -> [PASS][6] [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14489/bat-dg2-11/boot.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_131673v1/bat-dg2-11/boot.html ### IGT changes ### #### Issues hit #### * igt@gem_lmem_swapping@basic@lmem0: - bat-dg2-11: NOTRUN -> [FAIL][7] ([i915#10378]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_131673v1/bat-dg2-11/igt@gem_lmem_swapping@basic@lmem0.html * igt@gem_mmap@basic: - bat-dg1-7: NOTRUN -> [SKIP][8] ([i915#4083]) [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_131673v1/bat-dg1-7/igt@gem_mmap@basic.html - bat-dg2-11: NOTRUN -> [SKIP][9] ([i915#4083]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_131673v1/bat-dg2-11/igt@gem_mmap@basic.html * igt@gem_tiled_fence_blits@basic: - bat-dg1-7: NOTRUN -> [SKIP][10] ([i915#4077]) +2 other tests skip [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_131673v1/bat-dg1-7/igt@gem_tiled_fence_blits@basic.html - bat-dg2-11: NOTRUN -> [SKIP][11] ([i915#4077]) +2 other tests skip [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_131673v1/bat-dg2-11/igt@gem_tiled_fence_blits@basic.html * igt@gem_tiled_pread_basic: - bat-dg1-7: NOTRUN -> [SKIP][12] ([i915#4079]) +1 other test skip [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_131673v1/bat-dg1-7/igt@gem_tiled_pread_basic.html - bat-dg2-11: NOTRUN -> [SKIP][13] ([i915#4079]) +1 other test skip [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_131673v1/bat-dg2-11/igt@gem_tiled_pread_basic.html * igt@i915_pm_rps@basic-api: - bat-dg1-7: NOTRUN -> [SKIP][14] ([i915#6621]) [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_131673v1/bat-dg1-7/igt@i915_pm_rps@basic-api.html - bat-dg2-11: NOTRUN -> [SKIP][15] ([i915#6621]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_131673v1/bat-dg2-11/igt@i915_pm_rps@basic-api.html * igt@i915_selftest@live@uncore: - bat-dg2-9: [PASS][16] -> [ABORT][17] ([i915#10366]) [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14489/bat-dg2-9/igt@i915_selftest@live@uncore.html [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_131673v1/bat-dg2-9/igt@i915_selftest@live@uncore.html * igt@i915_selftest@live@vma: - bat-dg2-8: [PASS][18] -> [ABORT][19] ([i915#10366]) [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14489/bat-dg2-8/igt@i915_selftest@live@vma.html [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_131673v1/bat-dg2-8/igt@i915_selftest@live@vma.html * igt@kms_addfb_basic@addfb25-x-tiled-mismatch-legacy: - bat-dg1-7: NOTRUN -> [SKIP][20] ([i915#4212]) +7 other tests skip [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_131673v1/bat-dg1-7/igt@kms_addfb_basic@addfb25-x-tiled-mismatch-legacy.html - bat-dg2-11: NOTRUN -> [SKIP][21] ([i915#4212]) +7 other tests skip [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_131673v1/bat-dg2-11/igt@kms_addfb_basic@addfb25-x-tiled-mismatch-legacy.html * igt@kms_addfb_basic@addfb25-y-tiled-small-legacy: - bat-dg2-11: NOTRUN -> [SKIP][22] ([i915#5190]) [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_131673v1/bat-dg2-11/igt@kms_addfb_basic@addfb25-y-tiled-small-legacy.html * igt@kms_addfb_basic@basic-y-tiled-legacy: - bat-dg1-7: NOTRUN -> [SKIP][23] ([i915#4215]) [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_131673v1/bat-dg1-7/igt@kms_addfb_basic@basic-y-tiled-legacy.html - bat-dg2-11: NOTRUN -> [SKIP][24] ([i915#4215] / [i915#5190]) [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_131673v1/bat-dg2-11/igt@kms_addfb_basic@basic-y-tiled-legacy.html * igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic: - bat-dg2-11: NOTRUN -> [SKIP][25] ([i915#4103] / [i915#4213]) +1 other test skip [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_131673v1/bat-dg2-11/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html * igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy: - bat-dg1-7: NOTRUN -> [SKIP][26] ([i915#4103] / [i915#4213]) +1 other test skip [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_131673v1/bat-dg1-7/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html * igt@kms_dsc@dsc-basic: - bat-dg2-11: NOTRUN -> [SKIP][27] ([i915#3555] / [i915#3840]) [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_131673v1/bat-dg2-11/igt@kms_dsc@dsc-basic.html - bat-dg1-7: NOTRUN -> [SKIP][28] ([i915#3555] / [i915#3840]) [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_131673v1/bat-dg1-7/igt@kms_dsc@dsc-basic.html * igt@kms_force_connector_basic@force-load-detect: - bat-dg1-7: NOTRUN -> [SKIP][29] [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_131673v1/bat-dg1-7/igt@kms_force_connector_basic@force-load-detect.html - bat-dg2-11: NOTRUN -> [SKIP][30] [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_131673v1/bat-dg2-11/igt@kms_force_connector_basic@force-load-detect.html * igt@kms_force_connector_basic@prune-stale-modes: - bat-dg2-11: NOTRUN -> [SKIP][31] ([i915#5274]) [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_131673v1/bat-dg2-11/igt@kms_force_connector_basic@prune-stale-modes.html * igt@kms_hdmi_inject@inject-audio: - bat-dg1-7: NOTRUN -> [SKIP][32] ([i915#433]) [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_131673v1/bat-dg1-7/igt@kms_hdmi_inject@inject-audio.html * igt@kms_pm_backlight@basic-brightness: - bat-dg1-7: NOTRUN -> [SKIP][33] ([i915#5354]) [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_131673v1/bat-dg1-7/igt@kms_pm_backlight@basic-brightness.html - bat-dg2-11: NOTRUN -> [SKIP][34] ([i915#5354]) [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_131673v1/bat-dg2-11/igt@kms_pm_backlight@basic-brightness.html * igt@kms_psr@psr-primary-page-flip: - bat-dg1-7: NOTRUN -> [SKIP][35] ([i915#1072] / [i915#9732]) +3 other tests skip [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_131673v1/bat-dg1-7/igt@kms_psr@psr-primary-page-flip.html * igt@kms_psr@psr-sprite-plane-onoff: - bat-dg2-11: NOTRUN -> [SKIP][36] ([i915#1072] / [i915#9732]) +3 other tests skip [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_131673v1/bat-dg2-11/igt@kms_psr@psr-sprite-plane-onoff.html * igt@kms_setmode@basic-clone-single-crtc: - bat-dg2-11: NOTRUN -> [SKIP][37] ([i915#3555]) [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_131673v1/bat-dg2-11/igt@kms_setmode@basic-clone-single-crtc.html - bat-dg1-7: NOTRUN -> [SKIP][38] ([i915#3555]) [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_131673v1/bat-dg1-7/igt@kms_setmode@basic-clone-single-crtc.html * igt@prime_vgem@basic-fence-flip: - bat-dg1-7: NOTRUN -> [SKIP][39] ([i915#3708]) +3 other tests skip [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_131673v1/bat-dg1-7/igt@prime_vgem@basic-fence-flip.html - bat-dg2-11: NOTRUN -> [SKIP][40] ([i915#3708]) [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_131673v1/bat-dg2-11/igt@prime_vgem@basic-fence-flip.html * igt@prime_vgem@basic-fence-mmap: - bat-dg1-7: NOTRUN -> [SKIP][41] ([i915#3708] / [i915#4077]) +1 other test skip [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_131673v1/bat-dg1-7/igt@prime_vgem@basic-fence-mmap.html - bat-dg2-11: NOTRUN -> [SKIP][42] ([i915#3708] / [i915#4077]) +1 other test skip [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_131673v1/bat-dg2-11/igt@prime_vgem@basic-fence-mmap.html * igt@prime_vgem@basic-read: - bat-dg2-11: NOTRUN -> [SKIP][43] ([i915#3291] / [i915#3708]) +2 other tests skip [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_131673v1/bat-dg2-11/igt@prime_vgem@basic-read.html * igt@runner@aborted: - fi-kbl-8809g: NOTRUN -> [FAIL][44] ([i915#4991]) [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_131673v1/fi-kbl-8809g/igt@runner@aborted.html #### Possible fixes #### * igt@i915_selftest@live@ring_submission: - bat-dg2-14: [ABORT][45] ([i915#10366]) -> [PASS][46] [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14489/bat-dg2-14/igt@i915_selftest@live@ring_submission.html [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_131673v1/bat-dg2-14/igt@i915_selftest@live@ring_submission.html [i915#10234]: https://gitlab.freedesktop.org/drm/intel/issues/10234 [i915#10366]: https://gitlab.freedesktop.org/drm/intel/issues/10366 [i915#10378]: https://gitlab.freedesktop.org/drm/intel/issues/10378 [i915#10491]: https://gitlab.freedesktop.org/drm/intel/issues/10491 [i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072 [i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291 [i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555 [i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708 [i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840 [i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077 [i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079 [i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083 [i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103 [i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212 [i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213 [i915#4215]: https://gitlab.freedesktop.org/drm/intel/issues/4215 [i915#433]: https://gitlab.freedesktop.org/drm/intel/issues/433 [i915#4991]: https://gitlab.freedesktop.org/drm/intel/issues/4991 [i915#5190]: https://gitlab.freedesktop.org/drm/intel/issues/5190 [i915#5274]: https://gitlab.freedesktop.org/drm/intel/issues/5274 [i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354 [i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621 [i915#9732]: https://gitlab.freedesktop.org/drm/intel/issues/9732 Build changes ------------- * Linux: CI_DRM_14489 -> Patchwork_131673v1 CI-20190529: 20190529 CI_DRM_14489: f9c56f1a03b5c35488671e4ffe61e28b12ffe163 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_7785: 7785 Patchwork_131673v1: f9c56f1a03b5c35488671e4ffe61e28b12ffe163 @ git://anongit.freedesktop.org/gfx-ci/linux ### Linux commits 8ab9c397640e drm/i915/hdcp: Fix get remote hdcp capability function 799d49966cc8 drm/i915/display: Initialize capability variables == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_131673v1/index.html [-- Attachment #2: Type: text/html, Size: 15778 bytes --] ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2024-03-28 10:51 UTC | newest] Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2024-03-27 4:44 [PATCH 0/2] Fix UBSAN warning in hdcp_info Suraj Kandpal 2024-03-27 4:44 ` [PATCH 1/2] drm/i915/display: Initialize capability variables Suraj Kandpal 2024-03-28 10:22 ` Borah, Chaitanya Kumar 2024-03-27 4:44 ` [PATCH 2/2] drm/i915/hdcp: Fix get remote hdcp capability function Suraj Kandpal 2024-03-28 10:26 ` Borah, Chaitanya Kumar 2024-03-28 10:51 ` Borah, Chaitanya Kumar 2024-03-27 5:52 ` ✗ Fi.CI.SPARSE: warning for Fix UBSAN warning in hdcp_info Patchwork 2024-03-27 6:05 ` ✗ Fi.CI.BAT: failure " Patchwork
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.