All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/xe/uapi: Define topology types as indexes rather than masks
@ 2024-03-28 14:02 Francois Dugast
  2024-03-28 14:14 ` Lucas De Marchi
                   ` (8 more replies)
  0 siblings, 9 replies; 10+ messages in thread
From: Francois Dugast @ 2024-03-28 14:02 UTC (permalink / raw)
  To: intel-xe; +Cc: Francois Dugast, Lucas De Marchi, Matt Roper

The topology type is an index (not a mask) so define the values
like other indexes instead of using powers of 2. This is also
to make clear that the next type can use value 3. This commit
does not change the existing values so it does not break
compatibility.

Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Suggested-by: Matt Roper <matthew.d.roper@intel.com>
Signed-off-by: Francois Dugast <francois.dugast@intel.com>
Link: https://lore.kernel.org/intel-xe/20240327232317.GI718896@mdroper-desk1.amr.corp.intel.com/
---
 include/uapi/drm/xe_drm.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/include/uapi/drm/xe_drm.h b/include/uapi/drm/xe_drm.h
index 808ad1c308ec..95a8ecca21f4 100644
--- a/include/uapi/drm/xe_drm.h
+++ b/include/uapi/drm/xe_drm.h
@@ -518,9 +518,9 @@ struct drm_xe_query_topology_mask {
 	/** @gt_id: GT ID the mask is associated with */
 	__u16 gt_id;
 
-#define DRM_XE_TOPO_DSS_GEOMETRY	(1 << 0)
-#define DRM_XE_TOPO_DSS_COMPUTE		(1 << 1)
-#define DRM_XE_TOPO_EU_PER_DSS		(1 << 2)
+#define DRM_XE_TOPO_DSS_GEOMETRY	1
+#define DRM_XE_TOPO_DSS_COMPUTE		2
+#define DRM_XE_TOPO_EU_PER_DSS		4
 	/** @type: type of mask */
 	__u16 type;
 
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2024-03-29  0:01 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-28 14:02 [PATCH] drm/xe/uapi: Define topology types as indexes rather than masks Francois Dugast
2024-03-28 14:14 ` Lucas De Marchi
2024-03-28 17:50 ` ✓ CI.Patch_applied: success for " Patchwork
2024-03-28 17:51 ` ✓ CI.checkpatch: " Patchwork
2024-03-28 17:52 ` ✓ CI.KUnit: " Patchwork
2024-03-28 18:12 ` ✓ CI.Build: " Patchwork
2024-03-28 18:14 ` ✓ CI.Hooks: " Patchwork
2024-03-28 18:16 ` ✓ CI.checksparse: " Patchwork
2024-03-28 18:55 ` ✓ CI.BAT: " Patchwork
2024-03-29  0:01 ` [PATCH] " Lucas De Marchi

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.