* [PATCH] tools/resolve_btfids: fix build with musl libc
@ 2024-03-28 10:59 Natanael Copa
2024-03-28 16:18 ` Greg Thelen
2024-03-29 2:00 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 4+ messages in thread
From: Natanael Copa @ 2024-03-28 10:59 UTC (permalink / raw)
To: bpf
Cc: Natanael Copa, stable, Viktor Malik, Daniel Xu,
Alexei Starovoitov, Nick Desaulniers, Andrii Nakryiko,
linux-kernel
Include the header that defines u32.
Fixes: 9707ac4fe2f5 ("tools/resolve_btfids: Refactor set sorting with types from btf_ids.h")
Closes: https://bugzilla.kernel.org/show_bug.cgi?id=218647
Cc: stable@vger.kernel.org
Signed-off-by: Natanael Copa <ncopa@alpinelinux.org>
---
This fixes build of 6.6.23 and 6.1.83 kernels for Alpine Linux, which
uses musl libc. I assume that GNU libc indirecly pulls in linux/types.h.
tools/include/linux/btf_ids.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tools/include/linux/btf_ids.h b/tools/include/linux/btf_ids.h
index 72535f00572f..72ea363d434d 100644
--- a/tools/include/linux/btf_ids.h
+++ b/tools/include/linux/btf_ids.h
@@ -3,6 +3,8 @@
#ifndef _LINUX_BTF_IDS_H
#define _LINUX_BTF_IDS_H
+#include <linux/types.h> /* for u32 */
+
struct btf_id_set {
u32 cnt;
u32 ids[];
--
2.44.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] tools/resolve_btfids: fix build with musl libc
2024-03-28 10:59 [PATCH] tools/resolve_btfids: fix build with musl libc Natanael Copa
@ 2024-03-28 16:18 ` Greg Thelen
2024-03-29 1:59 ` Alexei Starovoitov
2024-03-29 2:00 ` patchwork-bot+netdevbpf
1 sibling, 1 reply; 4+ messages in thread
From: Greg Thelen @ 2024-03-28 16:18 UTC (permalink / raw)
To: Natanael Copa, bpf
Cc: Natanael Copa, stable, Viktor Malik, Daniel Xu,
Alexei Starovoitov, Nick Desaulniers, Andrii Nakryiko,
linux-kernel, Khazhy Kumykov, Dmitrii Bundin
Natanael Copa <ncopa@alpinelinux.org> wrote:
> Include the header that defines u32.
> Fixes: 9707ac4fe2f5 ("tools/resolve_btfids: Refactor set sorting with
> types from btf_ids.h")
> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=218647
Tested-by: Greg Thelen <gthelen@google.com>
> Cc: stable@vger.kernel.org
> Signed-off-by: Natanael Copa <ncopa@alpinelinux.org>
> ---
> This fixes build of 6.6.23 and 6.1.83 kernels for Alpine Linux, which
> uses musl libc. I assume that GNU libc indirecly pulls in linux/types.h.
> tools/include/linux/btf_ids.h | 2 ++
> 1 file changed, 2 insertions(+)
> diff --git a/tools/include/linux/btf_ids.h b/tools/include/linux/btf_ids.h
> index 72535f00572f..72ea363d434d 100644
> --- a/tools/include/linux/btf_ids.h
> +++ b/tools/include/linux/btf_ids.h
> @@ -3,6 +3,8 @@
> #ifndef _LINUX_BTF_IDS_H
> #define _LINUX_BTF_IDS_H
> +#include <linux/types.h> /* for u32 */
> +
> struct btf_id_set {
> u32 cnt;
> u32 ids[];
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] tools/resolve_btfids: fix build with musl libc
2024-03-28 16:18 ` Greg Thelen
@ 2024-03-29 1:59 ` Alexei Starovoitov
0 siblings, 0 replies; 4+ messages in thread
From: Alexei Starovoitov @ 2024-03-29 1:59 UTC (permalink / raw)
To: Greg Thelen
Cc: Natanael Copa, bpf, stable, Viktor Malik, Daniel Xu,
Alexei Starovoitov, Nick Desaulniers, Andrii Nakryiko,
linux-kernel, Khazhy Kumykov, Dmitrii Bundin, Gaosheng Cui
On Thu, Mar 28, 2024 at 9:18 AM Greg Thelen <gthelen@google.com> wrote:
>
> Natanael Copa <ncopa@alpinelinux.org> wrote:
>
> > Include the header that defines u32.
>
> > Fixes: 9707ac4fe2f5 ("tools/resolve_btfids: Refactor set sorting with
> > types from btf_ids.h")
> > Closes: https://bugzilla.kernel.org/show_bug.cgi?id=218647
>
> Tested-by: Greg Thelen <gthelen@google.com>
>
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Natanael Copa <ncopa@alpinelinux.org>
> > ---
> > This fixes build of 6.6.23 and 6.1.83 kernels for Alpine Linux, which
> > uses musl libc. I assume that GNU libc indirecly pulls in linux/types.h.
Ok. Applied to bpf tree and added the above explanation to commit log.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] tools/resolve_btfids: fix build with musl libc
2024-03-28 10:59 [PATCH] tools/resolve_btfids: fix build with musl libc Natanael Copa
2024-03-28 16:18 ` Greg Thelen
@ 2024-03-29 2:00 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-03-29 2:00 UTC (permalink / raw)
To: Natanael Copa
Cc: bpf, stable, vmalik, dxu, ast, ndesaulniers, andrii, linux-kernel
Hello:
This patch was applied to bpf/bpf.git (master)
by Alexei Starovoitov <ast@kernel.org>:
On Thu, 28 Mar 2024 11:59:13 +0100 you wrote:
> Include the header that defines u32.
>
> Fixes: 9707ac4fe2f5 ("tools/resolve_btfids: Refactor set sorting with types from btf_ids.h")
> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=218647
> Cc: stable@vger.kernel.org
> Signed-off-by: Natanael Copa <ncopa@alpinelinux.org>
>
> [...]
Here is the summary with links:
- tools/resolve_btfids: fix build with musl libc
https://git.kernel.org/bpf/bpf/c/62248b22d01e
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-03-29 2:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-28 10:59 [PATCH] tools/resolve_btfids: fix build with musl libc Natanael Copa
2024-03-28 16:18 ` Greg Thelen
2024-03-29 1:59 ` Alexei Starovoitov
2024-03-29 2:00 ` patchwork-bot+netdevbpf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.