All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2 0/3] Rework work queue usage
@ 2024-04-01 22:19 Matthew Brost
  2024-04-01 22:19 ` [PATCH v2 1/3] drm/xe: Use ordered wq for preempt fence waiting Matthew Brost
                   ` (9 more replies)
  0 siblings, 10 replies; 14+ messages in thread
From: Matthew Brost @ 2024-04-01 22:19 UTC (permalink / raw)
  To: intel-xe; +Cc: lucas.demarchi, Matthew Brost

Avoid sleeping or grabbing locks in work queues shared with the system.
Recent changes to work queues [1] have exposed deadlocks [2] in Xe.

I believe only patch #1 is required to unblock CI in 6.9rc1 [2] but
likely all patches should be included in stable kernels.

Matt

[1] https://lore.kernel.org/lkml/Ze7Jz9cQcUMtCqfk@slm.duckdns.org/
[2] https://intel-gfx-ci.01.org/tree/intel-xe/xe-984-093d82c02921344d8d400989af156aaf79b9d961/bat-adlp-7/igt_runner0.txt

Matthew Brost (3):
  drm/xe: Use ordered wq for preempt fence waiting
  drm/xe: Use device, gt ordered work queues for resource cleanup
  drm/xe: Use ordered WQ for TLB invalidation fences

 drivers/gpu/drm/xe/xe_device.c        | 11 ++++++++++-
 drivers/gpu/drm/xe/xe_device_types.h  |  8 +++++++-
 drivers/gpu/drm/xe/xe_execlist.c      |  2 +-
 drivers/gpu/drm/xe/xe_gt_types.h      |  5 ++++-
 drivers/gpu/drm/xe/xe_guc_submit.c    |  2 +-
 drivers/gpu/drm/xe/xe_preempt_fence.c |  2 +-
 drivers/gpu/drm/xe/xe_pt.c            |  2 +-
 drivers/gpu/drm/xe/xe_vm.c            |  4 ++--
 8 files changed, 27 insertions(+), 9 deletions(-)

-- 
2.34.1


^ permalink raw reply	[flat|nested] 14+ messages in thread
* [PATCH 0/3] Rework work queue usage
@ 2024-03-28 18:21 Matthew Brost
  2024-03-29  2:16 ` ✓ CI.checksparse: success for " Patchwork
  0 siblings, 1 reply; 14+ messages in thread
From: Matthew Brost @ 2024-03-28 18:21 UTC (permalink / raw)
  To: intel-xe; +Cc: thomas.hellstrom, rodrigo.vivi, lucas.demarchi, Matthew Brost

Avoid sleeping or grabbing locks in work queues shared with the system.
Recent changes to work queues [1] have exposed deadlocks [2] in Xe.

I believe only patch #1 is required to unblock CI in 6.9rc1 [2] but
likely all patches should be included in stable kernels.

Matt

[1] https://lore.kernel.org/lkml/Ze7Jz9cQcUMtCqfk@slm.duckdns.org/
[2] https://intel-gfx-ci.01.org/tree/intel-xe/xe-984-093d82c02921344d8d400989af156aaf79b9d961/bat-adlp-7/igt_runner0.txt

Matthew Brost (3):
  drm/xe: Use ordered wq for preempt fence waiting
  drm/xe: Use device, gt ordered work queues for resource cleanup
  drm/xe: Use ordered WQ for TLB invalidation fences

 drivers/gpu/drm/xe/xe_device.c        | 7 ++++++-
 drivers/gpu/drm/xe/xe_device_types.h  | 8 +++++++-
 drivers/gpu/drm/xe/xe_execlist.c      | 2 +-
 drivers/gpu/drm/xe/xe_gt_types.h      | 5 ++++-
 drivers/gpu/drm/xe/xe_guc_submit.c    | 2 +-
 drivers/gpu/drm/xe/xe_preempt_fence.c | 2 +-
 drivers/gpu/drm/xe/xe_pt.c            | 2 +-
 drivers/gpu/drm/xe/xe_vm.c            | 4 ++--
 8 files changed, 23 insertions(+), 9 deletions(-)

-- 
2.34.1


^ permalink raw reply	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2024-04-03 14:13 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-01 22:19 [PATCH v2 0/3] Rework work queue usage Matthew Brost
2024-04-01 22:19 ` [PATCH v2 1/3] drm/xe: Use ordered wq for preempt fence waiting Matthew Brost
2024-04-02  5:14   ` Lucas De Marchi
2024-04-03 14:13     ` Lucas De Marchi
2024-04-01 22:19 ` [PATCH v2 2/3] drm/xe: Use device, gt ordered work queues for resource cleanup Matthew Brost
2024-04-01 22:19 ` [PATCH v2 3/3] drm/xe: Use ordered WQ for TLB invalidation fences Matthew Brost
2024-04-01 22:24 ` ✓ CI.Patch_applied: success for Rework work queue usage Patchwork
2024-04-01 22:24 ` ✓ CI.checkpatch: " Patchwork
2024-04-01 22:25 ` ✓ CI.KUnit: " Patchwork
2024-04-01 22:36 ` ✓ CI.Build: " Patchwork
2024-04-01 22:39 ` ✓ CI.Hooks: " Patchwork
2024-04-01 22:41 ` ✓ CI.checksparse: " Patchwork
2024-04-01 23:17 ` ✓ CI.BAT: " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2024-03-28 18:21 [PATCH 0/3] " Matthew Brost
2024-03-29  2:16 ` ✓ CI.checksparse: success for " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.