From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> To: linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 4/4] ARM: shmobile: r7s72100: use workaround for non DT-clocks Date: Sun, 02 Mar 2014 22:21:40 +0000 [thread overview] Message-ID: <1712106.fu6iC2mT2W@avalon> (raw) In-Reply-To: <1393621768-12568-5-git-send-email-wsa@the-dreams.de> Hi Wolfram, Thank you for the patch. On Friday 28 February 2014 22:09:28 Wolfram Sang wrote: > From: Wolfram Sang <wsa@sang-engineering.com> > > SCIF2 and MTU2 are not yet prepared for DT usage, so use the common > workaround via clkdev for now. What about adding a DT node for the serial port instead ? :-) > Signed-off-by: Wolfram Sang <wsa@sang-engineering.com> > --- > arch/arm/mach-shmobile/board-genmai-reference.c | 15 +++++++++++++-- > 1 file changed, 13 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/mach-shmobile/board-genmai-reference.c > b/arch/arm/mach-shmobile/board-genmai-reference.c index 7630c10..91dcdd0 > 100644 > --- a/arch/arm/mach-shmobile/board-genmai-reference.c > +++ b/arch/arm/mach-shmobile/board-genmai-reference.c > @@ -18,18 +18,29 @@ > * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 > USA */ > > -#include <linux/clk-provider.h> > #include <linux/kernel.h> > #include <linux/of_platform.h> > +#include <mach/clock.h> > #include <mach/common.h> > #include <mach/r7s72100.h> > #include <asm/mach-types.h> > #include <asm/mach/arch.h> > > +#ifdef CONFIG_COMMON_CLK > +/* > + * This is a really crude hack to provide clkdev support to platform > + * devices until they get moved to DT. > + */ > +static const struct clk_name clk_names[] = { > + { "mtu2", NULL, "sh_mtu2.0" }, > + { "scif2", NULL, "sh-sci.2" }, > +}; > +#endif > + > static void __init genmai_add_standard_devices(void) > { > #ifdef CONFIG_COMMON_CLK > - of_clk_init(NULL); > + shmobile_clk_workaround(clk_names, ARRAY_SIZE(clk_names), true); > #else > r7s72100_clock_init(); > #endif -- Regards, Laurent Pinchart
WARNING: multiple messages have this Message-ID (diff)
From: laurent.pinchart@ideasonboard.com (Laurent Pinchart) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 4/4] ARM: shmobile: r7s72100: use workaround for non DT-clocks Date: Sun, 02 Mar 2014 23:21:40 +0100 [thread overview] Message-ID: <1712106.fu6iC2mT2W@avalon> (raw) In-Reply-To: <1393621768-12568-5-git-send-email-wsa@the-dreams.de> Hi Wolfram, Thank you for the patch. On Friday 28 February 2014 22:09:28 Wolfram Sang wrote: > From: Wolfram Sang <wsa@sang-engineering.com> > > SCIF2 and MTU2 are not yet prepared for DT usage, so use the common > workaround via clkdev for now. What about adding a DT node for the serial port instead ? :-) > Signed-off-by: Wolfram Sang <wsa@sang-engineering.com> > --- > arch/arm/mach-shmobile/board-genmai-reference.c | 15 +++++++++++++-- > 1 file changed, 13 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/mach-shmobile/board-genmai-reference.c > b/arch/arm/mach-shmobile/board-genmai-reference.c index 7630c10..91dcdd0 > 100644 > --- a/arch/arm/mach-shmobile/board-genmai-reference.c > +++ b/arch/arm/mach-shmobile/board-genmai-reference.c > @@ -18,18 +18,29 @@ > * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 > USA */ > > -#include <linux/clk-provider.h> > #include <linux/kernel.h> > #include <linux/of_platform.h> > +#include <mach/clock.h> > #include <mach/common.h> > #include <mach/r7s72100.h> > #include <asm/mach-types.h> > #include <asm/mach/arch.h> > > +#ifdef CONFIG_COMMON_CLK > +/* > + * This is a really crude hack to provide clkdev support to platform > + * devices until they get moved to DT. > + */ > +static const struct clk_name clk_names[] = { > + { "mtu2", NULL, "sh_mtu2.0" }, > + { "scif2", NULL, "sh-sci.2" }, > +}; > +#endif > + > static void __init genmai_add_standard_devices(void) > { > #ifdef CONFIG_COMMON_CLK > - of_clk_init(NULL); > + shmobile_clk_workaround(clk_names, ARRAY_SIZE(clk_names), true); > #else > r7s72100_clock_init(); > #endif -- Regards, Laurent Pinchart
next prev parent reply other threads:[~2014-03-02 22:21 UTC|newest] Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-02-28 21:09 [PATCH 0/4] CCF support for Renesas r7s72100 Wolfram Sang 2014-02-28 21:09 ` Wolfram Sang 2014-02-28 21:09 ` [PATCH 1/4] ARM: r7s72100: add clock nodes to dtsi Wolfram Sang 2014-02-28 21:09 ` Wolfram Sang 2014-02-28 21:09 ` [PATCH 2/4] ARM: r7s72100: genmai: populate extal clock node Wolfram Sang 2014-02-28 21:09 ` Wolfram Sang 2014-02-28 21:09 ` [PATCH 3/4] clk: shmobile: add CPG driver for rz-platforms Wolfram Sang 2014-02-28 21:09 ` Wolfram Sang 2014-03-02 22:15 ` Laurent Pinchart 2014-03-02 22:15 ` Laurent Pinchart 2014-03-03 9:19 ` Wolfram Sang 2014-03-03 9:19 ` Wolfram Sang 2014-03-03 10:59 ` Laurent Pinchart 2014-03-03 10:59 ` Laurent Pinchart 2014-03-03 16:27 ` Wolfram Sang 2014-03-03 16:27 ` Wolfram Sang 2014-03-04 11:02 ` Laurent Pinchart 2014-03-04 11:02 ` Laurent Pinchart 2014-03-04 11:07 ` Wolfram Sang 2014-03-04 11:07 ` Wolfram Sang 2014-03-04 11:13 ` Laurent Pinchart 2014-03-04 11:13 ` Laurent Pinchart 2014-03-04 11:56 ` Wolfram Sang 2014-03-04 11:56 ` Wolfram Sang 2014-03-05 13:54 ` Wolfram Sang 2014-03-05 13:54 ` Wolfram Sang 2014-03-05 13:59 ` Laurent Pinchart 2014-03-05 13:59 ` Laurent Pinchart 2014-03-05 15:07 ` Wolfram Sang 2014-03-05 15:07 ` Wolfram Sang 2014-02-28 21:09 ` [PATCH 4/4] ARM: shmobile: r7s72100: use workaround for non DT-clocks Wolfram Sang 2014-02-28 21:09 ` Wolfram Sang 2014-03-02 22:21 ` Laurent Pinchart [this message] 2014-03-02 22:21 ` Laurent Pinchart 2014-03-03 9:22 ` Wolfram Sang 2014-03-03 9:22 ` Wolfram Sang 2014-03-03 10:58 ` Laurent Pinchart 2014-03-03 11:00 ` Laurent Pinchart
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1712106.fu6iC2mT2W@avalon \ --to=laurent.pinchart@ideasonboard.com \ --cc=linux-arm-kernel@lists.infradead.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.