From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> To: Philippe CORNU <philippe.cornu@st.com> Cc: Archit Taneja <architt@codeaurora.org>, Andrzej Hajda <a.hajda@samsung.com>, David Airlie <airlied@linux.ie>, Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Yannick FERTRE <yannick.fertre@st.com>, Benjamin Gaignard <benjamin.gaignard@linaro.org>, Alexandre TORGUE <alexandre.torgue@st.com> Subject: Re: [PATCH 1/2] dt-bindings/display/bridge: sii902x: add optional power supplies Date: Thu, 19 Apr 2018 14:09:52 +0300 [thread overview] Message-ID: <1733412.i2Wslp7VkI@avalon> (raw) In-Reply-To: <e709e4f7-2266-f99f-5864-5a8c037dbdc2@st.com> Hi Philippe, On Thursday, 19 April 2018 12:31:15 EEST Philippe CORNU wrote: > On 04/19/2018 10:11 AM, Laurent Pinchart wrote: > > On Tuesday, 10 April 2018 08:19:26 EEST Philippe Cornu wrote: > > > >> Add the 3 optional power supplies using the exact description > >> found in the document named > >> "SiI9022A/SiI9024A HDMI Transmitter Data Sheet (August 2016)". > >> > >> Signed-off-by: Philippe Cornu <philippe.cornu@st.com> > >> --- > >> > >> Documentation/devicetree/bindings/display/bridge/sii902x.txt | 3 +++ > >> 1 file changed, 3 insertions(+) > >> > >> diff --git > >> a/Documentation/devicetree/bindings/display/bridge/sii902x.txt > >> b/Documentation/devicetree/bindings/display/bridge/sii902x.txt index > >> 56a3e68ccb80..cf53678fe574 100644 > >> --- a/Documentation/devicetree/bindings/display/bridge/sii902x.txt > >> +++ b/Documentation/devicetree/bindings/display/bridge/sii902x.txt > >> @@ -8,6 +8,9 @@ Optional properties: > >> - interrupts-extended or interrupt-parent + interrupts: describe > >> the interrupt line used to inform the host about hotplug events. > >> - reset-gpios: OF device-tree gpio specification for RST_N pin. > >> + - iovcc-supply: I/O supply voltage (1.8V or 3.3V, host-dependent). > >> + - avcc12-supply: TMDS analog supply voltage (1.2V). > >> + - cvcc12-supply: Digital core supply voltage (1.2V). > > > > It seems that the AVCC12 and CVCC12 power supplies are usually derived > > from the same source. How about starting with one DT property for both, > > and adding a second one later if needed ? > > Well, I do not know what is the best. Here I took the description from > the documentation, and to allow all possible board configurations, I > added these supplies as "optional" properties: if there is only one 1v2 > regulator on the board, the dt will contain only avcc12 or cvcc12 and > everything will work fine (we will have a dummy regulator for the > missing optional 1v2 reg), if both regulators are there for any reasons > (stability, noise, whatever...) then both entries will be in the dt. > > If you confirm you prefer a single 1v2 supply (named for instance > "vcc12-supply") then I will do :-) Please see https://lists.freedesktop.org/archives/dri-devel/2018-April/ 172400.html (and the messages that lead to it) and https:// lists.freedesktop.org/archives/dri-devel/2018-March/170763.html. > >> Optional subnodes: > >> - video input: this subnode can contain a video input port node -- Regards, Laurent Pinchart
WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> To: Philippe CORNU <philippe.cornu@st.com> Cc: Mark Rutland <mark.rutland@arm.com>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, Alexandre TORGUE <alexandre.torgue@st.com>, David Airlie <airlied@linux.ie>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>, Yannick FERTRE <yannick.fertre@st.com>, Rob Herring <robh+dt@kernel.org> Subject: Re: [PATCH 1/2] dt-bindings/display/bridge: sii902x: add optional power supplies Date: Thu, 19 Apr 2018 14:09:52 +0300 [thread overview] Message-ID: <1733412.i2Wslp7VkI@avalon> (raw) In-Reply-To: <e709e4f7-2266-f99f-5864-5a8c037dbdc2@st.com> Hi Philippe, On Thursday, 19 April 2018 12:31:15 EEST Philippe CORNU wrote: > On 04/19/2018 10:11 AM, Laurent Pinchart wrote: > > On Tuesday, 10 April 2018 08:19:26 EEST Philippe Cornu wrote: > > > >> Add the 3 optional power supplies using the exact description > >> found in the document named > >> "SiI9022A/SiI9024A HDMI Transmitter Data Sheet (August 2016)". > >> > >> Signed-off-by: Philippe Cornu <philippe.cornu@st.com> > >> --- > >> > >> Documentation/devicetree/bindings/display/bridge/sii902x.txt | 3 +++ > >> 1 file changed, 3 insertions(+) > >> > >> diff --git > >> a/Documentation/devicetree/bindings/display/bridge/sii902x.txt > >> b/Documentation/devicetree/bindings/display/bridge/sii902x.txt index > >> 56a3e68ccb80..cf53678fe574 100644 > >> --- a/Documentation/devicetree/bindings/display/bridge/sii902x.txt > >> +++ b/Documentation/devicetree/bindings/display/bridge/sii902x.txt > >> @@ -8,6 +8,9 @@ Optional properties: > >> - interrupts-extended or interrupt-parent + interrupts: describe > >> the interrupt line used to inform the host about hotplug events. > >> - reset-gpios: OF device-tree gpio specification for RST_N pin. > >> + - iovcc-supply: I/O supply voltage (1.8V or 3.3V, host-dependent). > >> + - avcc12-supply: TMDS analog supply voltage (1.2V). > >> + - cvcc12-supply: Digital core supply voltage (1.2V). > > > > It seems that the AVCC12 and CVCC12 power supplies are usually derived > > from the same source. How about starting with one DT property for both, > > and adding a second one later if needed ? > > Well, I do not know what is the best. Here I took the description from > the documentation, and to allow all possible board configurations, I > added these supplies as "optional" properties: if there is only one 1v2 > regulator on the board, the dt will contain only avcc12 or cvcc12 and > everything will work fine (we will have a dummy regulator for the > missing optional 1v2 reg), if both regulators are there for any reasons > (stability, noise, whatever...) then both entries will be in the dt. > > If you confirm you prefer a single 1v2 supply (named for instance > "vcc12-supply") then I will do :-) Please see https://lists.freedesktop.org/archives/dri-devel/2018-April/ 172400.html (and the messages that lead to it) and https:// lists.freedesktop.org/archives/dri-devel/2018-March/170763.html. > >> Optional subnodes: > >> - video input: this subnode can contain a video input port node -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-04-19 11:09 UTC|newest] Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-04-10 5:19 [PATCH 0/2] drm/bridge: sii902x: add optional power supplies Philippe Cornu 2018-04-10 5:19 ` Philippe Cornu 2018-04-10 5:19 ` [PATCH 1/2] dt-bindings/display/bridge: " Philippe Cornu 2018-04-10 5:19 ` Philippe Cornu 2018-04-13 17:58 ` Rob Herring 2018-04-13 17:58 ` Rob Herring 2018-04-19 8:11 ` Laurent Pinchart 2018-04-19 8:11 ` Laurent Pinchart 2018-04-19 9:31 ` Philippe CORNU 2018-04-19 9:31 ` Philippe CORNU 2018-04-19 11:09 ` Laurent Pinchart [this message] 2018-04-19 11:09 ` Laurent Pinchart 2018-04-19 12:41 ` Philippe CORNU 2018-04-19 12:41 ` Philippe CORNU 2018-04-19 12:50 ` Laurent Pinchart 2018-04-10 5:19 ` [PATCH 2/2] drm/bridge: " Philippe Cornu 2018-04-10 5:19 ` Philippe Cornu 2018-04-16 9:20 ` Yannick FERTRE 2018-04-19 8:20 ` Laurent Pinchart 2018-04-19 8:20 ` Laurent Pinchart 2018-04-19 9:46 ` Philippe CORNU 2018-04-19 9:46 ` Philippe CORNU 2018-04-19 11:00 ` Laurent Pinchart 2018-04-19 11:00 ` Laurent Pinchart
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1733412.i2Wslp7VkI@avalon \ --to=laurent.pinchart@ideasonboard.com \ --cc=a.hajda@samsung.com \ --cc=airlied@linux.ie \ --cc=alexandre.torgue@st.com \ --cc=architt@codeaurora.org \ --cc=benjamin.gaignard@linaro.org \ --cc=devicetree@vger.kernel.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=philippe.cornu@st.com \ --cc=robh+dt@kernel.org \ --cc=yannick.fertre@st.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.