From: Jason Wang <jasowang@redhat.com>
To: Zhang Chen <zhangchen.fnst@cn.fujitsu.com>,
qemu devel <qemu-devel@nongnu.org>
Cc: Li Zhijian <lizhijian@cn.fujitsu.com>,
zhanghailiang <zhang.zhanghailiang@huawei.com>
Subject: Re: [Qemu-devel] [PATCH V2 2/4] net/colo-compare.c: Compare the tcp packets that has the same sequence number
Date: Fri, 14 Jul 2017 11:25:49 +0800 [thread overview]
Message-ID: <174a3db3-6a14-edbb-641a-e93746c51861@redhat.com> (raw)
In-Reply-To: <1499925175-21218-3-git-send-email-zhangchen.fnst@cn.fujitsu.com>
On 2017年07月13日 13:52, Zhang Chen wrote:
> If primary packet's sequence number not same with secondary packet's
> sequence number, no need to compare the packet other field.
>
> Signed-off-by: Zhang Chen <zhangchen.fnst@cn.fujitsu.com>
> ---
> net/colo-compare.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/net/colo-compare.c b/net/colo-compare.c
> index 0f8e198..2caeb80 100644
> --- a/net/colo-compare.c
> +++ b/net/colo-compare.c
> @@ -222,6 +222,12 @@ static int colo_packet_compare_tcp(Packet *spkt, Packet *ppkt)
> ptcp = (struct tcphdr *)ppkt->transport_header;
> stcp = (struct tcphdr *)spkt->transport_header;
>
> + if ((ptcp->th_flags & TH_SYN) != TH_SYN &&
> + ptcp->th_seq != stcp->th_seq) {
> + trace_colo_compare_main("colo_packet_compare_tcp seq not same");
> + return -1;
> + }
> +
> /*
> * The 'identification' field in the IP header is *very* random
> * it almost never matches. Fudge this by ignoring differences in
Do we have any statistics numbers for this?
Thanks
next prev parent reply other threads:[~2017-07-14 3:25 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-13 5:52 [Qemu-devel] [PATCH V2 0/4] Optimize COLO-compare performance Zhang Chen
2017-07-13 5:52 ` [Qemu-devel] [PATCH V2 1/4] net/colo-compare.c: Add checkpoint min period to optimize performance Zhang Chen
2017-07-14 3:22 ` Jason Wang
2017-07-17 6:42 ` Zhang Chen
2017-07-14 12:10 ` Dr. David Alan Gilbert
2017-07-17 9:33 ` Zhang Chen
2017-07-17 12:24 ` Dr. David Alan Gilbert
2017-07-18 2:20 ` Zhang Chen
2017-07-13 5:52 ` [Qemu-devel] [PATCH V2 2/4] net/colo-compare.c: Compare the tcp packets that has the same sequence number Zhang Chen
2017-07-14 3:25 ` Jason Wang [this message]
2017-07-17 7:39 ` Zhang Chen
2017-07-17 8:55 ` Dr. David Alan Gilbert
2017-07-17 9:23 ` Zhang Chen
2017-07-17 10:02 ` Dr. David Alan Gilbert
2017-07-14 12:24 ` Dr. David Alan Gilbert
2017-07-13 5:52 ` [Qemu-devel] [PATCH V2 3/4] net/colo-compare.c: Optimize unpredictable tcp options comparison Zhang Chen
2017-07-14 3:33 ` Jason Wang
2017-07-17 9:06 ` Zhang Chen
2017-07-13 5:52 ` [Qemu-devel] [PATCH V2 4/4] net/colo-compare.c: Adjust net queue pop order for performance Zhang Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=174a3db3-6a14-edbb-641a-e93746c51861@redhat.com \
--to=jasowang@redhat.com \
--cc=lizhijian@cn.fujitsu.com \
--cc=qemu-devel@nongnu.org \
--cc=zhang.zhanghailiang@huawei.com \
--cc=zhangchen.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.