* [PATCH] ACPI / LPSS: check the result of ioremap
@ 2015-01-08 7:57 Heikki Krogerus
2015-01-11 22:35 ` Rafael J. Wysocki
0 siblings, 1 reply; 4+ messages in thread
From: Heikki Krogerus @ 2015-01-08 7:57 UTC (permalink / raw)
To: Rafael J. Wysocki; +Cc: Mika Westerberg, linux-acpi
If it fails we have to skip the device.
Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
---
drivers/acpi/acpi_lpss.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/acpi/acpi_lpss.c b/drivers/acpi/acpi_lpss.c
index 4f3febf..d12f98a 100644
--- a/drivers/acpi/acpi_lpss.c
+++ b/drivers/acpi/acpi_lpss.c
@@ -340,6 +340,8 @@ static int acpi_lpss_create_device(struct acpi_device *adev,
pdata->mmio_size = resource_size(&rentry->res);
pdata->mmio_base = ioremap(rentry->res.start,
pdata->mmio_size);
+ if (!pdata->mmio_base)
+ goto err_out;
break;
}
--
2.1.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ACPI / LPSS: check the result of ioremap
2015-01-08 7:57 [PATCH] ACPI / LPSS: check the result of ioremap Heikki Krogerus
@ 2015-01-11 22:35 ` Rafael J. Wysocki
2015-01-12 7:28 ` Heikki Krogerus
0 siblings, 1 reply; 4+ messages in thread
From: Rafael J. Wysocki @ 2015-01-11 22:35 UTC (permalink / raw)
To: Heikki Krogerus; +Cc: Mika Westerberg, linux-acpi
On Thursday, January 08, 2015 09:57:25 AM Heikki Krogerus wrote:
> If it fails we have to skip the device.
>
> Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
"stable" stuff? Which version if so?
> ---
> drivers/acpi/acpi_lpss.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/acpi/acpi_lpss.c b/drivers/acpi/acpi_lpss.c
> index 4f3febf..d12f98a 100644
> --- a/drivers/acpi/acpi_lpss.c
> +++ b/drivers/acpi/acpi_lpss.c
> @@ -340,6 +340,8 @@ static int acpi_lpss_create_device(struct acpi_device *adev,
> pdata->mmio_size = resource_size(&rentry->res);
> pdata->mmio_base = ioremap(rentry->res.start,
> pdata->mmio_size);
> + if (!pdata->mmio_base)
> + goto err_out;
> break;
> }
>
>
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ACPI / LPSS: check the result of ioremap
2015-01-11 22:35 ` Rafael J. Wysocki
@ 2015-01-12 7:28 ` Heikki Krogerus
2015-01-30 0:06 ` Rafael J. Wysocki
0 siblings, 1 reply; 4+ messages in thread
From: Heikki Krogerus @ 2015-01-12 7:28 UTC (permalink / raw)
To: Rafael J. Wysocki; +Cc: Mika Westerberg, linux-acpi
On Sun, Jan 11, 2015 at 11:35:30PM +0100, Rafael J. Wysocki wrote:
> On Thursday, January 08, 2015 09:57:25 AM Heikki Krogerus wrote:
> > If it fails we have to skip the device.
> >
> > Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
>
> "stable" stuff? Which version if so?
Not stable stuff. v3.20.
Cheers,
--
heikki
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ACPI / LPSS: check the result of ioremap
2015-01-12 7:28 ` Heikki Krogerus
@ 2015-01-30 0:06 ` Rafael J. Wysocki
0 siblings, 0 replies; 4+ messages in thread
From: Rafael J. Wysocki @ 2015-01-30 0:06 UTC (permalink / raw)
To: Heikki Krogerus; +Cc: Mika Westerberg, linux-acpi
On Monday, January 12, 2015 09:28:04 AM Heikki Krogerus wrote:
> On Sun, Jan 11, 2015 at 11:35:30PM +0100, Rafael J. Wysocki wrote:
> > On Thursday, January 08, 2015 09:57:25 AM Heikki Krogerus wrote:
> > > If it fails we have to skip the device.
> > >
> > > Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> >
> > "stable" stuff? Which version if so?
>
> Not stable stuff. v3.20.
Queued up for 3.20 then, thanks!
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-01-29 23:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-08 7:57 [PATCH] ACPI / LPSS: check the result of ioremap Heikki Krogerus
2015-01-11 22:35 ` Rafael J. Wysocki
2015-01-12 7:28 ` Heikki Krogerus
2015-01-30 0:06 ` Rafael J. Wysocki
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.