Re: [Buildroot] [PATCH v5] configs/kontron_bl_imx8mm_defconfig: new defconfig

From: Arnout Vandecappelle <arnout@mind.be>
To: Bartosz Bilas <b.bilas@grinn-global.com>,
	Giulio Benetti <giulio.benetti@benettiengineering.com>
Cc: Frieder Schrempf <frieder.schrempf@kontron.de>,
	Michael Walle <michael@walle.cc>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	buildroot@buildroot.org, Heiko Thiery <heiko.thiery@gmail.com>,
	Michael Nazzareno Trimarchi <michael@amarulasolutions.com>,
	Fabio Estevam <festevam@gmail.com>,
	"Yann E . MORIN" <yann.morin.1998@free.fr>
Subject: Re: [Buildroot] [PATCH v5] configs/kontron_bl_imx8mm_defconfig: new defconfig
Date: Tue, 1 Feb 2022 21:51:05 +0100	[thread overview]
Message-ID: <17628e7b-51cc-a075-196d-e45720089a12@mind.be> (raw)
In-Reply-To: <3ea22a9d-938a-5086-66c6-a8f5510c8573@grinn-global.com>

On 31/01/2022 18:45, Bartosz Bilas wrote:
> Hello,
> 
> On 31.01.2022 18:11, Giulio Benetti wrote:
>> On 31/01/22 17:42, Michael Nazzareno Trimarchi wrote:
>>
>> [SNIP]

  Thank you for the snip. My arm was getting tired of scrolling through all the 
quoting :-)

[snip some more]
>>>>>>> +# Required host tools to create the SD/eMMC image
>>>>>>> +BR2_ROOTFS_POST_BUILD_SCRIPT="board/kontron/bl-imx8mm/post-build.sh"
>>>>>>> +BR2_ROOTFS_POST_IMAGE_SCRIPT="support/scripts/genimage.sh"
>>>>>>> +BR2_ROOTFS_POST_SCRIPT_ARGS="-c $(BINARIES_DIR)/genimage.cfg"
>>>>>>> +BR2_PACKAGE_HOST_GENIMAGE=y
>>>>>>
>>>>>> I have seen that some people like to have this organization but it's
>>>>>> not really nice to maintain. I would like
>>>>>> to savedefconfig and use that one instead of having nice commented
>>>>>> part. Is this mandatory?
>>>>>
>>>>> As far as I know there is no rule how to do that. For me it seems to
>>>>> be more readable and clean. But this is only my opinion.
>>>>
>>>> As Heiko pointed it's a very good habit.
>>>>
>>>> One thing that must be taken into account while doing it, is to keep the
>>>> various BR2_* configs ordered as they are ordere inside the various
>>>> Config.in
>>>
>>> There are good information indeed but even those information must be
>>> keep updated. Daily work show me that work on
>>> savedefconfig make things nicely. Some of your option can be at some
>>> point autoselect by another one and so on.
>>
>> Yes, you're right, I've noticed that too. It's "not that automatic", but if 
>> you check the first 25 defconfigs you can see that more or less the 70% use 
>> the "descriptive" way. So basically one should savedefconfig to another file 
>> and compare to the configs/*_defconfig and eventually modify.
>>
>> Anyway there is still not a standard decided. So maintainers will accept both 
>> ways.
> 
> The global sync via `savedefconfig` for all existing configs should solve 
> everything. Besides, it should be impossible to edit those files manually.

  The in-tree defconfigs should *not* be generated with "make savedefconfig": we 
want to explicitly set some options even if they're at their default value. The 
reason is that on master, the defaults can be updated. The typical example is 
the kernel headers version (cfr. [1]). But also arch options can change default 
(a few years ago this happened for ARM floating point), and others as well.

  We're not very good in making sure that options are properly set. For sure, 
however:

- global sync via savedefconfig is *not* what we want;
- a defconfig with comments makes it easier to be sure that options are set 
explicitly.

  Regards,
  Arnout

[1] 
https://patchwork.ozlabs.org/project/buildroot/patch/20220201183331.4009320-6-giulio.benetti@benettiengineering.com/

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot