Re: [Buildroot] [PATCH v5] configs/kontron_bl_imx8mm_defconfig: new defconfig

[Giulio Benetti <giulio.benetti@benettiengineering.com>]

On 31/01/22 17:42, Michael Nazzareno Trimarchi wrote:

[SNIP]

>>>>> diff --git a/configs/kontron_bl_imx8mm_defconfig b/configs/kontron_bl_imx8mm_defconfig
>>>>> new file mode 100644
>>>>> index 0000000000..0cf0115bfa
>>>>> --- /dev/null
>>>>> +++ b/configs/kontron_bl_imx8mm_defconfig
>>>>> @@ -0,0 +1,58 @@
>>>>> +# Architecture
>>>>> +BR2_aarch64=y
>>>>> +BR2_ARM_FPU_VFPV3=y
>>>>> +
>>>>> +BR2_GLOBAL_PATCH_DIR="board/kontron/bl-imx8mm/patches"
>>>>> +
>>>>> +# System
>>>>> +BR2_TARGET_GENERIC_GETTY_PORT="ttymxc2"
>>>>> +
>>>>> +# Kernel
>>>>> +BR2_LINUX_KERNEL=y
>>>>> +BR2_LINUX_KERNEL_CUSTOM_VERSION=y
>>>>> +BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="5.16"
>>>>> +BR2_LINUX_KERNEL_USE_ARCH_DEFAULT_CONFIG=y
>>>>> +BR2_LINUX_KERNEL_DTS_SUPPORT=y
>>>>> +BR2_LINUX_KERNEL_INTREE_DTS_NAME="freescale/imx8mm-kontron-n801x-s"
>>>>> +BR2_LINUX_KERNEL_DTB_KEEP_DIRNAME=y
>>>>> +BR2_LINUX_KERNEL_INSTALL_TARGET=y
>>>>> +BR2_LINUX_KERNEL_NEEDS_HOST_OPENSSL=y
>>>>> +
>>>>> +BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_16=y
>>>>> +
>>>>> +BR2_PACKAGE_FREESCALE_IMX=y
>>>>> +BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8MM=y
>>>>> +BR2_PACKAGE_FIRMWARE_IMX=y
>>>>> +
>>>>> +# Filesystem / image
>>>>> +BR2_TARGET_ROOTFS_EXT2=y
>>>>> +BR2_TARGET_ROOTFS_EXT2_4=y
>>>>> +BR2_TARGET_ROOTFS_EXT2_SIZE="120M"
>>>>> +
>>>>> +# Bootloader
>>>>> +BR2_TARGET_ARM_TRUSTED_FIRMWARE=y
>>>>> +BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_VERSION=y
>>>>> +BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_VERSION_VALUE="v2.6"
>>>>> +BR2_TARGET_ARM_TRUSTED_FIRMWARE_PLATFORM="imx8mm"
>>>>> +BR2_TARGET_ARM_TRUSTED_FIRMWARE_BL31=y
>>>>> +BR2_TARGET_ARM_TRUSTED_FIRMWARE_ADDITIONAL_VARIABLES="IMX_BOOT_UART_BASE=0x30880000"
>>>>> +BR2_TARGET_UBOOT=y
>>>>> +BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG=y
>>>>> +BR2_TARGET_UBOOT_CUSTOM_VERSION=y
>>>>> +BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2022.01"
>>>>> +BR2_TARGET_UBOOT_BOARD_DEFCONFIG="kontron-sl-mx8mm"
>>>>> +BR2_TARGET_UBOOT_NEEDS_DTC=y
>>>>> +BR2_TARGET_UBOOT_NEEDS_PYTHON3=y
>>>>> +BR2_TARGET_UBOOT_NEEDS_PYLIBFDT=y
>>>>> +BR2_TARGET_UBOOT_NEEDS_ATF_BL31=y
>>>>> +BR2_TARGET_UBOOT_NEEDS_ATF_BL31_BIN=y
>>>>> +BR2_TARGET_UBOOT_NEEDS_IMX_FIRMWARE=y
>>>>> +BR2_TARGET_UBOOT_FORMAT_CUSTOM=y
>>>>> +BR2_TARGET_UBOOT_FORMAT_CUSTOM_NAME="flash.bin"
>>>>> +BR2_TARGET_UBOOT_SPL=y
>>>>> +
>>>>> +# Required host tools to create the SD/eMMC image
>>>>> +BR2_ROOTFS_POST_BUILD_SCRIPT="board/kontron/bl-imx8mm/post-build.sh"
>>>>> +BR2_ROOTFS_POST_IMAGE_SCRIPT="support/scripts/genimage.sh"
>>>>> +BR2_ROOTFS_POST_SCRIPT_ARGS="-c $(BINARIES_DIR)/genimage.cfg"
>>>>> +BR2_PACKAGE_HOST_GENIMAGE=y
>>>>
>>>> I have seen that some people like to have this organization but it's
>>>> not really nice to maintain. I would like
>>>> to savedefconfig and use that one instead of having nice commented
>>>> part. Is this mandatory?
>>>
>>> As far as I know there is no rule how to do that. For me it seems to
>>> be more readable and clean. But this is only my opinion.
>>
>> As Heiko pointed it's a very good habit.
>>
>> One thing that must be taken into account while doing it, is to keep the
>> various BR2_* configs ordered as they are ordere inside the various
>> Config.in
> 
> There are good information indeed but even those information must be
> keep updated. Daily work show me that work on
> savedefconfig make things nicely. Some of your option can be at some
> point autoselect by another one and so on.

Yes, you're right, I've noticed that too. It's "not that automatic", but 
if you check the first 25 defconfigs you can see that more or less the 
70% use the "descriptive" way. So basically one should savedefconfig to 
another file and compare to the configs/*_defconfig and eventually modify.

Anyway there is still not a standard decided. So maintainers will accept 
both ways.

Cheers
-- 
Giulio Benetti
Benetti Engineering sas
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot