* [PATCH 2/2] sh-pfc: r8a7791: add MLB+ pin group
@ 2015-01-10 18:22 ` Sergei Shtylyov
0 siblings, 0 replies; 8+ messages in thread
From: Sergei Shtylyov @ 2015-01-10 18:22 UTC (permalink / raw)
To: linus.walleij, linux-sh, laurent.pinchart, linux-gpio
Add MLB+ 3-pin mode pin group to R8A7791 PFC driver.
Based on original patch by Andrey Gusakov <andrey.gusakov@cogentembedded.com>.
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
---
The patch is against the 'devel' branch of Linus W.'s 'linux-pinctrl.git' repo.
drivers/pinctrl/sh-pfc/pfc-r8a7791.c | 13 +++++++++++++
1 file changed, 13 insertions(+)
Index: linux-pinctrl/drivers/pinctrl/sh-pfc/pfc-r8a7791.c
===================================================================
--- linux-pinctrl.orig/drivers/pinctrl/sh-pfc/pfc-r8a7791.c
+++ linux-pinctrl/drivers/pinctrl/sh-pfc/pfc-r8a7791.c
@@ -2391,6 +2391,13 @@ static const unsigned int intc_irq3_pins
static const unsigned int intc_irq3_mux[] = {
IRQ3_MARK,
};
+/* - MLB+ ------------------------------------------------------------------- */
+static const unsigned int mlb_3pin_pins[] = {
+ RCAR_GP_PIN(7, 7), RCAR_GP_PIN(7, 8), RCAR_GP_PIN(7, 9),
+};
+static const unsigned int mlb_3pin_mux[] = {
+ MLB_CLK_MARK, MLB_SIG_MARK, MLB_DAT_MARK,
+};
/* - MMCIF ------------------------------------------------------------------ */
static const unsigned int mmc_data1_pins[] = {
/* D[0] */
@@ -4267,6 +4274,7 @@ static const struct sh_pfc_pin_group pin
SH_PFC_PIN_GROUP(intc_irq1),
SH_PFC_PIN_GROUP(intc_irq2),
SH_PFC_PIN_GROUP(intc_irq3),
+ SH_PFC_PIN_GROUP(mlb_3pin),
SH_PFC_PIN_GROUP(mmc_data1),
SH_PFC_PIN_GROUP(mmc_data4),
SH_PFC_PIN_GROUP(mmc_data8),
@@ -4648,6 +4656,10 @@ static const char * const intc_groups[]
"intc_irq3",
};
+static const char * const mlb_groups[] = {
+ "mlb_3pin",
+};
+
static const char * const mmc_groups[] = {
"mmc_data1",
"mmc_data4",
@@ -4972,6 +4984,7 @@ static const struct sh_pfc_function pinm
SH_PFC_FUNCTION(i2c7),
SH_PFC_FUNCTION(i2c8),
SH_PFC_FUNCTION(intc),
+ SH_PFC_FUNCTION(mlb),
SH_PFC_FUNCTION(mmc),
SH_PFC_FUNCTION(msiof0),
SH_PFC_FUNCTION(msiof1),
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH 2/2] sh-pfc: r8a7791: add MLB+ pin group
2015-01-10 18:22 ` Sergei Shtylyov
@ 2015-01-12 9:39 ` Geert Uytterhoeven
-1 siblings, 0 replies; 8+ messages in thread
From: Geert Uytterhoeven @ 2015-01-12 9:39 UTC (permalink / raw)
To: Sergei Shtylyov
Cc: Linus Walleij, Linux-sh list, Laurent Pinchart, linux-gpio
On Sat, Jan 10, 2015 at 7:22 PM, Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
> Add MLB+ 3-pin mode pin group to R8A7791 PFC driver.
>
> Based on original patch by Andrey Gusakov <andrey.gusakov@cogentembedded.com>.
>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Thanks, looks OK to me
Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH 2/2] sh-pfc: r8a7791: add MLB+ pin group
@ 2015-01-12 9:39 ` Geert Uytterhoeven
0 siblings, 0 replies; 8+ messages in thread
From: Geert Uytterhoeven @ 2015-01-12 9:39 UTC (permalink / raw)
To: Sergei Shtylyov
Cc: Linus Walleij, Linux-sh list, Laurent Pinchart, linux-gpio
On Sat, Jan 10, 2015 at 7:22 PM, Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
> Add MLB+ 3-pin mode pin group to R8A7791 PFC driver.
>
> Based on original patch by Andrey Gusakov <andrey.gusakov@cogentembedded.com>.
>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Thanks, looks OK to me
Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] sh-pfc: r8a7791: add MLB+ pin group
2015-01-10 18:22 ` Sergei Shtylyov
@ 2015-01-13 7:33 ` Laurent Pinchart
-1 siblings, 0 replies; 8+ messages in thread
From: Laurent Pinchart @ 2015-01-13 7:33 UTC (permalink / raw)
To: Sergei Shtylyov; +Cc: linus.walleij, linux-sh, linux-gpio
Hi Sergei,
Thank you for the patch.
On Saturday 10 January 2015 21:22:36 Sergei Shtylyov wrote:
> Add MLB+ 3-pin mode pin group to R8A7791 PFC driver.
>
> Based on original patch by Andrey Gusakov
> <andrey.gusakov@cogentembedded.com>.
>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> ---
> The patch is against the 'devel' branch of Linus W.'s 'linux-pinctrl.git'
> repo.
>
> drivers/pinctrl/sh-pfc/pfc-r8a7791.c | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> Index: linux-pinctrl/drivers/pinctrl/sh-pfc/pfc-r8a7791.c
> =================================> --- linux-pinctrl.orig/drivers/pinctrl/sh-pfc/pfc-r8a7791.c
> +++ linux-pinctrl/drivers/pinctrl/sh-pfc/pfc-r8a7791.c
> @@ -2391,6 +2391,13 @@ static const unsigned int intc_irq3_pins
> static const unsigned int intc_irq3_mux[] = {
> IRQ3_MARK,
> };
> +/* - MLB+
> ------------------------------------------------------------------- */
> +static const unsigned int mlb_3pin_pins[] = {
> + RCAR_GP_PIN(7, 7), RCAR_GP_PIN(7, 8), RCAR_GP_PIN(7, 9),
> +};
> +static const unsigned int mlb_3pin_mux[] = {
> + MLB_CLK_MARK, MLB_SIG_MARK, MLB_DAT_MARK,
> +};
> /* - MMCIF
> ------------------------------------------------------------------ */
> static const unsigned int mmc_data1_pins[] = {
> /* D[0] */
> @@ -4267,6 +4274,7 @@ static const struct sh_pfc_pin_group pin
> SH_PFC_PIN_GROUP(intc_irq1),
> SH_PFC_PIN_GROUP(intc_irq2),
> SH_PFC_PIN_GROUP(intc_irq3),
> + SH_PFC_PIN_GROUP(mlb_3pin),
> SH_PFC_PIN_GROUP(mmc_data1),
> SH_PFC_PIN_GROUP(mmc_data4),
> SH_PFC_PIN_GROUP(mmc_data8),
> @@ -4648,6 +4656,10 @@ static const char * const intc_groups[]
> "intc_irq3",
> };
>
> +static const char * const mlb_groups[] = {
> + "mlb_3pin",
> +};
> +
> static const char * const mmc_groups[] = {
> "mmc_data1",
> "mmc_data4",
> @@ -4972,6 +4984,7 @@ static const struct sh_pfc_function pinm
> SH_PFC_FUNCTION(i2c7),
> SH_PFC_FUNCTION(i2c8),
> SH_PFC_FUNCTION(intc),
> + SH_PFC_FUNCTION(mlb),
> SH_PFC_FUNCTION(mmc),
> SH_PFC_FUNCTION(msiof0),
> SH_PFC_FUNCTION(msiof1),
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH 2/2] sh-pfc: r8a7791: add MLB+ pin group
@ 2015-01-13 7:33 ` Laurent Pinchart
0 siblings, 0 replies; 8+ messages in thread
From: Laurent Pinchart @ 2015-01-13 7:33 UTC (permalink / raw)
To: Sergei Shtylyov; +Cc: linus.walleij, linux-sh, linux-gpio
Hi Sergei,
Thank you for the patch.
On Saturday 10 January 2015 21:22:36 Sergei Shtylyov wrote:
> Add MLB+ 3-pin mode pin group to R8A7791 PFC driver.
>
> Based on original patch by Andrey Gusakov
> <andrey.gusakov@cogentembedded.com>.
>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> ---
> The patch is against the 'devel' branch of Linus W.'s 'linux-pinctrl.git'
> repo.
>
> drivers/pinctrl/sh-pfc/pfc-r8a7791.c | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> Index: linux-pinctrl/drivers/pinctrl/sh-pfc/pfc-r8a7791.c
> ===================================================================
> --- linux-pinctrl.orig/drivers/pinctrl/sh-pfc/pfc-r8a7791.c
> +++ linux-pinctrl/drivers/pinctrl/sh-pfc/pfc-r8a7791.c
> @@ -2391,6 +2391,13 @@ static const unsigned int intc_irq3_pins
> static const unsigned int intc_irq3_mux[] = {
> IRQ3_MARK,
> };
> +/* - MLB+
> ------------------------------------------------------------------- */
> +static const unsigned int mlb_3pin_pins[] = {
> + RCAR_GP_PIN(7, 7), RCAR_GP_PIN(7, 8), RCAR_GP_PIN(7, 9),
> +};
> +static const unsigned int mlb_3pin_mux[] = {
> + MLB_CLK_MARK, MLB_SIG_MARK, MLB_DAT_MARK,
> +};
> /* - MMCIF
> ------------------------------------------------------------------ */
> static const unsigned int mmc_data1_pins[] = {
> /* D[0] */
> @@ -4267,6 +4274,7 @@ static const struct sh_pfc_pin_group pin
> SH_PFC_PIN_GROUP(intc_irq1),
> SH_PFC_PIN_GROUP(intc_irq2),
> SH_PFC_PIN_GROUP(intc_irq3),
> + SH_PFC_PIN_GROUP(mlb_3pin),
> SH_PFC_PIN_GROUP(mmc_data1),
> SH_PFC_PIN_GROUP(mmc_data4),
> SH_PFC_PIN_GROUP(mmc_data8),
> @@ -4648,6 +4656,10 @@ static const char * const intc_groups[]
> "intc_irq3",
> };
>
> +static const char * const mlb_groups[] = {
> + "mlb_3pin",
> +};
> +
> static const char * const mmc_groups[] = {
> "mmc_data1",
> "mmc_data4",
> @@ -4972,6 +4984,7 @@ static const struct sh_pfc_function pinm
> SH_PFC_FUNCTION(i2c7),
> SH_PFC_FUNCTION(i2c8),
> SH_PFC_FUNCTION(intc),
> + SH_PFC_FUNCTION(mlb),
> SH_PFC_FUNCTION(mmc),
> SH_PFC_FUNCTION(msiof0),
> SH_PFC_FUNCTION(msiof1),
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] sh-pfc: r8a7791: add MLB+ pin group
2015-01-10 18:22 ` Sergei Shtylyov
@ 2015-01-15 16:11 ` Linus Walleij
-1 siblings, 0 replies; 8+ messages in thread
From: Linus Walleij @ 2015-01-15 16:11 UTC (permalink / raw)
To: Sergei Shtylyov; +Cc: linux-sh, Laurent Pinchart, linux-gpio
On Sat, Jan 10, 2015 at 7:22 PM, Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
> Add MLB+ 3-pin mode pin group to R8A7791 PFC driver.
>
> Based on original patch by Andrey Gusakov <andrey.gusakov@cogentembedded.com>.
>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Patch applied with the ACKs.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] sh-pfc: r8a7791: add MLB+ pin group
@ 2015-01-15 16:11 ` Linus Walleij
0 siblings, 0 replies; 8+ messages in thread
From: Linus Walleij @ 2015-01-15 16:11 UTC (permalink / raw)
To: Sergei Shtylyov; +Cc: linux-sh, Laurent Pinchart, linux-gpio
On Sat, Jan 10, 2015 at 7:22 PM, Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
> Add MLB+ 3-pin mode pin group to R8A7791 PFC driver.
>
> Based on original patch by Andrey Gusakov <andrey.gusakov@cogentembedded.com>.
>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Patch applied with the ACKs.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 8+ messages in thread