All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shuah Khan <skhan@linuxfoundation.org>
To: Yunke Cao <yunkec@google.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Kieran Bingham <kieran.bingham@ideasonboard.com>
Cc: Tomasz Figa <tfiga@chromium.org>,
	linux-media@vger.kernel.org,
	Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH v2 1/2] media: vimc: add ancillary lens
Date: Fri, 17 Jun 2022 14:01:16 -0600	[thread overview]
Message-ID: <177345ff-f601-e440-31e0-2c967736af6b@linuxfoundation.org> (raw)
In-Reply-To: <20220617015745.3950197-2-yunkec@google.com>

On 6/16/22 7:57 PM, Yunke Cao wrote:
> Add a basic version of vimc lens.
> The lens supports V4L2_CID_FOCUS_ABSOLUTE control.
> Link the lens with vimc sensors using media-controller
> ancillary links.
> 

Commit log lines are usually ~75 charracters long. Make it easier
to read.

> This change can be used to test the recently added ancillary
> links.
> 

Care to add instructions on how one would test ancillary with
this feature?

> Reviewed-by: Shuah Khan <skhan@linuxfoundation.org>
> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
> Signed-off-by: Yunke Cao <yunkec@google.com>
> ---
>   drivers/media/test-drivers/vimc/Makefile      |   2 +-
>   drivers/media/test-drivers/vimc/vimc-common.h |   1 +
>   drivers/media/test-drivers/vimc/vimc-core.c   |  86 +++++++++++----
>   drivers/media/test-drivers/vimc/vimc-lens.c   | 102 ++++++++++++++++++
>   4 files changed, 170 insertions(+), 21 deletions(-)
>   create mode 100644 drivers/media/test-drivers/vimc/vimc-lens.c
> 

thanks,
-- Shuah

  reply	other threads:[~2022-06-17 20:01 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-17  1:57 [PATCH v2 0/2] media: vimc: add ancillary lens Yunke Cao
2022-06-17  1:57 ` [PATCH v2 1/2] " Yunke Cao
2022-06-17 20:01   ` Shuah Khan [this message]
2022-06-20  1:57     ` Yunke Cao
2022-06-21 15:57       ` Shuah Khan
2022-06-27  1:30         ` Yunke Cao
2022-06-27 15:43           ` Shuah Khan
2022-06-28  0:54             ` Yunke Cao
2022-06-17  1:57 ` [PATCH v2 2/2] media: vimc: documentation for lens Yunke Cao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=177345ff-f601-e440-31e0-2c967736af6b@linuxfoundation.org \
    --to=skhan@linuxfoundation.org \
    --cc=kieran.bingham@ideasonboard.com \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=tfiga@chromium.org \
    --cc=yunkec@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.