All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yunke Cao <yunkec@google.com>
To: Shuah Khan <skhan@linuxfoundation.org>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
	Kieran Bingham <kieran.bingham@ideasonboard.com>,
	Tomasz Figa <tfiga@chromium.org>,
	linux-media@vger.kernel.org
Subject: Re: [PATCH v2 1/2] media: vimc: add ancillary lens
Date: Tue, 28 Jun 2022 09:54:59 +0900	[thread overview]
Message-ID: <CANqU6FcLNhMf4x=ie99vuPFUmk9vQYRhcjm6RnEQ8QWAZfs=TA@mail.gmail.com> (raw)
In-Reply-To: <5ec4238c-080f-f2e6-9b30-6595f9afe92a@linuxfoundation.org>

Thanks Shuah. Just sent out v3.

On Tue, Jun 28, 2022 at 12:43 AM Shuah Khan <skhan@linuxfoundation.org> wrote:
>
> On 6/26/22 7:30 PM, Yunke Cao wrote:
> > Hi Shuah,
> >
> > Thanks for the pointers.
> >
>
> >>
> >> Why is this necessary? How did you test this change? How could
> >> one use this feature?
> >>
> >
> > Add lens to vimc driver and link them with sensors using ancillary links.
> > Provides an example of ancillary link usage.The lens supports
> > FOCUS_ABSOLUTE control.
> >
> > Test example: With default vimc topology
> >> media-ctl -p
> > Media controller API version 5.18.0
> > …
> > - entity 28: Lens A (0 pad, 0 link)
> >               type V4L2 subdev subtype Lens flags 0
> >               device node name /dev/v4l-subdev6
> > - entity 29: Lens B (0 pad, 0 link)
> >               type V4L2 subdev subtype Lens flags 0
> >               device node name /dev/v4l-subdev7
> >>   v4l2-ctl -d /dev/v4l-subdev7 -C focus_absolute
> > focus_absolute: 0
> >
>
> Send me v3 with all of this information in the commit log and add
> this to document as well.
>
> thanks,
> -- Shuah

  reply	other threads:[~2022-06-28  0:55 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-17  1:57 [PATCH v2 0/2] media: vimc: add ancillary lens Yunke Cao
2022-06-17  1:57 ` [PATCH v2 1/2] " Yunke Cao
2022-06-17 20:01   ` Shuah Khan
2022-06-20  1:57     ` Yunke Cao
2022-06-21 15:57       ` Shuah Khan
2022-06-27  1:30         ` Yunke Cao
2022-06-27 15:43           ` Shuah Khan
2022-06-28  0:54             ` Yunke Cao [this message]
2022-06-17  1:57 ` [PATCH v2 2/2] media: vimc: documentation for lens Yunke Cao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CANqU6FcLNhMf4x=ie99vuPFUmk9vQYRhcjm6RnEQ8QWAZfs=TA@mail.gmail.com' \
    --to=yunkec@google.com \
    --cc=kieran.bingham@ideasonboard.com \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=skhan@linuxfoundation.org \
    --cc=tfiga@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.