* [PATCH] i915: Drop legacy execbuffer support @ 2021-03-10 21:00 ` Jason Ekstrand 0 siblings, 0 replies; 17+ messages in thread From: Jason Ekstrand @ 2021-03-10 21:00 UTC (permalink / raw) To: dri-devel, intel-gfx, airlied; +Cc: Jason Ekstrand libdrm has supported the newer execbuffer2 ioctl and using it by default when it exists since libdrm commit b50964027bef249a0cc3d511de05c2464e0a1e22 which landed Mar 2, 2010. The i915 and i965 drivers in Mesa at the time both used libdrm and so did the Intel X11 back-end. The SNA back-end for X11 has always used execbuffer2. Signed-off-by: Jason Ekstrand <jason@jlekstrand.net> --- .../gpu/drm/i915/gem/i915_gem_execbuffer.c | 100 ------------------ drivers/gpu/drm/i915/gem/i915_gem_ioctls.h | 2 - drivers/gpu/drm/i915/i915_drv.c | 2 +- 3 files changed, 1 insertion(+), 103 deletions(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c index fe170186dd428..99772f37bff60 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c +++ b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c @@ -3394,106 +3394,6 @@ static bool check_buffer_count(size_t count) return !(count < 1 || count > INT_MAX || count > SIZE_MAX / sz - 1); } -/* - * Legacy execbuffer just creates an exec2 list from the original exec object - * list array and passes it to the real function. - */ -int -i915_gem_execbuffer_ioctl(struct drm_device *dev, void *data, - struct drm_file *file) -{ - struct drm_i915_private *i915 = to_i915(dev); - struct drm_i915_gem_execbuffer *args = data; - struct drm_i915_gem_execbuffer2 exec2; - struct drm_i915_gem_exec_object *exec_list = NULL; - struct drm_i915_gem_exec_object2 *exec2_list = NULL; - const size_t count = args->buffer_count; - unsigned int i; - int err; - - if (!check_buffer_count(count)) { - drm_dbg(&i915->drm, "execbuf2 with %zd buffers\n", count); - return -EINVAL; - } - - exec2.buffers_ptr = args->buffers_ptr; - exec2.buffer_count = args->buffer_count; - exec2.batch_start_offset = args->batch_start_offset; - exec2.batch_len = args->batch_len; - exec2.DR1 = args->DR1; - exec2.DR4 = args->DR4; - exec2.num_cliprects = args->num_cliprects; - exec2.cliprects_ptr = args->cliprects_ptr; - exec2.flags = I915_EXEC_RENDER; - i915_execbuffer2_set_context_id(exec2, 0); - - err = i915_gem_check_execbuffer(&exec2); - if (err) - return err; - - /* Copy in the exec list from userland */ - exec_list = kvmalloc_array(count, sizeof(*exec_list), - __GFP_NOWARN | GFP_KERNEL); - - /* Allocate extra slots for use by the command parser */ - exec2_list = kvmalloc_array(count + 2, eb_element_size(), - __GFP_NOWARN | GFP_KERNEL); - if (exec_list == NULL || exec2_list == NULL) { - drm_dbg(&i915->drm, - "Failed to allocate exec list for %d buffers\n", - args->buffer_count); - kvfree(exec_list); - kvfree(exec2_list); - return -ENOMEM; - } - err = copy_from_user(exec_list, - u64_to_user_ptr(args->buffers_ptr), - sizeof(*exec_list) * count); - if (err) { - drm_dbg(&i915->drm, "copy %d exec entries failed %d\n", - args->buffer_count, err); - kvfree(exec_list); - kvfree(exec2_list); - return -EFAULT; - } - - for (i = 0; i < args->buffer_count; i++) { - exec2_list[i].handle = exec_list[i].handle; - exec2_list[i].relocation_count = exec_list[i].relocation_count; - exec2_list[i].relocs_ptr = exec_list[i].relocs_ptr; - exec2_list[i].alignment = exec_list[i].alignment; - exec2_list[i].offset = exec_list[i].offset; - if (INTEL_GEN(to_i915(dev)) < 4) - exec2_list[i].flags = EXEC_OBJECT_NEEDS_FENCE; - else - exec2_list[i].flags = 0; - } - - err = i915_gem_do_execbuffer(dev, file, &exec2, exec2_list); - if (exec2.flags & __EXEC_HAS_RELOC) { - struct drm_i915_gem_exec_object __user *user_exec_list = - u64_to_user_ptr(args->buffers_ptr); - - /* Copy the new buffer offsets back to the user's exec list. */ - for (i = 0; i < args->buffer_count; i++) { - if (!(exec2_list[i].offset & UPDATE)) - continue; - - exec2_list[i].offset = - gen8_canonical_addr(exec2_list[i].offset & PIN_OFFSET_MASK); - exec2_list[i].offset &= PIN_OFFSET_MASK; - if (__copy_to_user(&user_exec_list[i].offset, - &exec2_list[i].offset, - sizeof(user_exec_list[i].offset))) - break; - } - } - - kvfree(exec_list); - kvfree(exec2_list); - return err; -} - int i915_gem_execbuffer2_ioctl(struct drm_device *dev, void *data, struct drm_file *file) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ioctls.h b/drivers/gpu/drm/i915/gem/i915_gem_ioctls.h index 87d8b27f426de..7fd22f3efbef0 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_ioctls.h +++ b/drivers/gpu/drm/i915/gem/i915_gem_ioctls.h @@ -14,8 +14,6 @@ int i915_gem_busy_ioctl(struct drm_device *dev, void *data, struct drm_file *file); int i915_gem_create_ioctl(struct drm_device *dev, void *data, struct drm_file *file); -int i915_gem_execbuffer_ioctl(struct drm_device *dev, void *data, - struct drm_file *file); int i915_gem_execbuffer2_ioctl(struct drm_device *dev, void *data, struct drm_file *file); int i915_gem_get_aperture_ioctl(struct drm_device *dev, void *data, diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c index 3edd5e47ad682..64edcab59fe12 100644 --- a/drivers/gpu/drm/i915/i915_drv.c +++ b/drivers/gpu/drm/i915/i915_drv.c @@ -1701,7 +1701,7 @@ static const struct drm_ioctl_desc i915_ioctls[] = { DRM_IOCTL_DEF_DRV(I915_VBLANK_SWAP, drm_noop, DRM_AUTH), DRM_IOCTL_DEF_DRV(I915_HWS_ADDR, drm_noop, DRM_AUTH|DRM_MASTER|DRM_ROOT_ONLY), DRM_IOCTL_DEF_DRV(I915_GEM_INIT, drm_noop, DRM_AUTH|DRM_MASTER|DRM_ROOT_ONLY), - DRM_IOCTL_DEF_DRV(I915_GEM_EXECBUFFER, i915_gem_execbuffer_ioctl, DRM_AUTH), + DRM_IOCTL_DEF_DRV(I915_GEM_EXECBUFFER, drm_invalid_op, DRM_AUTH), DRM_IOCTL_DEF_DRV(I915_GEM_EXECBUFFER2_WR, i915_gem_execbuffer2_ioctl, DRM_RENDER_ALLOW), DRM_IOCTL_DEF_DRV(I915_GEM_PIN, i915_gem_reject_pin_ioctl, DRM_AUTH|DRM_ROOT_ONLY), DRM_IOCTL_DEF_DRV(I915_GEM_UNPIN, i915_gem_reject_pin_ioctl, DRM_AUTH|DRM_ROOT_ONLY), -- 2.29.2 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply related [flat|nested] 17+ messages in thread
* [Intel-gfx] [PATCH] i915: Drop legacy execbuffer support @ 2021-03-10 21:00 ` Jason Ekstrand 0 siblings, 0 replies; 17+ messages in thread From: Jason Ekstrand @ 2021-03-10 21:00 UTC (permalink / raw) To: dri-devel, intel-gfx, airlied libdrm has supported the newer execbuffer2 ioctl and using it by default when it exists since libdrm commit b50964027bef249a0cc3d511de05c2464e0a1e22 which landed Mar 2, 2010. The i915 and i965 drivers in Mesa at the time both used libdrm and so did the Intel X11 back-end. The SNA back-end for X11 has always used execbuffer2. Signed-off-by: Jason Ekstrand <jason@jlekstrand.net> --- .../gpu/drm/i915/gem/i915_gem_execbuffer.c | 100 ------------------ drivers/gpu/drm/i915/gem/i915_gem_ioctls.h | 2 - drivers/gpu/drm/i915/i915_drv.c | 2 +- 3 files changed, 1 insertion(+), 103 deletions(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c index fe170186dd428..99772f37bff60 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c +++ b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c @@ -3394,106 +3394,6 @@ static bool check_buffer_count(size_t count) return !(count < 1 || count > INT_MAX || count > SIZE_MAX / sz - 1); } -/* - * Legacy execbuffer just creates an exec2 list from the original exec object - * list array and passes it to the real function. - */ -int -i915_gem_execbuffer_ioctl(struct drm_device *dev, void *data, - struct drm_file *file) -{ - struct drm_i915_private *i915 = to_i915(dev); - struct drm_i915_gem_execbuffer *args = data; - struct drm_i915_gem_execbuffer2 exec2; - struct drm_i915_gem_exec_object *exec_list = NULL; - struct drm_i915_gem_exec_object2 *exec2_list = NULL; - const size_t count = args->buffer_count; - unsigned int i; - int err; - - if (!check_buffer_count(count)) { - drm_dbg(&i915->drm, "execbuf2 with %zd buffers\n", count); - return -EINVAL; - } - - exec2.buffers_ptr = args->buffers_ptr; - exec2.buffer_count = args->buffer_count; - exec2.batch_start_offset = args->batch_start_offset; - exec2.batch_len = args->batch_len; - exec2.DR1 = args->DR1; - exec2.DR4 = args->DR4; - exec2.num_cliprects = args->num_cliprects; - exec2.cliprects_ptr = args->cliprects_ptr; - exec2.flags = I915_EXEC_RENDER; - i915_execbuffer2_set_context_id(exec2, 0); - - err = i915_gem_check_execbuffer(&exec2); - if (err) - return err; - - /* Copy in the exec list from userland */ - exec_list = kvmalloc_array(count, sizeof(*exec_list), - __GFP_NOWARN | GFP_KERNEL); - - /* Allocate extra slots for use by the command parser */ - exec2_list = kvmalloc_array(count + 2, eb_element_size(), - __GFP_NOWARN | GFP_KERNEL); - if (exec_list == NULL || exec2_list == NULL) { - drm_dbg(&i915->drm, - "Failed to allocate exec list for %d buffers\n", - args->buffer_count); - kvfree(exec_list); - kvfree(exec2_list); - return -ENOMEM; - } - err = copy_from_user(exec_list, - u64_to_user_ptr(args->buffers_ptr), - sizeof(*exec_list) * count); - if (err) { - drm_dbg(&i915->drm, "copy %d exec entries failed %d\n", - args->buffer_count, err); - kvfree(exec_list); - kvfree(exec2_list); - return -EFAULT; - } - - for (i = 0; i < args->buffer_count; i++) { - exec2_list[i].handle = exec_list[i].handle; - exec2_list[i].relocation_count = exec_list[i].relocation_count; - exec2_list[i].relocs_ptr = exec_list[i].relocs_ptr; - exec2_list[i].alignment = exec_list[i].alignment; - exec2_list[i].offset = exec_list[i].offset; - if (INTEL_GEN(to_i915(dev)) < 4) - exec2_list[i].flags = EXEC_OBJECT_NEEDS_FENCE; - else - exec2_list[i].flags = 0; - } - - err = i915_gem_do_execbuffer(dev, file, &exec2, exec2_list); - if (exec2.flags & __EXEC_HAS_RELOC) { - struct drm_i915_gem_exec_object __user *user_exec_list = - u64_to_user_ptr(args->buffers_ptr); - - /* Copy the new buffer offsets back to the user's exec list. */ - for (i = 0; i < args->buffer_count; i++) { - if (!(exec2_list[i].offset & UPDATE)) - continue; - - exec2_list[i].offset = - gen8_canonical_addr(exec2_list[i].offset & PIN_OFFSET_MASK); - exec2_list[i].offset &= PIN_OFFSET_MASK; - if (__copy_to_user(&user_exec_list[i].offset, - &exec2_list[i].offset, - sizeof(user_exec_list[i].offset))) - break; - } - } - - kvfree(exec_list); - kvfree(exec2_list); - return err; -} - int i915_gem_execbuffer2_ioctl(struct drm_device *dev, void *data, struct drm_file *file) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ioctls.h b/drivers/gpu/drm/i915/gem/i915_gem_ioctls.h index 87d8b27f426de..7fd22f3efbef0 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_ioctls.h +++ b/drivers/gpu/drm/i915/gem/i915_gem_ioctls.h @@ -14,8 +14,6 @@ int i915_gem_busy_ioctl(struct drm_device *dev, void *data, struct drm_file *file); int i915_gem_create_ioctl(struct drm_device *dev, void *data, struct drm_file *file); -int i915_gem_execbuffer_ioctl(struct drm_device *dev, void *data, - struct drm_file *file); int i915_gem_execbuffer2_ioctl(struct drm_device *dev, void *data, struct drm_file *file); int i915_gem_get_aperture_ioctl(struct drm_device *dev, void *data, diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c index 3edd5e47ad682..64edcab59fe12 100644 --- a/drivers/gpu/drm/i915/i915_drv.c +++ b/drivers/gpu/drm/i915/i915_drv.c @@ -1701,7 +1701,7 @@ static const struct drm_ioctl_desc i915_ioctls[] = { DRM_IOCTL_DEF_DRV(I915_VBLANK_SWAP, drm_noop, DRM_AUTH), DRM_IOCTL_DEF_DRV(I915_HWS_ADDR, drm_noop, DRM_AUTH|DRM_MASTER|DRM_ROOT_ONLY), DRM_IOCTL_DEF_DRV(I915_GEM_INIT, drm_noop, DRM_AUTH|DRM_MASTER|DRM_ROOT_ONLY), - DRM_IOCTL_DEF_DRV(I915_GEM_EXECBUFFER, i915_gem_execbuffer_ioctl, DRM_AUTH), + DRM_IOCTL_DEF_DRV(I915_GEM_EXECBUFFER, drm_invalid_op, DRM_AUTH), DRM_IOCTL_DEF_DRV(I915_GEM_EXECBUFFER2_WR, i915_gem_execbuffer2_ioctl, DRM_RENDER_ALLOW), DRM_IOCTL_DEF_DRV(I915_GEM_PIN, i915_gem_reject_pin_ioctl, DRM_AUTH|DRM_ROOT_ONLY), DRM_IOCTL_DEF_DRV(I915_GEM_UNPIN, i915_gem_reject_pin_ioctl, DRM_AUTH|DRM_ROOT_ONLY), -- 2.29.2 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 17+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for i915: Drop legacy execbuffer support 2021-03-10 21:00 ` [Intel-gfx] " Jason Ekstrand (?) @ 2021-03-10 21:11 ` Patchwork -1 siblings, 0 replies; 17+ messages in thread From: Patchwork @ 2021-03-10 21:11 UTC (permalink / raw) To: Jason Ekstrand; +Cc: intel-gfx == Series Details == Series: i915: Drop legacy execbuffer support URL : https://patchwork.freedesktop.org/series/87854/ State : warning == Summary == $ dim checkpatch origin/drm-tip 1d49bdae0f72 i915: Drop legacy execbuffer support -:7: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit fatal: bad o ("1de05c2464e0a1e22")' #7: when it exists since libdrm commit b50964027bef249a0cc3d511de05c2464e0a1e22 total: 1 errors, 0 warnings, 0 checks, 122 lines checked _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 17+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for i915: Drop legacy execbuffer support 2021-03-10 21:00 ` [Intel-gfx] " Jason Ekstrand (?) (?) @ 2021-03-10 21:36 ` Patchwork -1 siblings, 0 replies; 17+ messages in thread From: Patchwork @ 2021-03-10 21:36 UTC (permalink / raw) To: Jason Ekstrand; +Cc: intel-gfx [-- Attachment #1.1: Type: text/plain, Size: 4535 bytes --] == Series Details == Series: i915: Drop legacy execbuffer support URL : https://patchwork.freedesktop.org/series/87854/ State : success == Summary == CI Bug Log - changes from CI_DRM_9845 -> Patchwork_19774 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/index.html Known issues ------------ Here are the changes found in Patchwork_19774 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@amdgpu/amd_basic@cs-gfx: - fi-kbl-soraka: NOTRUN -> [SKIP][1] ([fdo#109271]) +20 similar issues [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/fi-kbl-soraka/igt@amdgpu/amd_basic@cs-gfx.html * igt@amdgpu/amd_cs_nop@fork-compute0: - fi-ivb-3770: NOTRUN -> [SKIP][2] ([fdo#109271]) +28 similar issues [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/fi-ivb-3770/igt@amdgpu/amd_cs_nop@fork-compute0.html * igt@gem_exec_gttfill@basic: - fi-kbl-8809g: [PASS][3] -> [TIMEOUT][4] ([i915#3145]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9845/fi-kbl-8809g/igt@gem_exec_gttfill@basic.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/fi-kbl-8809g/igt@gem_exec_gttfill@basic.html * igt@gem_huc_copy@huc-copy: - fi-kbl-soraka: NOTRUN -> [SKIP][5] ([fdo#109271] / [i915#2190]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/fi-kbl-soraka/igt@gem_huc_copy@huc-copy.html * igt@i915_selftest@live@gt_pm: - fi-kbl-soraka: NOTRUN -> [DMESG-FAIL][6] ([i915#1886] / [i915#2291]) [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/fi-kbl-soraka/igt@i915_selftest@live@gt_pm.html * igt@kms_chamelium@common-hpd-after-suspend: - fi-kbl-soraka: NOTRUN -> [SKIP][7] ([fdo#109271] / [fdo#111827]) +8 similar issues [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/fi-kbl-soraka/igt@kms_chamelium@common-hpd-after-suspend.html * igt@kms_chamelium@dp-hpd-fast: - fi-ivb-3770: NOTRUN -> [SKIP][8] ([fdo#109271] / [fdo#111827]) +8 similar issues [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/fi-ivb-3770/igt@kms_chamelium@dp-hpd-fast.html * igt@kms_frontbuffer_tracking@basic: - fi-kbl-soraka: NOTRUN -> [FAIL][9] ([i915#49]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/fi-kbl-soraka/igt@kms_frontbuffer_tracking@basic.html * igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d: - fi-kbl-soraka: NOTRUN -> [SKIP][10] ([fdo#109271] / [i915#533]) [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/fi-kbl-soraka/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html #### Possible fixes #### * igt@gem_exec_suspend@basic-s0: - fi-kbl-soraka: [INCOMPLETE][11] ([i915#155]) -> [PASS][12] [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9845/fi-kbl-soraka/igt@gem_exec_suspend@basic-s0.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/fi-kbl-soraka/igt@gem_exec_suspend@basic-s0.html [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827 [i915#155]: https://gitlab.freedesktop.org/drm/intel/issues/155 [i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886 [i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190 [i915#2291]: https://gitlab.freedesktop.org/drm/intel/issues/2291 [i915#3145]: https://gitlab.freedesktop.org/drm/intel/issues/3145 [i915#49]: https://gitlab.freedesktop.org/drm/intel/issues/49 [i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533 Participating hosts (45 -> 40) ------------------------------ Additional (1): fi-ivb-3770 Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-j1900 fi-bsw-cyan fi-ctg-p8600 fi-bdw-samus Build changes ------------- * Linux: CI_DRM_9845 -> Patchwork_19774 CI-20190529: 20190529 CI_DRM_9845: 2532f22e558a98a8a6d8dca97cd34f7af2e68db1 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_6028: f3109d1e3b554903df9109e1e4d10c881b3f811b @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_19774: 1d49bdae0f725ebdae08ca18ac8b3708fa639ea5 @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == 1d49bdae0f72 i915: Drop legacy execbuffer support == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/index.html [-- Attachment #1.2: Type: text/html, Size: 5775 bytes --] [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] i915: Drop legacy execbuffer support 2021-03-10 21:00 ` [Intel-gfx] " Jason Ekstrand @ 2021-03-10 22:04 ` Keith Packard -1 siblings, 0 replies; 17+ messages in thread From: Keith Packard @ 2021-03-10 22:04 UTC (permalink / raw) To: Jason Ekstrand, dri-devel, intel-gfx, airlied; +Cc: Jason Ekstrand [-- Attachment #1.1: Type: text/plain, Size: 653 bytes --] Jason Ekstrand <jason@jlekstrand.net> writes: > libdrm has supported the newer execbuffer2 ioctl and using it by default > when it exists since libdrm commit b50964027bef249a0cc3d511de05c2464e0a1e22 > which landed Mar 2, 2010. The i915 and i965 drivers in Mesa at the time > both used libdrm and so did the Intel X11 back-end. The SNA back-end > for X11 has always used execbuffer2. All execbuffer users in the past that I'm aware of used libdrm, which now uses the execbuffer2 ioctl for this API. That means these applications will remain ABI compatible through this change. Acked-by: Keith Packard <keithp@keithp.com> -- -keith [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 832 bytes --] [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [Intel-gfx] [PATCH] i915: Drop legacy execbuffer support @ 2021-03-10 22:04 ` Keith Packard 0 siblings, 0 replies; 17+ messages in thread From: Keith Packard @ 2021-03-10 22:04 UTC (permalink / raw) To: Jason Ekstrand, dri-devel, intel-gfx, airlied [-- Attachment #1.1: Type: text/plain, Size: 653 bytes --] Jason Ekstrand <jason@jlekstrand.net> writes: > libdrm has supported the newer execbuffer2 ioctl and using it by default > when it exists since libdrm commit b50964027bef249a0cc3d511de05c2464e0a1e22 > which landed Mar 2, 2010. The i915 and i965 drivers in Mesa at the time > both used libdrm and so did the Intel X11 back-end. The SNA back-end > for X11 has always used execbuffer2. All execbuffer users in the past that I'm aware of used libdrm, which now uses the execbuffer2 ioctl for this API. That means these applications will remain ABI compatible through this change. Acked-by: Keith Packard <keithp@keithp.com> -- -keith [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 832 bytes --] [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [Intel-gfx] [PATCH] i915: Drop legacy execbuffer support 2021-03-10 22:04 ` [Intel-gfx] " Keith Packard @ 2021-03-11 19:08 ` Dave Airlie -1 siblings, 0 replies; 17+ messages in thread From: Dave Airlie @ 2021-03-11 19:08 UTC (permalink / raw) To: Keith Packard Cc: Dave Airlie, Intel Graphics Development, dri-devel, Jason Ekstrand On Thu, 11 Mar 2021 at 08:04, Keith Packard <keithp@keithp.com> wrote: > > Jason Ekstrand <jason@jlekstrand.net> writes: > > > libdrm has supported the newer execbuffer2 ioctl and using it by default > > when it exists since libdrm commit b50964027bef249a0cc3d511de05c2464e0a1e22 > > which landed Mar 2, 2010. The i915 and i965 drivers in Mesa at the time > > both used libdrm and so did the Intel X11 back-end. The SNA back-end > > for X11 has always used execbuffer2. > > All execbuffer users in the past that I'm aware of used libdrm, which > now uses the execbuffer2 ioctl for this API. That means these > applications will remain ABI compatible through this change. > > Acked-by: Keith Packard <keithp@keithp.com> Acked-by: Dave Airlie <airlied@redhat.com> Dave. _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [Intel-gfx] [PATCH] i915: Drop legacy execbuffer support @ 2021-03-11 19:08 ` Dave Airlie 0 siblings, 0 replies; 17+ messages in thread From: Dave Airlie @ 2021-03-11 19:08 UTC (permalink / raw) To: Keith Packard; +Cc: Dave Airlie, Intel Graphics Development, dri-devel On Thu, 11 Mar 2021 at 08:04, Keith Packard <keithp@keithp.com> wrote: > > Jason Ekstrand <jason@jlekstrand.net> writes: > > > libdrm has supported the newer execbuffer2 ioctl and using it by default > > when it exists since libdrm commit b50964027bef249a0cc3d511de05c2464e0a1e22 > > which landed Mar 2, 2010. The i915 and i965 drivers in Mesa at the time > > both used libdrm and so did the Intel X11 back-end. The SNA back-end > > for X11 has always used execbuffer2. > > All execbuffer users in the past that I'm aware of used libdrm, which > now uses the execbuffer2 ioctl for this API. That means these > applications will remain ABI compatible through this change. > > Acked-by: Keith Packard <keithp@keithp.com> Acked-by: Dave Airlie <airlied@redhat.com> Dave. _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 17+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for i915: Drop legacy execbuffer support 2021-03-10 21:00 ` [Intel-gfx] " Jason Ekstrand ` (3 preceding siblings ...) (?) @ 2021-03-10 23:48 ` Patchwork -1 siblings, 0 replies; 17+ messages in thread From: Patchwork @ 2021-03-10 23:48 UTC (permalink / raw) To: Jason Ekstrand; +Cc: intel-gfx [-- Attachment #1.1: Type: text/plain, Size: 30259 bytes --] == Series Details == Series: i915: Drop legacy execbuffer support URL : https://patchwork.freedesktop.org/series/87854/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9845_full -> Patchwork_19774_full ==================================================== Summary ------- **FAILURE** Serious unknown changes coming with Patchwork_19774_full absolutely need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in Patchwork_19774_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. Possible new issues ------------------- Here are the unknown changes that may have been introduced in Patchwork_19774_full: ### IGT changes ### #### Possible regressions #### * igt@kms_plane_scaling@plane-scaling: - shard-snb: NOTRUN -> [INCOMPLETE][1] [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/shard-snb5/igt@kms_plane_scaling@plane-scaling.html * igt@kms_plane_scaling@scaler-with-clipping-clamping: - shard-apl: NOTRUN -> [INCOMPLETE][2] +1 similar issue [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/shard-apl7/igt@kms_plane_scaling@scaler-with-clipping-clamping.html * igt@kms_plane_scaling@scaler-with-pixel-format: - shard-skl: NOTRUN -> [INCOMPLETE][3] [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/shard-skl6/igt@kms_plane_scaling@scaler-with-pixel-format.html - shard-iclb: NOTRUN -> [INCOMPLETE][4] [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/shard-iclb3/igt@kms_plane_scaling@scaler-with-pixel-format.html Known issues ------------ Here are the changes found in Patchwork_19774_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_ctx_persistence@legacy-engines-queued: - shard-snb: NOTRUN -> [SKIP][5] ([fdo#109271] / [i915#1099]) +5 similar issues [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/shard-snb7/igt@gem_ctx_persistence@legacy-engines-queued.html * igt@gem_eio@in-flight-suspend: - shard-kbl: NOTRUN -> [DMESG-WARN][6] ([i915#180]) [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/shard-kbl6/igt@gem_eio@in-flight-suspend.html * igt@gem_exec_fair@basic-none@vcs0: - shard-glk: [PASS][7] -> [FAIL][8] ([i915#2842]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9845/shard-glk3/igt@gem_exec_fair@basic-none@vcs0.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/shard-glk9/igt@gem_exec_fair@basic-none@vcs0.html * igt@gem_exec_fair@basic-none@vecs0: - shard-kbl: [PASS][9] -> [FAIL][10] ([i915#2842]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9845/shard-kbl1/igt@gem_exec_fair@basic-none@vecs0.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/shard-kbl4/igt@gem_exec_fair@basic-none@vecs0.html * igt@gem_exec_fair@basic-pace-share@rcs0: - shard-tglb: [PASS][11] -> [FAIL][12] ([i915#2842]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9845/shard-tglb1/igt@gem_exec_fair@basic-pace-share@rcs0.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/shard-tglb8/igt@gem_exec_fair@basic-pace-share@rcs0.html * igt@gem_exec_fair@basic-pace@vecs0: - shard-iclb: [PASS][13] -> [FAIL][14] ([i915#2842]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9845/shard-iclb1/igt@gem_exec_fair@basic-pace@vecs0.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/shard-iclb3/igt@gem_exec_fair@basic-pace@vecs0.html * igt@gem_exec_reloc@basic-cpu-gtt-active: - shard-skl: [PASS][15] -> [DMESG-WARN][16] ([i915#1982]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9845/shard-skl4/igt@gem_exec_reloc@basic-cpu-gtt-active.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/shard-skl9/igt@gem_exec_reloc@basic-cpu-gtt-active.html * igt@gem_exec_reloc@basic-many-active@rcs0: - shard-glk: [PASS][17] -> [FAIL][18] ([i915#2389]) [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9845/shard-glk9/igt@gem_exec_reloc@basic-many-active@rcs0.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/shard-glk7/igt@gem_exec_reloc@basic-many-active@rcs0.html * igt@gem_exec_suspend@basic-s3: - shard-apl: [PASS][19] -> [DMESG-WARN][20] ([i915#180]) [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9845/shard-apl8/igt@gem_exec_suspend@basic-s3.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/shard-apl7/igt@gem_exec_suspend@basic-s3.html * igt@gem_media_vme: - shard-tglb: NOTRUN -> [SKIP][21] ([i915#284]) [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/shard-tglb1/igt@gem_media_vme.html * igt@gem_mmap_gtt@cpuset-big-copy-odd: - shard-iclb: [PASS][22] -> [FAIL][23] ([i915#2428]) [22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9845/shard-iclb8/igt@gem_mmap_gtt@cpuset-big-copy-odd.html [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/shard-iclb4/igt@gem_mmap_gtt@cpuset-big-copy-odd.html - shard-glk: [PASS][24] -> [FAIL][25] ([i915#307]) [24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9845/shard-glk7/igt@gem_mmap_gtt@cpuset-big-copy-odd.html [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/shard-glk2/igt@gem_mmap_gtt@cpuset-big-copy-odd.html * igt@gem_mmap_gtt@cpuset-big-copy-xy: - shard-iclb: [PASS][26] -> [FAIL][27] ([i915#307]) [26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9845/shard-iclb8/igt@gem_mmap_gtt@cpuset-big-copy-xy.html [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/shard-iclb1/igt@gem_mmap_gtt@cpuset-big-copy-xy.html * igt@gem_pwrite@basic-exhaustion: - shard-snb: NOTRUN -> [WARN][28] ([i915#2658]) [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/shard-snb5/igt@gem_pwrite@basic-exhaustion.html * igt@gem_render_copy@yf-tiled-mc-ccs-to-vebox-yf-tiled: - shard-iclb: NOTRUN -> [SKIP][29] ([i915#768]) [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/shard-iclb3/igt@gem_render_copy@yf-tiled-mc-ccs-to-vebox-yf-tiled.html * igt@gen3_render_mixed_blits: - shard-tglb: NOTRUN -> [SKIP][30] ([fdo#109289]) +1 similar issue [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/shard-tglb1/igt@gen3_render_mixed_blits.html * igt@gen7_exec_parse@bitmasks: - shard-iclb: NOTRUN -> [SKIP][31] ([fdo#109289]) [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/shard-iclb3/igt@gen7_exec_parse@bitmasks.html * igt@gen9_exec_parse@unaligned-jump: - shard-iclb: NOTRUN -> [SKIP][32] ([fdo#112306]) [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/shard-iclb3/igt@gen9_exec_parse@unaligned-jump.html * igt@i915_pm_dc@dc6-dpms: - shard-skl: NOTRUN -> [FAIL][33] ([i915#454]) [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/shard-skl1/igt@i915_pm_dc@dc6-dpms.html * igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp: - shard-apl: NOTRUN -> [SKIP][34] ([fdo#109271] / [i915#1937]) [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/shard-apl2/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp.html * igt@i915_pm_rpm@dpms-non-lpsp: - shard-iclb: NOTRUN -> [SKIP][35] ([fdo#110892]) [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/shard-iclb3/igt@i915_pm_rpm@dpms-non-lpsp.html * igt@kms_async_flips@alternate-sync-async-flip: - shard-glk: [PASS][36] -> [FAIL][37] ([i915#2521]) [36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9845/shard-glk1/igt@kms_async_flips@alternate-sync-async-flip.html [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/shard-glk5/igt@kms_async_flips@alternate-sync-async-flip.html * igt@kms_atomic_transition@plane-all-transition-nonblocking@dp-1-pipe-b: - shard-kbl: [PASS][38] -> [FAIL][39] ([i915#3168]) [38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9845/shard-kbl2/igt@kms_atomic_transition@plane-all-transition-nonblocking@dp-1-pipe-b.html [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/shard-kbl3/igt@kms_atomic_transition@plane-all-transition-nonblocking@dp-1-pipe-b.html * igt@kms_big_fb@yf-tiled-64bpp-rotate-180: - shard-iclb: NOTRUN -> [SKIP][40] ([fdo#110723]) [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/shard-iclb3/igt@kms_big_fb@yf-tiled-64bpp-rotate-180.html * igt@kms_ccs@pipe-c-bad-pixel-format: - shard-skl: NOTRUN -> [SKIP][41] ([fdo#109271] / [fdo#111304]) [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/shard-skl6/igt@kms_ccs@pipe-c-bad-pixel-format.html * igt@kms_ccs@pipe-c-ccs-on-another-bo: - shard-kbl: NOTRUN -> [SKIP][42] ([fdo#109271]) +5 similar issues [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/shard-kbl6/igt@kms_ccs@pipe-c-ccs-on-another-bo.html * igt@kms_chamelium@dp-frame-dump: - shard-iclb: NOTRUN -> [SKIP][43] ([fdo#109284] / [fdo#111827]) +2 similar issues [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/shard-iclb3/igt@kms_chamelium@dp-frame-dump.html * igt@kms_chamelium@hdmi-edid-change-during-suspend: - shard-apl: NOTRUN -> [SKIP][44] ([fdo#109271] / [fdo#111827]) +26 similar issues [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/shard-apl7/igt@kms_chamelium@hdmi-edid-change-during-suspend.html * igt@kms_color_chamelium@pipe-c-ctm-red-to-blue: - shard-snb: NOTRUN -> [SKIP][45] ([fdo#109271] / [fdo#111827]) +17 similar issues [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/shard-snb5/igt@kms_color_chamelium@pipe-c-ctm-red-to-blue.html * igt@kms_color_chamelium@pipe-d-ctm-0-75: - shard-skl: NOTRUN -> [SKIP][46] ([fdo#109271] / [fdo#111827]) +12 similar issues [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/shard-skl6/igt@kms_color_chamelium@pipe-d-ctm-0-75.html - shard-iclb: NOTRUN -> [SKIP][47] ([fdo#109278] / [fdo#109284] / [fdo#111827]) [47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/shard-iclb3/igt@kms_color_chamelium@pipe-d-ctm-0-75.html * igt@kms_color_chamelium@pipe-d-ctm-blue-to-red: - shard-glk: NOTRUN -> [SKIP][48] ([fdo#109271] / [fdo#111827]) [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/shard-glk8/igt@kms_color_chamelium@pipe-d-ctm-blue-to-red.html * igt@kms_content_protection@lic: - shard-apl: NOTRUN -> [TIMEOUT][49] ([i915#1319]) [49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/shard-apl7/igt@kms_content_protection@lic.html * igt@kms_cursor_crc@pipe-c-cursor-suspend: - shard-kbl: [PASS][50] -> [DMESG-WARN][51] ([i915#180]) [50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9845/shard-kbl7/igt@kms_cursor_crc@pipe-c-cursor-suspend.html [51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/shard-kbl7/igt@kms_cursor_crc@pipe-c-cursor-suspend.html * igt@kms_cursor_crc@pipe-d-cursor-64x64-rapid-movement: - shard-iclb: NOTRUN -> [SKIP][52] ([fdo#109278]) +4 similar issues [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/shard-iclb3/igt@kms_cursor_crc@pipe-d-cursor-64x64-rapid-movement.html * igt@kms_cursor_legacy@cursorb-vs-flipb-toggle: - shard-iclb: NOTRUN -> [SKIP][53] ([fdo#109274] / [fdo#109278]) [53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/shard-iclb3/igt@kms_cursor_legacy@cursorb-vs-flipb-toggle.html * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions: - shard-skl: NOTRUN -> [FAIL][54] ([i915#2346]) [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/shard-skl1/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html * igt@kms_cursor_legacy@pipe-d-torture-move: - shard-skl: NOTRUN -> [SKIP][55] ([fdo#109271]) +123 similar issues [55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/shard-skl2/igt@kms_cursor_legacy@pipe-d-torture-move.html * igt@kms_flip@2x-single-buffer-flip-vs-dpms-off-vs-modeset-interruptible: - shard-iclb: NOTRUN -> [SKIP][56] ([fdo#109274]) [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/shard-iclb3/igt@kms_flip@2x-single-buffer-flip-vs-dpms-off-vs-modeset-interruptible.html * igt@kms_flip@plain-flip-fb-recreate-interruptible@c-edp1: - shard-skl: [PASS][57] -> [FAIL][58] ([i915#2122]) +2 similar issues [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9845/shard-skl7/igt@kms_flip@plain-flip-fb-recreate-interruptible@c-edp1.html [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/shard-skl3/igt@kms_flip@plain-flip-fb-recreate-interruptible@c-edp1.html * igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs: - shard-apl: NOTRUN -> [SKIP][59] ([fdo#109271] / [i915#2672]) [59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/shard-apl2/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs.html * igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile: - shard-apl: NOTRUN -> [SKIP][60] ([fdo#109271] / [i915#2642]) [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/shard-apl6/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile.html * igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile: - shard-snb: NOTRUN -> [SKIP][61] ([fdo#109271]) +267 similar issues [61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/shard-snb7/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile.html * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-blt: - shard-iclb: NOTRUN -> [SKIP][62] ([fdo#109280]) +8 similar issues [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/shard-iclb3/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-blt.html * igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-shrfb-pgflip-blt: - shard-tglb: NOTRUN -> [SKIP][63] ([fdo#111825]) +7 similar issues [63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/shard-tglb1/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-shrfb-pgflip-blt.html * igt@kms_frontbuffer_tracking@fbcpsr-1p-indfb-fliptrack: - shard-glk: NOTRUN -> [SKIP][64] ([fdo#109271]) +16 similar issues [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/shard-glk8/igt@kms_frontbuffer_tracking@fbcpsr-1p-indfb-fliptrack.html * igt@kms_hdr@bpc-switch-dpms: - shard-skl: NOTRUN -> [FAIL][65] ([i915#1188]) +2 similar issues [65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/shard-skl6/igt@kms_hdr@bpc-switch-dpms.html * igt@kms_pipe_crc_basic@disable-crc-after-crtc-pipe-d: - shard-skl: NOTRUN -> [SKIP][66] ([fdo#109271] / [i915#533]) [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/shard-skl6/igt@kms_pipe_crc_basic@disable-crc-after-crtc-pipe-d.html * igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes: - shard-kbl: [PASS][67] -> [DMESG-WARN][68] ([i915#180] / [i915#533]) [67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9845/shard-kbl2/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/shard-kbl7/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html * igt@kms_plane_alpha_blend@pipe-a-alpha-basic: - shard-apl: NOTRUN -> [FAIL][69] ([fdo#108145] / [i915#265]) +3 similar issues [69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/shard-apl7/igt@kms_plane_alpha_blend@pipe-a-alpha-basic.html * igt@kms_plane_alpha_blend@pipe-a-alpha-transparent-fb: - shard-skl: NOTRUN -> [FAIL][70] ([i915#265]) [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/shard-skl2/igt@kms_plane_alpha_blend@pipe-a-alpha-transparent-fb.html * igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min: - shard-skl: NOTRUN -> [FAIL][71] ([fdo#108145] / [i915#265]) +2 similar issues [71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/shard-skl10/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html * igt@kms_plane_multiple@atomic-pipe-b-tiling-yf: - shard-tglb: NOTRUN -> [SKIP][72] ([fdo#111615]) +1 similar issue [72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/shard-tglb1/igt@kms_plane_multiple@atomic-pipe-b-tiling-yf.html * igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-2: - shard-apl: NOTRUN -> [SKIP][73] ([fdo#109271] / [i915#658]) +7 similar issues [73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/shard-apl6/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-2.html * igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-5: - shard-skl: NOTRUN -> [SKIP][74] ([fdo#109271] / [i915#658]) +2 similar issues [74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/shard-skl2/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-5.html * igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-2: - shard-iclb: NOTRUN -> [SKIP][75] ([i915#658]) [75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/shard-iclb3/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-2.html * igt@kms_psr2_su@page_flip: - shard-kbl: NOTRUN -> [SKIP][76] ([fdo#109271] / [i915#658]) [76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/shard-kbl6/igt@kms_psr2_su@page_flip.html * igt@kms_psr@psr2_dpms: - shard-iclb: [PASS][77] -> [SKIP][78] ([fdo#109441]) +2 similar issues [77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9845/shard-iclb2/igt@kms_psr@psr2_dpms.html [78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/shard-iclb1/igt@kms_psr@psr2_dpms.html * igt@kms_sysfs_edid_timing: - shard-apl: NOTRUN -> [FAIL][79] ([IGT#2]) [79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/shard-apl3/igt@kms_sysfs_edid_timing.html - shard-skl: NOTRUN -> [FAIL][80] ([IGT#2]) [80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/shard-skl1/igt@kms_sysfs_edid_timing.html * igt@kms_vblank@pipe-d-ts-continuation-idle: - shard-apl: NOTRUN -> [SKIP][81] ([fdo#109271]) +256 similar issues [81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/shard-apl6/igt@kms_vblank@pipe-d-ts-continuation-idle.html * igt@kms_vblank@pipe-d-wait-idle: - shard-apl: NOTRUN -> [SKIP][82] ([fdo#109271] / [i915#533]) +4 similar issues [82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/shard-apl2/igt@kms_vblank@pipe-d-wait-idle.html * igt@kms_writeback@writeback-invalid-parameters: - shard-apl: NOTRUN -> [SKIP][83] ([fdo#109271] / [i915#2437]) +1 similar issue [83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/shard-apl7/igt@kms_writeback@writeback-invalid-parameters.html * igt@kms_writeback@writeback-pixel-formats: - shard-skl: NOTRUN -> [SKIP][84] ([fdo#109271] / [i915#2437]) [84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/shard-skl1/igt@kms_writeback@writeback-pixel-formats.html * igt@nouveau_crc@pipe-b-ctx-flip-detection: - shard-tglb: NOTRUN -> [SKIP][85] ([i915#2530]) [85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/shard-tglb1/igt@nouveau_crc@pipe-b-ctx-flip-detection.html * igt@nouveau_crc@pipe-b-source-rg: - shard-iclb: NOTRUN -> [SKIP][86] ([i915#2530]) [86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/shard-iclb3/igt@nouveau_crc@pipe-b-source-rg.html * igt@perf@polling-parameterized: - shard-tglb: [PASS][87] -> [FAIL][88] ([i915#1542]) [87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9845/shard-tglb3/igt@perf@polling-parameterized.html [88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/shard-tglb3/igt@perf@polling-parameterized.html * igt@prime_nv_pcopy@test3_2: - shard-iclb: NOTRUN -> [SKIP][89] ([fdo#109291]) [89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/shard-iclb3/igt@prime_nv_pcopy@test3_2.html * igt@prime_nv_test@nv_write_i915_cpu_mmap_read: - shard-tglb: NOTRUN -> [SKIP][90] ([fdo#109291]) [90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/shard-tglb1/igt@prime_nv_test@nv_write_i915_cpu_mmap_read.html * igt@sysfs_clients@recycle-many: - shard-iclb: [PASS][91] -> [FAIL][92] ([i915#3028]) +1 similar issue [91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9845/shard-iclb4/igt@sysfs_clients@recycle-many.html [92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/shard-iclb3/igt@sysfs_clients@recycle-many.html - shard-tglb: [PASS][93] -> [FAIL][94] ([i915#3028]) [93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9845/shard-tglb5/igt@sysfs_clients@recycle-many.html [94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/shard-tglb1/igt@sysfs_clients@recycle-many.html * igt@sysfs_clients@sema-10@vcs0: - shard-apl: NOTRUN -> [SKIP][95] ([fdo#109271] / [i915#3026]) +2 similar issues [95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/shard-apl2/igt@sysfs_clients@sema-10@vcs0.html #### Possible fixes #### * igt@gem_exec_balancer@hang: - shard-iclb: [INCOMPLETE][96] ([i915#1895] / [i915#3031]) -> [PASS][97] [96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9845/shard-iclb1/igt@gem_exec_balancer@hang.html [97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/shard-iclb3/igt@gem_exec_balancer@hang.html * igt@gem_exec_fair@basic-deadline: - shard-glk: [FAIL][98] ([i915#2846]) -> [PASS][99] [98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9845/shard-glk5/igt@gem_exec_fair@basic-deadline.html [99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/shard-glk4/igt@gem_exec_fair@basic-deadline.html * igt@gem_exec_fair@basic-pace@vcs0: - shard-kbl: [FAIL][100] ([i915#2842]) -> [PASS][101] [100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9845/shard-kbl3/igt@gem_exec_fair@basic-pace@vcs0.html [101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/shard-kbl1/igt@gem_exec_fair@basic-pace@vcs0.html * igt@gem_exec_fair@basic-throttle@rcs0: - shard-glk: [FAIL][102] ([i915#2842]) -> [PASS][103] +1 similar issue [102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9845/shard-glk1/igt@gem_exec_fair@basic-throttle@rcs0.html [103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/shard-glk5/igt@gem_exec_fair@basic-throttle@rcs0.html * igt@gem_exec_reloc@basic-many-active@rcs0: - shard-apl: [FAIL][104] ([i915#2389]) -> [PASS][105] [104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9845/shard-apl8/igt@gem_exec_reloc@basic-many-active@rcs0.html [105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/shard-apl3/igt@gem_exec_reloc@basic-many-active@rcs0.html * igt@gem_exec_schedule@u-fairslice@bcs0: - shard-tglb: [DMESG-WARN][106] ([i915#2803]) -> [PASS][107] [106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9845/shard-tglb7/igt@gem_exec_schedule@u-fairslice@bcs0.html [107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/shard-tglb1/igt@gem_exec_schedule@u-fairslice@bcs0.html * igt@gem_exec_schedule@u-fairslice@rcs0: - shard-apl: [DMESG-WARN][108] ([i915#1610]) -> [PASS][109] [108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9845/shard-apl3/igt@gem_exec_schedule@u-fairslice@rcs0.html [109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/shard-apl8/igt@gem_exec_schedule@u-fairslice@rcs0.html * igt@gem_mmap_gtt@cpuset-basic-small-copy: - shard-iclb: [FAIL][110] ([i915#307]) -> [PASS][111] +1 similar issue [110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9845/shard-iclb5/igt@gem_mmap_gtt@cpuset-basic-small-copy.html [111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/shard-iclb8/igt@gem_mmap_gtt@cpuset-basic-small-copy.html * igt@gen9_exec_parse@allowed-all: - shard-glk: [DMESG-WARN][112] ([i915#1436] / [i915#716]) -> [PASS][113] [112]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9845/shard-glk9/igt@gen9_exec_parse@allowed-all.html [113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/shard-glk8/igt@gen9_exec_parse@allowed-all.html * igt@i915_selftest@live@hangcheck: - shard-snb: [INCOMPLETE][114] ([i915#2782]) -> [PASS][115] [114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9845/shard-snb6/igt@i915_selftest@live@hangcheck.html [115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/shard-snb6/igt@i915_selftest@live@hangcheck.html * igt@i915_suspend@fence-restore-untiled: - shard-skl: [INCOMPLETE][116] ([i915#198]) -> [PASS][117] [116]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9845/shard-skl10/igt@i915_suspend@fence-restore-untiled.html [117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/shard-skl6/igt@i915_suspend@fence-restore-untiled.html * igt@kms_cursor_legacy@flip-vs-cursor-atomic: - shard-skl: [FAIL][118] ([i915#2346]) -> [PASS][119] [118]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9845/shard-skl3/igt@kms_cursor_legacy@flip-vs-cursor-atomic.html [119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/shard-skl3/igt@kms_cursor_legacy@flip-vs-cursor-atomic.html * igt@kms_fbcon_fbt@fbc-suspend: - shard-kbl: [INCOMPLETE][120] ([i915#155] / [i915#180] / [i915#636]) -> [PASS][121] [120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9845/shard-kbl7/igt@kms_fbcon_fbt@fbc-suspend.html [121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/shard-kbl6/igt@kms_fbcon_fbt@fbc-suspend.html * igt@kms_flip@flip-vs-expired-vblank@a-hdmi-a2: - shard-glk: [FAIL][122] ([i915#79]) -> [PASS][123] [122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9845/shard-glk2/igt@kms_flip@flip-vs-expired-vblank@a-hdmi-a2.html [123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/shard-glk4/igt@kms_flip@flip-vs-expired-vblank@a-hdmi-a2.html * igt@kms_frontbuffer_tracking@fbc-suspend: - shard-apl: [DMESG-WARN][124] ([i915#180] / [i915#1982]) -> [PASS][125] [124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9845/shard-apl6/igt@kms_frontbuffer_tracking@fbc-suspend.html [125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/shard-apl7/igt@kms_frontbuffer_tracking@fbc-suspend.html * igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min: - shard-skl: [FAIL][126] ([fdo#108145] / [i915#265]) -> [PASS][127] [126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9845/shard-skl5/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html [127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/shard-skl2/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html * igt@kms_psr@psr2_cursor_plane_move: - shard-iclb: [SKIP][128] ([fdo#109441]) -> [PASS][129] [128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9845/shard-iclb4/igt@kms_psr@psr2_cursor_plane_move.html [129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/shard-iclb2/igt@kms_psr@psr2_cursor_plane_move.html * igt@sysfs_clients@recycle-many: - shard-apl: [FAIL][130] ([i915#3028]) -> [PASS][131] [130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9845/shard-apl2/igt@sysfs_clients@recycle-many.html [131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/shard-apl1/igt@sysfs_clients@recycle-many.html - shard-skl: [FAIL][132] ([i915#3028]) -> [PASS][133] [132]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9845/shard-skl2/igt@sysfs_clients@recycle-many.html [133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/shard-skl2/igt@sysfs_clients@recycle-many.html #### Warnings #### * igt@gem_exec_fair@basic-throttle@rcs0: - shard-iclb: [FAIL][134] ([i915#2842]) -> [FAIL][135] ([i915#2849]) [134]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9845/shard-iclb2/igt@gem_exec_fair@basic-throttle@rcs0.html [135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/shard-iclb2/igt@gem_exec_fair@basic-throttle@rcs0.html * igt@i915_pm_rc6_residency@rc6-idle: - shard-iclb: [WARN][136] ([i915#2684]) -> [WARN][137] ([i915#2681] / [i915#2684]) [136]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9845/shard-iclb2/igt@i915_pm_rc6_residency@rc6-idle.html [137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/shard-iclb1/igt@i915_pm_rc6_residency@rc6-idle.html * igt@kms_content_protection@atomic: - shard-iclb: [SKIP][138] ([fdo#109300] / [fdo#111066]) -> [FAIL][139] ([i915#3144]) [138]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9845/shard-iclb3/igt@kms_content_protection@atomic.html [139]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/shard-iclb1/igt@kms_content_protection@atomic.html * igt@kms_content_protection@dp-mst-lic-type-0: - shard-iclb: [SKIP][140] ([i915#3116]) -> [FAIL][141] ([i915#3144]) [140]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9845/shard-iclb8/igt@kms_content_protection@dp-mst-lic-type-0.html [141]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/shard-iclb1/igt@kms_content_protection@dp-mst-lic-type-0.html * igt@kms_content_protection@uevent: - shard-iclb: [FAIL][142] ([i915#3144]) -> [SKIP][143] ([fdo#109300] / [fdo#111066]) [142]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9845/shard-iclb1/igt@kms_content_protection@ == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19774/index.html [-- Attachment #1.2: Type: text/html, Size: 33584 bytes --] [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] i915: Drop legacy execbuffer support 2021-03-10 21:00 ` [Intel-gfx] " Jason Ekstrand @ 2021-03-12 2:25 ` Dixit, Ashutosh -1 siblings, 0 replies; 17+ messages in thread From: Dixit, Ashutosh @ 2021-03-12 2:25 UTC (permalink / raw) To: Jason Ekstrand; +Cc: intel-gfx, dri-devel On Wed, 10 Mar 2021 13:00:49 -0800, Jason Ekstrand wrote: > > libdrm has supported the newer execbuffer2 ioctl and using it by default > when it exists since libdrm commit b50964027bef249a0cc3d511de05c2464e0a1e22 > which landed Mar 2, 2010. The i915 and i965 drivers in Mesa at the time > both used libdrm and so did the Intel X11 back-end. The SNA back-end > for X11 has always used execbuffer2. > > Signed-off-by: Jason Ekstrand <jason@jlekstrand.net> > --- > .../gpu/drm/i915/gem/i915_gem_execbuffer.c | 100 ------------------ > drivers/gpu/drm/i915/gem/i915_gem_ioctls.h | 2 - > drivers/gpu/drm/i915/i915_drv.c | 2 +- > 3 files changed, 1 insertion(+), 103 deletions(-) Don't we want to clean up references to legacy execbuffer in include/uapi/drm/i915_drm.h too? _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [Intel-gfx] [PATCH] i915: Drop legacy execbuffer support @ 2021-03-12 2:25 ` Dixit, Ashutosh 0 siblings, 0 replies; 17+ messages in thread From: Dixit, Ashutosh @ 2021-03-12 2:25 UTC (permalink / raw) To: Jason Ekstrand; +Cc: intel-gfx, dri-devel On Wed, 10 Mar 2021 13:00:49 -0800, Jason Ekstrand wrote: > > libdrm has supported the newer execbuffer2 ioctl and using it by default > when it exists since libdrm commit b50964027bef249a0cc3d511de05c2464e0a1e22 > which landed Mar 2, 2010. The i915 and i965 drivers in Mesa at the time > both used libdrm and so did the Intel X11 back-end. The SNA back-end > for X11 has always used execbuffer2. > > Signed-off-by: Jason Ekstrand <jason@jlekstrand.net> > --- > .../gpu/drm/i915/gem/i915_gem_execbuffer.c | 100 ------------------ > drivers/gpu/drm/i915/gem/i915_gem_ioctls.h | 2 - > drivers/gpu/drm/i915/i915_drv.c | 2 +- > 3 files changed, 1 insertion(+), 103 deletions(-) Don't we want to clean up references to legacy execbuffer in include/uapi/drm/i915_drm.h too? _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] i915: Drop legacy execbuffer support 2021-03-12 2:25 ` [Intel-gfx] " Dixit, Ashutosh @ 2021-03-12 4:31 ` Jason Ekstrand -1 siblings, 0 replies; 17+ messages in thread From: Jason Ekstrand @ 2021-03-12 4:31 UTC (permalink / raw) To: Dixit, Ashutosh; +Cc: intel-gfx, dri-devel [-- Attachment #1.1: Type: text/plain, Size: 996 bytes --] On March 11, 2021 20:26:06 "Dixit, Ashutosh" <ashutosh.dixit@intel.com> wrote: > On Wed, 10 Mar 2021 13:00:49 -0800, Jason Ekstrand wrote: >> >> libdrm has supported the newer execbuffer2 ioctl and using it by default >> when it exists since libdrm commit b50964027bef249a0cc3d511de05c2464e0a1e22 >> which landed Mar 2, 2010. The i915 and i965 drivers in Mesa at the time >> both used libdrm and so did the Intel X11 back-end. The SNA back-end >> for X11 has always used execbuffer2. >> >> Signed-off-by: Jason Ekstrand <jason@jlekstrand.net> >> --- >> .../gpu/drm/i915/gem/i915_gem_execbuffer.c | 100 ------------------ >> drivers/gpu/drm/i915/gem/i915_gem_ioctls.h | 2 - >> drivers/gpu/drm/i915/i915_drv.c | 2 +- >> 3 files changed, 1 insertion(+), 103 deletions(-) > > Don't we want to clean up references to legacy execbuffer in > include/uapi/drm/i915_drm.h too? I thought about that but Daniel said we should leave them. Maybe a comment is in order? --Jason [-- Attachment #1.2: Type: text/html, Size: 2165 bytes --] [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [Intel-gfx] [PATCH] i915: Drop legacy execbuffer support @ 2021-03-12 4:31 ` Jason Ekstrand 0 siblings, 0 replies; 17+ messages in thread From: Jason Ekstrand @ 2021-03-12 4:31 UTC (permalink / raw) To: Dixit, Ashutosh; +Cc: intel-gfx, dri-devel [-- Attachment #1.1: Type: text/plain, Size: 996 bytes --] On March 11, 2021 20:26:06 "Dixit, Ashutosh" <ashutosh.dixit@intel.com> wrote: > On Wed, 10 Mar 2021 13:00:49 -0800, Jason Ekstrand wrote: >> >> libdrm has supported the newer execbuffer2 ioctl and using it by default >> when it exists since libdrm commit b50964027bef249a0cc3d511de05c2464e0a1e22 >> which landed Mar 2, 2010. The i915 and i965 drivers in Mesa at the time >> both used libdrm and so did the Intel X11 back-end. The SNA back-end >> for X11 has always used execbuffer2. >> >> Signed-off-by: Jason Ekstrand <jason@jlekstrand.net> >> --- >> .../gpu/drm/i915/gem/i915_gem_execbuffer.c | 100 ------------------ >> drivers/gpu/drm/i915/gem/i915_gem_ioctls.h | 2 - >> drivers/gpu/drm/i915/i915_drv.c | 2 +- >> 3 files changed, 1 insertion(+), 103 deletions(-) > > Don't we want to clean up references to legacy execbuffer in > include/uapi/drm/i915_drm.h too? I thought about that but Daniel said we should leave them. Maybe a comment is in order? --Jason [-- Attachment #1.2: Type: text/html, Size: 2165 bytes --] [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] i915: Drop legacy execbuffer support 2021-03-12 4:31 ` [Intel-gfx] " Jason Ekstrand @ 2021-03-12 5:58 ` Dixit, Ashutosh -1 siblings, 0 replies; 17+ messages in thread From: Dixit, Ashutosh @ 2021-03-12 5:58 UTC (permalink / raw) To: Jason Ekstrand; +Cc: intel-gfx, dri-devel On Thu, 11 Mar 2021 20:31:33 -0800, Jason Ekstrand wrote: > On March 11, 2021 20:26:06 "Dixit, Ashutosh" <ashutosh.dixit@intel.com> wrote: > On Wed, 10 Mar 2021 13:00:49 -0800, Jason Ekstrand wrote: > > libdrm has supported the newer execbuffer2 ioctl and using it by default > when it exists since libdrm commit b50964027bef249a0cc3d511de05c2464e0a1e22 > which landed Mar 2, 2010. The i915 and i965 drivers in Mesa at the time > both used libdrm and so did the Intel X11 back-end. The SNA back-end > for X11 has always used execbuffer2. > > Signed-off-by: Jason Ekstrand <jason@jlekstrand.net> > --- > .../gpu/drm/i915/gem/i915_gem_execbuffer.c | 100 ------------------ > drivers/gpu/drm/i915/gem/i915_gem_ioctls.h | 2 - > drivers/gpu/drm/i915/i915_drv.c | 2 +- > 3 files changed, 1 insertion(+), 103 deletions(-) > > Don't we want to clean up references to legacy execbuffer in > include/uapi/drm/i915_drm.h too? > > I thought about that but Daniel said we should leave them. Maybe a > comment is in order? No, should be ok since we are using drm_invalid_op(). If we want to delete the unused 'struct drm_i915_gem_execbuffer' we can do that by converting from DRM_IOW to DRM_IO in the DRM_IOCTL_I915_GEM_EXECBUFFER #define. _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [Intel-gfx] [PATCH] i915: Drop legacy execbuffer support @ 2021-03-12 5:58 ` Dixit, Ashutosh 0 siblings, 0 replies; 17+ messages in thread From: Dixit, Ashutosh @ 2021-03-12 5:58 UTC (permalink / raw) To: Jason Ekstrand; +Cc: intel-gfx, dri-devel On Thu, 11 Mar 2021 20:31:33 -0800, Jason Ekstrand wrote: > On March 11, 2021 20:26:06 "Dixit, Ashutosh" <ashutosh.dixit@intel.com> wrote: > On Wed, 10 Mar 2021 13:00:49 -0800, Jason Ekstrand wrote: > > libdrm has supported the newer execbuffer2 ioctl and using it by default > when it exists since libdrm commit b50964027bef249a0cc3d511de05c2464e0a1e22 > which landed Mar 2, 2010. The i915 and i965 drivers in Mesa at the time > both used libdrm and so did the Intel X11 back-end. The SNA back-end > for X11 has always used execbuffer2. > > Signed-off-by: Jason Ekstrand <jason@jlekstrand.net> > --- > .../gpu/drm/i915/gem/i915_gem_execbuffer.c | 100 ------------------ > drivers/gpu/drm/i915/gem/i915_gem_ioctls.h | 2 - > drivers/gpu/drm/i915/i915_drv.c | 2 +- > 3 files changed, 1 insertion(+), 103 deletions(-) > > Don't we want to clean up references to legacy execbuffer in > include/uapi/drm/i915_drm.h too? > > I thought about that but Daniel said we should leave them. Maybe a > comment is in order? No, should be ok since we are using drm_invalid_op(). If we want to delete the unused 'struct drm_i915_gem_execbuffer' we can do that by converting from DRM_IOW to DRM_IO in the DRM_IOCTL_I915_GEM_EXECBUFFER #define. _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [Intel-gfx] [PATCH] i915: Drop legacy execbuffer support 2021-03-12 4:31 ` [Intel-gfx] " Jason Ekstrand @ 2021-03-12 14:15 ` Daniel Vetter -1 siblings, 0 replies; 17+ messages in thread From: Daniel Vetter @ 2021-03-12 14:15 UTC (permalink / raw) To: Jason Ekstrand; +Cc: Dixit, Ashutosh, intel-gfx, dri-devel On Thu, Mar 11, 2021 at 10:31:33PM -0600, Jason Ekstrand wrote: > > On March 11, 2021 20:26:06 "Dixit, Ashutosh" <ashutosh.dixit@intel.com> wrote: > > > On Wed, 10 Mar 2021 13:00:49 -0800, Jason Ekstrand wrote: > > > > > > libdrm has supported the newer execbuffer2 ioctl and using it by default > > > when it exists since libdrm commit b50964027bef249a0cc3d511de05c2464e0a1e22 > > > which landed Mar 2, 2010. The i915 and i965 drivers in Mesa at the time > > > both used libdrm and so did the Intel X11 back-end. The SNA back-end > > > for X11 has always used execbuffer2. > > > > > > Signed-off-by: Jason Ekstrand <jason@jlekstrand.net> > > > --- > > > .../gpu/drm/i915/gem/i915_gem_execbuffer.c | 100 ------------------ > > > drivers/gpu/drm/i915/gem/i915_gem_ioctls.h | 2 - > > > drivers/gpu/drm/i915/i915_drv.c | 2 +- > > > 3 files changed, 1 insertion(+), 103 deletions(-) > > > > Don't we want to clean up references to legacy execbuffer in > > include/uapi/drm/i915_drm.h too? > > I thought about that but Daniel said we should leave them. Maybe a comment > is in order? These headers are copied unchanged to userspace for building. We don't use kernel-headers packages directly in any of our userspace (I hope at least), but still better safe than sorry and avoid compilation failures simply due to updated uapi headers that lost a few old things. Also we need at least the struct size because that's encoded in the ioctl number, and at that point might as well keep the entire thing. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [Intel-gfx] [PATCH] i915: Drop legacy execbuffer support @ 2021-03-12 14:15 ` Daniel Vetter 0 siblings, 0 replies; 17+ messages in thread From: Daniel Vetter @ 2021-03-12 14:15 UTC (permalink / raw) To: Jason Ekstrand; +Cc: intel-gfx, dri-devel On Thu, Mar 11, 2021 at 10:31:33PM -0600, Jason Ekstrand wrote: > > On March 11, 2021 20:26:06 "Dixit, Ashutosh" <ashutosh.dixit@intel.com> wrote: > > > On Wed, 10 Mar 2021 13:00:49 -0800, Jason Ekstrand wrote: > > > > > > libdrm has supported the newer execbuffer2 ioctl and using it by default > > > when it exists since libdrm commit b50964027bef249a0cc3d511de05c2464e0a1e22 > > > which landed Mar 2, 2010. The i915 and i965 drivers in Mesa at the time > > > both used libdrm and so did the Intel X11 back-end. The SNA back-end > > > for X11 has always used execbuffer2. > > > > > > Signed-off-by: Jason Ekstrand <jason@jlekstrand.net> > > > --- > > > .../gpu/drm/i915/gem/i915_gem_execbuffer.c | 100 ------------------ > > > drivers/gpu/drm/i915/gem/i915_gem_ioctls.h | 2 - > > > drivers/gpu/drm/i915/i915_drv.c | 2 +- > > > 3 files changed, 1 insertion(+), 103 deletions(-) > > > > Don't we want to clean up references to legacy execbuffer in > > include/uapi/drm/i915_drm.h too? > > I thought about that but Daniel said we should leave them. Maybe a comment > is in order? These headers are copied unchanged to userspace for building. We don't use kernel-headers packages directly in any of our userspace (I hope at least), but still better safe than sorry and avoid compilation failures simply due to updated uapi headers that lost a few old things. Also we need at least the struct size because that's encoded in the ioctl number, and at that point might as well keep the entire thing. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 17+ messages in thread
end of thread, other threads:[~2021-03-12 14:15 UTC | newest] Thread overview: 17+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-03-10 21:00 [PATCH] i915: Drop legacy execbuffer support Jason Ekstrand 2021-03-10 21:00 ` [Intel-gfx] " Jason Ekstrand 2021-03-10 21:11 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork 2021-03-10 21:36 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork 2021-03-10 22:04 ` [PATCH] " Keith Packard 2021-03-10 22:04 ` [Intel-gfx] " Keith Packard 2021-03-11 19:08 ` Dave Airlie 2021-03-11 19:08 ` Dave Airlie 2021-03-10 23:48 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for " Patchwork 2021-03-12 2:25 ` [PATCH] " Dixit, Ashutosh 2021-03-12 2:25 ` [Intel-gfx] " Dixit, Ashutosh 2021-03-12 4:31 ` Jason Ekstrand 2021-03-12 4:31 ` [Intel-gfx] " Jason Ekstrand 2021-03-12 5:58 ` Dixit, Ashutosh 2021-03-12 5:58 ` [Intel-gfx] " Dixit, Ashutosh 2021-03-12 14:15 ` Daniel Vetter 2021-03-12 14:15 ` Daniel Vetter
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.