* [PATCH] MIPS: ralink: fix mt7628 alternative functions names
@ 2017-02-10 9:06 André Draszik
2017-02-10 9:12 ` John Crispin
0 siblings, 1 reply; 3+ messages in thread
From: André Draszik @ 2017-02-10 9:06 UTC (permalink / raw)
To: linux-kernel; +Cc: linux-mips, Ralf Baechle, John Crispin
They're all referenced as utif in the datasheet, not util.
Fixes: 53263a1c6852 ("MIPS: ralink: add mt7628an support")
Fixes: 2b436a351803 ("MIPS: ralink: add MT7628 EPHY LEDs pinmux support")
Signed-off-by: André Draszik <git@andred.net>
---
arch/mips/ralink/mt7620.c | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/arch/mips/ralink/mt7620.c b/arch/mips/ralink/mt7620.c
index 3c7c9bf57bf3..6f892c1f3ad7 100644
--- a/arch/mips/ralink/mt7620.c
+++ b/arch/mips/ralink/mt7620.c
@@ -176,7 +176,7 @@ static struct rt2880_pmx_func spi_cs1_grp_mt7628[] = {
static struct rt2880_pmx_func spis_grp_mt7628[] = {
FUNC("pwm_uart2", 3, 14, 4),
- FUNC("util", 2, 14, 4),
+ FUNC("utif", 2, 14, 4),
FUNC("gpio", 1, 14, 4),
FUNC("spis", 0, 14, 4),
};
@@ -190,28 +190,28 @@ static struct rt2880_pmx_func gpio_grp_mt7628[] = {
static struct rt2880_pmx_func p4led_kn_grp_mt7628[] = {
FUNC("jtag", 3, 30, 1),
- FUNC("util", 2, 30, 1),
+ FUNC("utif", 2, 30, 1),
FUNC("gpio", 1, 30, 1),
FUNC("p4led_kn", 0, 30, 1),
};
static struct rt2880_pmx_func p3led_kn_grp_mt7628[] = {
FUNC("jtag", 3, 31, 1),
- FUNC("util", 2, 31, 1),
+ FUNC("utif", 2, 31, 1),
FUNC("gpio", 1, 31, 1),
FUNC("p3led_kn", 0, 31, 1),
};
static struct rt2880_pmx_func p2led_kn_grp_mt7628[] = {
FUNC("jtag", 3, 32, 1),
- FUNC("util", 2, 32, 1),
+ FUNC("utif", 2, 32, 1),
FUNC("gpio", 1, 32, 1),
FUNC("p2led_kn", 0, 32, 1),
};
static struct rt2880_pmx_func p1led_kn_grp_mt7628[] = {
FUNC("jtag", 3, 33, 1),
- FUNC("util", 2, 33, 1),
+ FUNC("utif", 2, 33, 1),
FUNC("gpio", 1, 33, 1),
FUNC("p1led_kn", 0, 33, 1),
};
@@ -232,28 +232,28 @@ static struct rt2880_pmx_func wled_kn_grp_mt7628[] = {
static struct rt2880_pmx_func p4led_an_grp_mt7628[] = {
FUNC("jtag", 3, 39, 1),
- FUNC("util", 2, 39, 1),
+ FUNC("utif", 2, 39, 1),
FUNC("gpio", 1, 39, 1),
FUNC("p4led_an", 0, 39, 1),
};
static struct rt2880_pmx_func p3led_an_grp_mt7628[] = {
FUNC("jtag", 3, 40, 1),
- FUNC("util", 2, 40, 1),
+ FUNC("utif", 2, 40, 1),
FUNC("gpio", 1, 40, 1),
FUNC("p3led_an", 0, 40, 1),
};
static struct rt2880_pmx_func p2led_an_grp_mt7628[] = {
FUNC("jtag", 3, 41, 1),
- FUNC("util", 2, 41, 1),
+ FUNC("utif", 2, 41, 1),
FUNC("gpio", 1, 41, 1),
FUNC("p2led_an", 0, 41, 1),
};
static struct rt2880_pmx_func p1led_an_grp_mt7628[] = {
FUNC("jtag", 3, 42, 1),
- FUNC("util", 2, 42, 1),
+ FUNC("utif", 2, 42, 1),
FUNC("gpio", 1, 42, 1),
FUNC("p1led_an", 0, 42, 1),
};
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] MIPS: ralink: fix mt7628 alternative functions names
2017-02-10 9:06 [PATCH] MIPS: ralink: fix mt7628 alternative functions names André Draszik
@ 2017-02-10 9:12 ` John Crispin
2017-02-10 17:06 ` James Hogan
0 siblings, 1 reply; 3+ messages in thread
From: John Crispin @ 2017-02-10 9:12 UTC (permalink / raw)
To: André Draszik, linux-kernel; +Cc: linux-mips, Ralf Baechle
On 10/02/2017 10:06, André Draszik wrote:
> They're all referenced as utif in the datasheet, not util.
>
> Fixes: 53263a1c6852 ("MIPS: ralink: add mt7628an support")
> Fixes: 2b436a351803 ("MIPS: ralink: add MT7628 EPHY LEDs pinmux support")
>
> Signed-off-by: André Draszik <git@andred.net>
I was under the impression that I had sent this patch already, maybe it
got lost somewhere along the line
Acked-by: John Crispin <john@phrozen.org>
> ---
> arch/mips/ralink/mt7620.c | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/arch/mips/ralink/mt7620.c b/arch/mips/ralink/mt7620.c
> index 3c7c9bf57bf3..6f892c1f3ad7 100644
> --- a/arch/mips/ralink/mt7620.c
> +++ b/arch/mips/ralink/mt7620.c
> @@ -176,7 +176,7 @@ static struct rt2880_pmx_func spi_cs1_grp_mt7628[] = {
>
> static struct rt2880_pmx_func spis_grp_mt7628[] = {
> FUNC("pwm_uart2", 3, 14, 4),
> - FUNC("util", 2, 14, 4),
> + FUNC("utif", 2, 14, 4),
> FUNC("gpio", 1, 14, 4),
> FUNC("spis", 0, 14, 4),
> };
> @@ -190,28 +190,28 @@ static struct rt2880_pmx_func gpio_grp_mt7628[] = {
>
> static struct rt2880_pmx_func p4led_kn_grp_mt7628[] = {
> FUNC("jtag", 3, 30, 1),
> - FUNC("util", 2, 30, 1),
> + FUNC("utif", 2, 30, 1),
> FUNC("gpio", 1, 30, 1),
> FUNC("p4led_kn", 0, 30, 1),
> };
>
> static struct rt2880_pmx_func p3led_kn_grp_mt7628[] = {
> FUNC("jtag", 3, 31, 1),
> - FUNC("util", 2, 31, 1),
> + FUNC("utif", 2, 31, 1),
> FUNC("gpio", 1, 31, 1),
> FUNC("p3led_kn", 0, 31, 1),
> };
>
> static struct rt2880_pmx_func p2led_kn_grp_mt7628[] = {
> FUNC("jtag", 3, 32, 1),
> - FUNC("util", 2, 32, 1),
> + FUNC("utif", 2, 32, 1),
> FUNC("gpio", 1, 32, 1),
> FUNC("p2led_kn", 0, 32, 1),
> };
>
> static struct rt2880_pmx_func p1led_kn_grp_mt7628[] = {
> FUNC("jtag", 3, 33, 1),
> - FUNC("util", 2, 33, 1),
> + FUNC("utif", 2, 33, 1),
> FUNC("gpio", 1, 33, 1),
> FUNC("p1led_kn", 0, 33, 1),
> };
> @@ -232,28 +232,28 @@ static struct rt2880_pmx_func wled_kn_grp_mt7628[] = {
>
> static struct rt2880_pmx_func p4led_an_grp_mt7628[] = {
> FUNC("jtag", 3, 39, 1),
> - FUNC("util", 2, 39, 1),
> + FUNC("utif", 2, 39, 1),
> FUNC("gpio", 1, 39, 1),
> FUNC("p4led_an", 0, 39, 1),
> };
>
> static struct rt2880_pmx_func p3led_an_grp_mt7628[] = {
> FUNC("jtag", 3, 40, 1),
> - FUNC("util", 2, 40, 1),
> + FUNC("utif", 2, 40, 1),
> FUNC("gpio", 1, 40, 1),
> FUNC("p3led_an", 0, 40, 1),
> };
>
> static struct rt2880_pmx_func p2led_an_grp_mt7628[] = {
> FUNC("jtag", 3, 41, 1),
> - FUNC("util", 2, 41, 1),
> + FUNC("utif", 2, 41, 1),
> FUNC("gpio", 1, 41, 1),
> FUNC("p2led_an", 0, 41, 1),
> };
>
> static struct rt2880_pmx_func p1led_an_grp_mt7628[] = {
> FUNC("jtag", 3, 42, 1),
> - FUNC("util", 2, 42, 1),
> + FUNC("utif", 2, 42, 1),
> FUNC("gpio", 1, 42, 1),
> FUNC("p1led_an", 0, 42, 1),
> };
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] MIPS: ralink: fix mt7628 alternative functions names
2017-02-10 9:12 ` John Crispin
@ 2017-02-10 17:06 ` James Hogan
0 siblings, 0 replies; 3+ messages in thread
From: James Hogan @ 2017-02-10 17:06 UTC (permalink / raw)
To: John Crispin; +Cc: André Draszik, linux-kernel, linux-mips, Ralf Baechle
[-- Attachment #1: Type: text/plain, Size: 739 bytes --]
On Fri, Feb 10, 2017 at 10:12:24AM +0100, John Crispin wrote:
>
>
> On 10/02/2017 10:06, André Draszik wrote:
> > They're all referenced as utif in the datasheet, not util.
> >
> > Fixes: 53263a1c6852 ("MIPS: ralink: add mt7628an support")
> > Fixes: 2b436a351803 ("MIPS: ralink: add MT7628 EPHY LEDs pinmux support")
> >
> > Signed-off-by: André Draszik <git@andred.net>
>
> I was under the impression that I had sent this patch already, maybe it
> got lost somewhere along the line
Yep:
https://patchwork.linux-mips.org/patch/14899/
Applied as commit 58181a117d353427127a2e7afc7cf1ab44759828
Though without Fixes or stable tag, so if that matters we'll have to
explicitly request backports.
Cheers
James
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-02-10 17:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-10 9:06 [PATCH] MIPS: ralink: fix mt7628 alternative functions names André Draszik
2017-02-10 9:12 ` John Crispin
2017-02-10 17:06 ` James Hogan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.