All of lore.kernel.org
 help / color / mirror / Atom feed
* RE: [PATCH 1/1] Drivers: net-next: hyperv: Adjust the size of sendbuf region to support ws2008r2
  2014-08-06 18:11 ` K. Y. Srinivasan
  (?)
@ 2014-08-06 17:18 ` Jeff Leung
  2014-08-06 17:25   ` KY Srinivasan
  -1 siblings, 1 reply; 6+ messages in thread
From: Jeff Leung @ 2014-08-06 17:18 UTC (permalink / raw)
  To: K. Y. Srinivasan, davem, netdev, linux-kernel, devel, olaf, apw,
	jasowang

> WS2008R2 is a supported platform and it turns out that the maximum
sendbuf
> size that ws2008R2 can support is only 15MB. Make the necessary
> adjustment.
> 
> Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
> ---
>  drivers/net/hyperv/hyperv_net.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/hyperv/hyperv_net.h
b/drivers/net/hyperv/hyperv_net.h
> index 40ba1ef..459b823 100644
> --- a/drivers/net/hyperv/hyperv_net.h
> +++ b/drivers/net/hyperv/hyperv_net.h
> @@ -584,7 +584,7 @@ struct nvsp_message {
> 
>  #define NETVSC_RECEIVE_BUFFER_SIZE		(1024*1024*16)	/* 16MB
> */
>  #define NETVSC_RECEIVE_BUFFER_SIZE_LEGACY	(1024*1024*15)  /* 15MB
*/
> -#define NETVSC_SEND_BUFFER_SIZE			(1024 * 1024 *
16)   /* 16MB */
> +#define NETVSC_SEND_BUFFER_SIZE			(1024 * 1024 *
15)   /* 15MB */

Would it be possible to use separate ifdefs depending on the version of
the Hyper-V host so we can maintain the 16MB buffer for hosts that
support it and leave it at 15MB for hosts that don't support that large
of a buffer? 

>  #define NETVSC_INVALID_INDEX			-1
> 
> 
> --
> 1.7.4.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe
linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/


^ permalink raw reply	[flat|nested] 6+ messages in thread
* RE: [PATCH 1/1] Drivers: net-next: hyperv: Adjust the size of sendbuf region to support ws2008r2
  2014-08-06 17:18 ` Jeff Leung
@ 2014-08-06 17:25   ` KY Srinivasan
  0 siblings, 0 replies; 6+ messages in thread
From: KY Srinivasan @ 2014-08-06 17:25 UTC (permalink / raw)
  To: Jeff Leung, davem, netdev, linux-kernel, devel, olaf, apw, jasowang



> -----Original Message-----
> From: Jeff Leung [mailto:jleung@v10networks.ca]
> Sent: Wednesday, August 6, 2014 10:19 AM
> To: KY Srinivasan; davem@davemloft.net; netdev@vger.kernel.org; linux-
> kernel@vger.kernel.org; devel@linuxdriverproject.org; olaf@aepfle.de;
> apw@canonical.com; jasowang@redhat.com
> Subject: RE: [PATCH 1/1] Drivers: net-next: hyperv: Adjust the size of
> sendbuf region to support ws2008r2
> 
> > WS2008R2 is a supported platform and it turns out that the maximum
> sendbuf
> > size that ws2008R2 can support is only 15MB. Make the necessary
> > adjustment.
> >
> > Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
> > ---
> >  drivers/net/hyperv/hyperv_net.h |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/net/hyperv/hyperv_net.h
> b/drivers/net/hyperv/hyperv_net.h
> > index 40ba1ef..459b823 100644
> > --- a/drivers/net/hyperv/hyperv_net.h
> > +++ b/drivers/net/hyperv/hyperv_net.h
> > @@ -584,7 +584,7 @@ struct nvsp_message {
> >
> >  #define NETVSC_RECEIVE_BUFFER_SIZE		(1024*1024*16)
> 	/* 16MB
> > */
> >  #define NETVSC_RECEIVE_BUFFER_SIZE_LEGACY	(1024*1024*15)  /*
> 15MB
> */
> > -#define NETVSC_SEND_BUFFER_SIZE			(1024 * 1024 *
> 16)   /* 16MB */
> > +#define NETVSC_SEND_BUFFER_SIZE			(1024 * 1024 *
> 15)   /* 15MB */
> 
> Would it be possible to use separate ifdefs depending on the version of the
> Hyper-V host so we can maintain the 16MB buffer for hosts that support it
> and leave it at 15MB for hosts that don't support that large of a buffer?

We could certainly do that. For the receive buffers, we actually size them based on the host.
For sendbuf, the performance difference between 15M and 16M is not measurable. I had initially
chosen 16MB to match with the receive buffer size. Since there was no perf advantage, I chose to
set the sendbuf size to 15M to work on all supported hosts.

K. Y 
> 
> >  #define NETVSC_INVALID_INDEX			-1
> >
> >
> > --
> > 1.7.4.1
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe
> linux-kernel" in
> > the body of a message to majordomo@vger.kernel.org More majordomo
> info
> > at  http://vger.kernel.org/majordomo-info.html
> > Please read the FAQ at  http://www.tux.org/lkml/


^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH 1/1] Drivers: net-next: hyperv: Adjust the size of sendbuf region to support ws2008r2
@ 2014-08-06 18:11 ` K. Y. Srinivasan
  0 siblings, 0 replies; 6+ messages in thread
From: K. Y. Srinivasan @ 2014-08-06 18:11 UTC (permalink / raw)
  To: davem, netdev, linux-kernel, devel, olaf, apw, jasowang; +Cc: K. Y. Srinivasan

WS2008R2 is a supported platform and it turns out that the maximum sendbuf
size that ws2008R2 can support is only 15MB. Make the necessary
adjustment.

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
---
 drivers/net/hyperv/hyperv_net.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/hyperv/hyperv_net.h b/drivers/net/hyperv/hyperv_net.h
index 40ba1ef..459b823 100644
--- a/drivers/net/hyperv/hyperv_net.h
+++ b/drivers/net/hyperv/hyperv_net.h
@@ -584,7 +584,7 @@ struct nvsp_message {
 
 #define NETVSC_RECEIVE_BUFFER_SIZE		(1024*1024*16)	/* 16MB */
 #define NETVSC_RECEIVE_BUFFER_SIZE_LEGACY	(1024*1024*15)  /* 15MB */
-#define NETVSC_SEND_BUFFER_SIZE			(1024 * 1024 * 16)   /* 16MB */
+#define NETVSC_SEND_BUFFER_SIZE			(1024 * 1024 * 15)   /* 15MB */
 #define NETVSC_INVALID_INDEX			-1
 
 
-- 
1.7.4.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH 1/1] Drivers: net-next: hyperv: Adjust the size of sendbuf region to support ws2008r2
@ 2014-08-06 18:11 ` K. Y. Srinivasan
  0 siblings, 0 replies; 6+ messages in thread
From: K. Y. Srinivasan @ 2014-08-06 18:11 UTC (permalink / raw)
  To: davem, netdev, linux-kernel, devel, olaf, apw, jasowang

WS2008R2 is a supported platform and it turns out that the maximum sendbuf
size that ws2008R2 can support is only 15MB. Make the necessary
adjustment.

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
---
 drivers/net/hyperv/hyperv_net.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/hyperv/hyperv_net.h b/drivers/net/hyperv/hyperv_net.h
index 40ba1ef..459b823 100644
--- a/drivers/net/hyperv/hyperv_net.h
+++ b/drivers/net/hyperv/hyperv_net.h
@@ -584,7 +584,7 @@ struct nvsp_message {
 
 #define NETVSC_RECEIVE_BUFFER_SIZE		(1024*1024*16)	/* 16MB */
 #define NETVSC_RECEIVE_BUFFER_SIZE_LEGACY	(1024*1024*15)  /* 15MB */
-#define NETVSC_SEND_BUFFER_SIZE			(1024 * 1024 * 16)   /* 16MB */
+#define NETVSC_SEND_BUFFER_SIZE			(1024 * 1024 * 15)   /* 15MB */
 #define NETVSC_INVALID_INDEX			-1
 
 
-- 
1.7.4.1

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] Drivers: net-next: hyperv: Adjust the size of sendbuf region to support ws2008r2
  2014-08-06 18:11 ` K. Y. Srinivasan
@ 2014-08-06 20:52   ` David Miller
  -1 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2014-08-06 20:52 UTC (permalink / raw)
  To: kys; +Cc: netdev, linux-kernel, devel, olaf, apw, jasowang

From: "K. Y. Srinivasan" <kys@microsoft.com>
Date: Wed,  6 Aug 2014 11:11:00 -0700

> WS2008R2 is a supported platform and it turns out that the maximum sendbuf
> size that ws2008R2 can support is only 15MB. Make the necessary
> adjustment.
> 
> Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>

Applied, thanks.

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] Drivers: net-next: hyperv: Adjust the size of sendbuf region to support ws2008r2
@ 2014-08-06 20:52   ` David Miller
  0 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2014-08-06 20:52 UTC (permalink / raw)
  To: kys; +Cc: olaf, netdev, jasowang, linux-kernel, apw, devel

From: "K. Y. Srinivasan" <kys@microsoft.com>
Date: Wed,  6 Aug 2014 11:11:00 -0700

> WS2008R2 is a supported platform and it turns out that the maximum sendbuf
> size that ws2008R2 can support is only 15MB. Make the necessary
> adjustment.
> 
> Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>

Applied, thanks.

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-08-06 20:52 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-08-06 18:11 [PATCH 1/1] Drivers: net-next: hyperv: Adjust the size of sendbuf region to support ws2008r2 K. Y. Srinivasan
2014-08-06 18:11 ` K. Y. Srinivasan
2014-08-06 17:18 ` Jeff Leung
2014-08-06 17:25   ` KY Srinivasan
2014-08-06 20:52 ` David Miller
2014-08-06 20:52   ` David Miller

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.