All of lore.kernel.org
 help / color / mirror / Atom feed
From: Leo Li <sunpeng.li@amd.com>
To: August Wikerfors <git@augustwikerfors.se>,
	Alex Deucher <alexdeucher@gmail.com>
Cc: Thorsten Leemhuis <regressions@leemhuis.info>,
	Harry Wentland <harry.wentland@amd.com>,
	Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>,
	Alex Deucher <alexander.deucher@amd.com>,
	linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org,
	regressions@lists.linux.dev
Subject: Re: [REGRESSION] Graphical issues on Lenovo Yoga 7 14ARB7 laptop since v6.0-rc1 (bisected)
Date: Tue, 27 Sep 2022 19:18:55 -0400	[thread overview]
Message-ID: <179b3e55-695a-d145-0b3b-2b67fbb54097@amd.com> (raw)
In-Reply-To: <f84e4956-293f-801d-6b9f-df4226df87d2@augustwikerfors.se>


Hi August,

I've sent a fix here: https://patchwork.freedesktop.org/patch/504993/

It's not the most ideal fix, but it should address the regression. Let 
me know it works for you.

Thanks!
Leo

On 2022-09-27 10:22, August Wikerfors wrote:
> Hi Leo,
> 
> On 2022-09-27 00:29, Leo Li wrote:
>>
>> Hi August, thanks for the log.
>>
>> It seems the eDP panel does not fully satisfy the amdgpu requirements
>> for enabling PSR SU, but we're enabling it anyways.
>>
>> I suspect it may be due to the "DP_FORCE_PSRSU_CAPABILITY" bit being set
>> in it's DPCD registers, I'm checking with some devs to see if that is
>> expected.
>>
>> In the meantime, can you give these two hacks a spin? Let me know if
>> this helps with the glitches and system hangs:
>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.freedesktop.org%2F-%2Fsnippets%2F7076&amp;data=05%7C01%7Csunpeng.li%40amd.com%7Ca5864225840b4bbbd04c08daa093bb26%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637998853607058272%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=cNAK%2FMhWCGwXySpITTTvKtzXQ7WCEQL4DYSrPKzWSkY%3D&amp;reserved=0
> Yes, the issues do not happen with those patches applied.
> 
>> Also the dmesg, in particular this line:
>>> [drm] PSR support 1, DC PSR ver 1, sink PSR ver 3 DPCD caps 
>>> 0x70su_y_granularity 4 force_psrsu_cap **X**
> Here is that line:
>> [   12.085196] [drm] PSR support 1, DC PSR ver 1, sink PSR ver 3 DPCD 
>> caps 0x7b su_y_granularity 4 force_psrsu_cap 1
> 
> Regards,
> August Wikerfors

WARNING: multiple messages have this Message-ID (diff)
From: Leo Li <sunpeng.li@amd.com>
To: August Wikerfors <git@augustwikerfors.se>,
	Alex Deucher <alexdeucher@gmail.com>
Cc: regressions@lists.linux.dev,
	Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>,
	linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org,
	Thorsten Leemhuis <regressions@leemhuis.info>,
	Alex Deucher <alexander.deucher@amd.com>,
	Harry Wentland <harry.wentland@amd.com>
Subject: Re: [REGRESSION] Graphical issues on Lenovo Yoga 7 14ARB7 laptop since v6.0-rc1 (bisected)
Date: Tue, 27 Sep 2022 19:18:55 -0400	[thread overview]
Message-ID: <179b3e55-695a-d145-0b3b-2b67fbb54097@amd.com> (raw)
In-Reply-To: <f84e4956-293f-801d-6b9f-df4226df87d2@augustwikerfors.se>


Hi August,

I've sent a fix here: https://patchwork.freedesktop.org/patch/504993/

It's not the most ideal fix, but it should address the regression. Let 
me know it works for you.

Thanks!
Leo

On 2022-09-27 10:22, August Wikerfors wrote:
> Hi Leo,
> 
> On 2022-09-27 00:29, Leo Li wrote:
>>
>> Hi August, thanks for the log.
>>
>> It seems the eDP panel does not fully satisfy the amdgpu requirements
>> for enabling PSR SU, but we're enabling it anyways.
>>
>> I suspect it may be due to the "DP_FORCE_PSRSU_CAPABILITY" bit being set
>> in it's DPCD registers, I'm checking with some devs to see if that is
>> expected.
>>
>> In the meantime, can you give these two hacks a spin? Let me know if
>> this helps with the glitches and system hangs:
>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.freedesktop.org%2F-%2Fsnippets%2F7076&amp;data=05%7C01%7Csunpeng.li%40amd.com%7Ca5864225840b4bbbd04c08daa093bb26%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637998853607058272%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=cNAK%2FMhWCGwXySpITTTvKtzXQ7WCEQL4DYSrPKzWSkY%3D&amp;reserved=0
> Yes, the issues do not happen with those patches applied.
> 
>> Also the dmesg, in particular this line:
>>> [drm] PSR support 1, DC PSR ver 1, sink PSR ver 3 DPCD caps 
>>> 0x70su_y_granularity 4 force_psrsu_cap **X**
> Here is that line:
>> [   12.085196] [drm] PSR support 1, DC PSR ver 1, sink PSR ver 3 DPCD 
>> caps 0x7b su_y_granularity 4 force_psrsu_cap 1
> 
> Regards,
> August Wikerfors

  reply	other threads:[~2022-09-27 23:19 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-17 16:57 [REGRESSION] Graphical issues on Lenovo Yoga 7 14ARB7 laptop since v6.0-rc1 (bisected) August Wikerfors
2022-09-17 16:57 ` August Wikerfors
2022-09-22 11:26 ` Thorsten Leemhuis
2022-09-22 11:26   ` Thorsten Leemhuis
2022-09-22 13:59   ` Alex Deucher
2022-09-22 13:59     ` Alex Deucher
2022-09-22 18:13     ` August Wikerfors
2022-09-22 18:13       ` August Wikerfors
2022-09-23 18:41       ` Leo Li
2022-09-23 18:41         ` Leo Li
2022-09-23 20:26         ` August Wikerfors
2022-09-23 20:26           ` August Wikerfors
2022-09-26 22:29           ` Leo Li
2022-09-26 22:29             ` Leo Li
2022-09-27 14:22             ` August Wikerfors
2022-09-27 14:22               ` August Wikerfors
2022-09-27 23:18               ` Leo Li [this message]
2022-09-27 23:18                 ` Leo Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=179b3e55-695a-d145-0b3b-2b67fbb54097@amd.com \
    --to=sunpeng.li@amd.com \
    --cc=Rodrigo.Siqueira@amd.com \
    --cc=alexander.deucher@amd.com \
    --cc=alexdeucher@gmail.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=git@augustwikerfors.se \
    --cc=harry.wentland@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=regressions@leemhuis.info \
    --cc=regressions@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.