From: Lu Baolu <baolu.lu@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: baolu.lu@linux.intel.com, Joerg Roedel <jroedel@suse.de>,
iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
David Woodhouse <dwmw2@infradead.org>,
Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>
Subject: Re: [PATCH v1 1/2] iommu/vt-d: Move intel_iommu_ops to header file
Date: Fri, 30 Jul 2021 21:01:41 +0800 [thread overview]
Message-ID: <17a2b3f2-747d-2798-7fea-5846eec0b1fe@linux.intel.com> (raw)
In-Reply-To: <YQOyzka9VDJU3NhU@smile.fi.intel.com>
On 2021/7/30 16:05, Andy Shevchenko wrote:
> On Fri, Jul 30, 2021 at 10:20:08AM +0800, Lu Baolu wrote:
>> On 7/30/21 12:35 AM, Andy Shevchenko wrote:
>>> Compiler is not happy about hidden declaration of intel_iommu_ops.
>>>
>>> .../drivers/iommu/intel/iommu.c:414:24: warning: symbol 'intel_iommu_ops' was not declared. Should it be static?
>>>
>>> Move declaration to header file to make compiler happy.
>>
>> Thanks for the cleanup. Sharing data structures between different files
>> doesn't seem to be a good design. How about adding a helper so that the
>> intel_iommu_ops could be a static one?
>
> Whatever suits the purpose.
> Can you apply patch 2 of this series, please?
>
Yes, I will. Thanks!
Best regards,
baolu
WARNING: multiple messages have this Message-ID (diff)
From: Lu Baolu <baolu.lu@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Joerg Roedel <jroedel@suse.de>, Will Deacon <will@kernel.org>,
linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH v1 1/2] iommu/vt-d: Move intel_iommu_ops to header file
Date: Fri, 30 Jul 2021 21:01:41 +0800 [thread overview]
Message-ID: <17a2b3f2-747d-2798-7fea-5846eec0b1fe@linux.intel.com> (raw)
In-Reply-To: <YQOyzka9VDJU3NhU@smile.fi.intel.com>
On 2021/7/30 16:05, Andy Shevchenko wrote:
> On Fri, Jul 30, 2021 at 10:20:08AM +0800, Lu Baolu wrote:
>> On 7/30/21 12:35 AM, Andy Shevchenko wrote:
>>> Compiler is not happy about hidden declaration of intel_iommu_ops.
>>>
>>> .../drivers/iommu/intel/iommu.c:414:24: warning: symbol 'intel_iommu_ops' was not declared. Should it be static?
>>>
>>> Move declaration to header file to make compiler happy.
>>
>> Thanks for the cleanup. Sharing data structures between different files
>> doesn't seem to be a good design. How about adding a helper so that the
>> intel_iommu_ops could be a static one?
>
> Whatever suits the purpose.
> Can you apply patch 2 of this series, please?
>
Yes, I will. Thanks!
Best regards,
baolu
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2021-07-30 13:01 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-29 16:35 [PATCH v1 1/2] iommu/vt-d: Move intel_iommu_ops to header file Andy Shevchenko
2021-07-29 16:35 ` Andy Shevchenko
2021-07-29 16:35 ` [PATCH v1 2/2] iommu/vt-d: Drop the kernel doc annotation Andy Shevchenko
2021-07-29 16:35 ` Andy Shevchenko
2021-07-30 2:20 ` [PATCH v1 1/2] iommu/vt-d: Move intel_iommu_ops to header file Lu Baolu
2021-07-30 2:20 ` Lu Baolu
2021-07-30 8:05 ` Andy Shevchenko
2021-07-30 8:05 ` Andy Shevchenko
2021-07-30 13:01 ` Lu Baolu [this message]
2021-07-30 13:01 ` Lu Baolu
2021-08-11 13:49 ` Andy Shevchenko
2021-08-11 13:49 ` Andy Shevchenko
2021-08-11 14:02 ` Lu Baolu
2021-08-11 14:02 ` Lu Baolu
2021-08-11 14:23 ` Andy Shevchenko
2021-08-11 14:23 ` Andy Shevchenko
2021-10-06 16:14 ` Andy Shevchenko
2021-10-06 16:14 ` Andy Shevchenko
2021-10-08 4:34 ` Lu Baolu
2021-10-08 4:34 ` Lu Baolu
2021-10-08 11:59 ` Lu Baolu
2021-10-08 11:59 ` Lu Baolu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17a2b3f2-747d-2798-7fea-5846eec0b1fe@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=dwmw2@infradead.org \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=jroedel@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.