From: "Noralf Trønnes" <noralf@tronnes.org> To: Sam Ravnborg <sam@ravnborg.org> Cc: dri-devel@lists.freedesktop.org, linux-usb@vger.kernel.org Subject: Re: [PATCH 04/10] drm/client: Add drm_client_framebuffer_flush() Date: Sun, 3 May 2020 11:54:56 +0200 [thread overview] Message-ID: <17a3a14e-c4ea-6da6-db4e-675825ff0a11@tronnes.org> (raw) In-Reply-To: <20200503074837.GB11582@ravnborg.org> Den 03.05.2020 09.48, skrev Sam Ravnborg: > Hi Noralf. > > On Wed, Apr 29, 2020 at 02:48:24PM +0200, Noralf Trønnes wrote: >> Some drivers need explicit flushing of buffer changes, add a function >> that does that. > I trust you on this. All drivers in tiny/ and at least udl need to be told to flush changes. For userspace this happens either by calling DRM_IOCTL_MODE_DIRTYFB or doing a page/buffer flip DRM_IOCTL_MODE_PAGE_FLIP or do a DRM_IOCTL_MODE_ATOMIC (can contain damage report using plane property FB_DAMAGE_CLIPS). For drivers that use drm_gem_fb_create_with_dirty() and the drm_damage_helper (all of them now I think) this will result in an atomic commit. The driver can use drm_atomic_helper_damage_merged() to get the combined damage rectangle. Noralf. > >> >> Signed-off-by: Noralf Trønnes <noralf@tronnes.org> > Some bikeshedding below. Either way: > Reviewed-by: Sam Ravnborg <sam@ravnborg.org> > >> --- >> drivers/gpu/drm/drm_client.c | 31 +++++++++++++++++++++++++++++++ >> include/drm/drm_client.h | 1 + >> 2 files changed, 32 insertions(+) >> >> diff --git a/drivers/gpu/drm/drm_client.c b/drivers/gpu/drm/drm_client.c >> index cb5ee9f1ffaa..8dbc2ecdcaea 100644 >> --- a/drivers/gpu/drm/drm_client.c >> +++ b/drivers/gpu/drm/drm_client.c >> @@ -483,6 +483,37 @@ void drm_client_framebuffer_delete(struct drm_client_buffer *buffer) >> } >> EXPORT_SYMBOL(drm_client_framebuffer_delete); >> >> +/** >> + * drm_client_framebuffer_flush - Manually flush client framebuffer >> + * @buffer: DRM client buffer (can be NULL) >> + * @rect: Damage rectangle (if NULL flushes all) >> + * >> + * This calls &drm_framebuffer_funcs->dirty (if present) to flush buffer changes >> + * for drivers that need it. >> + * >> + * Returns: >> + * Zero on success or negative error code on failure. >> + */ > > Alternative proposal - that I think is simpler. > But both variants works for me. >> +int drm_client_framebuffer_flush(struct drm_client_buffer *buffer, struct drm_rect *rect) >> +{ > struct drm_framebuffer_funcs *funcs; > struct drm_clip_rect clip; >> + >> + if (!buffer || !buffer->fb || !buffer->fb->funcs->dirty) >> + return 0; > funcs = buffer->fb->funcs; >> + >> + if (rect) { >> + clip.x1 = rect->x1; >> + clip.y1 = rect->y1; >> + clip.x2 = rect->x2; >> + clip.y2 = rect->y2; > return funcs->dirty(buffer->fb, buffer->client->file, > 0, 0, &clip, 1); >> + } else { > return funcs->dirty(buffer->fb, buffer->client->file, > 0, 0, NULL, 0); > } > >> + >> + return buffer->fb->funcs->dirty(buffer->fb, buffer->client->file, >> + 0, 0, clip, clip ? 1 : 0); >> +} >> +EXPORT_SYMBOL(drm_client_framebuffer_flush); >> + >> #ifdef CONFIG_DEBUG_FS >> static int drm_client_debugfs_internal_clients(struct seq_file *m, void *data) >> { >> diff --git a/include/drm/drm_client.h b/include/drm/drm_client.h >> index bbb5689fa9a8..6ef5364d6dfb 100644 >> --- a/include/drm/drm_client.h >> +++ b/include/drm/drm_client.h >> @@ -156,6 +156,7 @@ struct drm_client_buffer { >> struct drm_client_buffer * >> drm_client_framebuffer_create(struct drm_client_dev *client, u32 width, u32 height, u32 format); >> void drm_client_framebuffer_delete(struct drm_client_buffer *buffer); >> +int drm_client_framebuffer_flush(struct drm_client_buffer *buffer, struct drm_rect *rect); >> void *drm_client_buffer_vmap(struct drm_client_buffer *buffer); >> void drm_client_buffer_vunmap(struct drm_client_buffer *buffer); >> >> -- >> 2.23.0 >> >> _______________________________________________ >> dri-devel mailing list >> dri-devel@lists.freedesktop.org >> https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: "Noralf Trønnes" <noralf@tronnes.org> To: Sam Ravnborg <sam@ravnborg.org> Cc: linux-usb@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH 04/10] drm/client: Add drm_client_framebuffer_flush() Date: Sun, 3 May 2020 11:54:56 +0200 [thread overview] Message-ID: <17a3a14e-c4ea-6da6-db4e-675825ff0a11@tronnes.org> (raw) In-Reply-To: <20200503074837.GB11582@ravnborg.org> Den 03.05.2020 09.48, skrev Sam Ravnborg: > Hi Noralf. > > On Wed, Apr 29, 2020 at 02:48:24PM +0200, Noralf Trønnes wrote: >> Some drivers need explicit flushing of buffer changes, add a function >> that does that. > I trust you on this. All drivers in tiny/ and at least udl need to be told to flush changes. For userspace this happens either by calling DRM_IOCTL_MODE_DIRTYFB or doing a page/buffer flip DRM_IOCTL_MODE_PAGE_FLIP or do a DRM_IOCTL_MODE_ATOMIC (can contain damage report using plane property FB_DAMAGE_CLIPS). For drivers that use drm_gem_fb_create_with_dirty() and the drm_damage_helper (all of them now I think) this will result in an atomic commit. The driver can use drm_atomic_helper_damage_merged() to get the combined damage rectangle. Noralf. > >> >> Signed-off-by: Noralf Trønnes <noralf@tronnes.org> > Some bikeshedding below. Either way: > Reviewed-by: Sam Ravnborg <sam@ravnborg.org> > >> --- >> drivers/gpu/drm/drm_client.c | 31 +++++++++++++++++++++++++++++++ >> include/drm/drm_client.h | 1 + >> 2 files changed, 32 insertions(+) >> >> diff --git a/drivers/gpu/drm/drm_client.c b/drivers/gpu/drm/drm_client.c >> index cb5ee9f1ffaa..8dbc2ecdcaea 100644 >> --- a/drivers/gpu/drm/drm_client.c >> +++ b/drivers/gpu/drm/drm_client.c >> @@ -483,6 +483,37 @@ void drm_client_framebuffer_delete(struct drm_client_buffer *buffer) >> } >> EXPORT_SYMBOL(drm_client_framebuffer_delete); >> >> +/** >> + * drm_client_framebuffer_flush - Manually flush client framebuffer >> + * @buffer: DRM client buffer (can be NULL) >> + * @rect: Damage rectangle (if NULL flushes all) >> + * >> + * This calls &drm_framebuffer_funcs->dirty (if present) to flush buffer changes >> + * for drivers that need it. >> + * >> + * Returns: >> + * Zero on success or negative error code on failure. >> + */ > > Alternative proposal - that I think is simpler. > But both variants works for me. >> +int drm_client_framebuffer_flush(struct drm_client_buffer *buffer, struct drm_rect *rect) >> +{ > struct drm_framebuffer_funcs *funcs; > struct drm_clip_rect clip; >> + >> + if (!buffer || !buffer->fb || !buffer->fb->funcs->dirty) >> + return 0; > funcs = buffer->fb->funcs; >> + >> + if (rect) { >> + clip.x1 = rect->x1; >> + clip.y1 = rect->y1; >> + clip.x2 = rect->x2; >> + clip.y2 = rect->y2; > return funcs->dirty(buffer->fb, buffer->client->file, > 0, 0, &clip, 1); >> + } else { > return funcs->dirty(buffer->fb, buffer->client->file, > 0, 0, NULL, 0); > } > >> + >> + return buffer->fb->funcs->dirty(buffer->fb, buffer->client->file, >> + 0, 0, clip, clip ? 1 : 0); >> +} >> +EXPORT_SYMBOL(drm_client_framebuffer_flush); >> + >> #ifdef CONFIG_DEBUG_FS >> static int drm_client_debugfs_internal_clients(struct seq_file *m, void *data) >> { >> diff --git a/include/drm/drm_client.h b/include/drm/drm_client.h >> index bbb5689fa9a8..6ef5364d6dfb 100644 >> --- a/include/drm/drm_client.h >> +++ b/include/drm/drm_client.h >> @@ -156,6 +156,7 @@ struct drm_client_buffer { >> struct drm_client_buffer * >> drm_client_framebuffer_create(struct drm_client_dev *client, u32 width, u32 height, u32 format); >> void drm_client_framebuffer_delete(struct drm_client_buffer *buffer); >> +int drm_client_framebuffer_flush(struct drm_client_buffer *buffer, struct drm_rect *rect); >> void *drm_client_buffer_vmap(struct drm_client_buffer *buffer); >> void drm_client_buffer_vunmap(struct drm_client_buffer *buffer); >> >> -- >> 2.23.0 >> >> _______________________________________________ >> dri-devel mailing list >> dri-devel@lists.freedesktop.org >> https://lists.freedesktop.org/mailman/listinfo/dri-devel _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-05-03 9:55 UTC|newest] Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-04-29 12:48 [PATCH 00/10] Generic USB Display driver Noralf Trønnes 2020-04-29 12:48 ` Noralf Trønnes 2020-04-29 12:48 ` [PATCH 01/10] backlight: Add backlight_device_get_by_name() Noralf Trønnes 2020-04-29 12:48 ` Noralf Trønnes 2020-04-30 8:32 ` Lee Jones 2020-04-30 8:32 ` Lee Jones 2020-04-30 9:20 ` Noralf Trønnes 2020-04-30 9:20 ` Noralf Trønnes 2020-04-30 10:15 ` Lee Jones 2020-04-30 10:15 ` Lee Jones 2020-04-30 10:42 ` Noralf Trønnes 2020-04-30 10:42 ` Noralf Trønnes 2020-04-30 14:02 ` Daniel Vetter 2020-04-30 14:02 ` Daniel Vetter 2020-05-04 7:10 ` Lee Jones 2020-05-04 7:10 ` Lee Jones 2020-05-03 7:13 ` Sam Ravnborg 2020-05-03 7:13 ` Sam Ravnborg 2020-04-29 12:48 ` [PATCH 02/10] drm: Add backlight helper Noralf Trønnes 2020-04-29 12:48 ` Noralf Trønnes 2020-04-29 14:13 ` Hans de Goede 2020-04-29 14:13 ` Hans de Goede 2020-04-29 18:40 ` Noralf Trønnes 2020-04-29 18:40 ` Noralf Trønnes 2020-04-30 15:36 ` Hans de Goede 2020-04-30 15:36 ` Hans de Goede 2020-05-04 12:06 ` Daniel Vetter 2020-05-04 12:06 ` Daniel Vetter 2020-05-04 15:54 ` Noralf Trønnes 2020-05-04 15:54 ` Noralf Trønnes 2020-04-29 12:48 ` [PATCH 03/10] drm/client: Add drm_client_init_from_id() Noralf Trønnes 2020-04-29 12:48 ` Noralf Trønnes 2020-04-29 12:48 ` [PATCH 04/10] drm/client: Add drm_client_framebuffer_flush() Noralf Trønnes 2020-04-29 12:48 ` Noralf Trønnes 2020-05-03 7:48 ` Sam Ravnborg 2020-05-03 7:48 ` Sam Ravnborg 2020-05-03 9:54 ` Noralf Trønnes [this message] 2020-05-03 9:54 ` Noralf Trønnes 2020-04-29 12:48 ` [PATCH 05/10] drm/client: Add drm_client_modeset_check() Noralf Trønnes 2020-04-29 12:48 ` Noralf Trønnes 2020-05-03 8:03 ` Sam Ravnborg 2020-05-03 8:03 ` Sam Ravnborg 2020-05-03 10:02 ` Noralf Trønnes 2020-05-03 10:02 ` Noralf Trønnes 2020-04-29 12:48 ` [PATCH 06/10] drm/client: Add a way to set modeset, properties and rotation Noralf Trønnes 2020-04-29 12:48 ` Noralf Trønnes 2020-05-03 8:47 ` Sam Ravnborg 2020-05-03 8:47 ` Sam Ravnborg 2020-05-03 10:50 ` Noralf Trønnes 2020-05-03 10:50 ` Noralf Trønnes 2020-04-29 12:48 ` [PATCH 07/10] drm/format-helper: Add drm_fb_swab() Noralf Trønnes 2020-04-29 12:48 ` Noralf Trønnes 2020-05-03 10:29 ` Sam Ravnborg 2020-05-03 10:29 ` Sam Ravnborg 2020-05-03 13:38 ` Noralf Trønnes 2020-05-03 13:38 ` Noralf Trønnes 2020-04-29 12:48 ` [PATCH 08/10] drm: Add Generic USB Display driver Noralf Trønnes 2020-04-29 12:48 ` Noralf Trønnes 2020-05-02 17:58 ` Noralf Trønnes 2020-05-02 17:58 ` Noralf Trønnes 2020-04-29 12:48 ` [PATCH 09/10] drm/gud: Add functionality for the USB gadget side Noralf Trønnes 2020-04-29 12:48 ` Noralf Trønnes 2020-04-29 12:48 ` [PATCH 10/10] usb: gadget: function: Add Generic USB Display support Noralf Trønnes 2020-04-29 12:48 ` Noralf Trønnes 2020-05-01 13:22 ` [PATCH 00/10] Generic USB Display driver Noralf Trønnes 2020-05-01 13:22 ` Noralf Trønnes
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=17a3a14e-c4ea-6da6-db4e-675825ff0a11@tronnes.org \ --to=noralf@tronnes.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=linux-usb@vger.kernel.org \ --cc=sam@ravnborg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.