Re: [PATCH net-next v1] net: mptcp, Fast Open Mechanism

[Dmytro Shytyi <dmytro@shytyi.net>]

Hello Matthieu,

---- On Fri, 22 Oct 2021 09:22:05 +0200 Matthieu Baerts <matthieu.baerts@tessares.net> wrote ----

 > Hi Dmytro, 
 >  
 > On 22/10/2021 07:15, Dmytro Shytyi wrote: 
 > > This set of patches will bring "Fast Open" Option support to MPTCP. 
 > > The aim of Fast Open Mechanism is to eliminate one round trip 
 > > time from a TCP conversation by allowing data to be included as 
 > > part of the SYN segment that initiates the connection. 
 > > 
 > > IETF RFC 8684: Appendix B.  TCP Fast Open and MPTCP. 
 > > 
 > > [PATCH v1] includes "client" partial support for : 
 > > 1. send request for cookie; 
 > > 2. send syn+data+cookie. 
 >  
 > Thank you for working on that and sharing this patch with us! 

 Thank you for checking my patch!

 > It looks like some modifications are going to be needed, e.g. after a 
 > very quick look, it seems all tabs have been converted to spaces causing 
 > the patch not being applicable on git[1]: did you not use git 
 > format-patch to generate it? Also, some issues will be reported by 
 > checkpatch.pl, the "reversed XMas tree" order is not respected for 
 > variables declaration, etc. 

I used scripts/checkpatch.pl. I meant no disrespect, and checked 
the patch before submission. I will do it one more time before next submission.
I used "git diff". Thanks for pointing that out. I will use "git format-patch".



 > Do you mind if we continue the discussion on MPTCP mailing list only? In 
 > other words, without Netdev mailing list and Net maintainers, not to 
 > bother everybody for MPTCP specific stuff? 

 I do not mind. Starting from this message, this is only on mptcp list.
These mail addresses I got by executing ./scripts/get_maintainer.pl

 > Our usual way of working for MPTCP patches is to have the code review on 
 > MPTCP ML only, then apply accepted patches in our tree first and once a 
 > validation has been done, send patches later to Netdev ML for inclusion 
 > in the -net or net-next tree. 

Great,  

 > Cheers, 
 > Matt 

Take care,
Dmytro SHYTYI.

 >  
 > [1] 
 > https://patchew.org/logs/17ca66cd439.10a0a3ce11621928.1543611905599720914@shytyi.net/git/ 
 > -- 
 > Tessares | Belgium | Hybrid Access Solutions 
 > www.tessares.net 
 >