Re: [PATCH net-next v1] net: mptcp, Fast Open Mechanism

[Matthieu Baerts <matthieu.baerts@tessares.net>]

Hi Dmytro,

On 25/10/2021 13:34, Dmytro Shytyi wrote:
> 
> ---- On Fri, 22 Oct 2021 11:22:31 +0200 Matthieu Baerts <matthieu.baerts@tessares.net> wrote ----
> 
>  > Hi Dmytro, 
>  >  

Small detail: it looks like your email client is adding unusual spaces
before ">" to quote the previous message. That's not a big issue but it
makes other email clients and even lore [1] not interpreting that as
quotes, e.g. on lore, you can see the quotes are in blue in my reply and
Mat's one but not in yours.

[1]
https://lore.kernel.org/mptcp/17cb73b1343.c752fede1729351.6463099199494289591@shytyi.net/T/#t

(...)

>  > I hope this might help reviewing the new versions ;-) 
>  
> Thank you, Metthieu. 
> I'm working on PATCH net-next v2 net: mptcp. It will include all your comments, except this one:
> 
>  > It looks like you don't use it. Does the compiler not complain about that? 
>  >  
>  > > +       tp->fastopen_req = kzalloc(sizeof(*tp->fatopen_req), 
>  > > +                                  ssk->sk->sk_allocation); 
> Compiler not compalin about that because it is used in the code.

In the version you sent, in mptcp_sendmsg_fastopen_cookie_send() you are
indeed using it but not it in mptcp_sendmsg_fastopen_cookie_req(), no?

Cheers,
Matt
-- 
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net