From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> To: dri-devel@lists.freedesktop.org Cc: "Noralf Trønnes" <noralf@tronnes.org>, devicetree@vger.kernel.org, thomas.petazzoni@free-electrons.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 5/7] dt-bindings: display/panel: Add common rotation property Date: Tue, 11 Apr 2017 08:29:43 +0300 [thread overview] Message-ID: <1802283.9kerWUhyh6@avalon> (raw) In-Reply-To: <20170211184858.26421-6-noralf@tronnes.org> Hi Noralf, On Saturday 11 Feb 2017 19:48:56 Noralf Trønnes wrote: > Display panels can be oriented many ways, especially in the embedded > world. The rotation property is a way to describe this orientation. > The counter clockwise direction is chosen because that's what fbdev > and drm use. > > Signed-off-by: Noralf Trønnes <noralf@tronnes.org> > Acked-by: Thierry Reding <treding@nvidia.com> > --- > > Changes since version 3: > - Changed display/display.txt -> display/panel/panel.txt > > Documentation/devicetree/bindings/display/panel/panel.txt | 4 ++++ We now have both Documentation/devicetree/bindings/display/panel/panel.txt and Documentation/devicetree/bindings/display/panel/panel-common.txt as they have been merged concurrently without being aware of each other. Would you mind if I moved this property to panel-common.txt ? I would also like to document the property in a bit more details to avoid confusion about the rotation direction, as "display rotation" could be interpreted as the angle by which the display output has to be rotated to obtain an upside-up image. What would you think of the following, am I overdoing it, or is it even more confusing ? - rotation: Panels are commonly mounted rotated, with their native orientation not aligned with the device's orientation. The rotation property specifies the angle in degrees between the panel's orientation and the device's orientation (corresponding to a counter-clockwise rotation of the panel). Valid values are 0, 90, 180 and 270. > 1 file changed, 4 insertions(+) > create mode 100644 > Documentation/devicetree/bindings/display/panel/panel.txt > > diff --git a/Documentation/devicetree/bindings/display/panel/panel.txt > b/Documentation/devicetree/bindings/display/panel/panel.txt new file mode > 100644 > index 0000000..e2e6867 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/panel.txt > @@ -0,0 +1,4 @@ > +Common display properties > +------------------------- > + > +- rotation: Display rotation in degrees counter clockwise (0,90,180,270) -- Regards, Laurent Pinchart
WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org> To: dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Cc: "Noralf Trønnes" <noralf-L59+Z2yzLopAfugRpC6u6w@public.gmane.org>, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Subject: Re: [PATCH v4 5/7] dt-bindings: display/panel: Add common rotation property Date: Tue, 11 Apr 2017 08:29:43 +0300 [thread overview] Message-ID: <1802283.9kerWUhyh6@avalon> (raw) In-Reply-To: <20170211184858.26421-6-noralf-L59+Z2yzLopAfugRpC6u6w@public.gmane.org> Hi Noralf, On Saturday 11 Feb 2017 19:48:56 Noralf Trønnes wrote: > Display panels can be oriented many ways, especially in the embedded > world. The rotation property is a way to describe this orientation. > The counter clockwise direction is chosen because that's what fbdev > and drm use. > > Signed-off-by: Noralf Trønnes <noralf-L59+Z2yzLopAfugRpC6u6w@public.gmane.org> > Acked-by: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> > --- > > Changes since version 3: > - Changed display/display.txt -> display/panel/panel.txt > > Documentation/devicetree/bindings/display/panel/panel.txt | 4 ++++ We now have both Documentation/devicetree/bindings/display/panel/panel.txt and Documentation/devicetree/bindings/display/panel/panel-common.txt as they have been merged concurrently without being aware of each other. Would you mind if I moved this property to panel-common.txt ? I would also like to document the property in a bit more details to avoid confusion about the rotation direction, as "display rotation" could be interpreted as the angle by which the display output has to be rotated to obtain an upside-up image. What would you think of the following, am I overdoing it, or is it even more confusing ? - rotation: Panels are commonly mounted rotated, with their native orientation not aligned with the device's orientation. The rotation property specifies the angle in degrees between the panel's orientation and the device's orientation (corresponding to a counter-clockwise rotation of the panel). Valid values are 0, 90, 180 and 270. > 1 file changed, 4 insertions(+) > create mode 100644 > Documentation/devicetree/bindings/display/panel/panel.txt > > diff --git a/Documentation/devicetree/bindings/display/panel/panel.txt > b/Documentation/devicetree/bindings/display/panel/panel.txt new file mode > 100644 > index 0000000..e2e6867 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/panel.txt > @@ -0,0 +1,4 @@ > +Common display properties > +------------------------- > + > +- rotation: Display rotation in degrees counter clockwise (0,90,180,270) -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-04-11 5:28 UTC|newest] Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-02-11 18:48 [PATCH v4 0/7] drm: Add support for tiny LCD displays Noralf Trønnes 2017-02-11 18:48 ` Noralf Trønnes 2017-02-11 18:48 ` [PATCH v4 1/7] drm: Add DRM " Noralf Trønnes 2017-02-11 18:48 ` Noralf Trønnes 2017-02-12 11:05 ` Andy Shevchenko 2017-02-12 11:05 ` Andy Shevchenko 2017-02-12 13:57 ` Noralf Trønnes 2017-02-12 13:57 ` Noralf Trønnes 2017-02-14 19:54 ` Daniel Vetter 2017-02-14 19:54 ` Daniel Vetter 2017-03-07 22:21 ` Daniel Vetter 2017-03-07 22:21 ` Daniel Vetter 2017-03-08 12:23 ` Noralf Trønnes 2017-03-08 12:23 ` Noralf Trønnes 2017-02-11 18:48 ` [PATCH v4 2/7] drm/tinydrm: Add helper functions Noralf Trønnes 2017-02-11 18:48 ` Noralf Trønnes 2017-02-12 11:50 ` Andy Shevchenko 2017-02-12 11:50 ` Andy Shevchenko 2017-02-12 15:33 ` Noralf Trønnes 2017-02-12 15:33 ` Noralf Trønnes 2017-02-11 18:48 ` [PATCH v4 3/7] drm/tinydrm: Add MIPI DBI support Noralf Trønnes 2017-02-11 18:48 ` Noralf Trønnes 2017-03-12 18:42 ` Daniel Vetter 2017-03-12 18:42 ` Daniel Vetter 2017-03-12 19:02 ` Daniel Vetter 2017-03-12 19:02 ` Daniel Vetter 2017-02-11 18:48 ` [PATCH v4 4/7] of: Add vendor prefix for Multi-Inno Noralf Trønnes 2017-02-11 18:48 ` Noralf Trønnes 2017-02-11 18:48 ` [PATCH v4 5/7] dt-bindings: display/panel: Add common rotation property Noralf Trønnes 2017-02-11 18:48 ` Noralf Trønnes 2017-02-14 16:19 ` Rob Herring 2017-02-14 16:19 ` Rob Herring 2017-04-11 5:29 ` Laurent Pinchart [this message] 2017-04-11 5:29 ` Laurent Pinchart 2017-04-12 11:01 ` Noralf Trønnes 2017-04-12 11:01 ` Noralf Trønnes 2017-02-11 18:48 ` [PATCH v4 6/7] dt-bindings: Add Multi-Inno MI0283QT binding Noralf Trønnes 2017-02-11 18:48 ` Noralf Trønnes 2017-02-11 18:48 ` [PATCH v4 7/7] drm/tinydrm: Add support for Multi-Inno MI0283QT display Noralf Trønnes 2017-02-11 18:48 ` Noralf Trønnes
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1802283.9kerWUhyh6@avalon \ --to=laurent.pinchart@ideasonboard.com \ --cc=devicetree@vger.kernel.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=linux-kernel@vger.kernel.org \ --cc=noralf@tronnes.org \ --cc=thomas.petazzoni@free-electrons.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.