[PATCH 0/1] Turn on GuC/HuC auto mode again

[PATCH 0/1] Turn on GuC/HuC auto mode again

[Michal Wajdeczko]

In commit f774f0964919 ("drm/i915/guc: Turn on GuC/HuC auto mode")
we already enabled GuC/HuC auto-mode, however due to holes in our
test coverage we missed to check scenario when GuC firmware is not
present on the target filesystem.

Unfortunatelly such case was fatal to our driver and we decided to
keep GuC disabled in commit 92508da7e3da ("Revert "drm/i915/guc:
Turn on GuC/HuC auto mode"").

Since then we improved both our driver and test coverage and we now
believe that driver works fine without GuC/HuC firmwares available.
See [1] Without HuC firmware and [2] Without GuC/HuC firmwares.

[1] https://patchwork.freedesktop.org/series/65378/#rev1
[2] https://patchwork.freedesktop.org/series/65379/#rev1

References: commit f774f0964919 ("drm/i915/guc: Turn on GuC/HuC auto mode")
References: commit 92508da7e3da ("Revert "drm/i915/guc: Turn on GuC/HuC auto mode"")

Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com> 

Michal Wajdeczko (1):
  drm/i915/uc: Turn on GuC/HuC auto mode again

 drivers/gpu/drm/i915/i915_params.c | 2 +-
 drivers/gpu/drm/i915/i915_params.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

-- 
2.19.2

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[PATCH 1/1] drm/i915/uc: Turn on GuC/HuC auto mode again

[Michal Wajdeczko]

We hope that now all issues related to missing uC firmwares
are fixed and that driver can continue to load without GuC
or HuC firmware available and running:

 - missing or corrupted HuC firmware has no impact to driver
   load (clients should continue to use HUC_STATUS to check
   if HuC firmware was loaded and authenticated)

 - missing or corrupted GuC firmware has no impact to driver
   load (unless GuC firmware blob was overridden by the user
   or GuC submission was requested or GuC was previously
   enabled on this system without reboot - then we will mark
   GPU as wedged and continue with KMS only)

References: commit f774f0964919 ("drm/i915/guc: Turn on GuC/HuC auto mode")
Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
---
 drivers/gpu/drm/i915/i915_params.c | 2 +-
 drivers/gpu/drm/i915/i915_params.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c
index 296452f9efe4..b4f481e1e6b6 100644
--- a/drivers/gpu/drm/i915/i915_params.c
+++ b/drivers/gpu/drm/i915/i915_params.c
@@ -146,7 +146,7 @@ i915_param_named_unsafe(edp_vswing, int, 0400,
 i915_param_named_unsafe(enable_guc, int, 0400,
 	"Enable GuC load for GuC submission and/or HuC load. "
 	"Required functionality can be selected using bitmask values. "
-	"(-1=auto, 0=disable [default], 1=GuC submission, 2=HuC load)");
+	"(-1=auto [default], 0=disable, 1=GuC submission, 2=HuC load)");
 
 i915_param_named(guc_log_level, int, 0400,
 	"GuC firmware logging level. Requires GuC to be loaded. "
diff --git a/drivers/gpu/drm/i915/i915_params.h b/drivers/gpu/drm/i915/i915_params.h
index d29ade3b7de6..5736c55694fe 100644
--- a/drivers/gpu/drm/i915/i915_params.h
+++ b/drivers/gpu/drm/i915/i915_params.h
@@ -54,7 +54,7 @@ struct drm_printer;
 	param(int, disable_power_well, -1) \
 	param(int, enable_ips, 1) \
 	param(int, invert_brightness, 0) \
-	param(int, enable_guc, 0) \
+	param(int, enable_guc, -1) \
 	param(int, guc_log_level, -1) \
 	param(char *, guc_firmware_path, NULL) \
 	param(char *, huc_firmware_path, NULL) \
-- 
2.19.2

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✓ Fi.CI.BAT: success for Turn on GuC/HuC auto mode again

[Patchwork]

== Series Details ==

Series: Turn on GuC/HuC auto mode again
URL   : https://patchwork.freedesktop.org/series/65384/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_6732 -> Patchwork_14077
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14077/

Known issues
------------

  Here are the changes found in Patchwork_14077 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@i915_pm_rpm@basic-pci-d3-state:
    - fi-hsw-4770:        [PASS][1] -> [SKIP][2] ([fdo#109271]) +1 similar issue
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6732/fi-hsw-4770/igt@i915_pm_rpm@basic-pci-d3-state.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14077/fi-hsw-4770/igt@i915_pm_rpm@basic-pci-d3-state.html

  * igt@i915_selftest@live_reset:
    - fi-icl-u3:          [PASS][3] -> [INCOMPLETE][4] ([fdo#107713])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6732/fi-icl-u3/igt@i915_selftest@live_reset.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14077/fi-icl-u3/igt@i915_selftest@live_reset.html

  * igt@kms_busy@basic-flip-a:
    - fi-kbl-7567u:       [PASS][5] -> [SKIP][6] ([fdo#109271] / [fdo#109278]) +2 similar issues
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6732/fi-kbl-7567u/igt@kms_busy@basic-flip-a.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14077/fi-kbl-7567u/igt@kms_busy@basic-flip-a.html

  * igt@kms_busy@basic-flip-c:
    - fi-skl-6770hq:      [PASS][7] -> [SKIP][8] ([fdo#109271] / [fdo#109278]) +2 similar issues
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6732/fi-skl-6770hq/igt@kms_busy@basic-flip-c.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14077/fi-skl-6770hq/igt@kms_busy@basic-flip-c.html

  * igt@kms_flip@basic-flip-vs-dpms:
    - fi-skl-6770hq:      [PASS][9] -> [SKIP][10] ([fdo#109271]) +23 similar issues
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6732/fi-skl-6770hq/igt@kms_flip@basic-flip-vs-dpms.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14077/fi-skl-6770hq/igt@kms_flip@basic-flip-vs-dpms.html

  
#### Possible fixes ####

  * igt@debugfs_test@read_all_entries:
    - fi-icl-u3:          [DMESG-WARN][11] ([fdo#107724]) -> [PASS][12]
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6732/fi-icl-u3/igt@debugfs_test@read_all_entries.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14077/fi-icl-u3/igt@debugfs_test@read_all_entries.html

  * igt@gem_exec_suspend@basic-s4-devices:
    - fi-blb-e6850:       [INCOMPLETE][13] ([fdo#107718]) -> [PASS][14]
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6732/fi-blb-e6850/igt@gem_exec_suspend@basic-s4-devices.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14077/fi-blb-e6850/igt@gem_exec_suspend@basic-s4-devices.html

  * igt@kms_chamelium@hdmi-edid-read:
    - {fi-icl-u4}:        [FAIL][15] ([fdo#111045]) -> [PASS][16]
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6732/fi-icl-u4/igt@kms_chamelium@hdmi-edid-read.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14077/fi-icl-u4/igt@kms_chamelium@hdmi-edid-read.html

  * igt@kms_frontbuffer_tracking@basic:
    - fi-icl-u3:          [FAIL][17] ([fdo#103167]) -> [PASS][18]
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6732/fi-icl-u3/igt@kms_frontbuffer_tracking@basic.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14077/fi-icl-u3/igt@kms_frontbuffer_tracking@basic.html
    - fi-icl-u2:          [FAIL][19] ([fdo#103167]) -> [PASS][20]
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6732/fi-icl-u2/igt@kms_frontbuffer_tracking@basic.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14077/fi-icl-u2/igt@kms_frontbuffer_tracking@basic.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#102505]: https://bugs.freedesktop.org/show_bug.cgi?id=102505
  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
  [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
  [fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
  [fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
  [fdo#111045]: https://bugs.freedesktop.org/show_bug.cgi?id=111045
  [fdo#111049]: https://bugs.freedesktop.org/show_bug.cgi?id=111049
  [fdo#111407]: https://bugs.freedesktop.org/show_bug.cgi?id=111407


Participating hosts (52 -> 41)
------------------------------

  Missing    (11): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-j1900 fi-hsw-peppy fi-byt-squawks fi-bsw-cyan fi-byt-clapper fi-icl-y fi-icl-dsi fi-bdw-samus 


Build changes
-------------

  * CI: CI-20190529 -> None
  * Linux: CI_DRM_6732 -> Patchwork_14077

  CI-20190529: 20190529
  CI_DRM_6732: e64af2bda23c0f43f9353caa92007ba599b53430 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_5138: b9abe0bf6c478c4f6cac56bff286d6926ad8c0ab @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_14077: 73bc2e907176109d2f7401067c4aa09c7b72c577 @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

73bc2e907176 drm/i915/uc: Turn on GuC/HuC auto mode again

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14077/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✗ Fi.CI.IGT: failure for Turn on GuC/HuC auto mode again

[Patchwork]

== Series Details ==

Series: Turn on GuC/HuC auto mode again
URL   : https://patchwork.freedesktop.org/series/65384/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_6732_full -> Patchwork_14077_full
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with Patchwork_14077_full absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_14077_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in Patchwork_14077_full:

### IGT changes ###

#### Possible regressions ####

  * igt@i915_pm_rc6_residency@rc6-accuracy:
    - shard-iclb:         [PASS][1] -> [SKIP][2]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6732/shard-iclb7/igt@i915_pm_rc6_residency@rc6-accuracy.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14077/shard-iclb1/igt@i915_pm_rc6_residency@rc6-accuracy.html

  * igt@i915_selftest@live_gtt:
    - shard-glk:          [PASS][3] -> [DMESG-WARN][4]
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6732/shard-glk3/igt@i915_selftest@live_gtt.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14077/shard-glk8/igt@i915_selftest@live_gtt.html

  
#### Warnings ####

  * igt@gem_ctx_shared@disjoint-timelines:
    - shard-hsw:          [SKIP][5] ([fdo#109271]) -> [FAIL][6]
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6732/shard-hsw2/igt@gem_ctx_shared@disjoint-timelines.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14077/shard-hsw2/igt@gem_ctx_shared@disjoint-timelines.html
    - shard-snb:          [SKIP][7] ([fdo#109271]) -> [FAIL][8]
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6732/shard-snb5/igt@gem_ctx_shared@disjoint-timelines.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14077/shard-snb5/igt@gem_ctx_shared@disjoint-timelines.html

  * igt@i915_pm_rc6_residency@media-rc6-accuracy:
    - shard-iclb:         [SKIP][9] ([fdo#109289]) -> [SKIP][10]
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6732/shard-iclb3/igt@i915_pm_rc6_residency@media-rc6-accuracy.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14077/shard-iclb1/igt@i915_pm_rc6_residency@media-rc6-accuracy.html

  * igt@perf_pmu@busy-accuracy-2-bcs0:
    - shard-snb:          [SKIP][11] ([fdo#109271]) -> [DMESG-WARN][12]
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6732/shard-snb4/igt@perf_pmu@busy-accuracy-2-bcs0.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14077/shard-snb4/igt@perf_pmu@busy-accuracy-2-bcs0.html

  
Known issues
------------

  Here are the changes found in Patchwork_14077_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_exec_schedule@independent-bsd2:
    - shard-iclb:         [PASS][13] -> [SKIP][14] ([fdo#109276]) +11 similar issues
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6732/shard-iclb2/igt@gem_exec_schedule@independent-bsd2.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14077/shard-iclb6/igt@gem_exec_schedule@independent-bsd2.html

  * igt@gem_exec_schedule@preempt-bsd:
    - shard-iclb:         [PASS][15] -> [SKIP][16] ([fdo#111325]) +4 similar issues
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6732/shard-iclb6/igt@gem_exec_schedule@preempt-bsd.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14077/shard-iclb2/igt@gem_exec_schedule@preempt-bsd.html

  * igt@gem_pwrite@big-cpu-forwards:
    - shard-iclb:         [PASS][17] -> [INCOMPLETE][18] ([fdo#107713] / [fdo#109100])
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6732/shard-iclb2/igt@gem_pwrite@big-cpu-forwards.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14077/shard-iclb1/igt@gem_pwrite@big-cpu-forwards.html

  * igt@gem_tiled_swapping@non-threaded:
    - shard-glk:          [PASS][19] -> [DMESG-WARN][20] ([fdo#108686])
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6732/shard-glk4/igt@gem_tiled_swapping@non-threaded.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14077/shard-glk6/igt@gem_tiled_swapping@non-threaded.html

  * igt@i915_suspend@sysfs-reader:
    - shard-apl:          [PASS][21] -> [DMESG-WARN][22] ([fdo#108566]) +8 similar issues
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6732/shard-apl5/igt@i915_suspend@sysfs-reader.html
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14077/shard-apl1/igt@i915_suspend@sysfs-reader.html

  * igt@kms_cursor_crc@pipe-c-cursor-128x128-random:
    - shard-skl:          [PASS][23] -> [FAIL][24] ([fdo#103232]) +1 similar issue
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6732/shard-skl5/igt@kms_cursor_crc@pipe-c-cursor-128x128-random.html
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14077/shard-skl8/igt@kms_cursor_crc@pipe-c-cursor-128x128-random.html

  * igt@kms_cursor_legacy@cursor-vs-flip-atomic:
    - shard-hsw:          [PASS][25] -> [FAIL][26] ([fdo#103355]) +1 similar issue
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6732/shard-hsw4/igt@kms_cursor_legacy@cursor-vs-flip-atomic.html
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14077/shard-hsw6/igt@kms_cursor_legacy@cursor-vs-flip-atomic.html

  * igt@kms_cursor_legacy@cursor-vs-flip-varying-size:
    - shard-apl:          [PASS][27] -> [INCOMPLETE][28] ([fdo#103927]) +4 similar issues
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6732/shard-apl1/igt@kms_cursor_legacy@cursor-vs-flip-varying-size.html
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14077/shard-apl6/igt@kms_cursor_legacy@cursor-vs-flip-varying-size.html

  * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render:
    - shard-iclb:         [PASS][29] -> [FAIL][30] ([fdo#103167]) +4 similar issues
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6732/shard-iclb3/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14077/shard-iclb3/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html

  * igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-indfb-draw-pwrite:
    - shard-skl:          [PASS][31] -> [FAIL][32] ([fdo#103167])
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6732/shard-skl9/igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-indfb-draw-pwrite.html
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14077/shard-skl8/igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-indfb-draw-pwrite.html

  * igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min:
    - shard-skl:          [PASS][33] -> [FAIL][34] ([fdo#108145]) +1 similar issue
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6732/shard-skl5/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14077/shard-skl8/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html

  * igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
    - shard-skl:          [PASS][35] -> [FAIL][36] ([fdo#108145] / [fdo#110403])
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6732/shard-skl6/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14077/shard-skl5/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html

  * igt@kms_psr@psr2_sprite_mmap_gtt:
    - shard-iclb:         [PASS][37] -> [SKIP][38] ([fdo#109441]) +1 similar issue
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6732/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_gtt.html
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14077/shard-iclb1/igt@kms_psr@psr2_sprite_mmap_gtt.html

  * igt@kms_vblank@pipe-b-ts-continuation-suspend:
    - shard-kbl:          [PASS][39] -> [INCOMPLETE][40] ([fdo#103665])
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6732/shard-kbl7/igt@kms_vblank@pipe-b-ts-continuation-suspend.html
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14077/shard-kbl4/igt@kms_vblank@pipe-b-ts-continuation-suspend.html

  
#### Possible fixes ####

  * igt@gem_ctx_shared@exec-single-timeline-bsd:
    - shard-iclb:         [SKIP][41] ([fdo#110841]) -> [PASS][42]
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6732/shard-iclb1/igt@gem_ctx_shared@exec-single-timeline-bsd.html
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14077/shard-iclb8/igt@gem_ctx_shared@exec-single-timeline-bsd.html

  * igt@gem_exec_balancer@smoke:
    - shard-iclb:         [SKIP][43] ([fdo#110854]) -> [PASS][44]
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6732/shard-iclb7/igt@gem_exec_balancer@smoke.html
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14077/shard-iclb1/igt@gem_exec_balancer@smoke.html

  * igt@gem_exec_schedule@preemptive-hang-bsd:
    - shard-iclb:         [SKIP][45] ([fdo#111325]) -> [PASS][46] +3 similar issues
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6732/shard-iclb4/igt@gem_exec_schedule@preemptive-hang-bsd.html
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14077/shard-iclb3/igt@gem_exec_schedule@preemptive-hang-bsd.html

  * igt@i915_suspend@debugfs-reader:
    - shard-apl:          [DMESG-WARN][47] ([fdo#108566]) -> [PASS][48] +2 similar issues
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6732/shard-apl7/igt@i915_suspend@debugfs-reader.html
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14077/shard-apl7/igt@i915_suspend@debugfs-reader.html

  * igt@kms_color@pipe-b-gamma:
    - shard-skl:          [FAIL][49] ([fdo#104782]) -> [PASS][50]
   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6732/shard-skl3/igt@kms_color@pipe-b-gamma.html
   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14077/shard-skl8/igt@kms_color@pipe-b-gamma.html

  * igt@kms_cursor_crc@pipe-b-cursor-64x64-random:
    - shard-iclb:         [INCOMPLETE][51] ([fdo#107713]) -> [PASS][52] +1 similar issue
   [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6732/shard-iclb7/igt@kms_cursor_crc@pipe-b-cursor-64x64-random.html
   [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14077/shard-iclb8/igt@kms_cursor_crc@pipe-b-cursor-64x64-random.html

  * igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy:
    - shard-hsw:          [FAIL][53] ([fdo#105767]) -> [PASS][54]
   [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6732/shard-hsw1/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy.html
   [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14077/shard-hsw4/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy.html

  * igt@kms_flip@2x-flip-vs-panning:
    - shard-hsw:          [INCOMPLETE][55] ([fdo#103540]) -> [PASS][56] +1 similar issue
   [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6732/shard-hsw4/igt@kms_flip@2x-flip-vs-panning.html
   [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14077/shard-hsw2/igt@kms_flip@2x-flip-vs-panning.html

  * igt@kms_flip@plain-flip-fb-recreate-interruptible:
    - shard-skl:          [FAIL][57] ([fdo#100368]) -> [PASS][58]
   [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6732/shard-skl3/igt@kms_flip@plain-flip-fb-recreate-interruptible.html
   [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14077/shard-skl9/igt@kms_flip@plain-flip-fb-recreate-interruptible.html

  * igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrite:
    - shard-iclb:         [FAIL][59] ([fdo#103167]) -> [PASS][60] +4 similar issues
   [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6732/shard-iclb8/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrite.html
   [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14077/shard-iclb6/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrite.html

  * igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min:
    - shard-skl:          [FAIL][61] ([fdo#108145]) -> [PASS][62]
   [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6732/shard-skl3/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min.html
   [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14077/shard-skl7/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min.html

  * igt@kms_plane_lowres@pipe-a-tiling-x:
    - shard-iclb:         [FAIL][63] ([fdo#103166]) -> [PASS][64] +1 similar issue
   [63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6732/shard-iclb8/igt@kms_plane_lowres@pipe-a-tiling-x.html
   [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14077/shard-iclb2/igt@kms_plane_lowres@pipe-a-tiling-x.html

  * igt@kms_psr@psr2_cursor_render:
    - shard-iclb:         [SKIP][65] ([fdo#109441]) -> [PASS][66] +3 similar issues
   [65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6732/shard-iclb8/igt@kms_psr@psr2_cursor_render.html
   [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14077/shard-iclb2/igt@kms_psr@psr2_cursor_render.html

  * igt@kms_setmode@basic:
    - shard-hsw:          [FAIL][67] ([fdo#99912]) -> [PASS][68]
   [67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6732/shard-hsw6/igt@kms_setmode@basic.html
   [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14077/shard-hsw4/igt@kms_setmode@basic.html

  * igt@kms_vblank@pipe-a-ts-continuation-dpms-suspend:
    - shard-skl:          [INCOMPLETE][69] ([fdo#104108]) -> [PASS][70] +1 similar issue
   [69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6732/shard-skl5/igt@kms_vblank@pipe-a-ts-continuation-dpms-suspend.html
   [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14077/shard-skl9/igt@kms_vblank@pipe-a-ts-continuation-dpms-suspend.html

  * igt@perf_pmu@busy-accuracy-2-rcs0:
    - shard-snb:          [SKIP][71] ([fdo#109271]) -> [PASS][72] +10 similar issues
   [71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6732/shard-snb6/igt@perf_pmu@busy-accuracy-2-rcs0.html
   [72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14077/shard-snb2/igt@perf_pmu@busy-accuracy-2-rcs0.html

  * igt@perf_pmu@enable-race-bcs0:
    - shard-hsw:          [SKIP][73] ([fdo#109271]) -> [PASS][74] +15 similar issues
   [73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6732/shard-hsw6/igt@perf_pmu@enable-race-bcs0.html
   [74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14077/shard-hsw4/igt@perf_pmu@enable-race-bcs0.html

  * igt@prime_vgem@fence-wait-bsd2:
    - shard-iclb:         [SKIP][75] ([fdo#109276]) -> [PASS][76] +25 similar issues
   [75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6732/shard-iclb6/igt@prime_vgem@fence-wait-bsd2.html
   [76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14077/shard-iclb4/igt@prime_vgem@fence-wait-bsd2.html

  
#### Warnings ####

  * igt@gem_ctx_isolation@vcs1-nonpriv:
    - shard-iclb:         [SKIP][77] ([fdo#109276]) -> [FAIL][78] ([fdo#111329])
   [77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6732/shard-iclb3/igt@gem_ctx_isolation@vcs1-nonpriv.html
   [78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14077/shard-iclb1/igt@gem_ctx_isolation@vcs1-nonpriv.html

  * igt@gem_mocs_settings@mocs-reset-bsd2:
    - shard-iclb:         [FAIL][79] ([fdo#111330]) -> [SKIP][80] ([fdo#109276]) +1 similar issue
   [79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6732/shard-iclb4/igt@gem_mocs_settings@mocs-reset-bsd2.html
   [80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14077/shard-iclb7/igt@gem_mocs_settings@mocs-reset-bsd2.html

  
  [fdo#100368]: https://bugs.freedesktop.org/show_bug.cgi?id=100368
  [fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
  [fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
  [fdo#103355]: https://bugs.freedesktop.org/show_bug.cgi?id=103355
  [fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
  [fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
  [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
  [fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
  [fdo#104782]: https://bugs.freedesktop.org/show_bug.cgi?id=104782
  [fdo#105767]: https://bugs.freedesktop.org/show_bug.cgi?id=105767
  [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
  [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
  [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
  [fdo#108686]: https://bugs.freedesktop.org/show_bug.cgi?id=108686
  [fdo#109100]: https://bugs.freedesktop.org/show_bug.cgi?id=109100
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
  [fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
  [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
  [fdo#110403]: https://bugs.freedesktop.org/show_bug.cgi?id=110403
  [fdo#110841]: https://bugs.freedesktop.org/show_bug.cgi?id=110841
  [fdo#110854]: https://bugs.freedesktop.org/show_bug.cgi?id=110854
  [fdo#111325]: https://bugs.freedesktop.org/show_bug.cgi?id=111325
  [fdo#111329]: https://bugs.freedesktop.org/show_bug.cgi?id=111329
  [fdo#111330]: https://bugs.freedesktop.org/show_bug.cgi?id=111330
  [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912


Participating hosts (10 -> 10)
------------------------------

  No changes in participating hosts


Build changes
-------------

  * CI: CI-20190529 -> None
  * Linux: CI_DRM_6732 -> Patchwork_14077

  CI-20190529: 20190529
  CI_DRM_6732: e64af2bda23c0f43f9353caa92007ba599b53430 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_5138: b9abe0bf6c478c4f6cac56bff286d6926ad8c0ab @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_14077: 73bc2e907176109d2f7401067c4aa09c7b72c577 @ git://anongit.freedesktop.org/gfx-ci/linux
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14077/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 1/1] drm/i915/uc: Turn on GuC/HuC auto mode again

[Martin Peres]

On 18/08/2019 18:51, Michal Wajdeczko wrote:
> We hope that now all issues related to missing uC firmwares
> are fixed and that driver can continue to load without GuC
> or HuC firmware available and running:
> 
>  - missing or corrupted HuC firmware has no impact to driver
>    load (clients should continue to use HUC_STATUS to check
>    if HuC firmware was loaded and authenticated)
> 
>  - missing or corrupted GuC firmware has no impact to driver
>    load (unless GuC firmware blob was overridden by the user
>    or GuC submission was requested or GuC was previously
>    enabled on this system without reboot - then we will mark
>    GPU as wedged and continue with KMS only)

Please hold merging this patch, as many more items need to be crossed
off before such a patch can land.

Such items include:

 - Assess all the existing GUC-related bugs, and prove they won't
suddenly get seen by more users
 - add fault injection to the FW loading path
 - add IGT tests to make sure driver behaves well on different FW
loading errors

Martin

> 
> References: commit f774f0964919 ("drm/i915/guc: Turn on GuC/HuC auto mode")
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> ---
>  drivers/gpu/drm/i915/i915_params.c | 2 +-
>  drivers/gpu/drm/i915/i915_params.h | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c
> index 296452f9efe4..b4f481e1e6b6 100644
> --- a/drivers/gpu/drm/i915/i915_params.c
> +++ b/drivers/gpu/drm/i915/i915_params.c
> @@ -146,7 +146,7 @@ i915_param_named_unsafe(edp_vswing, int, 0400,
>  i915_param_named_unsafe(enable_guc, int, 0400,
>  	"Enable GuC load for GuC submission and/or HuC load. "
>  	"Required functionality can be selected using bitmask values. "
> -	"(-1=auto, 0=disable [default], 1=GuC submission, 2=HuC load)");
> +	"(-1=auto [default], 0=disable, 1=GuC submission, 2=HuC load)");
>  
>  i915_param_named(guc_log_level, int, 0400,
>  	"GuC firmware logging level. Requires GuC to be loaded. "
> diff --git a/drivers/gpu/drm/i915/i915_params.h b/drivers/gpu/drm/i915/i915_params.h
> index d29ade3b7de6..5736c55694fe 100644
> --- a/drivers/gpu/drm/i915/i915_params.h
> +++ b/drivers/gpu/drm/i915/i915_params.h
> @@ -54,7 +54,7 @@ struct drm_printer;
>  	param(int, disable_power_well, -1) \
>  	param(int, enable_ips, 1) \
>  	param(int, invert_brightness, 0) \
> -	param(int, enable_guc, 0) \
> +	param(int, enable_guc, -1) \
>  	param(int, guc_log_level, -1) \
>  	param(char *, guc_firmware_path, NULL) \
>  	param(char *, huc_firmware_path, NULL) \
> 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 1/1] drm/i915/uc: Turn on GuC/HuC auto mode again

[Michal Wajdeczko]

On Mon, 19 Aug 2019 10:09:15 +0200, Martin Peres  
<martin.peres@linux.intel.com> wrote:

> On 18/08/2019 18:51, Michal Wajdeczko wrote:
>> We hope that now all issues related to missing uC firmwares
>> are fixed and that driver can continue to load without GuC
>> or HuC firmware available and running:
>>
>>  - missing or corrupted HuC firmware has no impact to driver
>>    load (clients should continue to use HUC_STATUS to check
>>    if HuC firmware was loaded and authenticated)
>>
>>  - missing or corrupted GuC firmware has no impact to driver
>>    load (unless GuC firmware blob was overridden by the user
>>    or GuC submission was requested or GuC was previously
>>    enabled on this system without reboot - then we will mark
>>    GPU as wedged and continue with KMS only)
>
> Please hold merging this patch, as many more items need to be crossed
> off before such a patch can land.
>
> Such items include:
>
>  - Assess all the existing GUC-related bugs, and prove they won't
> suddenly get seen by more users

Yep, this is right time to double check that.

>  - add fault injection to the FW loading path

About 40 new failure points were added to firmware loading path by
recent commits like [1] ("drm/i915/uc: Hardening firmware fetch")
and [2] ("drm/i915/uc: Inject probe errors into intel_uc_init_hw")
so I assume we could mark this item as done.

>  - add IGT tests to make sure driver behaves well on different FW
> loading errors

Not sure which if we need another set of tests beyond existing and
already used igt@i915_module_load@reload-with-fault-injection.

Maybe all we need is to add dedicated CI machines that will try to
use GuC but without valid firmware on the system? Let CI team speak
here. Note I was already trying to mimic that scenario with [3] and
[4] and they we all good.

Thanks,
Michal

[1]  
https://cgit.freedesktop.org/drm/drm-tip/commit/?id=5e0a809af2a2b577934ec54c0e50897b806f0732
[2]  
https://cgit.freedesktop.org/drm/drm-tip/commit/?id=5d1ef2b4270de45e1b1b40a00838e3b6196eefd7
[3] https://patchwork.freedesktop.org/series/65378/#rev1
[4] https://patchwork.freedesktop.org/series/65379/#rev1

>
> Martin
>
>>
>> References: commit f774f0964919 ("drm/i915/guc: Turn on GuC/HuC auto  
>> mode")
>> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
>> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
>> Cc: Jani Nikula <jani.nikula@intel.com>
>> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
>> Cc: Chris Wilson <chris@chris-wilson.co.uk>
>> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
>> ---
>>  drivers/gpu/drm/i915/i915_params.c | 2 +-
>>  drivers/gpu/drm/i915/i915_params.h | 2 +-
>>  2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/i915_params.c  
>> b/drivers/gpu/drm/i915/i915_params.c
>> index 296452f9efe4..b4f481e1e6b6 100644
>> --- a/drivers/gpu/drm/i915/i915_params.c
>> +++ b/drivers/gpu/drm/i915/i915_params.c
>> @@ -146,7 +146,7 @@ i915_param_named_unsafe(edp_vswing, int, 0400,
>>  i915_param_named_unsafe(enable_guc, int, 0400,
>>  	"Enable GuC load for GuC submission and/or HuC load. "
>>  	"Required functionality can be selected using bitmask values. "
>> -	"(-1=auto, 0=disable [default], 1=GuC submission, 2=HuC load)");
>> +	"(-1=auto [default], 0=disable, 1=GuC submission, 2=HuC load)");
>>
>>  i915_param_named(guc_log_level, int, 0400,
>>  	"GuC firmware logging level. Requires GuC to be loaded. "
>> diff --git a/drivers/gpu/drm/i915/i915_params.h  
>> b/drivers/gpu/drm/i915/i915_params.h
>> index d29ade3b7de6..5736c55694fe 100644
>> --- a/drivers/gpu/drm/i915/i915_params.h
>> +++ b/drivers/gpu/drm/i915/i915_params.h
>> @@ -54,7 +54,7 @@ struct drm_printer;
>>  	param(int, disable_power_well, -1) \
>>  	param(int, enable_ips, 1) \
>>  	param(int, invert_brightness, 0) \
>> -	param(int, enable_guc, 0) \
>> +	param(int, enable_guc, -1) \
>>  	param(int, guc_log_level, -1) \
>>  	param(char *, guc_firmware_path, NULL) \
>>  	param(char *, huc_firmware_path, NULL) \
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 1/1] drm/i915/uc: Turn on GuC/HuC auto mode again

[Lucas De Marchi]

On Mon, Aug 19, l we need is to add2019 at 4:15 AM Michal Wajdeczko
<michal.wajdeczko@intel.com> wrote:
>
> On Mon, 19 Aug 2019 10:09:15 +0200, Martin Peres
> <martin.peres@linux.intel.com> wrote:
>
> > On 18/08/2019 18:51, Michal Wajdeczko wrote:
> >> We hope that now all issues related to missing uC firmwares
> >> are fixed and that driver can continue to load without GuC
> >> or HuC firmware available and running:
> >>
> >>  - missing or corrupted HuC firmware has no impact to driver
> >>    load (clients should continue to use HUC_STATUS to check
> >>    if HuC firmware was loaded and authenticated)
> >>
> >>  - missing or corrupted GuC firmware has no impact to driver
> >>    load (unless GuC firmware blob was overridden by the user
> >>    or GuC submission was requested or GuC was previously
> >>    enabled on this system without reboot - then we will mark
> >>    GPU as wedged and continue with KMS only)
> >
> > Please hold merging this patch, as many more items need to be crossed
> > off before such a patch can land.
> >
> > Such items include:
> >
> >  - Assess all the existing GUC-related bugs, and prove they won't
> > suddenly get seen by more users
>
> Yep, this is right time to double check that.
>
> >  - add fault injection to the FW loading path
>
> About 40 new failure points were added to firmware loading path by
> recent commits like [1] ("drm/i915/uc: Hardening firmware fetch")
> and [2] ("drm/i915/uc: Inject probe errors into intel_uc_init_hw")
> so I assume we could mark this item as done.
>
> >  - add IGT tests to make sure driver behaves well on different FW
> > loading errors
>
> Not sure which if we need another set of tests beyond existing and
> already used igt@i915_module_load@reload-with-fault-injection.
>
> Maybe all we need is to add dedicated CI machines that will try to
> use GuC but without valid firmware on the system? Let CI team speak
> here. Note I was already trying to mimic that scenario with [3] and
> [4] and they we all good.

I don't think we should use dedicated CI machines for that. We could
make the test to bind mount an empty
directory before executing in order to hide the firmware, which would
be an easy solution.

In kmod testsuite I do something similar for modules, but I trap all
fs-related calls (I had to do that for other reasons):
https://git.kernel.org/pub/scm/utils/kernel/kmod/kmod.git/tree/testsuite/path.c

Lucas De Marchi


>
> Thanks,
> Michal
>
> [1]
> https://cgit.freedesktop.org/drm/drm-tip/commit/?id=5e0a809af2a2b577934ec54c0e50897b806f0732
> [2]
> https://cgit.freedesktop.org/drm/drm-tip/commit/?id=5d1ef2b4270de45e1b1b40a00838e3b6196eefd7
> [3] https://patchwork.freedesktop.org/series/65378/#rev1
> [4] https://patchwork.freedesktop.org/series/65379/#rev1
>
> >
> > Martin
> >
> >>
> >> References: commit f774f0964919 ("drm/i915/guc: Turn on GuC/HuC auto
> >> mode")
> >> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> >> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> >> Cc: Jani Nikula <jani.nikula@intel.com>
> >> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> >> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> >> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> >> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> >> ---
> >>  drivers/gpu/drm/i915/i915_params.c | 2 +-
> >>  drivers/gpu/drm/i915/i915_params.h | 2 +-
> >>  2 files changed, 2 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/drivers/gpu/drm/i915/i915_params.c
> >> b/drivers/gpu/drm/i915/i915_params.c
> >> index 296452f9efe4..b4f481e1e6b6 100644
> >> --- a/drivers/gpu/drm/i915/i915_params.c
> >> +++ b/drivers/gpu/drm/i915/i915_params.c
> >> @@ -146,7 +146,7 @@ i915_param_named_unsafe(edp_vswing, int, 0400,
> >>  i915_param_named_unsafe(enable_guc, int, 0400,
> >>      "Enable GuC load for GuC submission and/or HuC load. "
> >>      "Required functionality can be selected using bitmask values. "
> >> -    "(-1=auto, 0=disable [default], 1=GuC submission, 2=HuC load)");
> >> +    "(-1=auto [default], 0=disable, 1=GuC submission, 2=HuC load)");
> >>
> >>  i915_param_named(guc_log_level, int, 0400,
> >>      "GuC firmware logging level. Requires GuC to be loaded. "
> >> diff --git a/drivers/gpu/drm/i915/i915_params.h
> >> b/drivers/gpu/drm/i915/i915_params.h
> >> index d29ade3b7de6..5736c55694fe 100644
> >> --- a/drivers/gpu/drm/i915/i915_params.h
> >> +++ b/drivers/gpu/drm/i915/i915_params.h
> >> @@ -54,7 +54,7 @@ struct drm_printer;
> >>      param(int, disable_power_well, -1) \
> >>      param(int, enable_ips, 1) \
> >>      param(int, invert_brightness, 0) \
> >> -    param(int, enable_guc, 0) \
> >> +    param(int, enable_guc, -1) \
> >>      param(int, guc_log_level, -1) \
> >>      param(char *, guc_firmware_path, NULL) \
> >>      param(char *, huc_firmware_path, NULL) \
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx



-- 
Lucas De Marchi
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 1/1] drm/i915/uc: Turn on GuC/HuC auto mode again

[Martin Peres]

On 19/08/2019 21:22, Lucas De Marchi wrote:
> On Mon, Aug 19, l we need is to add2019 at 4:15 AM Michal Wajdeczko
> <michal.wajdeczko@intel.com> wrote:
>>
>> On Mon, 19 Aug 2019 10:09:15 +0200, Martin Peres
>> <martin.peres@linux.intel.com> wrote:
>>
>>> On 18/08/2019 18:51, Michal Wajdeczko wrote:
>>>> We hope that now all issues related to missing uC firmwares
>>>> are fixed and that driver can continue to load without GuC
>>>> or HuC firmware available and running:
>>>>
>>>>  - missing or corrupted HuC firmware has no impact to driver
>>>>    load (clients should continue to use HUC_STATUS to check
>>>>    if HuC firmware was loaded and authenticated)
>>>>
>>>>  - missing or corrupted GuC firmware has no impact to driver
>>>>    load (unless GuC firmware blob was overridden by the user
>>>>    or GuC submission was requested or GuC was previously
>>>>    enabled on this system without reboot - then we will mark
>>>>    GPU as wedged and continue with KMS only)
>>>
>>> Please hold merging this patch, as many more items need to be crossed
>>> off before such a patch can land.
>>>
>>> Such items include:
>>>
>>>  - Assess all the existing GUC-related bugs, and prove they won't
>>> suddenly get seen by more users
>>
>> Yep, this is right time to double check that.
>>
>>>  - add fault injection to the FW loading path
>>
>> About 40 new failure points were added to firmware loading path by
>> recent commits like [1] ("drm/i915/uc: Hardening firmware fetch")
>> and [2] ("drm/i915/uc: Inject probe errors into intel_uc_init_hw")
>> so I assume we could mark this item as done.
>>
>>>  - add IGT tests to make sure driver behaves well on different FW
>>> loading errors
>>
>> Not sure which if we need another set of tests beyond existing and
>> already used igt@i915_module_load@reload-with-fault-injection.
>>
>> Maybe all we need is to add dedicated CI machines that will try to
>> use GuC but without valid firmware on the system? Let CI team speak
>> here. Note I was already trying to mimic that scenario with [3] and
>> [4] and they we all good.
> 
> I don't think we should use dedicated CI machines for that. We could
> make the test to bind mount an empty
> directory before executing in order to hide the firmware, which would
> be an easy solution.
> 
> In kmod testsuite I do something similar for modules, but I trap all
> fs-related calls (I had to do that for other reasons):
> https://git.kernel.org/pub/scm/utils/kernel/kmod/kmod.git/tree/testsuite/path.c

Let's not forget that IGT is meant to be run by anyone, and the more
testing we can do on a developer's machine, the better.

So thank you Lucas for being faster than me to suggest that relying on
dedicated machines is a bad idea, especially when it is such an easy
solution :)

Martin

> 
> Lucas De Marchi
> 
> 
>>
>> Thanks,
>> Michal
>>
>> [1]
>> https://cgit.freedesktop.org/drm/drm-tip/commit/?id=5e0a809af2a2b577934ec54c0e50897b806f0732
>> [2]
>> https://cgit.freedesktop.org/drm/drm-tip/commit/?id=5d1ef2b4270de45e1b1b40a00838e3b6196eefd7
>> [3] https://patchwork.freedesktop.org/series/65378/#rev1
>> [4] https://patchwork.freedesktop.org/series/65379/#rev1
>>
>>>
>>> Martin
>>>
>>>>
>>>> References: commit f774f0964919 ("drm/i915/guc: Turn on GuC/HuC auto
>>>> mode")
>>>> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
>>>> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
>>>> Cc: Jani Nikula <jani.nikula@intel.com>
>>>> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
>>>> Cc: Chris Wilson <chris@chris-wilson.co.uk>
>>>> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>>> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
>>>> ---
>>>>  drivers/gpu/drm/i915/i915_params.c | 2 +-
>>>>  drivers/gpu/drm/i915/i915_params.h | 2 +-
>>>>  2 files changed, 2 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/drivers/gpu/drm/i915/i915_params.c
>>>> b/drivers/gpu/drm/i915/i915_params.c
>>>> index 296452f9efe4..b4f481e1e6b6 100644
>>>> --- a/drivers/gpu/drm/i915/i915_params.c
>>>> +++ b/drivers/gpu/drm/i915/i915_params.c
>>>> @@ -146,7 +146,7 @@ i915_param_named_unsafe(edp_vswing, int, 0400,
>>>>  i915_param_named_unsafe(enable_guc, int, 0400,
>>>>      "Enable GuC load for GuC submission and/or HuC load. "
>>>>      "Required functionality can be selected using bitmask values. "
>>>> -    "(-1=auto, 0=disable [default], 1=GuC submission, 2=HuC load)");
>>>> +    "(-1=auto [default], 0=disable, 1=GuC submission, 2=HuC load)");
>>>>
>>>>  i915_param_named(guc_log_level, int, 0400,
>>>>      "GuC firmware logging level. Requires GuC to be loaded. "
>>>> diff --git a/drivers/gpu/drm/i915/i915_params.h
>>>> b/drivers/gpu/drm/i915/i915_params.h
>>>> index d29ade3b7de6..5736c55694fe 100644
>>>> --- a/drivers/gpu/drm/i915/i915_params.h
>>>> +++ b/drivers/gpu/drm/i915/i915_params.h
>>>> @@ -54,7 +54,7 @@ struct drm_printer;
>>>>      param(int, disable_power_well, -1) \
>>>>      param(int, enable_ips, 1) \
>>>>      param(int, invert_brightness, 0) \
>>>> -    param(int, enable_guc, 0) \
>>>> +    param(int, enable_guc, -1) \
>>>>      param(int, guc_log_level, -1) \
>>>>      param(char *, guc_firmware_path, NULL) \
>>>>      param(char *, huc_firmware_path, NULL) \
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> 
> 
> 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 1/1] drm/i915/uc: Turn on GuC/HuC auto mode again

[Michal Wajdeczko]

On Thu, 22 Aug 2019 08:40:33 +0200, Arkadiusz Hiler  
<arkadiusz.hiler@intel.com> wrote:

> On Mon, Aug 19, 2019 at 11:09:15AM +0300, Martin Peres wrote:
>> On 18/08/2019 18:51, Michal Wajdeczko wrote:
>> > We hope that now all issues related to missing uC firmwares
>> > are fixed and that driver can continue to load without GuC
>> > or HuC firmware available and running:
>> >
>> >  - missing or corrupted HuC firmware has no impact to driver
>> >    load (clients should continue to use HUC_STATUS to check
>> >    if HuC firmware was loaded and authenticated)
>> >
>> >  - missing or corrupted GuC firmware has no impact to driver
>> >    load (unless GuC firmware blob was overridden by the user
>> >    or GuC submission was requested or GuC was previously
>> >    enabled on this system without reboot - then we will mark
>> >    GPU as wedged and continue with KMS only)
>>
>> Please hold merging this patch, as many more items need to be crossed
>> off before such a patch can land.
>>
>> Such items include:
>>
>>  - Assess all the existing GUC-related bugs, and prove they won't
>> suddenly get seen by more users
>>  - add fault injection to the FW loading path
>>  - add IGT tests to make sure driver behaves well on different FW
>> loading errors
>
> If this is going to get enabled by default we should add some tests to
> verify that HuC is indeed loaded and operational. Otherwise this may
> degrade without anyone noticing.

we were discussing such test some time ago [1], but we couldn't get
into final agreement.

[1] https://patchwork.freedesktop.org/series/60800/


>
> Something along those lines:
>     int huc_status = getparam(I915_PARAM_HUC_STATUS);
>
>     assert(MI_PREDICATE(HUC_STATUS) == !!huc_status);
>     skip_on_f(huc_status == 0, "HuC disabled\n");
>
>     assert_f(huc_status == 1, "HuC status is not enabled: %d\n",  
> huc_status);
>     assert(submit_commands_to_check_that_huc_is_operational());
>
>
>
> The issue is that the PARAM_HUC_STATUS won't even work right now because:
>
>     case I915_PARAM_HUC_STATUS:
>     	value = intel_huc_check_status(&i915->gt.uc.huc);
>     	if (value < 0)
>     		return value;
>     	break;
>     /* ... */
>     return 0;

Please note that this return if for ioctl() call status

>
>
>     /**
>      * intel_huc_check_status() - check HuC status
>      * @huc: intel_huc structure
>      *
>      * This function reads status register to verify if HuC
>      * firmware was successfully loaded.
>      *
>      * Returns: 1 if HuC firmware is loaded and verified,
>      * 0 if HuC firmware is not loaded and -ENODEV if HuC
>      * is not present on this platform.
>      */
>
> This is broken - we will get 0 whether it's enabled or disabled.

I don't think so. Negative values returned by this function are simply
used as ioctl() errors, while 0/1 values are returned as 'value' field
that holds reply with actual HuC status:

	if (put_user(value, param->value))
		return -EFAULT;

More coffee?

Michal
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 1/1] drm/i915/uc: Turn on GuC/HuC auto mode again

[Arkadiusz Hiler]

On Thu, Aug 22, 2019 at 09:31:07AM +0200, Michal Wajdeczko wrote:
> On Thu, 22 Aug 2019 08:40:33 +0200, Arkadiusz Hiler
> <arkadiusz.hiler@intel.com> wrote:
> 
> > On Mon, Aug 19, 2019 at 11:09:15AM +0300, Martin Peres wrote:
> > > On 18/08/2019 18:51, Michal Wajdeczko wrote:
> > > > We hope that now all issues related to missing uC firmwares
> > > > are fixed and that driver can continue to load without GuC
> > > > or HuC firmware available and running:
> > > >
> > > >  - missing or corrupted HuC firmware has no impact to driver
> > > >    load (clients should continue to use HUC_STATUS to check
> > > >    if HuC firmware was loaded and authenticated)
> > > >
> > > >  - missing or corrupted GuC firmware has no impact to driver
> > > >    load (unless GuC firmware blob was overridden by the user
> > > >    or GuC submission was requested or GuC was previously
> > > >    enabled on this system without reboot - then we will mark
> > > >    GPU as wedged and continue with KMS only)
> > > 
> > > Please hold merging this patch, as many more items need to be crossed
> > > off before such a patch can land.
> > > 
> > > Such items include:
> > > 
> > >  - Assess all the existing GUC-related bugs, and prove they won't
> > > suddenly get seen by more users
> > >  - add fault injection to the FW loading path
> > >  - add IGT tests to make sure driver behaves well on different FW
> > > loading errors
> > 
> > If this is going to get enabled by default we should add some tests to
> > verify that HuC is indeed loaded and operational. Otherwise this may
> > degrade without anyone noticing.
> 
> we were discussing such test some time ago [1], but we couldn't get
> into final agreement.
> 
> [1] https://patchwork.freedesktop.org/series/60800/

Oh, that's a good start. It would be good to land this along the default
enabling of HuC and have the agreement on the "best error codes" by then.

> > Something along those lines:
> >     int huc_status = getparam(I915_PARAM_HUC_STATUS);
> > 
> >     assert(MI_PREDICATE(HUC_STATUS) == !!huc_status);
> >     skip_on_f(huc_status == 0, "HuC disabled\n");
> > 
> >     assert_f(huc_status == 1, "HuC status is not enabled: %d\n",
> > huc_status);
> >     assert(submit_commands_to_check_that_huc_is_operational());
> > 
> > 
> > 
> > The issue is that the PARAM_HUC_STATUS won't even work right now because:
> > 
> >     case I915_PARAM_HUC_STATUS:
> >     	value = intel_huc_check_status(&i915->gt.uc.huc);
> >     	if (value < 0)
> >     		return value;
> >     	break;
> >     /* ... */
> >     return 0;
> 
> Please note that this return if for ioctl() call status
> 
> > 
> > 
> >     /**
> >      * intel_huc_check_status() - check HuC status
> >      * @huc: intel_huc structure
> >      *
> >      * This function reads status register to verify if HuC
> >      * firmware was successfully loaded.
> >      *
> >      * Returns: 1 if HuC firmware is loaded and verified,
> >      * 0 if HuC firmware is not loaded and -ENODEV if HuC
> >      * is not present on this platform.
> >      */
> > 
> > This is broken - we will get 0 whether it's enabled or disabled.
> 
> I don't think so. Negative values returned by this function are simply
> used as ioctl() errors, while 0/1 values are returned as 'value' field
> that holds reply with actual HuC status:
> 
> 	if (put_user(value, param->value))
> 		return -EFAULT;
> 
> More coffee?

My bad. coffee++ would have helped
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx