* [PATCH] arm: dts: rk3288: Add missing #sound-dai-cells
@ 2018-03-01 20:25 ` Rob Herring
0 siblings, 0 replies; 4+ messages in thread
From: Rob Herring @ 2018-03-01 20:25 UTC (permalink / raw)
To: linux-arm-kernel, devicetree; +Cc: linux-rockchip, arm, Heiko Stuebner
dtc now gives the following warning:
arch/arm/boot/dts/rk3288-tinker.dtb: Warning (sound_dai_property): /sound/simple-audio-card,codec: Missing property '#sound-dai-cells' in node /hdmi@ff980000 or bad phandle (referred from sound-dai[0])
Add the missing #sound-dai-cells property.
Cc: Heiko Stuebner <heiko@sntech.de>
Cc: linux-rockchip@lists.infradead.org
Signed-off-by: Rob Herring <robh@kernel.org>
---
arch/arm/boot/dts/rk3288.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
index 6102e4e7f35c..354aff45c1af 100644
--- a/arch/arm/boot/dts/rk3288.dtsi
+++ b/arch/arm/boot/dts/rk3288.dtsi
@@ -927,6 +927,7 @@
i2s: i2s@ff890000 {
compatible = "rockchip,rk3288-i2s", "rockchip,rk3066-i2s";
reg = <0x0 0xff890000 0x0 0x10000>;
+ #sound-dai-cells = <0>;
interrupts = <GIC_SPI 53 IRQ_TYPE_LEVEL_HIGH>;
#address-cells = <1>;
#size-cells = <0>;
@@ -1176,6 +1177,7 @@
compatible = "rockchip,rk3288-dw-hdmi";
reg = <0x0 0xff980000 0x0 0x20000>;
reg-io-width = <4>;
+ #sound-dai-cells = <0>;
rockchip,grf = <&grf>;
interrupts = <GIC_SPI 103 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&cru PCLK_HDMI_CTRL>, <&cru SCLK_HDMI_HDCP>, <&cru SCLK_HDMI_CEC>;
--
2.14.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] arm: dts: rk3288: Add missing #sound-dai-cells
@ 2018-03-01 20:25 ` Rob Herring
0 siblings, 0 replies; 4+ messages in thread
From: Rob Herring @ 2018-03-01 20:25 UTC (permalink / raw)
To: linux-arm-kernel
dtc now gives the following warning:
arch/arm/boot/dts/rk3288-tinker.dtb: Warning (sound_dai_property): /sound/simple-audio-card,codec: Missing property '#sound-dai-cells' in node /hdmi at ff980000 or bad phandle (referred from sound-dai[0])
Add the missing #sound-dai-cells property.
Cc: Heiko Stuebner <heiko@sntech.de>
Cc: linux-rockchip at lists.infradead.org
Signed-off-by: Rob Herring <robh@kernel.org>
---
arch/arm/boot/dts/rk3288.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
index 6102e4e7f35c..354aff45c1af 100644
--- a/arch/arm/boot/dts/rk3288.dtsi
+++ b/arch/arm/boot/dts/rk3288.dtsi
@@ -927,6 +927,7 @@
i2s: i2s at ff890000 {
compatible = "rockchip,rk3288-i2s", "rockchip,rk3066-i2s";
reg = <0x0 0xff890000 0x0 0x10000>;
+ #sound-dai-cells = <0>;
interrupts = <GIC_SPI 53 IRQ_TYPE_LEVEL_HIGH>;
#address-cells = <1>;
#size-cells = <0>;
@@ -1176,6 +1177,7 @@
compatible = "rockchip,rk3288-dw-hdmi";
reg = <0x0 0xff980000 0x0 0x20000>;
reg-io-width = <4>;
+ #sound-dai-cells = <0>;
rockchip,grf = <&grf>;
interrupts = <GIC_SPI 103 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&cru PCLK_HDMI_CTRL>, <&cru SCLK_HDMI_HDCP>, <&cru SCLK_HDMI_CEC>;
--
2.14.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] arm: dts: rk3288: Add missing #sound-dai-cells
2018-03-01 20:25 ` Rob Herring
@ 2018-03-12 14:02 ` Heiko Stübner
-1 siblings, 0 replies; 4+ messages in thread
From: Heiko Stübner @ 2018-03-12 14:02 UTC (permalink / raw)
To: Rob Herring; +Cc: devicetree, arm, linux-arm-kernel, linux-rockchip
Am Donnerstag, 1. März 2018, 21:25:35 CET schrieb Rob Herring:
> dtc now gives the following warning:
>
> arch/arm/boot/dts/rk3288-tinker.dtb: Warning (sound_dai_property):
> /sound/simple-audio-card,codec: Missing property '#sound-dai-cells' in node
> /hdmi@ff980000 or bad phandle (referred from sound-dai[0])
>
> Add the missing #sound-dai-cells property.
>
> Cc: Heiko Stuebner <heiko@sntech.de>
> Cc: linux-rockchip@lists.infradead.org
> Signed-off-by: Rob Herring <robh@kernel.org>
applied as fix for 4.16 (on 2018-03-05 already)
Thanks for the catch
Heiko
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] arm: dts: rk3288: Add missing #sound-dai-cells
@ 2018-03-12 14:02 ` Heiko Stübner
0 siblings, 0 replies; 4+ messages in thread
From: Heiko Stübner @ 2018-03-12 14:02 UTC (permalink / raw)
To: linux-arm-kernel
Am Donnerstag, 1. M?rz 2018, 21:25:35 CET schrieb Rob Herring:
> dtc now gives the following warning:
>
> arch/arm/boot/dts/rk3288-tinker.dtb: Warning (sound_dai_property):
> /sound/simple-audio-card,codec: Missing property '#sound-dai-cells' in node
> /hdmi at ff980000 or bad phandle (referred from sound-dai[0])
>
> Add the missing #sound-dai-cells property.
>
> Cc: Heiko Stuebner <heiko@sntech.de>
> Cc: linux-rockchip at lists.infradead.org
> Signed-off-by: Rob Herring <robh@kernel.org>
applied as fix for 4.16 (on 2018-03-05 already)
Thanks for the catch
Heiko
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-03-12 14:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-01 20:25 [PATCH] arm: dts: rk3288: Add missing #sound-dai-cells Rob Herring
2018-03-01 20:25 ` Rob Herring
2018-03-12 14:02 ` Heiko Stübner
2018-03-12 14:02 ` Heiko Stübner
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.