All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: Sekhar Nori <nsekhar@ti.com>
Cc: Tejun Heo <tj@kernel.org>,
	Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
	Kevin Hilman <khilman@baylibre.com>,
	Arnd Bergmann <arnd@arndb.de>,
	Russell King <linux@arm.linux.org.uk>,
	Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
	linux-ide@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] ata: add Palmchip BK3710 PATA controller driver
Date: Wed, 22 Mar 2017 18:49:12 +0100	[thread overview]
Message-ID: <1819267.Nm9hpTOhuY@amdc3058> (raw)
In-Reply-To: <8fc9171f-15b7-2c6a-d0b5-3af21cc88405@ti.com>


Hi,

On Tuesday, March 21, 2017 02:04:38 PM Sekhar Nori wrote:
> Hi,
> 
> On Tuesday 14 March 2017 10:06 PM, Bartlomiej Zolnierkiewicz wrote:
> > Add Palmchip BK3710 PATA controller driver.
> > 
> > Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> 
> There are some checkpatch suggestions that are worth fixing, I think.
> 
> [PATCH v2 1_3] ata: add Palmchip BK3710 PATA controller driver - Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2017-03-14 2206.eml:277: CHECK: Alignment should match open parenthesis
> [PATCH v2 1_3] ata: add Palmchip BK3710 PATA controller driver - Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2017-03-14 2206.eml:320: CHECK: Alignment should match open parenthesis
> [PATCH v2 1_3] ata: add Palmchip BK3710 PATA controller driver - Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2017-03-14 2206.eml:489: CHECK: Comparison to NULL could be written "!mem"

Will be fixed in v3, thanks.

[ My scripts didn't run checkpatch with --strict so I haven't noticed them. ]

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

WARNING: multiple messages have this Message-ID (diff)
From: b.zolnierkie@samsung.com (Bartlomiej Zolnierkiewicz)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/3] ata: add Palmchip BK3710 PATA controller driver
Date: Wed, 22 Mar 2017 18:49:12 +0100	[thread overview]
Message-ID: <1819267.Nm9hpTOhuY@amdc3058> (raw)
In-Reply-To: <8fc9171f-15b7-2c6a-d0b5-3af21cc88405@ti.com>


Hi,

On Tuesday, March 21, 2017 02:04:38 PM Sekhar Nori wrote:
> Hi,
> 
> On Tuesday 14 March 2017 10:06 PM, Bartlomiej Zolnierkiewicz wrote:
> > Add Palmchip BK3710 PATA controller driver.
> > 
> > Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> 
> There are some checkpatch suggestions that are worth fixing, I think.
> 
> [PATCH v2 1_3] ata: add Palmchip BK3710 PATA controller driver - Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2017-03-14 2206.eml:277: CHECK: Alignment should match open parenthesis
> [PATCH v2 1_3] ata: add Palmchip BK3710 PATA controller driver - Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2017-03-14 2206.eml:320: CHECK: Alignment should match open parenthesis
> [PATCH v2 1_3] ata: add Palmchip BK3710 PATA controller driver - Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2017-03-14 2206.eml:489: CHECK: Comparison to NULL could be written "!mem"

Will be fixed in v3, thanks.

[ My scripts didn't run checkpatch with --strict so I haven't noticed them. ]

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

  parent reply	other threads:[~2017-03-22 17:49 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20170314163738epcas5p3db719229d59550476c918a15d8c16d63@epcas5p3.samsung.com>
2017-03-14 16:36 ` [PATCH v2 0/3] ATA/ARM: convert ARM/DaVinci to use libata PATA drivers Bartlomiej Zolnierkiewicz
2017-03-14 16:36   ` Bartlomiej Zolnierkiewicz
     [not found]   ` <CGME20170314163742epcas5p32a49df6b4ae6c21ee159c79320df5781@epcas5p3.samsung.com>
2017-03-14 16:36     ` [PATCH v2 1/3] ata: add Palmchip BK3710 PATA controller driver Bartlomiej Zolnierkiewicz
2017-03-14 16:36       ` Bartlomiej Zolnierkiewicz
2017-03-18 13:52       ` Sergei Shtylyov
2017-03-18 13:52         ` Sergei Shtylyov
2017-03-18 13:52         ` Sergei Shtylyov
     [not found]         ` <CGME20170322175912epcas5p2dc82f4879de4c440523e7d31c9bf385b@epcas5p2.samsung.com>
2017-03-22 17:59           ` Bartlomiej Zolnierkiewicz
2017-03-22 17:59             ` Bartlomiej Zolnierkiewicz
2017-03-21  8:34       ` Sekhar Nori
2017-03-21  8:34         ` Sekhar Nori
2017-03-21  8:34         ` Sekhar Nori
     [not found]         ` <CGME20170322174917epcas1p1a4ba3e4da231ee3b7784cb0c669611ed@epcas1p1.samsung.com>
2017-03-22 17:49           ` Bartlomiej Zolnierkiewicz [this message]
2017-03-22 17:49             ` Bartlomiej Zolnierkiewicz
2017-03-22 17:56             ` Sergei Shtylyov
2017-03-22 17:56               ` Sergei Shtylyov
     [not found]   ` <CGME20170314163746epcas5p3c934d9a5cde073f33c89c504eaa557ee@epcas5p3.samsung.com>
2017-03-14 16:36     ` [PATCH v2 2/3] ARM: davinci: add pata_bk3710 libata driver support Bartlomiej Zolnierkiewicz
2017-03-14 16:36       ` Bartlomiej Zolnierkiewicz
     [not found]   ` <CGME20170314163749epcas5p35c246bab0e37dbc23117dc0e0ed33878@epcas5p3.samsung.com>
2017-03-14 16:36     ` [PATCH v2 3/3] ARM: davinci_all_defconfig: convert to use libata PATA Bartlomiej Zolnierkiewicz
2017-03-14 16:36       ` Bartlomiej Zolnierkiewicz
2017-03-16 21:32   ` [PATCH v2 0/3] ATA/ARM: convert ARM/DaVinci to use libata PATA drivers Tejun Heo
2017-03-16 21:32     ` Tejun Heo
2017-03-16 21:32     ` Tejun Heo
2017-03-21  8:38     ` Sekhar Nori
2017-03-21  8:38       ` Sekhar Nori
2017-03-21  8:38       ` Sekhar Nori
2017-03-21 16:56       ` Tejun Heo
2017-03-21 16:56         ` Tejun Heo
2017-03-21 16:56         ` Tejun Heo
2017-03-21  8:39   ` Sekhar Nori
2017-03-21  8:39     ` Sekhar Nori
2017-03-21  8:39     ` Sekhar Nori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1819267.Nm9hpTOhuY@amdc3058 \
    --to=b.zolnierkie@samsung.com \
    --cc=arnd@arndb.de \
    --cc=dbaryshkov@gmail.com \
    --cc=khilman@baylibre.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=nsekhar@ti.com \
    --cc=sergei.shtylyov@cogentembedded.com \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.