* [PATCH] qla2xxx: Fix a recently introduced kernel warning
@ 2019-08-20 2:18 Bart Van Assche
2019-08-20 17:57 ` Lee Duncan
2019-08-29 21:54 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Bart Van Assche @ 2019-08-20 2:18 UTC (permalink / raw)
To: Martin K . Petersen, James E . J . Bottomley
Cc: linux-scsi, Bart Van Assche, Himanshu Madhani, Abdul Haleem
According to the firmware documentation a status type 0 IOCB can be
followed by one or more status continuation type 0 IOCBs. Hence do not
complain if the completion function is not called from inside the status
type 0 IOCB handler.
WARNING: CPU: 10 PID: 425 at drivers/scsi/qla2xxx/qla_isr.c:2784
qla2x00_status_entry.isra.7+0x484/0x17b0 [qla2xxx]
CPU: 10 PID: 425 Comm: kworker/10:1 Tainted: G E 5.3.0-rc4-next-20190813-autotest-autotest #1
Workqueue: qla2xxx_wq qla25xx_free_rsp_que [qla2xxx]
Call Trace:
qla2x00_status_entry.isra.7+0x1484/0x17b0 [qla2xxx] (unreliable)
qla24xx_process_response_queue+0x7d8/0xbd0 [qla2xxx]
qla25xx_free_rsp_que+0x1a0/0x220 [qla2xxx]
process_one_work+0x25c/0x520
worker_thread+0x8c/0x5e0
kthread+0x154/0x1a0
ret_from_kernel_thread+0x5c/0x7c
Cc: Himanshu Madhani <hmadhani@marvell.com>
Cc: Abdul Haleem <abdhalee@linux.vnet.ibm.com>
Reported-and-tested-by: Abdul Haleem <abdhalee@linux.vnet.ibm.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
---
drivers/scsi/qla2xxx/qla_isr.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/qla_isr.c
index cd39ac18c5fd..d81b5ecce24b 100644
--- a/drivers/scsi/qla2xxx/qla_isr.c
+++ b/drivers/scsi/qla2xxx/qla_isr.c
@@ -2780,8 +2780,6 @@ qla2x00_status_entry(scsi_qla_host_t *vha, struct rsp_que *rsp, void *pkt)
if (rsp->status_srb == NULL)
sp->done(sp, res);
- else
- WARN_ON_ONCE(true);
}
/**
--
2.22.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] qla2xxx: Fix a recently introduced kernel warning
2019-08-20 2:18 [PATCH] qla2xxx: Fix a recently introduced kernel warning Bart Van Assche
@ 2019-08-20 17:57 ` Lee Duncan
2019-08-29 21:54 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Lee Duncan @ 2019-08-20 17:57 UTC (permalink / raw)
To: Bart Van Assche, James E . J . Bottomley, Martin K . Petersen
Cc: Abdul Haleem, Himanshu Madhani, linux-scsi
On 8/19/19 7:18 PM, Bart Van Assche wrote:
> According to the firmware documentation a status type 0 IOCB can be
> followed by one or more status continuation type 0 IOCBs. Hence do not
> complain if the completion function is not called from inside the status
> type 0 IOCB handler.
>
> WARNING: CPU: 10 PID: 425 at drivers/scsi/qla2xxx/qla_isr.c:2784
> qla2x00_status_entry.isra.7+0x484/0x17b0 [qla2xxx]
> CPU: 10 PID: 425 Comm: kworker/10:1 Tainted: G E 5.3.0-rc4-next-20190813-autotest-autotest #1
> Workqueue: qla2xxx_wq qla25xx_free_rsp_que [qla2xxx]
> Call Trace:
> qla2x00_status_entry.isra.7+0x1484/0x17b0 [qla2xxx] (unreliable)
> qla24xx_process_response_queue+0x7d8/0xbd0 [qla2xxx]
> qla25xx_free_rsp_que+0x1a0/0x220 [qla2xxx]
> process_one_work+0x25c/0x520
> worker_thread+0x8c/0x5e0
> kthread+0x154/0x1a0
> ret_from_kernel_thread+0x5c/0x7c
>
> Cc: Himanshu Madhani <hmadhani@marvell.com>
> Cc: Abdul Haleem <abdhalee@linux.vnet.ibm.com>
> Reported-and-tested-by: Abdul Haleem <abdhalee@linux.vnet.ibm.com>
> Signed-off-by: Bart Van Assche <bvanassche@acm.org>
> ---
> drivers/scsi/qla2xxx/qla_isr.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/qla_isr.c
> index cd39ac18c5fd..d81b5ecce24b 100644
> --- a/drivers/scsi/qla2xxx/qla_isr.c
> +++ b/drivers/scsi/qla2xxx/qla_isr.c
> @@ -2780,8 +2780,6 @@ qla2x00_status_entry(scsi_qla_host_t *vha, struct rsp_que *rsp, void *pkt)
>
> if (rsp->status_srb == NULL)
> sp->done(sp, * do-not-remove-the-first-digit-when-auto-completing-the-tpg-tag
res);
> - else
> - WARN_ON_ONCE(true);
> }
>
> /**
>
Reviewed-by: Lee Duncan <lduncan@suse.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] qla2xxx: Fix a recently introduced kernel warning
2019-08-20 2:18 [PATCH] qla2xxx: Fix a recently introduced kernel warning Bart Van Assche
2019-08-20 17:57 ` Lee Duncan
@ 2019-08-29 21:54 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2019-08-29 21:54 UTC (permalink / raw)
To: Bart Van Assche
Cc: Martin K . Petersen, James E . J . Bottomley, linux-scsi,
Himanshu Madhani, Abdul Haleem
Bart,
> According to the firmware documentation a status type 0 IOCB can be
> followed by one or more status continuation type 0 IOCBs. Hence do not
> complain if the completion function is not called from inside the
> status type 0 IOCB handler.
Applied to 5.4/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-08-29 21:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-20 2:18 [PATCH] qla2xxx: Fix a recently introduced kernel warning Bart Van Assche
2019-08-20 17:57 ` Lee Duncan
2019-08-29 21:54 ` Martin K. Petersen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.