All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
To: Saurav Girepunje <saurav.girepunje@gmail.com>,
	Phillip Potter <phil@philpotter.co.uk>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
	Greg KH <gregkh@linuxfoundation.org>,
	linux-staging@lists.linux.dev,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	saurav.girepunje@hotmail.com
Subject: Re: [PATCH] staging: r8188eu: core: remove condition with no effect
Date: Sun, 22 Aug 2021 13:06:09 +0200	[thread overview]
Message-ID: <1821445.fzUCeO1EU3@localhost.localdomain> (raw)
In-Reply-To: <CAA=Fs0kByg1NztU+Nf__RUzTHuVh_q2hvcyh+3JqXiVgn+_VeQ@mail.gmail.com>

On Sunday, August 22, 2021 1:58:10 AM CEST Phillip Potter wrote:
> On Sat, 21 Aug 2021 at 21:23, Saurav Girepunje
> 
> <saurav.girepunje@gmail.com> wrote:
> > Remove the condition with no effect (if == else) in rtw_led.c
> > file.
> > 
> > Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
> > ---
> > 
> >  drivers/staging/r8188eu/core/rtw_led.c | 5 +----
> >  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> Thanks for this, looks good.
> 
> Acked-by: Phillip Potter <phil@philpotter.co.uk>
> 
> Regards,
> Phil

Dear Philip,

Before acking, please check at least if it applies to the current version of 
the tree and check if it compiles without adding warnings and / or errors. :-)

Thanks,

Fabio
 




  reply	other threads:[~2021-08-22 11:06 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-21 20:23 [PATCH] staging: r8188eu: core: remove condition with no effect Saurav Girepunje
2021-08-21 23:58 ` Phillip Potter
2021-08-21 23:58   ` Phillip Potter
2021-08-22 11:06   ` Fabio M. De Francesco [this message]
2021-08-22 12:36     ` Greg KH
2021-08-26 10:34       ` Greg KH
2021-08-28 12:24         ` SAURAV GIREPUNJE
2021-08-22 14:58     ` Phillip Potter
2021-08-22 14:58       ` Phillip Potter
2021-08-22 16:24       ` Fabio M. De Francesco
2021-08-22 23:58         ` Phillip Potter
2021-08-22 23:58           ` Phillip Potter
2021-08-25  3:54           ` SAURAV GIREPUNJE
2021-08-22 10:58 ` Michael Straube
2021-08-29  9:01 Saurav Girepunje
2021-08-29 12:08 ` Pavel Skripkin
2021-08-29 12:48 ` Michael Straube

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1821445.fzUCeO1EU3@localhost.localdomain \
    --to=fmdefrancesco@gmail.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=phil@philpotter.co.uk \
    --cc=saurav.girepunje@gmail.com \
    --cc=saurav.girepunje@hotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.