Re: [PATCH] staging: r8188eu: core: remove condition with no effect

From: Phillip Potter <phil@philpotter.co.uk>
To: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
Cc: Saurav Girepunje <saurav.girepunje@gmail.com>,
	Larry Finger <Larry.Finger@lwfinger.net>,
	 Greg KH <gregkh@linuxfoundation.org>,
	 "open list:STAGING SUBSYSTEM" <linux-staging@lists.linux.dev>,
	 Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	saurav.girepunje@hotmail.com
Subject: Re: [PATCH] staging: r8188eu: core: remove condition with no effect
Date: Mon, 23 Aug 2021 00:58:31 +0100	[thread overview]
Message-ID: <CAA=Fs0kZvkSmf9vH_Z1rUbDMYYd5SWbQQXhGpMxDbfvWQs338A@mail.gmail.com> (raw)
In-Reply-To: <18734228.Nv2I6EOGHm@localhost.localdomain>

On Sun, 22 Aug 2021 at 17:24, Fabio M. De Francesco
<fmdefrancesco@gmail.com> wrote:
>
>
> Dear Philip,
>
> I didn't mean to be harsh with you, I apologize if this is the message
> I conveyed. Really!

Dear Fabio,

No apology necessary :-)

>
>
> Now it is clearer to me what acking means. I've given only a handful of
> acks because I thought I should also check if they applied and if they
> build. It takes time. Now I understand it is not required. Thanks.
>

Yeah I try to ack as many as I can now, but couldn't possibly do as
many as I do if I had to build test them all, especially with my own
code to write and a family/full time non-kernel dev role. It is
certainly desirable for the majority, but if the code looks
good/correct and is a simple patch then in my mind an Acked-by is fine
to give in any case. That said, I will no doubt make mistakes on that.

>
> Please, don't ever think I'm not more than sure that you give a lot
> of your _unpaid_ time to the kernel and I thank you very much
> I know what it means, because I too have other commitments :-)

Thank you, and I appreciate your involvement so keep up the good work :-)

Regards,
Phil