All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bob Peterson <rpeterso@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH] gfs2: Fix fallocate chunk size
Date: Tue, 20 Feb 2018 10:36:16 -0500 (EST)	[thread overview]
Message-ID: <1821636171.4802829.1519140976672.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20180219225113.17682-1-agruenba@redhat.com>

----- Original Message -----
| The chunk size of allocations in __gfs2_fallocate is calculated
| incorrectly.  The size can collapse, causing __gfs2_fallocate to
| allocate one block at a time, which is very inefficient.  This needs
| fixing in two places:
| 
| In gfs2_quota_lock_check, always set ap->allowed to UINT_MAX to indicate
| that there is no quota limit.  This fixes callers that rely on
| ap->allowed to be set even when quotas are off.
| 
| In __gfs2_fallocate, reset max_blks to UINT_MAX in each iteration of the
| loop to make sure that allocation limits from one resource group won't
| spill over into another resource group.
| 
| Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>

Hi,

Thanks. This is now pushed to the for-next branch of the linux-gfs2 tree:

https://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git/commit/fs/gfs2?h=for-next&id=3fc7c7e1cfaac17cb7b0bfd54e5abf9b1ef2b819

Regards,

Bob Peterson
Red Hat File Systems



      reply	other threads:[~2018-02-20 15:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-19 22:51 [Cluster-devel] [PATCH] gfs2: Fix fallocate chunk size Andreas Gruenbacher
2018-02-20 15:36 ` Bob Peterson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1821636171.4802829.1519140976672.JavaMail.zimbra@redhat.com \
    --to=rpeterso@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.