From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: I2C eeprom compatibles? (was Re: [PATCH/RFC 03/19] ARM: shmobile: gose: add i2c2 bus to device t
Date: Fri, 18 Dec 2015 09:06:48 +0000 [thread overview]
Message-ID: <1839177.77Qt0RnI3v@wuerfel> (raw)
In-Reply-To: <20151218073531.GA1517@katana>
On Friday 18 December 2015 08:35:32 Wolfram Sang wrote:
> >
> > It seems to me that we have some consensus around:
> >
> > compatible = "renesas,r1ex24002", "24c02";
>
> Thinking again, "generic,24c02" or "generic-24c02" could also be an
> option.
>
> > Should this be added to Documentation/devicetree/bindings/eeprom/eeprom.txt ?
> > Or documented elsewhere?
>
> Probably we need a DT maintainers advice here? I don't mind vendor
> specific compatibles being documented, but I'm reluctant to add all
> these compatibles for the myriads of I2C eeproms to the at24 driver. 99%
> are covered by the generic case.
>
> Adding DT to CC.
I'd rather use some vendor string in addition to 24c02. Isn't this originally
an Atmel part? In that case, using "atmel,24c02" as the most generic string
would be appropriate, and IIRC the i2c framework will just match that with
the "24c02" entry in the i2c_device_id list.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: devicetree@vger.kernel.org,
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
Linux-sh list <linux-sh@vger.kernel.org>,
Wolfram Sang <wsa@the-dreams.de>,
Magnus Damm <magnus.damm@gmail.com>,
Wolfram Sang <wsa@sang-engineering.com>,
Simon Horman <horms@verge.net.au>,
Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: I2C eeprom compatibles? (was Re: [PATCH/RFC 03/19] ARM: shmobile: gose: add i2c2 bus to device tree)
Date: Fri, 18 Dec 2015 10:06:48 +0100 [thread overview]
Message-ID: <1839177.77Qt0RnI3v@wuerfel> (raw)
In-Reply-To: <20151218073531.GA1517@katana>
On Friday 18 December 2015 08:35:32 Wolfram Sang wrote:
> >
> > It seems to me that we have some consensus around:
> >
> > compatible = "renesas,r1ex24002", "24c02";
>
> Thinking again, "generic,24c02" or "generic-24c02" could also be an
> option.
>
> > Should this be added to Documentation/devicetree/bindings/eeprom/eeprom.txt ?
> > Or documented elsewhere?
>
> Probably we need a DT maintainers advice here? I don't mind vendor
> specific compatibles being documented, but I'm reluctant to add all
> these compatibles for the myriads of I2C eeproms to the at24 driver. 99%
> are covered by the generic case.
>
> Adding DT to CC.
I'd rather use some vendor string in addition to 24c02. Isn't this originally
an Atmel part? In that case, using "atmel,24c02" as the most generic string
would be appropriate, and IIRC the i2c framework will just match that with
the "24c02" entry in the i2c_device_id list.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: I2C eeprom compatibles? (was Re: [PATCH/RFC 03/19] ARM: shmobile: gose: add i2c2 bus to device tree)
Date: Fri, 18 Dec 2015 10:06:48 +0100 [thread overview]
Message-ID: <1839177.77Qt0RnI3v@wuerfel> (raw)
In-Reply-To: <20151218073531.GA1517@katana>
On Friday 18 December 2015 08:35:32 Wolfram Sang wrote:
> >
> > It seems to me that we have some consensus around:
> >
> > compatible = "renesas,r1ex24002", "24c02";
>
> Thinking again, "generic,24c02" or "generic-24c02" could also be an
> option.
>
> > Should this be added to Documentation/devicetree/bindings/eeprom/eeprom.txt ?
> > Or documented elsewhere?
>
> Probably we need a DT maintainers advice here? I don't mind vendor
> specific compatibles being documented, but I'm reluctant to add all
> these compatibles for the myriads of I2C eeproms to the at24 driver. 99%
> are covered by the generic case.
>
> Adding DT to CC.
I'd rather use some vendor string in addition to 24c02. Isn't this originally
an Atmel part? In that case, using "atmel,24c02" as the most generic string
would be appropriate, and IIRC the i2c framework will just match that with
the "24c02" entry in the i2c_device_id list.
Arnd
next prev parent reply other threads:[~2015-12-18 9:06 UTC|newest]
Thread overview: 95+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-11 2:52 [PATCH/RFC 00/19] r8a7793, gose: Add i2c and audio support to device tree Simon Horman
2015-12-11 2:52 ` Simon Horman
2015-12-11 2:52 ` [PATCH/RFC 01/19] ARM: shmobile: r8a7793: add i2c clocks Simon Horman
2015-12-11 2:52 ` Simon Horman
2015-12-13 18:59 ` Laurent Pinchart
2015-12-13 18:59 ` Laurent Pinchart
2015-12-11 2:52 ` [PATCH/RFC 02/19] ARM: shmobile: r8a7793: add i2c to device tree Simon Horman
2015-12-11 2:52 ` Simon Horman
2015-12-11 2:52 ` [PATCH/RFC 03/19] ARM: shmobile: gose: add i2c2 bus " Simon Horman
2015-12-11 2:52 ` Simon Horman
2015-12-11 11:25 ` Sergei Shtylyov
2015-12-11 11:25 ` Sergei Shtylyov
2015-12-14 2:11 ` Simon Horman
2015-12-14 2:11 ` Simon Horman
2015-12-14 7:11 ` Wolfram Sang
2015-12-14 7:11 ` Wolfram Sang
2015-12-14 9:39 ` Geert Uytterhoeven
2015-12-14 9:39 ` Geert Uytterhoeven
2015-12-18 3:02 ` Simon Horman
2015-12-18 3:02 ` Simon Horman
2015-12-18 7:35 ` I2C eeprom compatibles? (was Re: [PATCH/RFC 03/19] ARM: shmobile: gose: add i2c2 bus to device tree) Wolfram Sang
2015-12-18 7:35 ` Wolfram Sang
2015-12-18 7:35 ` Wolfram Sang
2015-12-18 9:06 ` Arnd Bergmann [this message]
2015-12-18 9:06 ` Arnd Bergmann
2015-12-18 9:06 ` Arnd Bergmann
2015-12-18 10:32 ` I2C eeprom compatibles? (was Re: [PATCH/RFC 03/19] ARM: shmobile: gose: add i2c2 bus to device t Wolfram Sang
2015-12-18 10:32 ` I2C eeprom compatibles? (was Re: [PATCH/RFC 03/19] ARM: shmobile: gose: add i2c2 bus to device tree) Wolfram Sang
2015-12-18 10:32 ` Wolfram Sang
2015-12-21 4:33 ` I2C eeprom compatibles? (was Re: [PATCH/RFC 03/19] ARM: shmobile: gose: add i2c2 bus to device t Simon Horman
2015-12-21 4:33 ` I2C eeprom compatibles? (was Re: [PATCH/RFC 03/19] ARM: shmobile: gose: add i2c2 bus to device tree) Simon Horman
2015-12-21 4:33 ` Simon Horman
2015-12-21 8:02 ` I2C eeprom compatibles? (was Re: [PATCH/RFC 03/19] ARM: shmobile: gose: add i2c2 bus to device t Geert Uytterhoeven
2015-12-21 8:02 ` I2C eeprom compatibles? (was Re: [PATCH/RFC 03/19] ARM: shmobile: gose: add i2c2 bus to device tree) Geert Uytterhoeven
2015-12-21 8:02 ` Geert Uytterhoeven
2015-12-14 17:03 ` [PATCH/RFC 03/19] ARM: shmobile: gose: add i2c2 bus to device tree Sergei Shtylyov
2015-12-14 17:03 ` Sergei Shtylyov
2015-12-11 2:52 ` [PATCH/RFC 04/19] ARM: shmobile: r8a7793: add iic(b) " Simon Horman
2015-12-11 2:52 ` Simon Horman
2015-12-11 9:40 ` Geert Uytterhoeven
2015-12-11 9:40 ` Geert Uytterhoeven
2015-12-14 2:21 ` Simon Horman
2015-12-14 2:21 ` Simon Horman
2015-12-14 8:13 ` Geert Uytterhoeven
2015-12-14 8:13 ` Geert Uytterhoeven
2015-12-11 2:52 ` [PATCH/RFC 05/19] ARM: shmobile: r8a7793: add MSTP10 clocks " Simon Horman
2015-12-11 2:52 ` Simon Horman
2015-12-14 1:00 ` Kuninori Morimoto
2015-12-14 1:00 ` Kuninori Morimoto
2015-12-14 1:47 ` Simon Horman
2015-12-14 1:47 ` Simon Horman
2015-12-14 3:49 ` Kuninori Morimoto
2015-12-14 3:49 ` Kuninori Morimoto
2015-12-14 9:41 ` Geert Uytterhoeven
2015-12-14 9:41 ` Geert Uytterhoeven
2015-12-11 2:52 ` [PATCH/RFC 06/19] ARM: shmobile: r8a7793: add audio clock " Simon Horman
2015-12-11 2:52 ` Simon Horman
2015-12-11 2:52 ` [PATCH/RFC 07/19] ARM: shmobile: r8a7793: add m2 " Simon Horman
2015-12-11 2:52 ` Simon Horman
2015-12-13 18:56 ` Laurent Pinchart
2015-12-13 18:56 ` Laurent Pinchart
2015-12-11 2:52 ` [PATCH/RFC 08/19] ARM: shmobile: r8a7793: add R-Car sound support " Simon Horman
2015-12-11 2:52 ` Simon Horman
2015-12-11 9:44 ` Geert Uytterhoeven
2015-12-11 9:44 ` Geert Uytterhoeven
2015-12-14 1:49 ` Simon Horman
2015-12-14 1:49 ` Simon Horman
2015-12-11 2:52 ` [PATCH/RFC 09/19] ARM: shmobile: r8a7793: add DVC " Simon Horman
2015-12-11 2:52 ` Simon Horman
2015-12-11 2:52 ` [PATCH/RFC 10/19] ARM: shmobile: r8a7793: add audio DMAC clocks " Simon Horman
2015-12-11 2:52 ` Simon Horman
2015-12-11 2:52 ` [PATCH/RFC 11/19] ARM: shmobile: r8a7793: add audio DMAC " Simon Horman
2015-12-11 2:52 ` Simon Horman
2015-12-11 2:52 ` [PATCH/RFC 12/19] ARM: shmobile: gose: Enable sound PIO support in " Simon Horman
2015-12-11 2:52 ` Simon Horman
2015-12-11 2:52 ` [PATCH/RFC 13/19] ARM: shmobile: gose: enable sound DMA " Simon Horman
2015-12-11 2:52 ` Simon Horman
2015-12-11 2:52 ` [PATCH/RFC 14/19] ARM: shmobile: gose: enable sound DMA support via BUSIF " Simon Horman
2015-12-11 2:52 ` Simon Horman
2015-12-11 2:52 ` [PATCH/RFC 15/19] ARM: shmobile: gose: enable sound DMA support via SRC " Simon Horman
2015-12-11 2:52 ` Simon Horman
2015-12-11 2:52 ` [PATCH/RFC 16/19] ARM: shmobile: gose: enable sound DMA support via DVC " Simon Horman
2015-12-11 2:52 ` Simon Horman
2015-12-11 2:52 ` [PATCH/RFC 17/19] ARM: shmobile: r8a7793: enable audio DMAC " Simon Horman
2015-12-11 2:52 ` Simon Horman
2015-12-11 2:52 ` [PATCH/RFC 18/19] ARM: shmobile: r8a7793: Add Audio CTU support to " Simon Horman
2015-12-11 2:52 ` Simon Horman
2015-12-11 2:52 ` [PATCH/RFC 19/19] ARM: shmobile: r8a7793: add Audio MIX " Simon Horman
2015-12-11 2:52 ` Simon Horman
2015-12-14 1:07 ` Kuninori Morimoto
2015-12-14 1:07 ` Kuninori Morimoto
2015-12-14 1:54 ` Simon Horman
2015-12-14 1:54 ` Simon Horman
2015-12-11 9:45 ` [PATCH/RFC 00/19] r8a7793, gose: Add i2c and audio " Geert Uytterhoeven
2015-12-11 9:45 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1839177.77Qt0RnI3v@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.