All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marc Dietrich <marvin24@gmx.de>
To: Paul Fertser <fercerpav@gmail.com>
Cc: devel@driverdev.osuosl.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
	ac100@lists.launchpad.net
Subject: Re: [PATCH] Revert "staging: nvec: ps2: change serio type to passthrough"
Date: Tue, 25 Oct 2016 14:24:52 +0200	[thread overview]
Message-ID: <18470230.WG6Q7IXVVu@fb07-iapwap2> (raw)
In-Reply-To: <1477397482-31087-1-git-send-email-fercerpav@gmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 1847 bytes --]

Hi Paul, Greg,

Am Dienstag, 25. Oktober 2016, 15:10:55 CEST schrieb Paul Fertser:
> This reverts commit 36b30d6138f4677514aca35ab76c20c1604baaad.
> 
> This is necessary to detect paz00 (ac100) touchpad properly as one
> speaking ETPS/2 protocol. Without it X.org's synaptics driver doesn't
> work as the touchpad is detected as an ImPS/2 mouse instead.
> 
> Commit ec6184b1c717b8768122e25fe6d312f609cc1bb4 changed the way
> auto-detection is performed on ports marked as pass through and made the
> issue apparent.
> 
> A pass through port is an additional PS/2 port used to connect a slave
> device to a master device that is using PS/2 to communicate with the
> host (so slave's PS/2 communication is tunneled over master's PS/2
> link). "Synaptics PS/2 TouchPad Interfacing Guide" describes such a
> setup (PS/2 PASS-THROUGH OPTION section).
> 
> Since paz00's embedded controller is not connected to a PS/2 port
> itself, the PS/2 interface it exposes is not a pass-through one.
> 
> Acked-by: Marc Dietrich <marvin24@gmx.de>
> Signed-off-by: Paul Fertser <fercerpav@gmail.com>

In fact I was a bit to fast to ack. Turns out I booted the wrong kernel. So 
please hold off this one, until some issues with this patch are fixed.

Marc


> ---
>  drivers/staging/nvec/nvec_ps2.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/nvec/nvec_ps2.c
> b/drivers/staging/nvec/nvec_ps2.c index a324322..c83eeb4 100644
> --- a/drivers/staging/nvec/nvec_ps2.c
> +++ b/drivers/staging/nvec/nvec_ps2.c
> @@ -112,7 +112,7 @@ static int nvec_mouse_probe(struct platform_device
> *pdev) if (!ser_dev)
>  		return -ENOMEM;
> 
> -	ser_dev->id.type = SERIO_PS_PSTHRU;
> +	ser_dev->id.type = SERIO_8042;
>  	ser_dev->write = ps2_sendcommand;
>  	ser_dev->start = ps2_startstreaming;
>  	ser_dev->stop = ps2_stopstreaming;


[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 455 bytes --]

[-- Attachment #2: Type: text/plain, Size: 169 bytes --]

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

WARNING: multiple messages have this Message-ID (diff)
From: Marc Dietrich <marvin24@gmx.de>
To: Paul Fertser <fercerpav@gmail.com>
Cc: devel@driverdev.osuosl.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	ac100@lists.launchpad.net, linux-tegra@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Revert "staging: nvec: ps2: change serio type to passthrough"
Date: Tue, 25 Oct 2016 14:24:52 +0200	[thread overview]
Message-ID: <18470230.WG6Q7IXVVu@fb07-iapwap2> (raw)
In-Reply-To: <1477397482-31087-1-git-send-email-fercerpav@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1847 bytes --]

Hi Paul, Greg,

Am Dienstag, 25. Oktober 2016, 15:10:55 CEST schrieb Paul Fertser:
> This reverts commit 36b30d6138f4677514aca35ab76c20c1604baaad.
> 
> This is necessary to detect paz00 (ac100) touchpad properly as one
> speaking ETPS/2 protocol. Without it X.org's synaptics driver doesn't
> work as the touchpad is detected as an ImPS/2 mouse instead.
> 
> Commit ec6184b1c717b8768122e25fe6d312f609cc1bb4 changed the way
> auto-detection is performed on ports marked as pass through and made the
> issue apparent.
> 
> A pass through port is an additional PS/2 port used to connect a slave
> device to a master device that is using PS/2 to communicate with the
> host (so slave's PS/2 communication is tunneled over master's PS/2
> link). "Synaptics PS/2 TouchPad Interfacing Guide" describes such a
> setup (PS/2 PASS-THROUGH OPTION section).
> 
> Since paz00's embedded controller is not connected to a PS/2 port
> itself, the PS/2 interface it exposes is not a pass-through one.
> 
> Acked-by: Marc Dietrich <marvin24@gmx.de>
> Signed-off-by: Paul Fertser <fercerpav@gmail.com>

In fact I was a bit to fast to ack. Turns out I booted the wrong kernel. So 
please hold off this one, until some issues with this patch are fixed.

Marc


> ---
>  drivers/staging/nvec/nvec_ps2.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/nvec/nvec_ps2.c
> b/drivers/staging/nvec/nvec_ps2.c index a324322..c83eeb4 100644
> --- a/drivers/staging/nvec/nvec_ps2.c
> +++ b/drivers/staging/nvec/nvec_ps2.c
> @@ -112,7 +112,7 @@ static int nvec_mouse_probe(struct platform_device
> *pdev) if (!ser_dev)
>  		return -ENOMEM;
> 
> -	ser_dev->id.type = SERIO_PS_PSTHRU;
> +	ser_dev->id.type = SERIO_8042;
>  	ser_dev->write = ps2_sendcommand;
>  	ser_dev->start = ps2_startstreaming;
>  	ser_dev->stop = ps2_stopstreaming;


[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 455 bytes --]

  reply	other threads:[~2016-10-25 12:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-25 12:10 [PATCH] Revert "staging: nvec: ps2: change serio type to passthrough" Paul Fertser
2016-10-25 12:10 ` Paul Fertser
2016-10-25 12:24 ` Marc Dietrich [this message]
2016-10-25 12:24   ` Marc Dietrich
2016-10-27 13:55   ` [PATCH] drivers: staging: nvec: remove bogus reset command for PS/2 interface Paul Fertser
2016-10-27 13:59     ` Marc Dietrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=18470230.WG6Q7IXVVu@fb07-iapwap2 \
    --to=marvin24@gmx.de \
    --cc=ac100@lists.launchpad.net \
    --cc=devel@driverdev.osuosl.org \
    --cc=fercerpav@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.