From: "Thomas Hellström" <thomas.hellstrom@linux.intel.com> To: Matthew Auld <matthew.william.auld@gmail.com>, Ramalingam C <ramalingam.c@intel.com> Cc: intel-gfx <intel-gfx@lists.freedesktop.org>, Lucas De Marchi <lucas.demarchi@intel.com>, dri-devel <dri-devel@lists.freedesktop.org>, Hellstrom Thomas <thomas.hellstrom@intel.com>, Matthew Auld <matthew.auld@intel.com>, Rodrigo Vivi <rodrigo.vivi@intel.com> Subject: Re: [PATCH 2/4] drm/i915/xehpsdv: set min page-size to 64K Date: Wed, 8 Dec 2021 16:10:18 +0100 [thread overview] Message-ID: <184922c4-0cc4-4e95-5248-e9c56ef1141d@linux.intel.com> (raw) In-Reply-To: <CAM0jSHPQwFvn5exHVB2yShGxiXHQrE6vyQz2d70ySQmTYDis+A@mail.gmail.com> On 12/8/21 15:34, Matthew Auld wrote: > On Wed, 8 Dec 2021 at 14:16, Ramalingam C <ramalingam.c@intel.com> wrote: >> From: Matthew Auld <matthew.auld@intel.com> >> >> LMEM should be allocated at 64K granularity, since 4K page support will >> eventually be dropped for LMEM when using the PPGTT. > s/will eventually be dropped/has been dropped/ as per Thomas' suggestion. Or perhaps something along the lines of Conditionally allocate LMEM with 64K granularity, since 4K page support for LMEM will be dropped on some platforms when using the PPGTT. /Thomas > >> Signed-off-by: Matthew Auld <matthew.auld@intel.com> >> Signed-off-by: Stuart Summers <stuart.summers@intel.com> >> Signed-off-by: Ramalingam C <ramalingam.c@intel.com> >> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> >> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> >> Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com> >> Reviewed-by: Thomas Hellstrom <thomas.hellstrom@linux.intel.com> >> --- >> drivers/gpu/drm/i915/gem/i915_gem_stolen.c | 6 +++++- >> drivers/gpu/drm/i915/gt/intel_region_lmem.c | 5 ++++- >> 2 files changed, 9 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_stolen.c b/drivers/gpu/drm/i915/gem/i915_gem_stolen.c >> index bce03d74a0b4..ba90ab47d838 100644 >> --- a/drivers/gpu/drm/i915/gem/i915_gem_stolen.c >> +++ b/drivers/gpu/drm/i915/gem/i915_gem_stolen.c >> @@ -780,6 +780,7 @@ i915_gem_stolen_lmem_setup(struct drm_i915_private *i915, u16 type, >> struct intel_uncore *uncore = &i915->uncore; >> struct pci_dev *pdev = to_pci_dev(i915->drm.dev); >> struct intel_memory_region *mem; >> + resource_size_t min_page_size; >> resource_size_t io_start; >> resource_size_t lmem_size; >> u64 lmem_base; >> @@ -791,8 +792,11 @@ i915_gem_stolen_lmem_setup(struct drm_i915_private *i915, u16 type, >> lmem_size = pci_resource_len(pdev, 2) - lmem_base; >> io_start = pci_resource_start(pdev, 2) + lmem_base; >> >> + min_page_size = HAS_64K_PAGES(i915) ? I915_GTT_PAGE_SIZE_64K : >> + I915_GTT_PAGE_SIZE_4K; >> + >> mem = intel_memory_region_create(i915, lmem_base, lmem_size, >> - I915_GTT_PAGE_SIZE_4K, io_start, >> + min_page_size, io_start, >> type, instance, >> &i915_region_stolen_lmem_ops); >> if (IS_ERR(mem)) >> diff --git a/drivers/gpu/drm/i915/gt/intel_region_lmem.c b/drivers/gpu/drm/i915/gt/intel_region_lmem.c >> index 9ea49e0a27c0..fde2dcb59809 100644 >> --- a/drivers/gpu/drm/i915/gt/intel_region_lmem.c >> +++ b/drivers/gpu/drm/i915/gt/intel_region_lmem.c >> @@ -197,6 +197,7 @@ static struct intel_memory_region *setup_lmem(struct intel_gt *gt) >> struct intel_uncore *uncore = gt->uncore; >> struct pci_dev *pdev = to_pci_dev(i915->drm.dev); >> struct intel_memory_region *mem; >> + resource_size_t min_page_size; >> resource_size_t io_start; >> resource_size_t lmem_size; >> int err; >> @@ -211,10 +212,12 @@ static struct intel_memory_region *setup_lmem(struct intel_gt *gt) >> if (GEM_WARN_ON(lmem_size > pci_resource_len(pdev, 2))) >> return ERR_PTR(-ENODEV); >> >> + min_page_size = HAS_64K_PAGES(i915) ? I915_GTT_PAGE_SIZE_64K : >> + I915_GTT_PAGE_SIZE_4K; >> mem = intel_memory_region_create(i915, >> 0, >> lmem_size, >> - I915_GTT_PAGE_SIZE_4K, >> + min_page_size, >> io_start, >> INTEL_MEMORY_LOCAL, >> 0, >> -- >> 2.20.1 >>
WARNING: multiple messages have this Message-ID (diff)
From: "Thomas Hellström" <thomas.hellstrom@linux.intel.com> To: Matthew Auld <matthew.william.auld@gmail.com>, Ramalingam C <ramalingam.c@intel.com> Cc: intel-gfx <intel-gfx@lists.freedesktop.org>, Lucas De Marchi <lucas.demarchi@intel.com>, dri-devel <dri-devel@lists.freedesktop.org>, Hellstrom Thomas <thomas.hellstrom@intel.com>, Matthew Auld <matthew.auld@intel.com> Subject: Re: [Intel-gfx] [PATCH 2/4] drm/i915/xehpsdv: set min page-size to 64K Date: Wed, 8 Dec 2021 16:10:18 +0100 [thread overview] Message-ID: <184922c4-0cc4-4e95-5248-e9c56ef1141d@linux.intel.com> (raw) In-Reply-To: <CAM0jSHPQwFvn5exHVB2yShGxiXHQrE6vyQz2d70ySQmTYDis+A@mail.gmail.com> On 12/8/21 15:34, Matthew Auld wrote: > On Wed, 8 Dec 2021 at 14:16, Ramalingam C <ramalingam.c@intel.com> wrote: >> From: Matthew Auld <matthew.auld@intel.com> >> >> LMEM should be allocated at 64K granularity, since 4K page support will >> eventually be dropped for LMEM when using the PPGTT. > s/will eventually be dropped/has been dropped/ as per Thomas' suggestion. Or perhaps something along the lines of Conditionally allocate LMEM with 64K granularity, since 4K page support for LMEM will be dropped on some platforms when using the PPGTT. /Thomas > >> Signed-off-by: Matthew Auld <matthew.auld@intel.com> >> Signed-off-by: Stuart Summers <stuart.summers@intel.com> >> Signed-off-by: Ramalingam C <ramalingam.c@intel.com> >> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> >> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> >> Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com> >> Reviewed-by: Thomas Hellstrom <thomas.hellstrom@linux.intel.com> >> --- >> drivers/gpu/drm/i915/gem/i915_gem_stolen.c | 6 +++++- >> drivers/gpu/drm/i915/gt/intel_region_lmem.c | 5 ++++- >> 2 files changed, 9 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_stolen.c b/drivers/gpu/drm/i915/gem/i915_gem_stolen.c >> index bce03d74a0b4..ba90ab47d838 100644 >> --- a/drivers/gpu/drm/i915/gem/i915_gem_stolen.c >> +++ b/drivers/gpu/drm/i915/gem/i915_gem_stolen.c >> @@ -780,6 +780,7 @@ i915_gem_stolen_lmem_setup(struct drm_i915_private *i915, u16 type, >> struct intel_uncore *uncore = &i915->uncore; >> struct pci_dev *pdev = to_pci_dev(i915->drm.dev); >> struct intel_memory_region *mem; >> + resource_size_t min_page_size; >> resource_size_t io_start; >> resource_size_t lmem_size; >> u64 lmem_base; >> @@ -791,8 +792,11 @@ i915_gem_stolen_lmem_setup(struct drm_i915_private *i915, u16 type, >> lmem_size = pci_resource_len(pdev, 2) - lmem_base; >> io_start = pci_resource_start(pdev, 2) + lmem_base; >> >> + min_page_size = HAS_64K_PAGES(i915) ? I915_GTT_PAGE_SIZE_64K : >> + I915_GTT_PAGE_SIZE_4K; >> + >> mem = intel_memory_region_create(i915, lmem_base, lmem_size, >> - I915_GTT_PAGE_SIZE_4K, io_start, >> + min_page_size, io_start, >> type, instance, >> &i915_region_stolen_lmem_ops); >> if (IS_ERR(mem)) >> diff --git a/drivers/gpu/drm/i915/gt/intel_region_lmem.c b/drivers/gpu/drm/i915/gt/intel_region_lmem.c >> index 9ea49e0a27c0..fde2dcb59809 100644 >> --- a/drivers/gpu/drm/i915/gt/intel_region_lmem.c >> +++ b/drivers/gpu/drm/i915/gt/intel_region_lmem.c >> @@ -197,6 +197,7 @@ static struct intel_memory_region *setup_lmem(struct intel_gt *gt) >> struct intel_uncore *uncore = gt->uncore; >> struct pci_dev *pdev = to_pci_dev(i915->drm.dev); >> struct intel_memory_region *mem; >> + resource_size_t min_page_size; >> resource_size_t io_start; >> resource_size_t lmem_size; >> int err; >> @@ -211,10 +212,12 @@ static struct intel_memory_region *setup_lmem(struct intel_gt *gt) >> if (GEM_WARN_ON(lmem_size > pci_resource_len(pdev, 2))) >> return ERR_PTR(-ENODEV); >> >> + min_page_size = HAS_64K_PAGES(i915) ? I915_GTT_PAGE_SIZE_64K : >> + I915_GTT_PAGE_SIZE_4K; >> mem = intel_memory_region_create(i915, >> 0, >> lmem_size, >> - I915_GTT_PAGE_SIZE_4K, >> + min_page_size, >> io_start, >> INTEL_MEMORY_LOCAL, >> 0, >> -- >> 2.20.1 >>
next prev parent reply other threads:[~2021-12-08 15:10 UTC|newest] Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-12-08 14:16 [PATCH 0/4] drm/i915: Basic enabling of 64k page support Ramalingam C 2021-12-08 14:16 ` [Intel-gfx] " Ramalingam C 2021-12-08 14:16 ` [PATCH 1/4] drm/i915: Add has_64k_pages flag Ramalingam C 2021-12-08 14:16 ` [Intel-gfx] " Ramalingam C 2021-12-08 16:08 ` Andi Shyti 2021-12-08 14:16 ` [PATCH 2/4] drm/i915/xehpsdv: set min page-size to 64K Ramalingam C 2021-12-08 14:16 ` [Intel-gfx] " Ramalingam C 2021-12-08 14:34 ` Matthew Auld 2021-12-08 14:34 ` [Intel-gfx] " Matthew Auld 2021-12-08 15:10 ` Thomas Hellström [this message] 2021-12-08 15:10 ` Thomas Hellström 2021-12-08 15:48 ` Ramalingam C 2021-12-08 15:48 ` [Intel-gfx] " Ramalingam C 2021-12-08 16:09 ` Andi Shyti 2021-12-08 14:16 ` [PATCH 3/4] drm/i915/gtt/xehpsdv: move scratch page to system memory Ramalingam C 2021-12-08 14:16 ` [Intel-gfx] " Ramalingam C 2021-12-08 16:11 ` Andi Shyti 2021-12-08 14:16 ` [PATCH 4/4] drm/i915: enforce min page size for scratch Ramalingam C 2021-12-08 14:16 ` [Intel-gfx] " Ramalingam C 2021-12-08 16:12 ` Andi Shyti 2021-12-08 15:34 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Basic enabling of 64k page support Patchwork 2021-12-08 16:15 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork 2021-12-08 20:36 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Basic enabling of 64k page support (rev2) Patchwork 2021-12-08 21:04 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork 2021-12-09 3:14 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork 2021-12-09 16:45 ` [Intel-gfx] [PATCH 0/4] drm/i915: Basic enabling of 64k page support Ramalingam C 2021-12-09 16:45 ` Ramalingam C -- strict thread matches above, loose matches on Subject: below -- 2021-12-07 16:51 [PATCH 0/4] " Ramalingam C 2021-12-07 16:51 ` [PATCH 2/4] drm/i915/xehpsdv: set min page-size to 64K Ramalingam C
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=184922c4-0cc4-4e95-5248-e9c56ef1141d@linux.intel.com \ --to=thomas.hellstrom@linux.intel.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=intel-gfx@lists.freedesktop.org \ --cc=lucas.demarchi@intel.com \ --cc=matthew.auld@intel.com \ --cc=matthew.william.auld@gmail.com \ --cc=ramalingam.c@intel.com \ --cc=rodrigo.vivi@intel.com \ --cc=thomas.hellstrom@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.