From: Heiko Stuebner <heiko@sntech.de>
To: Doug Anderson <dianders@chromium.org>,
Guenter Roeck <groeck@chromium.org>,
LKML <linux-kernel@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Kishon Vijay Abraham I <kishon@ti.com>
Cc: Elaine Zhang <zhangqing@rock-chips.com>,
Caesar <wxt@rock-chips.com>, Lin Huang <hl@rock-chips.com>,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>,
Derek Basehore <dbasehore@chromium.org>,
Matthias Kaehlcke <mka@chromium.org>,
Ryan Case <ryandcase@chromium.org>
Subject: Re: [PATCH] phy: rockchip-dp: Avoid power leak by leaving the PHY power on
Date: Sat, 18 May 2019 09:51:06 +0200 [thread overview]
Message-ID: <1862323.vETM5zrFmV@phil> (raw)
In-Reply-To: <CAD=FV=VcF688tSArf5gu0sV5oKVgFEvPBxXm7j-5GXXMP_CYRw@mail.gmail.com>
Hi,
Am Samstag, 18. Mai 2019, 01:57:47 CEST schrieb Doug Anderson:
> Elaine and Caesar,
>
> On Tue, May 7, 2019 at 4:50 PM Douglas Anderson <dianders@chromium.org> wrote:
> >
> > While testing a newer kernel on rk3288-based Chromebooks I found that
> > the power draw in suspend was higher on newer kernels compared to the
> > downstream Chrome OS 3.14 kernel. Specifically the power of an
> > rk3288-veyron-jerry board that I tested (as measured by the smart
> > battery) was ~16 mA on Chrome OS 3.14 and ~21 mA on a newer kernel.
> >
> > I tracked the regression down to the fact that the "DP PHY" driver
> > didn't exist in our downstream 3.14. We relied on the eDP driver to
> > turn on the clock and relied on the fact that the power for the PHY
> > was default turned on.
> >
> > Specifically the thing that caused the power regression was turning
> > the eDP PHY _off_. Presumably there is some sort of power leak in the
> > system and when we turn the PHY off something is leaching power from
> > something else and causing excessive power draw.
> >
> > Doing a search through device trees shows that this PHY is only ever
> > used on rk3288. Presumably this power leak is present on all
> > rk3288-SoCs running upstream Linux so let's just whack the driver to
> > make sure we never turn off power. We'll still leave the parts that
> > turn _on_ the power and grab the clock, though.
> >
> > NOTES:
> > A) If someone can identify what this power leak is and fix it in some
> > other way we can revert this patch.
> > B) If someone can show that their particular board doesn't have this
> > power leak (maybe they have rails hooked up differently?) we can
> > perhaps add a device tree property indicating that for some boards
> > it's OK to turn this rail off. I don't want to add this property
> > until I know of a board that needs it.
> >
> > Fixes: fd968973de95 ("phy: Add driver for rockchip Display Port PHY")
> > Signed-off-by: Douglas Anderson <dianders@chromium.org>
> > ---
> > As far as I know Yakir (the original author) is no longer at Rockchip.
> > I've added a few other Rockchip people and hopefully one of them can
> > help direct even if they're not directly responsible.
> >
> > drivers/phy/rockchip/phy-rockchip-dp.c | 11 +++++++----
> > 1 file changed, 7 insertions(+), 4 deletions(-)
>
> Can you help direct this to the right person? ...or should we just
> land it and assume it's fine?
I tink Kishon as phy-maintainer is the correct person to take on this
patch, but maybe he's waiting for the merge-window to be over.
Heiko
WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko@sntech.de>
To: Doug Anderson <dianders@chromium.org>,
Guenter Roeck <groeck@chromium.org>,
LKML <linux-kernel@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Kishon Vijay Abraham I <kishon@ti.com>
Cc: Elaine Zhang <zhangqing@rock-chips.com>,
Lin Huang <hl@rock-chips.com>,
Derek Basehore <dbasehore@chromium.org>,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>,
Matthias Kaehlcke <mka@chromium.org>,
Ryan Case <ryandcase@chromium.org>, Caesar <wxt@rock-chips.com>
Subject: Re: [PATCH] phy: rockchip-dp: Avoid power leak by leaving the PHY power on
Date: Sat, 18 May 2019 09:51:06 +0200 [thread overview]
Message-ID: <1862323.vETM5zrFmV@phil> (raw)
In-Reply-To: <CAD=FV=VcF688tSArf5gu0sV5oKVgFEvPBxXm7j-5GXXMP_CYRw@mail.gmail.com>
Hi,
Am Samstag, 18. Mai 2019, 01:57:47 CEST schrieb Doug Anderson:
> Elaine and Caesar,
>
> On Tue, May 7, 2019 at 4:50 PM Douglas Anderson <dianders@chromium.org> wrote:
> >
> > While testing a newer kernel on rk3288-based Chromebooks I found that
> > the power draw in suspend was higher on newer kernels compared to the
> > downstream Chrome OS 3.14 kernel. Specifically the power of an
> > rk3288-veyron-jerry board that I tested (as measured by the smart
> > battery) was ~16 mA on Chrome OS 3.14 and ~21 mA on a newer kernel.
> >
> > I tracked the regression down to the fact that the "DP PHY" driver
> > didn't exist in our downstream 3.14. We relied on the eDP driver to
> > turn on the clock and relied on the fact that the power for the PHY
> > was default turned on.
> >
> > Specifically the thing that caused the power regression was turning
> > the eDP PHY _off_. Presumably there is some sort of power leak in the
> > system and when we turn the PHY off something is leaching power from
> > something else and causing excessive power draw.
> >
> > Doing a search through device trees shows that this PHY is only ever
> > used on rk3288. Presumably this power leak is present on all
> > rk3288-SoCs running upstream Linux so let's just whack the driver to
> > make sure we never turn off power. We'll still leave the parts that
> > turn _on_ the power and grab the clock, though.
> >
> > NOTES:
> > A) If someone can identify what this power leak is and fix it in some
> > other way we can revert this patch.
> > B) If someone can show that their particular board doesn't have this
> > power leak (maybe they have rails hooked up differently?) we can
> > perhaps add a device tree property indicating that for some boards
> > it's OK to turn this rail off. I don't want to add this property
> > until I know of a board that needs it.
> >
> > Fixes: fd968973de95 ("phy: Add driver for rockchip Display Port PHY")
> > Signed-off-by: Douglas Anderson <dianders@chromium.org>
> > ---
> > As far as I know Yakir (the original author) is no longer at Rockchip.
> > I've added a few other Rockchip people and hopefully one of them can
> > help direct even if they're not directly responsible.
> >
> > drivers/phy/rockchip/phy-rockchip-dp.c | 11 +++++++----
> > 1 file changed, 7 insertions(+), 4 deletions(-)
>
> Can you help direct this to the right person? ...or should we just
> land it and assume it's fine?
I tink Kishon as phy-maintainer is the correct person to take on this
patch, but maybe he's waiting for the merge-window to be over.
Heiko
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-05-18 7:51 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-07 23:48 [PATCH] phy: rockchip-dp: Avoid power leak by leaving the PHY power on Douglas Anderson
2019-05-07 23:48 ` Douglas Anderson
2019-05-17 23:57 ` Doug Anderson
2019-05-17 23:57 ` Doug Anderson
2019-05-18 7:51 ` Heiko Stuebner [this message]
2019-05-18 7:51 ` Heiko Stuebner
2019-05-18 13:42 ` Doug Anderson
2019-05-18 13:42 ` Doug Anderson
2019-05-20 8:04 ` Caesar Wang
2019-05-20 8:04 ` Caesar Wang
2019-05-20 8:04 ` Caesar Wang
2019-06-03 11:20 ` Kishon Vijay Abraham I
2019-06-03 11:20 ` Kishon Vijay Abraham I
2019-06-03 11:20 ` Kishon Vijay Abraham I
2019-06-03 15:22 ` Doug Anderson
2019-06-03 15:22 ` Doug Anderson
2019-06-03 15:22 ` Doug Anderson
2019-06-03 15:23 ` Doug Anderson
2019-06-03 15:23 ` Doug Anderson
2019-06-03 15:23 ` Doug Anderson
2019-07-22 21:52 ` Doug Anderson
2019-07-22 21:52 ` Doug Anderson
2019-07-22 21:52 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1862323.vETM5zrFmV@phil \
--to=heiko@sntech.de \
--cc=dbasehore@chromium.org \
--cc=dianders@chromium.org \
--cc=groeck@chromium.org \
--cc=hl@rock-chips.com \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mka@chromium.org \
--cc=ryandcase@chromium.org \
--cc=wxt@rock-chips.com \
--cc=zhangqing@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.