All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Wang <jasowang@redhat.com>
To: David Ahern <dsahern@gmail.com>,
	"xdp-newbies@vger.kernel.org" <xdp-newbies@vger.kernel.org>
Subject: Re: error loading xdp program on virtio nic
Date: Thu, 21 Nov 2019 11:54:53 +0800	[thread overview]
Message-ID: <18659bd0-432e-f317-fa8a-b5670a91c5b9@redhat.com> (raw)
In-Reply-To: <3dc7b9d8-bcb2-1a90-630e-681cbf0f1ace@gmail.com>


On 2019/11/21 上午11:35, David Ahern wrote:
> On 11/20/19 8:26 PM, Jason Wang wrote:
>> On 2019/11/21 上午1:52, David Ahern wrote:
>>> Hi:
>>>
>>> Trying to load an XDP program on a virtio based nic is failing with:
>>>
>>> virtio_net: XDP expects header/data in single page, any_header_sg
>>> required
>>>
>>> I have not encountered this error before and not able to find what is
>>> missing. Any tips?
>>
>> Hi David:
>>
>> What qemu + guest kernel version did you use? And could you share you
>> qemu cli?
>>
>> Old qemu requires vnet header to be placed into a separate sg which
>> breaks the assumption of XDP. Recent qemu doesn't have such limitation
>> (any_header_sg feature).
>>
>>
> Hi Jason,
>
> When I run qemu via my older vm-tools scripts XDP works fine. This is
> the first time I am trying to use XDP with guests started by libvirt.
>
> We isolated it to a libvirt xml file using an old machine type
> (pc-i440fx-1.5) - basically any machine with VIRTIO_F_VERSION_1 not set.
> Using a newer one move the problem forward.


Yes, if VERSION_1 implies ANY_HEADER_SG, and if you're using old qemu, 
make sure any_header_sg is enabled in qemu cli.


>
> The current error message is:
>    virtio_net: Too few free TX rings available
> again, looking for some libvirt setting for the vm create.
>

Make sure you have sufficient queues, e.g if you N vcpus with multiqueue 
enabled, you need 2*N queues for virtio-net.

Thanks

  reply	other threads:[~2019-11-21  3:54 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-20 17:52 error loading xdp program on virtio nic David Ahern
2019-11-21  3:26 ` Jason Wang
2019-11-21  3:35   ` David Ahern
2019-11-21  3:54     ` Jason Wang [this message]
2019-11-21  4:05       ` David Ahern
2019-11-21  6:26         ` Jesper Dangaard Brouer
2019-11-21  7:02           ` Jason Wang
2019-11-21 15:49             ` David Ahern
2019-11-22  6:09               ` Jason Wang
2019-11-22 15:43                 ` David Ahern
2019-11-22 16:50                   ` Jakub Kicinski
2019-11-22 16:57                   ` Jesper Dangaard Brouer
2019-11-22 17:42                     ` David Ahern
2019-11-23 13:27                       ` Toke Høiland-Jørgensen
2019-11-23 13:27                         ` Toke Høiland-Jørgensen
2019-11-25  2:42                     ` Jason Wang
2019-11-25  2:48                   ` Jason Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=18659bd0-432e-f317-fa8a-b5670a91c5b9@redhat.com \
    --to=jasowang@redhat.com \
    --cc=dsahern@gmail.com \
    --cc=xdp-newbies@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.