From: David Ahern <dsahern@gmail.com>
To: Jesper Dangaard Brouer <brouer@redhat.com>
Cc: Jason Wang <jasowang@redhat.com>,
"xdp-newbies@vger.kernel.org" <xdp-newbies@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: error loading xdp program on virtio nic
Date: Fri, 22 Nov 2019 10:42:53 -0700 [thread overview]
Message-ID: <1fc9364a-ab96-e085-1fc5-9ed29f43f815@gmail.com> (raw)
In-Reply-To: <20191122175749.47728e42@carbon>
On 11/22/19 9:57 AM, Jesper Dangaard Brouer wrote:
> Implementation wise, I would not add flags to xdp_buff / xdp_md.
> Instead I propose in[1] slide 46, that the verifier should detect the
> XDP features used by a BPF-prog. If you XDP prog doesn't use e.g.
> XDP_TX, then you should be allowed to run it on a virtio_net device
> with less queue configured, right?
Thanks for the reference and yes, that is the goal: allow XDP in the
most use cases possible. e.g., Why limit XDP_DROP which requires no
resources because XDP_TX does not work?
I agree a flag in the api is an ugly way to allow it. For the verifier
approach, you mean add an internal flag (e.g., bitmask of return codes)
that the program uses and the NIC driver can check at attach time?
next prev parent reply other threads:[~2019-11-22 17:42 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-20 17:52 error loading xdp program on virtio nic David Ahern
2019-11-21 3:26 ` Jason Wang
2019-11-21 3:35 ` David Ahern
2019-11-21 3:54 ` Jason Wang
2019-11-21 4:05 ` David Ahern
2019-11-21 6:26 ` Jesper Dangaard Brouer
2019-11-21 7:02 ` Jason Wang
2019-11-21 15:49 ` David Ahern
2019-11-22 6:09 ` Jason Wang
2019-11-22 15:43 ` David Ahern
2019-11-22 16:50 ` Jakub Kicinski
2019-11-22 16:57 ` Jesper Dangaard Brouer
2019-11-22 17:42 ` David Ahern [this message]
2019-11-23 13:27 ` Toke Høiland-Jørgensen
2019-11-23 13:27 ` Toke Høiland-Jørgensen
2019-11-25 2:42 ` Jason Wang
2019-11-25 2:48 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1fc9364a-ab96-e085-1fc5-9ed29f43f815@gmail.com \
--to=dsahern@gmail.com \
--cc=brouer@redhat.com \
--cc=jasowang@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=xdp-newbies@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.