scsi: qla2xxx: Fix apparent cut-n-paste error.

scsi: qla2xxx: Fix apparent cut-n-paste error.

[Dave Jones]

commit 093df73771bac8a37d607c0e705d157a8cef4c5c introduces two bodies of
code that look similar but with s/req/rsp/ in the second instance.
But in one case, it looks like this conversion was missed.

Signed-off-by: Dave Jones <davej@codemonkey.org.uk>

diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c
index 8521cfe302e9..ad4edc13ebcf 100644
--- a/drivers/scsi/qla2xxx/qla_os.c
+++ b/drivers/scsi/qla2xxx/qla_os.c
@@ -466,7 +466,7 @@ static void qla2x00_free_queues(struct qla_hw_data *ha)
 			continue;
 
 		rsp = ha->rsp_q_map[cnt];
-		clear_bit(cnt, ha->req_qid_map);
+		clear_bit(cnt, ha->rsp_qid_map);
 		ha->rsp_q_map[cnt] =  NULL;
 		spin_unlock_irqrestore(&ha->hardware_lock, flags);
 		qla2x00_free_rsp_que(ha, rsp);

Re: scsi: qla2xxx: Fix apparent cut-n-paste error.

[Laurence Oberman]

----- Original Message -----
> From: "Dave Jones" <davej@codemonkey.org.uk>
> To: linux-scsi@vger.kernel.org
> Cc: "Quinn Tran" <quinn.tran@cavium.com>
> Sent: Tuesday, December 27, 2016 1:13:21 PM
> Subject: scsi: qla2xxx: Fix apparent cut-n-paste error.
> 
> commit 093df73771bac8a37d607c0e705d157a8cef4c5c introduces two bodies of
> code that look similar but with s/req/rsp/ in the second instance.
> But in one case, it looks like this conversion was missed.
> 
> Signed-off-by: Dave Jones <davej@codemonkey.org.uk>
> 
> diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c
> index 8521cfe302e9..ad4edc13ebcf 100644
> --- a/drivers/scsi/qla2xxx/qla_os.c
> +++ b/drivers/scsi/qla2xxx/qla_os.c
> @@ -466,7 +466,7 @@ static void qla2x00_free_queues(struct qla_hw_data *ha)
>  			continue;
>  
>  		rsp = ha->rsp_q_map[cnt];
> -		clear_bit(cnt, ha->req_qid_map);
> +		clear_bit(cnt, ha->rsp_qid_map);
>  		ha->rsp_q_map[cnt] =  NULL;
>  		spin_unlock_irqrestore(&ha->hardware_lock, flags);
>  		qla2x00_free_rsp_que(ha, rsp);
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

Hi Dave

This had me going for a while but I figured out what you were pointing out.
Your change seems correct to me.

Reviewed-by: Laurence Oberman <loberman@redhat.com>

Re: scsi: qla2xxx: Fix apparent cut-n-paste error.

[Martin K. Petersen]

>>>>> "Dave" == Dave Jones <davej@codemonkey.org.uk> writes:

Dave> commit 093df73771bac8a37d607c0e705d157a8cef4c5c introduces two
Dave> bodies of code that look similar but with s/req/rsp/ in the second
Dave> instance.  But in one case, it looks like this conversion was
Dave> missed.

Quinn?

-- 
Martin K. Petersen	Oracle Linux Engineering

Re: scsi: qla2xxx: Fix apparent cut-n-paste error.

[Tran, Quinn]

-----Original Message-----
From: "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Date: Thursday, January 5, 2017 at 5:52 PM
To: Dave Jones <davej@codemonkey.org.uk>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>, "Tran, Quinn" <Quinn.Tran@cavium.com>
Subject: Re: scsi: qla2xxx: Fix apparent cut-n-paste error.

    >>>>> "Dave" == Dave Jones <davej@codemonkey.org.uk> writes:
    
    Dave> commit 093df73771bac8a37d607c0e705d157a8cef4c5c introduces two
    Dave> bodies of code that look similar but with s/req/rsp/ in the second
    Dave> instance.  But in one case, it looks like this conversion was
    Dave> missed.
    
    Quinn?

Good catch. Thanks.  
    
    -- 
    Martin K. Petersen	Oracle Linux Engineering
    

Re: scsi: qla2xxx: Fix apparent cut-n-paste error.

[Martin K. Petersen]

>>>>> "Dave" == Dave Jones <davej@codemonkey.org.uk> writes:

Dave> commit 093df73771bac8a37d607c0e705d157a8cef4c5c introduces two
Dave> bodies of code that look similar but with s/req/rsp/ in the second
Dave> instance.  But in one case, it looks like this conversion was
Dave> missed.

Applied to 4.10/scsi-fixes.

-- 
Martin K. Petersen	Oracle Linux Engineering