* [PATCH] Do not print `***' when compiling unless we fall over
@ 2009-01-06 16:07 Ian Jackson
2009-01-09 17:18 ` Ian Jackson
0 siblings, 1 reply; 2+ messages in thread
From: Ian Jackson @ 2009-01-06 16:07 UTC (permalink / raw)
To: xen-devel
[-- Attachment #1: message body text --]
[-- Type: text/plain, Size: 518 bytes --]
This has finally bugged me enough to do something about it:
make prints `***' when it stops due to an error. With make -j, and/or
with automated build systems, this error marker can be in the middle
of a large logfile. It is useful to be able to search for it.
Therefore change occurrences of `*' to `#' for information and warning
messages. `***' is reserved for cases where the build stops.
A corresponding change is being applied to qemu-xen-unstable.
Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
[-- Attachment #2: use asterisks for errors only --]
[-- Type: text/plain, Size: 3701 bytes --]
diff -r f2ede9e01d14 buildconfigs/mk.linux-2.6-common
--- a/buildconfigs/mk.linux-2.6-common Tue Jan 06 14:01:39 2009 +0000
+++ b/buildconfigs/mk.linux-2.6-common Tue Jan 06 15:52:03 2009 +0000
@@ -100,10 +100,10 @@ endif
endif
$(__NONINT_CONFIG) $(MAKE) -C $(LINUX_SRCDIR) ARCH=$(LINUX_ARCH) oldconfig O=$$(/bin/pwd)/$(LINUX_DIR)
@set -e ; if [ ! -f $(LINUX_DIR)/Makefile ] ; then \
- echo "***********************************"; \
+ echo "###################################"; \
echo "oldconfig did not create a Makefile"; \
echo "Generating $(LINUX_DIR)/Makefile "; \
- echo "***********************************"; \
+ echo "###################################"; \
( echo "# Automatically generated: don't edit"; \
echo ""; \
echo "VERSION = 2"; \
diff -r f2ede9e01d14 docs/check_pkgs
--- a/docs/check_pkgs Tue Jan 06 14:01:39 2009 +0000
+++ b/docs/check_pkgs Tue Jan 06 15:57:53 2009 +0000
@@ -2,12 +2,12 @@ silent_which ()
silent_which ()
{
which $1 1>/dev/null 2>/dev/null || {
- echo "*************************************************"
- echo "*************************************************"
- echo "* WARNING: Package '$1' is required"
- echo "* to build Xen documentation"
- echo "*************************************************"
- echo "*************************************************"
+ echo "#################################################"
+ echo "#################################################"
+ echo "# WARNING: Package '$1' is required"
+ echo "# to build Xen documentation"
+ echo "#################################################"
+ echo "#################################################"
}
which $1 1>/dev/null 2>/dev/null
}
diff -r f2ede9e01d14 tools/blktap/drivers/Makefile
--- a/tools/blktap/drivers/Makefile Tue Jan 06 14:01:39 2009 +0000
+++ b/tools/blktap/drivers/Makefile Tue Jan 06 16:00:21 2009 +0000
@@ -22,7 +22,7 @@ CRYPT_LIB := -lgcrypt
CRYPT_LIB := -lgcrypt
else
CRYPT_LIB := -lcrypto
-$(warning *** libgcrypt not installed: falling back to libcrypto ***)
+$(warning ### libgcrypt not installed: falling back to libcrypto ###)
endif
LDFLAGS_blktapctrl := $(LDFLAGS_libxenctrl) $(LDFLAGS_libxenstore) -L../lib -lblktap
diff -r f2ede9e01d14 tools/firmware/Makefile
--- a/tools/firmware/Makefile Tue Jan 06 14:01:39 2009 +0000
+++ b/tools/firmware/Makefile Tue Jan 06 15:59:54 2009 +0000
@@ -15,10 +15,10 @@ SUBDIRS += hvmloader
.PHONY: all
all:
@set -e; if [ $$((`( bcc -v 2>&1 | grep version || echo 0.0.0 ) | cut -d' ' -f 3 | awk -F. '{ printf "0x%02x%02x%02x", $$1, $$2, $$3}'`)) -lt $$((0x00100e)) ] ; then \
- echo "***********************************************************"; \
+ echo "###########################################################"; \
echo "Require dev86 package version >= 0.16.14 to build firmware!"; \
echo "(visit http://www.cix.co.uk/~mayday for more information)"; \
- echo "***********************************************************"; \
+ echo "###########################################################"; \
else \
$(MAKE) subdirs-$@; \
fi
diff -r f2ede9e01d14 tools/vtpm/Makefile
--- a/tools/vtpm/Makefile Tue Jan 06 14:01:39 2009 +0000
+++ b/tools/vtpm/Makefile Tue Jan 06 15:59:45 2009 +0000
@@ -89,6 +89,6 @@ build_sub:
$(MAKE) -C $(TPM_EMULATOR_DIR); \
fi \
else \
- echo "*** Unable to build VTPMs. libgmp could not be found."; \
+ echo "### Unable to build VTPMs. libgmp could not be found."; \
fi
[-- Attachment #3: Type: text/plain, Size: 138 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Do not print `***' when compiling unless we fall over
2009-01-06 16:07 [PATCH] Do not print `***' when compiling unless we fall over Ian Jackson
@ 2009-01-09 17:18 ` Ian Jackson
0 siblings, 0 replies; 2+ messages in thread
From: Ian Jackson @ 2009-01-09 17:18 UTC (permalink / raw)
To: xen-devel
[-- Attachment #1: message body text --]
[-- Type: text/plain, Size: 738 bytes --]
I wrote:
> This has finally bugged me enough to do something about it:
>
> make prints `***' when it stops due to an error. With make -j, and/or
> with automated build systems, this error marker can be in the middle
> of a large logfile. It is useful to be able to search for it.
>
> Therefore change occurrences of `*' to `#' for information and warning
> messages. `***' is reserved for cases where the build stops.
>
> A corresponding change is being applied to qemu-xen-unstable.
It turns out that the `make' on our automated testing systems is too
old to cope with $(warning ### something ###) even with quotes, so
here is a revised patch which uses === instead.
Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
Ian.
[-- Attachment #2: replace *** with === except for actual bombing out --]
[-- Type: text/plain, Size: 3701 bytes --]
diff -r f2ede9e01d14 buildconfigs/mk.linux-2.6-common
--- a/buildconfigs/mk.linux-2.6-common Tue Jan 06 14:01:39 2009 +0000
+++ b/buildconfigs/mk.linux-2.6-common Tue Jan 06 15:52:03 2009 +0000
@@ -100,10 +100,10 @@ endif
endif
$(__NONINT_CONFIG) $(MAKE) -C $(LINUX_SRCDIR) ARCH=$(LINUX_ARCH) oldconfig O=$$(/bin/pwd)/$(LINUX_DIR)
@set -e ; if [ ! -f $(LINUX_DIR)/Makefile ] ; then \
- echo "***********************************"; \
+ echo "==================================="; \
echo "oldconfig did not create a Makefile"; \
echo "Generating $(LINUX_DIR)/Makefile "; \
- echo "***********************************"; \
+ echo "==================================="; \
( echo "# Automatically generated: don't edit"; \
echo ""; \
echo "VERSION = 2"; \
diff -r f2ede9e01d14 docs/check_pkgs
--- a/docs/check_pkgs Tue Jan 06 14:01:39 2009 +0000
+++ b/docs/check_pkgs Tue Jan 06 15:57:53 2009 +0000
@@ -2,12 +2,12 @@ silent_which ()
silent_which ()
{
which $1 1>/dev/null 2>/dev/null || {
- echo "*************************************************"
- echo "*************************************************"
- echo "* WARNING: Package '$1' is required"
- echo "* to build Xen documentation"
- echo "*************************************************"
- echo "*************************************************"
+ echo "================================================="
+ echo "================================================="
+ echo "= WARNING: Package '$1' is required"
+ echo "= to build Xen documentation"
+ echo "================================================="
+ echo "================================================="
}
which $1 1>/dev/null 2>/dev/null
}
diff -r f2ede9e01d14 tools/blktap/drivers/Makefile
--- a/tools/blktap/drivers/Makefile Tue Jan 06 14:01:39 2009 +0000
+++ b/tools/blktap/drivers/Makefile Tue Jan 06 16:00:21 2009 +0000
@@ -22,7 +22,7 @@ CRYPT_LIB := -lgcrypt
CRYPT_LIB := -lgcrypt
else
CRYPT_LIB := -lcrypto
-$(warning *** libgcrypt not installed: falling back to libcrypto ***)
+$(warning === libgcrypt not installed: falling back to libcrypto ===)
endif
LDFLAGS_blktapctrl := $(LDFLAGS_libxenctrl) $(LDFLAGS_libxenstore) -L../lib -lblktap
diff -r f2ede9e01d14 tools/firmware/Makefile
--- a/tools/firmware/Makefile Tue Jan 06 14:01:39 2009 +0000
+++ b/tools/firmware/Makefile Tue Jan 06 15:59:54 2009 +0000
@@ -15,10 +15,10 @@ SUBDIRS += hvmloader
.PHONY: all
all:
@set -e; if [ $$((`( bcc -v 2>&1 | grep version || echo 0.0.0 ) | cut -d' ' -f 3 | awk -F. '{ printf "0x%02x%02x%02x", $$1, $$2, $$3}'`)) -lt $$((0x00100e)) ] ; then \
- echo "***********************************************************"; \
+ echo "==========================================================="; \
echo "Require dev86 package version >= 0.16.14 to build firmware!"; \
echo "(visit http://www.cix.co.uk/~mayday for more information)"; \
- echo "***********************************************************"; \
+ echo "==========================================================="; \
else \
$(MAKE) subdirs-$@; \
fi
diff -r f2ede9e01d14 tools/vtpm/Makefile
--- a/tools/vtpm/Makefile Tue Jan 06 14:01:39 2009 +0000
+++ b/tools/vtpm/Makefile Tue Jan 06 15:59:45 2009 +0000
@@ -89,6 +89,6 @@ build_sub:
$(MAKE) -C $(TPM_EMULATOR_DIR); \
fi \
else \
- echo "*** Unable to build VTPMs. libgmp could not be found."; \
+ echo "=== Unable to build VTPMs. libgmp could not be found."; \
fi
[-- Attachment #3: Type: text/plain, Size: 138 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-01-09 17:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-01-06 16:07 [PATCH] Do not print `***' when compiling unless we fall over Ian Jackson
2009-01-09 17:18 ` Ian Jackson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.