All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
To: Nigel Christian <nigel.l.christian@gmail.com>, marcel@holtmann.org
Cc: johan.hedberg@gmail.com, kernel-janitors@vger.kernel.org,
	linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH][v2] Bluetooth: hci_qca: resolve various warnings
Date: Wed, 11 Nov 2020 11:47:48 +0100	[thread overview]
Message-ID: <187b1016-06cf-9f6c-eeac-4bac8c970d58@wanadoo.fr> (raw)
In-Reply-To: <20201111045538.GA90261@fedora-project>

Le 11/11/2020 à 05:55, Nigel Christian a écrit :
> Replace symbolic permissions with octal values. Use usleep_range
> for small msec values due to the fact that msleep() less than
> 20ms may have unexpected behavior/sleep longer.
> 
> - https://lkml.org/lkml/2016/8/2/1945
> - Documentation/timers/timers-howto.rst
> 
> Signed-off-by: Nigel Christian <nigel.l.christian@gmail.com>
> ---
>   drivers/bluetooth/hci_qca.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c
> index 2d3f1f179a1e..039fb117bd8f 100644
> --- a/drivers/bluetooth/hci_qca.c
> +++ b/drivers/bluetooth/hci_qca.c
> @@ -631,7 +631,7 @@ static void qca_debugfs_init(struct hci_dev *hdev)
>   	ibs_dir = debugfs_create_dir("ibs", hdev->debugfs);
>   
>   	/* read only */
> -	mode = S_IRUGO;
> +	mode = 0444;
>   	debugfs_create_u8("tx_ibs_state", mode, ibs_dir, &qca->tx_ibs_state);
>   	debugfs_create_u8("rx_ibs_state", mode, ibs_dir, &qca->rx_ibs_state);
>   	debugfs_create_u64("ibs_sent_sleeps", mode, ibs_dir,
> @@ -658,7 +658,7 @@ static void qca_debugfs_init(struct hci_dev *hdev)
>   	debugfs_create_u32("vote_off_ms", mode, ibs_dir, &qca->vote_off_ms);
>   
>   	/* read/write */
> -	mode = S_IRUGO | S_IWUSR;
> +	mode = 0644;
>   	debugfs_create_u32("wake_retrans", mode, ibs_dir, &qca->wake_retrans);
>   	debugfs_create_u32("tx_idle_delay", mode, ibs_dir,
>   			   &qca->tx_idle_delay);
> @@ -1302,7 +1302,7 @@ static int qca_set_baudrate(struct hci_dev *hdev, uint8_t baudrate)
>   
>   	/* Give the controller time to process the request */
>   	if (qca_is_wcn399x(qca_soc_type(hu)))
> -		msleep(10);
> +		usleep_range(1000, 10000);
This...
>   	else
>   		msleep(300);
>   
> @@ -1350,7 +1350,7 @@ static int qca_send_power_pulse(struct hci_uart *hu, bool on)
>   	if (on)
>   		msleep(100);
>   	else
> -		msleep(10);
> +		usleep_range(1000, 10000);
and this change change a delay which is expected to be 10 ms, and will 
likely be ~20 ms, into a delay which can be down to 1 ms.
Is it intended or tested?

I've not looked at the datasheet, but it looks spurious.

Just my 2c.

CJ

>   
>   	return 0;
>   }
> 


WARNING: multiple messages have this Message-ID (diff)
From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
To: Nigel Christian <nigel.l.christian@gmail.com>, marcel@holtmann.org
Cc: johan.hedberg@gmail.com, kernel-janitors@vger.kernel.org,
	linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH][v2] Bluetooth: hci_qca: resolve various warnings
Date: Wed, 11 Nov 2020 10:47:48 +0000	[thread overview]
Message-ID: <187b1016-06cf-9f6c-eeac-4bac8c970d58@wanadoo.fr> (raw)
In-Reply-To: <20201111045538.GA90261@fedora-project>

Le 11/11/2020 à 05:55, Nigel Christian a écrit :
> Replace symbolic permissions with octal values. Use usleep_range
> for small msec values due to the fact that msleep() less than
> 20ms may have unexpected behavior/sleep longer.
> 
> - https://lkml.org/lkml/2016/8/2/1945
> - Documentation/timers/timers-howto.rst
> 
> Signed-off-by: Nigel Christian <nigel.l.christian@gmail.com>
> ---
>   drivers/bluetooth/hci_qca.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c
> index 2d3f1f179a1e..039fb117bd8f 100644
> --- a/drivers/bluetooth/hci_qca.c
> +++ b/drivers/bluetooth/hci_qca.c
> @@ -631,7 +631,7 @@ static void qca_debugfs_init(struct hci_dev *hdev)
>   	ibs_dir = debugfs_create_dir("ibs", hdev->debugfs);
>   
>   	/* read only */
> -	mode = S_IRUGO;
> +	mode = 0444;
>   	debugfs_create_u8("tx_ibs_state", mode, ibs_dir, &qca->tx_ibs_state);
>   	debugfs_create_u8("rx_ibs_state", mode, ibs_dir, &qca->rx_ibs_state);
>   	debugfs_create_u64("ibs_sent_sleeps", mode, ibs_dir,
> @@ -658,7 +658,7 @@ static void qca_debugfs_init(struct hci_dev *hdev)
>   	debugfs_create_u32("vote_off_ms", mode, ibs_dir, &qca->vote_off_ms);
>   
>   	/* read/write */
> -	mode = S_IRUGO | S_IWUSR;
> +	mode = 0644;
>   	debugfs_create_u32("wake_retrans", mode, ibs_dir, &qca->wake_retrans);
>   	debugfs_create_u32("tx_idle_delay", mode, ibs_dir,
>   			   &qca->tx_idle_delay);
> @@ -1302,7 +1302,7 @@ static int qca_set_baudrate(struct hci_dev *hdev, uint8_t baudrate)
>   
>   	/* Give the controller time to process the request */
>   	if (qca_is_wcn399x(qca_soc_type(hu)))
> -		msleep(10);
> +		usleep_range(1000, 10000);
This...
>   	else
>   		msleep(300);
>   
> @@ -1350,7 +1350,7 @@ static int qca_send_power_pulse(struct hci_uart *hu, bool on)
>   	if (on)
>   		msleep(100);
>   	else
> -		msleep(10);
> +		usleep_range(1000, 10000);
and this change change a delay which is expected to be 10 ms, and will 
likely be ~20 ms, into a delay which can be down to 1 ms.
Is it intended or tested?

I've not looked at the datasheet, but it looks spurious.

Just my 2c.

CJ

>   
>   	return 0;
>   }
> 

  parent reply	other threads:[~2020-11-11 10:47 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-11  4:55 [PATCH][v2] Bluetooth: hci_qca: resolve various warnings Nigel Christian
2020-11-11  4:55 ` Nigel Christian
2020-11-11  9:55 ` Marcel Holtmann
2020-11-11  9:55   ` Marcel Holtmann
2020-11-11 10:47 ` Christophe JAILLET [this message]
2020-11-11 10:47   ` Christophe JAILLET
2020-11-11 14:14   ` Nigel Christian
2020-11-11 14:14     ` Nigel Christian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=187b1016-06cf-9f6c-eeac-4bac8c970d58@wanadoo.fr \
    --to=christophe.jaillet@wanadoo.fr \
    --cc=johan.hedberg@gmail.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=marcel@holtmann.org \
    --cc=nigel.l.christian@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.