* [Qemu-devel] [PATCH V5] hw/pcie-pci-bridge: restrict to X86 and ARM
@ 2017-11-09 15:46 Marcel Apfelbaum
2017-11-09 16:33 ` Thomas Huth
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Marcel Apfelbaum @ 2017-11-09 15:46 UTC (permalink / raw)
To: qemu-devel; +Cc: marcel, mst, thuth, zuban32s, cohuck
The PCIE-PCI bridge is specific to "pure" PCIe systems
(on QEMU we have X86 and ARM), it does not make sense to
have it in other archs.
Reported-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Marcel Apfelbaum <marcel@redhat.com>
---
V4 -> V5
- Since all other tries failed, conditioned the
device on the PCIe Root Port.
V3 -> V4:
- Move the config line to pci.mak (Thomas)
V2 -> V3:
- Another tweak in subject s/if/it (Cornelia)
V1 -> V2:
Addressed Thomas and Cornelia comments:
- Conditioned the pcie-pci-bridge compilation on
the PCIe Root CONFIG_PCIE_PORT
- Tweaked subject PCI -> PCIe
Thanks,
Marcel
hw/pci-bridge/Makefile.objs | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/pci-bridge/Makefile.objs b/hw/pci-bridge/Makefile.objs
index 666db37da2..1b05023662 100644
--- a/hw/pci-bridge/Makefile.objs
+++ b/hw/pci-bridge/Makefile.objs
@@ -1,5 +1,5 @@
-common-obj-y += pci_bridge_dev.o pcie_pci_bridge.o
-common-obj-$(CONFIG_PCIE_PORT) += pcie_root_port.o gen_pcie_root_port.o
+common-obj-y += pci_bridge_dev.o
+common-obj-$(CONFIG_PCIE_PORT) += pcie_root_port.o gen_pcie_root_port.o pcie_pci_bridge.o
common-obj-$(CONFIG_PXB) += pci_expander_bridge.o
common-obj-$(CONFIG_XIO3130) += xio3130_upstream.o xio3130_downstream.o
common-obj-$(CONFIG_IOH3420) += ioh3420.o
--
2.13.5
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [PATCH V5] hw/pcie-pci-bridge: restrict to X86 and ARM
2017-11-09 15:46 [Qemu-devel] [PATCH V5] hw/pcie-pci-bridge: restrict to X86 and ARM Marcel Apfelbaum
@ 2017-11-09 16:33 ` Thomas Huth
2017-11-09 16:43 ` Philippe Mathieu-Daudé
2017-11-10 10:53 ` Cornelia Huck
2 siblings, 0 replies; 5+ messages in thread
From: Thomas Huth @ 2017-11-09 16:33 UTC (permalink / raw)
To: Marcel Apfelbaum, qemu-devel; +Cc: mst, zuban32s, cohuck
On 09.11.2017 16:46, Marcel Apfelbaum wrote:
> The PCIE-PCI bridge is specific to "pure" PCIe systems
> (on QEMU we have X86 and ARM), it does not make sense to
> have it in other archs.
>
> Reported-by: Thomas Huth <thuth@redhat.com>
> Signed-off-by: Marcel Apfelbaum <marcel@redhat.com>
> ---
>
> V4 -> V5
> - Since all other tries failed, conditioned the
> device on the PCIe Root Port.
>
> V3 -> V4:
> - Move the config line to pci.mak (Thomas)
>
> V2 -> V3:
> - Another tweak in subject s/if/it (Cornelia)
>
> V1 -> V2:
> Addressed Thomas and Cornelia comments:
> - Conditioned the pcie-pci-bridge compilation on
> the PCIe Root CONFIG_PCIE_PORT
> - Tweaked subject PCI -> PCIe
>
> Thanks,
> Marcel
>
>
> hw/pci-bridge/Makefile.objs | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/pci-bridge/Makefile.objs b/hw/pci-bridge/Makefile.objs
> index 666db37da2..1b05023662 100644
> --- a/hw/pci-bridge/Makefile.objs
> +++ b/hw/pci-bridge/Makefile.objs
> @@ -1,5 +1,5 @@
> -common-obj-y += pci_bridge_dev.o pcie_pci_bridge.o
> -common-obj-$(CONFIG_PCIE_PORT) += pcie_root_port.o gen_pcie_root_port.o
> +common-obj-y += pci_bridge_dev.o
> +common-obj-$(CONFIG_PCIE_PORT) += pcie_root_port.o gen_pcie_root_port.o pcie_pci_bridge.o
> common-obj-$(CONFIG_PXB) += pci_expander_bridge.o
> common-obj-$(CONFIG_XIO3130) += xio3130_upstream.o xio3130_downstream.o
> common-obj-$(CONFIG_IOH3420) += ioh3420.o
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH V5] hw/pcie-pci-bridge: restrict to X86 and ARM
2017-11-09 15:46 [Qemu-devel] [PATCH V5] hw/pcie-pci-bridge: restrict to X86 and ARM Marcel Apfelbaum
2017-11-09 16:33 ` Thomas Huth
@ 2017-11-09 16:43 ` Philippe Mathieu-Daudé
2017-11-14 12:26 ` Yongbok Kim
2017-11-10 10:53 ` Cornelia Huck
2 siblings, 1 reply; 5+ messages in thread
From: Philippe Mathieu-Daudé @ 2017-11-09 16:43 UTC (permalink / raw)
To: Marcel Apfelbaum, qemu-devel, Paul Burton, Yongbok Kim
Cc: thuth, cohuck, zuban32s, mst, Paul Burton, Yongbok Kim
Hi Marcel,
Cc'ing Paul and Yongbok Since I'm not sure their Boston board could also
use it.
On 11/09/2017 12:46 PM, Marcel Apfelbaum wrote:
> The PCIE-PCI bridge is specific to "pure" PCIe systems
> (on QEMU we have X86 and ARM), it does not make sense to
> have it in other archs.
>
> Reported-by: Thomas Huth <thuth@redhat.com>
> Signed-off-by: Marcel Apfelbaum <marcel@redhat.com>
> ---
>
> V4 -> V5
> - Since all other tries failed, conditioned the
> device on the PCIe Root Port.
>
> V3 -> V4:
> - Move the config line to pci.mak (Thomas)
>
> V2 -> V3:
> - Another tweak in subject s/if/it (Cornelia)
>
> V1 -> V2:
> Addressed Thomas and Cornelia comments:
> - Conditioned the pcie-pci-bridge compilation on
> the PCIe Root CONFIG_PCIE_PORT
> - Tweaked subject PCI -> PCIe
>
> Thanks,
> Marcel
>
>
> hw/pci-bridge/Makefile.objs | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/pci-bridge/Makefile.objs b/hw/pci-bridge/Makefile.objs
> index 666db37da2..1b05023662 100644
> --- a/hw/pci-bridge/Makefile.objs
> +++ b/hw/pci-bridge/Makefile.objs
> @@ -1,5 +1,5 @@
> -common-obj-y += pci_bridge_dev.o pcie_pci_bridge.o
> -common-obj-$(CONFIG_PCIE_PORT) += pcie_root_port.o gen_pcie_root_port.o
> +common-obj-y += pci_bridge_dev.o
> +common-obj-$(CONFIG_PCIE_PORT) += pcie_root_port.o gen_pcie_root_port.o pcie_pci_bridge.o
KISS :)
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Tested-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> common-obj-$(CONFIG_PXB) += pci_expander_bridge.o
> common-obj-$(CONFIG_XIO3130) += xio3130_upstream.o xio3130_downstream.o
> common-obj-$(CONFIG_IOH3420) += ioh3420.o
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH V5] hw/pcie-pci-bridge: restrict to X86 and ARM
2017-11-09 16:43 ` Philippe Mathieu-Daudé
@ 2017-11-14 12:26 ` Yongbok Kim
0 siblings, 0 replies; 5+ messages in thread
From: Yongbok Kim @ 2017-11-14 12:26 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, Marcel Apfelbaum, qemu-devel, Paul Burton
Cc: thuth, cohuck, zuban32s, mst, Paul Burton, Yongbok Kim
On 09/11/2017 16:43, Philippe Mathieu-Daudé wrote:
> Hi Marcel,
>
> Cc'ing Paul and Yongbok Since I'm not sure their Boston board could also
> use it.
>
> On 11/09/2017 12:46 PM, Marcel Apfelbaum wrote:
>> The PCIE-PCI bridge is specific to "pure" PCIe systems
>> (on QEMU we have X86 and ARM), it does not make sense to
>> have it in other archs.
>>
>> Reported-by: Thomas Huth <thuth@redhat.com>
>> Signed-off-by: Marcel Apfelbaum <marcel@redhat.com>
>> ---
>>
>> V4 -> V5
>> - Since all other tries failed, conditioned the
>> device on the PCIe Root Port.
>>
>> V3 -> V4:
>> - Move the config line to pci.mak (Thomas)
>>
>> V2 -> V3:
>> - Another tweak in subject s/if/it (Cornelia)
>>
>> V1 -> V2:
>> Addressed Thomas and Cornelia comments:
>> - Conditioned the pcie-pci-bridge compilation on
>> the PCIe Root CONFIG_PCIE_PORT
>> - Tweaked subject PCI -> PCIe
>>
>> Thanks,
>> Marcel
>>
>>
>> hw/pci-bridge/Makefile.objs | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/hw/pci-bridge/Makefile.objs b/hw/pci-bridge/Makefile.objs
>> index 666db37da2..1b05023662 100644
>> --- a/hw/pci-bridge/Makefile.objs
>> +++ b/hw/pci-bridge/Makefile.objs
>> @@ -1,5 +1,5 @@
>> -common-obj-y += pci_bridge_dev.o pcie_pci_bridge.o
>> -common-obj-$(CONFIG_PCIE_PORT) += pcie_root_port.o gen_pcie_root_port.o
>> +common-obj-y += pci_bridge_dev.o
>> +common-obj-$(CONFIG_PCIE_PORT) += pcie_root_port.o gen_pcie_root_port.o pcie_pci_bridge.o
> KISS :)
>
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> Tested-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>
>> common-obj-$(CONFIG_PXB) += pci_expander_bridge.o
>> common-obj-$(CONFIG_XIO3130) += xio3130_upstream.o xio3130_downstream.o
>> common-obj-$(CONFIG_IOH3420) += ioh3420.o
>>
Hi Marcel, Philippe.
It looks ok for MIPS Boston.
[Yongbok Kim:
tested for MIPS boston]
Tested-by: Yongbok Kim <yongbok.kim@mips.com>
Regards,
Yongbok
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH V5] hw/pcie-pci-bridge: restrict to X86 and ARM
2017-11-09 15:46 [Qemu-devel] [PATCH V5] hw/pcie-pci-bridge: restrict to X86 and ARM Marcel Apfelbaum
2017-11-09 16:33 ` Thomas Huth
2017-11-09 16:43 ` Philippe Mathieu-Daudé
@ 2017-11-10 10:53 ` Cornelia Huck
2 siblings, 0 replies; 5+ messages in thread
From: Cornelia Huck @ 2017-11-10 10:53 UTC (permalink / raw)
To: Marcel Apfelbaum; +Cc: qemu-devel, mst, thuth, zuban32s
On Thu, 9 Nov 2017 17:46:45 +0200
Marcel Apfelbaum <marcel@redhat.com> wrote:
> The PCIE-PCI bridge is specific to "pure" PCIe systems
> (on QEMU we have X86 and ARM), it does not make sense to
> have it in other archs.
>
> Reported-by: Thomas Huth <thuth@redhat.com>
> Signed-off-by: Marcel Apfelbaum <marcel@redhat.com>
> ---
>
> V4 -> V5
> - Since all other tries failed, conditioned the
> device on the PCIe Root Port.
>
> V3 -> V4:
> - Move the config line to pci.mak (Thomas)
>
> V2 -> V3:
> - Another tweak in subject s/if/it (Cornelia)
>
> V1 -> V2:
> Addressed Thomas and Cornelia comments:
> - Conditioned the pcie-pci-bridge compilation on
> the PCIe Root CONFIG_PCIE_PORT
> - Tweaked subject PCI -> PCIe
>
> Thanks,
> Marcel
>
>
> hw/pci-bridge/Makefile.objs | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/pci-bridge/Makefile.objs b/hw/pci-bridge/Makefile.objs
> index 666db37da2..1b05023662 100644
> --- a/hw/pci-bridge/Makefile.objs
> +++ b/hw/pci-bridge/Makefile.objs
> @@ -1,5 +1,5 @@
> -common-obj-y += pci_bridge_dev.o pcie_pci_bridge.o
> -common-obj-$(CONFIG_PCIE_PORT) += pcie_root_port.o gen_pcie_root_port.o
> +common-obj-y += pci_bridge_dev.o
> +common-obj-$(CONFIG_PCIE_PORT) += pcie_root_port.o gen_pcie_root_port.o pcie_pci_bridge.o
> common-obj-$(CONFIG_PXB) += pci_expander_bridge.o
> common-obj-$(CONFIG_XIO3130) += xio3130_upstream.o xio3130_downstream.o
> common-obj-$(CONFIG_IOH3420) += ioh3420.o
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-11-14 12:27 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-09 15:46 [Qemu-devel] [PATCH V5] hw/pcie-pci-bridge: restrict to X86 and ARM Marcel Apfelbaum
2017-11-09 16:33 ` Thomas Huth
2017-11-09 16:43 ` Philippe Mathieu-Daudé
2017-11-14 12:26 ` Yongbok Kim
2017-11-10 10:53 ` Cornelia Huck
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.