All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] init/calibrate.c - provide proper prototype.
@ 2019-01-29  8:35 valdis.kletnieks
  0 siblings, 0 replies; only message in thread
From: valdis.kletnieks @ 2019-01-29  8:35 UTC (permalink / raw)
  To: Andrew Morton; +Cc: linux-kernel

Sparse issues a warning:

  CHECK   init/calibrate.c
init/calibrate.c:271:28: warning: symbol 'calibration_delay_done' was not declared. Should it be static?

The actual issue is that it's a __weak symbol that archs can override (in fact,
ARM does so), but no prototype is provided. Let's provide one to prevent
surprises.

Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>

diff --git a/include/linux/delay.h b/include/linux/delay.h
index b78bab4395d8..8e6828094c1e 100644
--- a/include/linux/delay.h
+++ b/include/linux/delay.h
@@ -55,6 +55,7 @@ static inline void ndelay(unsigned long x)
 
 extern unsigned long lpj_fine;
 void calibrate_delay(void);
+void __attribute__((weak)) calibration_delay_done(void);
 void msleep(unsigned int msecs);
 unsigned long msleep_interruptible(unsigned int msecs);
 void usleep_range(unsigned long min, unsigned long max);



^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2019-01-29  8:35 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-29  8:35 [PATCH] init/calibrate.c - provide proper prototype valdis.kletnieks

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.