qemu usb not working after restore

qemu usb not working after restore

[James Harper]

I have tracked my gplpv hanging-on-restore problem down to the qemu usb
interrupt getting 'stuck'.

Even when it doesn't get 'stuck', the tablet device (and therefore
presumably the USB) doesn't work anymore and the pointer reverts back to
the mouse that doesn't track the real pointer very well.

Is this a known bug anywhere? If not, any suggestions as to where to
start looking would be greatly appreciated!

Thanks

James

RE: qemu usb not working after restore

[James Harper]

> 
> I have tracked my gplpv hanging-on-restore problem down to the qemu
usb
> interrupt getting 'stuck'.
> 
> Even when it doesn't get 'stuck', the tablet device (and therefore
> presumably the USB) doesn't work anymore and the pointer reverts back
to
> the mouse that doesn't track the real pointer very well.
> 
> Is this a known bug anywhere? If not, any suggestions as to where to
> start looking would be greatly appreciated!
> 

After a quick look, I can see that the _save and _load code in
usb_uhci.c is "#if 0"'d out. Stefano Stabellini posted a patch on Oct 15
to enable it again, but I can't see it anywhere... maybe I'm just using
a bad tree?

James

Re: qemu usb not working after restore

[Keir Fraser]

On 11/02/2009 22:44, "James Harper" <james.harper@bendigoit.com.au> wrote:

>> Is this a known bug anywhere? If not, any suggestions as to where to
>> start looking would be greatly appreciated!
>> 
> 
> After a quick look, I can see that the _save and _load code in
> usb_uhci.c is "#if 0"'d out. Stefano Stabellini posted a patch on Oct 15
> to enable it again, but I can't see it anywhere... maybe I'm just using
> a bad tree?

That's a question for Stefano and Ian Jackson. If we're not backporting
sufficient stabiliation patches from the unstable git repo, that's quite a
problem.

 -- Keir

Re: qemu usb not working after restore

[Stefano Stabellini]

Keir Fraser wrote:

> On 11/02/2009 22:44, "James Harper" <james.harper@bendigoit.com.au> wrote:
> 
>>> Is this a known bug anywhere? If not, any suggestions as to where to
>>> start looking would be greatly appreciated!
>>>
>> After a quick look, I can see that the _save and _load code in
>> usb_uhci.c is "#if 0"'d out. Stefano Stabellini posted a patch on Oct 15
>> to enable it again, but I can't see it anywhere... maybe I'm just using
>> a bad tree?
> 
> That's a question for Stefano and Ian Jackson. If we're not backporting
> sufficient stabiliation patches from the unstable git repo, that's quite a
> problem.
> 

I can see that my patch was not backported to the 3.3 testing tree.
Ian, can you please backport commit
5f8914edc785ddbd3cae769aa8309c80609c3601 on qemu-xen-unstable?

Re: qemu usb not working after restore

[venkatesh k]

make -f buildconfigs/mk.linux-2.6-xen build
make[2]: Entering directory `/home/mamce/Desktop/xen-3.3.1'
set -e ; \
	if [ ! -e linux-2.6.18-xen.hg/.hg ] ; then \
	    __repo=$(sh buildconfigs/select-repository linux-2.6.18-xen.hg .:..) ; \
	    if [ -d ${__repo} ] ; then \
	        echo "Linking ${__repo} to linux-2.6.18-xen.hg." ; \
	        ln -s ${__repo} linux-2.6.18-xen.hg ; \
	    else \
	        echo "Cloning ${__repo} to linux-2.6.18-xen.hg." ; \
	        hg clone ${__repo#file://} linux-2.6.18-xen.hg ; \
	    fi ; \
	else \
	    __parent=$(hg -R linux-2.6.18-xen.hg path default) ; \
	    echo "Pulling changes from ${__parent} into linux-2.6.18-xen.hg." ; \
	    hg -R linux-2.6.18-xen.hg pull ${__parent} ; \
	fi
select-repository: Searching `.:..' for linux-2.6.18-xen.hg
select-repository: Ignoring `.'
Unable to determine path to Linux source tree.
Falling back to linux-2.6.18-xen Mercurial repository.
Cloning http://xenbits.xensource.com/linux-2.6.18-xen.hg to linux-2.6.18-xen.hg.
/bin/sh: hg: not found
make[2]: *** [linux-2.6.18-xen.hg/.valid-src] Error 127
make[2]: Leaving directory `/home/mamce/Desktop/xen-3.3.1'
make[1]: *** [linux-2.6-xen-install] Error 2
make[1]: Leaving directory `/home/mamce/Desktop/xen-3.3.1'
make: *** [install-kernels] Error 1


On 2/12/09, Stefano Stabellini <stefano.stabellini@eu.citrix.com> wrote:
> Keir Fraser wrote:
>
>> On 11/02/2009 22:44, "James Harper" <james.harper@bendigoit.com.au> wrote:
>>
>>>> Is this a known bug anywhere? If not, any suggestions as to where to
>>>> start looking would be greatly appreciated!
>>>>
>>> After a quick look, I can see that the _save and _load code in
>>> usb_uhci.c is "#if 0"'d out. Stefano Stabellini posted a patch on Oct 15
>>> to enable it again, but I can't see it anywhere... maybe I'm just using
>>> a bad tree?
>>
>> That's a question for Stefano and Ian Jackson. If we're not backporting
>> sufficient stabiliation patches from the unstable git repo, that's quite a
>> problem.
>>
>
> I can see that my patch was not backported to the 3.3 testing tree.
> Ian, can you please backport commit
> 5f8914edc785ddbd3cae769aa8309c80609c3601 on qemu-xen-unstable?
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
>

Re: qemu usb not working after restore

[Stefano Stabellini]

venkatesh k wrote:

> make -f buildconfigs/mk.linux-2.6-xen build
> make[2]: Entering directory `/home/mamce/Desktop/xen-3.3.1'
> set -e ; \
> 	if [ ! -e linux-2.6.18-xen.hg/.hg ] ; then \
> 	    __repo=$(sh buildconfigs/select-repository linux-2.6.18-xen.hg .:..) ; \
> 	    if [ -d ${__repo} ] ; then \
> 	        echo "Linking ${__repo} to linux-2.6.18-xen.hg." ; \
> 	        ln -s ${__repo} linux-2.6.18-xen.hg ; \
> 	    else \
> 	        echo "Cloning ${__repo} to linux-2.6.18-xen.hg." ; \
> 	        hg clone ${__repo#file://} linux-2.6.18-xen.hg ; \
> 	    fi ; \
> 	else \
> 	    __parent=$(hg -R linux-2.6.18-xen.hg path default) ; \
> 	    echo "Pulling changes from ${__parent} into linux-2.6.18-xen.hg." ; \
> 	    hg -R linux-2.6.18-xen.hg pull ${__parent} ; \
> 	fi
> select-repository: Searching `.:..' for linux-2.6.18-xen.hg
> select-repository: Ignoring `.'
> Unable to determine path to Linux source tree.
> Falling back to linux-2.6.18-xen Mercurial repository.
> Cloning http://xenbits.xensource.com/linux-2.6.18-xen.hg to linux-2.6.18-xen.hg.
> /bin/sh: hg: not found

do you have mercurial installed on you machine?

Re: qemu usb not working after restore

[Keir Fraser]

Your backtrace doesn't seem very pertinent to this thread. Looks like you
don't have the mercurial package installed on your build system.

 -- Keir

On 12/02/2009 10:36, "venkatesh k" <venkatesh7venkatesh@gmail.com> wrote:

> make -f buildconfigs/mk.linux-2.6-xen build
> make[2]: Entering directory `/home/mamce/Desktop/xen-3.3.1'
> set -e ; \
> if [ ! -e linux-2.6.18-xen.hg/.hg ] ; then \
>    __repo=$(sh buildconfigs/select-repository linux-2.6.18-xen.hg .:..) ; \
>    if [ -d ${__repo} ] ; then \
>        echo "Linking ${__repo} to linux-2.6.18-xen.hg." ; \
>        ln -s ${__repo} linux-2.6.18-xen.hg ; \
>    else \
>        echo "Cloning ${__repo} to linux-2.6.18-xen.hg." ; \
>        hg clone ${__repo#file://} linux-2.6.18-xen.hg ; \
>    fi ; \
> else \
>    __parent=$(hg -R linux-2.6.18-xen.hg path default) ; \
>    echo "Pulling changes from ${__parent} into linux-2.6.18-xen.hg." ; \
>    hg -R linux-2.6.18-xen.hg pull ${__parent} ; \
> fi
> select-repository: Searching `.:..' for linux-2.6.18-xen.hg
> select-repository: Ignoring `.'
> Unable to determine path to Linux source tree.
> Falling back to linux-2.6.18-xen Mercurial repository.
> Cloning http://xenbits.xensource.com/linux-2.6.18-xen.hg to
> linux-2.6.18-xen.hg.
> /bin/sh: hg: not found
> make[2]: *** [linux-2.6.18-xen.hg/.valid-src] Error 127
> make[2]: Leaving directory `/home/mamce/Desktop/xen-3.3.1'
> make[1]: *** [linux-2.6-xen-install] Error 2
> make[1]: Leaving directory `/home/mamce/Desktop/xen-3.3.1'
> make: *** [install-kernels] Error 1
> 
> 
> On 2/12/09, Stefano Stabellini <stefano.stabellini@eu.citrix.com> wrote:
>> Keir Fraser wrote:
>> 
>>> On 11/02/2009 22:44, "James Harper" <james.harper@bendigoit.com.au> wrote:
>>> 
>>>>> Is this a known bug anywhere? If not, any suggestions as to where to
>>>>> start looking would be greatly appreciated!
>>>>> 
>>>> After a quick look, I can see that the _save and _load code in
>>>> usb_uhci.c is "#if 0"'d out. Stefano Stabellini posted a patch on Oct 15
>>>> to enable it again, but I can't see it anywhere... maybe I'm just using
>>>> a bad tree?
>>> 
>>> That's a question for Stefano and Ian Jackson. If we're not backporting
>>> sufficient stabiliation patches from the unstable git repo, that's quite a
>>> problem.
>>> 
>> 
>> I can see that my patch was not backported to the 3.3 testing tree.
>> Ian, can you please backport commit
>> 5f8914edc785ddbd3cae769aa8309c80609c3601 on qemu-xen-unstable?
>> 
>> _______________________________________________
>> Xen-devel mailing list
>> Xen-devel@lists.xensource.com
>> http://lists.xensource.com/xen-devel
>> 

Re: qemu usb not working after restore

[Ian Jackson]

Stefano Stabellini writes ("Re: [Xen-devel] qemu usb not working after restore"):
> I can see that my patch was not backported to the 3.3 testing tree.
> Ian, can you please backport commit
> 5f8914edc785ddbd3cae769aa8309c80609c3601 on qemu-xen-unstable?

Done.  James, thanks for pointing that out.

Ian.

Re: qemu usb not working after restore

[Ian Jackson]

James Harper writes ("[Xen-devel] qemu usb not working after restore"):
> I have tracked my gplpv hanging-on-restore problem down to the qemu usb
> interrupt getting 'stuck'.

So once again sorry for not backporting the usb save/restore fix to
3.3 earlier.  Do you have everything you need now, to apply that
change to your own trees ?  If you need any help feel free to ask here
or email me privately.

Ian.

RE: qemu usb not working after restore

[James Harper]

> James Harper writes ("[Xen-devel] qemu usb not working after
restore"):
> > I have tracked my gplpv hanging-on-restore problem down to the qemu
usb
> > interrupt getting 'stuck'.
> 
> So once again sorry for not backporting the usb save/restore fix to
> 3.3 earlier.  Do you have everything you need now, to apply that
> change to your own trees ?  If you need any help feel free to ask here
> or email me privately.
> 

It's all good now. It was driving me quite crazy there for a while, as
the most obvious result was that the DomU would hang hard as soon as I
enabled interrupts after a restore, and I assumed my GPLPV drivers were
breaking something and causing an IRQ to be stuck, but it turned out to
be the USB drivers. It's one of those things that was obvious in
retrospect (the mouse pointer reverted to mouse instead of tablet on the
occasions when it didn't hang). The moment I applied the fix it all
worked again.

Thanks

James