phosphor-ipmi-flash: A problem in BMC FW update over LPC

phosphor-ipmi-flash: A problem in BMC FW update over LPC

[CS20 KWLiu]

[-- Attachment #1: Type: text/plain, Size: 1191 bytes --]

Hello Patrick:

We are currently trying to enable the BMC FW update over LPC on our platform (nuvoton BMC), but we encounter a problem with BIOS.

The BIOS engineer has reserved memory region as mmio space, but we couldn't see any data change in this region during run burn_my_bmc.

We have checked the BMC setting(in lpc_nuvoton.c and LDN SHM) but we couldn't identify the root cause of this problem.

Is there any settings we lost?

Thanks,
Joseph
________________________________
The privileged confidential information contained in this email is intended for use only by the addressees as indicated by the original sender of this email. If you are not the addressee indicated in this email or are not responsible for delivery of the email to such a person, please kindly reply to the sender indicating this fact and delete all copies of it from your computer and network server immediately. Your cooperation is highly appreciated. It is advised that any unauthorized use of confidential information of Nuvoton is strictly prohibited; and any information in this email irrelevant to the official business of Nuvoton shall be deemed as neither given nor endorsed by Nuvoton.

[-- Attachment #2: Type: text/html, Size: 3851 bytes --]

Re: phosphor-ipmi-flash: A problem in BMC FW update over LPC

[Patrick Venture]

On Fri, Aug 23, 2019 at 4:13 AM CS20 KWLiu <KWLIU@nuvoton.com> wrote:
>
> Hello Patrick:
>
>
>
> We are currently trying to enable the BMC FW update over LPC on our platform (nuvoton BMC), but we encounter a problem with BIOS.
> The BIOS engineer has reserved memory region as mmio space, but we couldn't see any data change in this region during run burn_my_bmc.
> We have checked the BMC setting(in lpc_nuvoton.c and LDN SHM) but we couldn't identify the root cause of this problem.

+Benjamin Fair

I don't know the Nuvoton BMC that well, but I do know that I tested it
on a system we have that uses it.  I'm adding Benjamin as he's more
familiar with any nuances associated with Nuvoton's BMC.

>
>
>
> Is there any settings we lost?
>
>
>
> Thanks,
>
> Joseph
>
> ________________________________
> The privileged confidential information contained in this email is intended for use only by the addressees as indicated by the original sender of this email. If you are not the addressee indicated in this email or are not responsible for delivery of the email to such a person, please kindly reply to the sender indicating this fact and delete all copies of it from your computer and network server immediately. Your cooperation is highly appreciated. It is advised that any unauthorized use of confidential information of Nuvoton is strictly prohibited; and any information in this email irrelevant to the official business of Nuvoton shall be deemed as neither given nor endorsed by Nuvoton.

RE: phosphor-ipmi-flash: A problem in BMC FW update over LPC

[Corey Chen (陳志銘)]

[-- Attachment #1: Type: text/plain, Size: 2203 bytes --]

Hi,

Currently, I’m doing following steps,

  1. Get a MMIO space via GCD service.
  2. Program LPC/eSPI PCI Offset 98h [0] to [0] to disable memory decoding first before changing base address.
  3. Program LPC/eSPI PCI Offset 98h [31:16, 0] to [Address, 1].
  4. Program LPC/eSPI Memory Range, PCR[DMI] + 2740h to the same value programmed in LPC/eSPI PCI Offset 98h.

But after discussing with Intel,
perhaps I have to make sure that the MMIO space I’m using is claimed in MMIO_RULE_CFG_X as Skylake BIOS writer guide mentions.

BR,
Corey

From: CS20 KWLiu [mailto:KWLIU@nuvoton.com]
Sent: Friday, August 23, 2019 7:13 PM
To: Patrick Venture <venture@google.com>
Cc: CS20 CTCchien <CTCCHIEN@nuvoton.com>; Corey Chen (陳志銘) <Corey.Chen@quantatw.com>; Fran Hsu (徐誌謙) <Fran.Hsu@quantatw.com>; Samuel Jiang (江騏先) <Samuel.Jiang@quantatw.com>; George Hung (洪忠敬) <George.Hung@quantatw.com>; openbmc@lists.ozlabs.org
Subject: phosphor-ipmi-flash: A problem in BMC FW update over LPC

Hello Patrick:

We are currently trying to enable the BMC FW update over LPC on our platform (nuvoton BMC), but we encounter a problem with BIOS.

The BIOS engineer has reserved memory region as mmio space, but we couldn't see any data change in this region during run burn_my_bmc.

We have checked the BMC setting(in lpc_nuvoton.c and LDN SHM) but we couldn't identify the root cause of this problem.

Is there any settings we lost?

Thanks,
Joseph
________________________________
The privileged confidential information contained in this email is intended for use only by the addressees as indicated by the original sender of this email. If you are not the addressee indicated in this email or are not responsible for delivery of the email to such a person, please kindly reply to the sender indicating this fact and delete all copies of it from your computer and network server immediately. Your cooperation is highly appreciated. It is advised that any unauthorized use of confidential information of Nuvoton is strictly prohibited; and any information in this email irrelevant to the official business of Nuvoton shall be deemed as neither given nor endorsed by Nuvoton.

[-- Attachment #2: Type: text/html, Size: 7973 bytes --]

RE: phosphor-ipmi-flash: A problem in BMC FW update over LPC

[CS20 CTCchien]

Hi Patrick,

I use latest phosphor-ipmi-flash, and I met an error about /flash/image in bmc/config-static-bmc-reboot.json.in,
I change it to /flash/static, then the issue disappeared.
Did I miss something?

Thanks

B.R.
Medad


-----Original Message-----
From: Patrick Venture <venture@google.com>
Sent: Friday, August 23, 2019 10:43 PM
To: CS20 KWLiu <KWLIU@nuvoton.com>; Benjamin Fair <benjaminfair@google.com>
Cc: CS20 CTCchien <CTCCHIEN@nuvoton.com>; Corey Chen (陳志銘) <Corey.Chen@quantatw.com>; Fran Hsu (徐誌謙) <Fran.Hsu@quantatw.com>; Samuel Jiang (江騏先) <Samuel.Jiang@quantatw.com>; George Hung (洪忠敬) <George.Hung@quantatw.com>; openbmc@lists.ozlabs.org
Subject: Re: phosphor-ipmi-flash: A problem in BMC FW update over LPC

On Fri, Aug 23, 2019 at 4:13 AM CS20 KWLiu <KWLIU@nuvoton.com> wrote:
>
> Hello Patrick:
>
>
>
> We are currently trying to enable the BMC FW update over LPC on our platform (nuvoton BMC), but we encounter a problem with BIOS.
> The BIOS engineer has reserved memory region as mmio space, but we couldn't see any data change in this region during run burn_my_bmc.
> We have checked the BMC setting(in lpc_nuvoton.c and LDN SHM) but we couldn't identify the root cause of this problem.

+Benjamin Fair

I don't know the Nuvoton BMC that well, but I do know that I tested it on a system we have that uses it.  I'm adding Benjamin as he's more familiar with any nuances associated with Nuvoton's BMC.

>
>
>
> Is there any settings we lost?
>
>
>
> Thanks,
>
> Joseph
>
> ________________________________
> The privileged confidential information contained in this email is intended for use only by the addressees as indicated by the original sender of this email. If you are not the addressee indicated in this email or are not responsible for delivery of the email to such a person, please kindly reply to the sender indicating this fact and delete all copies of it from your computer and network server immediately. Your cooperation is highly appreciated. It is advised that any unauthorized use of confidential information of Nuvoton is strictly prohibited; and any information in this email irrelevant to the official business of Nuvoton shall be deemed as neither given nor endorsed by Nuvoton.
________________________________
________________________________
 The privileged confidential information contained in this email is intended for use only by the addressees as indicated by the original sender of this email. If you are not the addressee indicated in this email or are not responsible for delivery of the email to such a person, please kindly reply to the sender indicating this fact and delete all copies of it from your computer and network server immediately. Your cooperation is highly appreciated. It is advised that any unauthorized use of confidential information of Nuvoton is strictly prohibited; and any information in this email irrelevant to the official business of Nuvoton shall be deemed as neither given nor endorsed by Nuvoton.

Re: phosphor-ipmi-flash: A problem in BMC FW update over LPC

[Patrick Venture]

On Sun, Sep 1, 2019 at 8:02 PM CS20 CTCchien <CTCCHIEN@nuvoton.com> wrote:
>
> Hi Patrick,
>
> I use latest phosphor-ipmi-flash, and I met an error about /flash/image in bmc/config-static-bmc-reboot.json.in,
> I change it to /flash/static, then the issue disappeared.
> Did I miss something?

The name of the thing in the json file is the type to use now with the
"--type" parameter, not the whole name, just the ending.  So
/flash/static becomes --type static, and /flash/image becomes --type
image

It was a change related to needing to support arbitrary update targets.
>
> Thanks
>
> B.R.
> Medad
>
>
> -----Original Message-----
> From: Patrick Venture <venture@google.com>
> Sent: Friday, August 23, 2019 10:43 PM
> To: CS20 KWLiu <KWLIU@nuvoton.com>; Benjamin Fair <benjaminfair@google.com>
> Cc: CS20 CTCchien <CTCCHIEN@nuvoton.com>; Corey Chen (陳志銘) <Corey.Chen@quantatw.com>; Fran Hsu (徐誌謙) <Fran.Hsu@quantatw.com>; Samuel Jiang (江騏先) <Samuel.Jiang@quantatw.com>; George Hung (洪忠敬) <George.Hung@quantatw.com>; openbmc@lists.ozlabs.org
> Subject: Re: phosphor-ipmi-flash: A problem in BMC FW update over LPC
>
> On Fri, Aug 23, 2019 at 4:13 AM CS20 KWLiu <KWLIU@nuvoton.com> wrote:
> >
> > Hello Patrick:
> >
> >
> >
> > We are currently trying to enable the BMC FW update over LPC on our platform (nuvoton BMC), but we encounter a problem with BIOS.
> > The BIOS engineer has reserved memory region as mmio space, but we couldn't see any data change in this region during run burn_my_bmc.
> > We have checked the BMC setting(in lpc_nuvoton.c and LDN SHM) but we couldn't identify the root cause of this problem.
>
> +Benjamin Fair
>
> I don't know the Nuvoton BMC that well, but I do know that I tested it on a system we have that uses it.  I'm adding Benjamin as he's more familiar with any nuances associated with Nuvoton's BMC.
>
> >
> >
> >
> > Is there any settings we lost?
> >
> >
> >
> > Thanks,
> >
> > Joseph
> >
> > ________________________________
> > The privileged confidential information contained in this email is intended for use only by the addressees as indicated by the original sender of this email. If you are not the addressee indicated in this email or are not responsible for delivery of the email to such a person, please kindly reply to the sender indicating this fact and delete all copies of it from your computer and network server immediately. Your cooperation is highly appreciated. It is advised that any unauthorized use of confidential information of Nuvoton is strictly prohibited; and any information in this email irrelevant to the official business of Nuvoton shall be deemed as neither given nor endorsed by Nuvoton.
> ________________________________
> ________________________________
>  The privileged confidential information contained in this email is intended for use only by the addressees as indicated by the original sender of this email. If you are not the addressee indicated in this email or are not responsible for delivery of the email to such a person, please kindly reply to the sender indicating this fact and delete all copies of it from your computer and network server immediately. Your cooperation is highly appreciated. It is advised that any unauthorized use of confidential information of Nuvoton is strictly prohibited; and any information in this email irrelevant to the official business of Nuvoton shall be deemed as neither given nor endorsed by Nuvoton.

Re: phosphor-ipmi-flash: A problem in BMC FW update over LPC

[Patrick Venture]

On Wed, Sep 25, 2019 at 10:30 PM CS20 CTCchien <CTCCHIEN@nuvoton.com> wrote:
>
> Hello Patrick,
>
> Should I move enable-nuvoton-p2a-mbox and enable-nuvoton-p2a-vga to PACKAGECONFIG in phosphor-ipmi-flash_git.bb?

Please add the code that supports them first to phosphor-ipmi-flash.
Otherwise they're invalid options.

Also, please always include the mailing list unless the communication
is strictly confidential and then follow whatever rules apply.

Thanks.

>
> B.R.
> Medad
>
> -----Original Message-----
> From: Patrick Venture <venture@google.com>
> Sent: Wednesday, September 25, 2019 12:29 PM
> To: CS20 CTCchien <CTCCHIEN@nuvoton.com>
> Subject: Re: phosphor-ipmi-flash: A problem in BMC FW update over LPC
>
> On Tue, Sep 24, 2019 at 7:10 PM CS20 CTCchien <CTCCHIEN@nuvoton.com> wrote:
> >
> > Hello Patrick,
> >
> > You mentioned " If you dropped these values in meta-phosphor/recipes-phosphor/ipmi/phosphor-ipmi-flash_git.bb, I would +2 it."
> >
> > In
> >
> > https://urldefense.proofpoint.com/v2/url?u=https-3A__gerrit.openbmc-2D
> > project.xyz_c_openbmc_meta-2Dphosphor_-2B_25440_3_nuvoton-2Dlayer_reci
> > pes-2Dphosphor_ipmi_phosphor-2Dipmi-2Dflash-5F-252525.bbappend-235&d=D
> > wIFaQ&c=ue8mO8zgC4VZ4q_aNVKt8G9MC01UFDmisvMR1k-EoDM&r=HqT4ScbSY2YNT4sF
> > BmDErzNgMDeKfQmTiR08x2qtobg&m=pU2gA8MnD8d5MLAxqPVtD1a4cOienC3F0H-3BG5a
> > Z80&s=IIpKpu1IRFCg1egtL7Ol_rdHMcJKojurE_UB5RyoPQo&e=
> >
> > do you mean I should move these values to phosphor-ipmi-flash_git.bb ?
>
> The three nuvoton named values. yeah> If you put those there, that'd make sense to me.
>
> >
> > thanks
> >
> > B.R.
> > Medad
> > ________________________________
> > ________________________________
> >  The privileged confidential information contained in this email is intended for use only by the addressees as indicated by the original sender of this email. If you are not the addressee indicated in this email or are not responsible for delivery of the email to such a person, please kindly reply to the sender indicating this fact and delete all copies of it from your computer and network server immediately. Your cooperation is highly appreciated. It is advised that any unauthorized use of confidential information of Nuvoton is strictly prohibited; and any information in this email irrelevant to the official business of Nuvoton shall be deemed as neither given nor endorsed by Nuvoton.
> ________________________________
> ________________________________
>  The privileged confidential information contained in this email is intended for use only by the addressees as indicated by the original sender of this email. If you are not the addressee indicated in this email or are not responsible for delivery of the email to such a person, please kindly reply to the sender indicating this fact and delete all copies of it from your computer and network server immediately. Your cooperation is highly appreciated. It is advised that any unauthorized use of confidential information of Nuvoton is strictly prohibited; and any information in this email irrelevant to the official business of Nuvoton shall be deemed as neither given nor endorsed by Nuvoton.

RE: phosphor-ipmi-flash: A problem in BMC FW update over LPC

[CS20 CTCchien]

Hello  Patrick,

I add the code to phosphor-ipmi-flash.
But build failed,
Do you know how could I know what is the error?
Thanks



B.R.
Medad

-----Original Message-----
From: Patrick Venture <venture@google.com>
Sent: Thursday, September 26, 2019 10:33 PM
To: CS20 CTCchien <CTCCHIEN@nuvoton.com>
Cc: OpenBMC Maillist <openbmc@lists.ozlabs.org>
Subject: Re: phosphor-ipmi-flash: A problem in BMC FW update over LPC

On Wed, Sep 25, 2019 at 10:30 PM CS20 CTCchien <CTCCHIEN@nuvoton.com> wrote:
>
> Hello Patrick,
>
> Should I move enable-nuvoton-p2a-mbox and enable-nuvoton-p2a-vga to PACKAGECONFIG in phosphor-ipmi-flash_git.bb?

Please add the code that supports them first to phosphor-ipmi-flash.
Otherwise they're invalid options.

Also, please always include the mailing list unless the communication is strictly confidential and then follow whatever rules apply.

Thanks.

>
> B.R.
> Medad
>
> -----Original Message-----
> From: Patrick Venture <venture@google.com>
> Sent: Wednesday, September 25, 2019 12:29 PM
> To: CS20 CTCchien <CTCCHIEN@nuvoton.com>
> Subject: Re: phosphor-ipmi-flash: A problem in BMC FW update over LPC
>
> On Tue, Sep 24, 2019 at 7:10 PM CS20 CTCchien <CTCCHIEN@nuvoton.com> wrote:
> >
> > Hello Patrick,
> >
> > You mentioned " If you dropped these values in meta-phosphor/recipes-phosphor/ipmi/phosphor-ipmi-flash_git.bb, I would +2 it."
> >
> > In
> >
> > https://urldefense.proofpoint.com/v2/url?u=https-3A__gerrit.openbmc-
> > 2D
> > project.xyz_c_openbmc_meta-2Dphosphor_-2B_25440_3_nuvoton-2Dlayer_re
> > ci
> > pes-2Dphosphor_ipmi_phosphor-2Dipmi-2Dflash-5F-252525.bbappend-235&d
> > =D
> > wIFaQ&c=ue8mO8zgC4VZ4q_aNVKt8G9MC01UFDmisvMR1k-EoDM&r=HqT4ScbSY2YNT4
> > sF
> > BmDErzNgMDeKfQmTiR08x2qtobg&m=pU2gA8MnD8d5MLAxqPVtD1a4cOienC3F0H-3BG
> > 5a Z80&s=IIpKpu1IRFCg1egtL7Ol_rdHMcJKojurE_UB5RyoPQo&e=
> >
> > do you mean I should move these values to phosphor-ipmi-flash_git.bb ?
>
> The three nuvoton named values. yeah> If you put those there, that'd make sense to me.
>
> >
> > thanks
> >
> > B.R.
> > Medad
> > ________________________________
> > ________________________________
> >  The privileged confidential information contained in this email is intended for use only by the addressees as indicated by the original sender of this email. If you are not the addressee indicated in this email or are not responsible for delivery of the email to such a person, please kindly reply to the sender indicating this fact and delete all copies of it from your computer and network server immediately. Your cooperation is highly appreciated. It is advised that any unauthorized use of confidential information of Nuvoton is strictly prohibited; and any information in this email irrelevant to the official business of Nuvoton shall be deemed as neither given nor endorsed by Nuvoton.
> ________________________________
> ________________________________
>  The privileged confidential information contained in this email is intended for use only by the addressees as indicated by the original sender of this email. If you are not the addressee indicated in this email or are not responsible for delivery of the email to such a person, please kindly reply to the sender indicating this fact and delete all copies of it from your computer and network server immediately. Your cooperation is highly appreciated. It is advised that any unauthorized use of confidential information of Nuvoton is strictly prohibited; and any information in this email irrelevant to the official business of Nuvoton shall be deemed as neither given nor endorsed by Nuvoton.
________________________________
________________________________
 The privileged confidential information contained in this email is intended for use only by the addressees as indicated by the original sender of this email. If you are not the addressee indicated in this email or are not responsible for delivery of the email to such a person, please kindly reply to the sender indicating this fact and delete all copies of it from your computer and network server immediately. Your cooperation is highly appreciated. It is advised that any unauthorized use of confidential information of Nuvoton is strictly prohibited; and any information in this email irrelevant to the official business of Nuvoton shall be deemed as neither given nor endorsed by Nuvoton.

Re: phosphor-ipmi-flash: A problem in BMC FW update over LPC

[Patrick Venture]

On Thu, Sep 26, 2019 at 8:24 PM CS20 CTCchien <CTCCHIEN@nuvoton.com> wrote:
>
> Hello  Patrick,
>
> I add the code to phosphor-ipmi-flash.
> But build failed,
> Do you know how could I know what is the error?
> Thanks

The jenkins logs aren't kept around long, so they are not super
helpful in this case.  You should run the build locally to validate
your CL.

You can follow these steps to do so:

https://github.com/openbmc/docs/blob/master/local-ci-build.md

>
>
>
> B.R.
> Medad
>
> -----Original Message-----
> From: Patrick Venture <venture@google.com>
> Sent: Thursday, September 26, 2019 10:33 PM
> To: CS20 CTCchien <CTCCHIEN@nuvoton.com>
> Cc: OpenBMC Maillist <openbmc@lists.ozlabs.org>
> Subject: Re: phosphor-ipmi-flash: A problem in BMC FW update over LPC
>
> On Wed, Sep 25, 2019 at 10:30 PM CS20 CTCchien <CTCCHIEN@nuvoton.com> wrote:
> >
> > Hello Patrick,
> >
> > Should I move enable-nuvoton-p2a-mbox and enable-nuvoton-p2a-vga to PACKAGECONFIG in phosphor-ipmi-flash_git.bb?
>
> Please add the code that supports them first to phosphor-ipmi-flash.
> Otherwise they're invalid options.
>
> Also, please always include the mailing list unless the communication is strictly confidential and then follow whatever rules apply.
>
> Thanks.
>
> >
> > B.R.
> > Medad
> >
> > -----Original Message-----
> > From: Patrick Venture <venture@google.com>
> > Sent: Wednesday, September 25, 2019 12:29 PM
> > To: CS20 CTCchien <CTCCHIEN@nuvoton.com>
> > Subject: Re: phosphor-ipmi-flash: A problem in BMC FW update over LPC
> >
> > On Tue, Sep 24, 2019 at 7:10 PM CS20 CTCchien <CTCCHIEN@nuvoton.com> wrote:
> > >
> > > Hello Patrick,
> > >
> > > You mentioned " If you dropped these values in meta-phosphor/recipes-phosphor/ipmi/phosphor-ipmi-flash_git.bb, I would +2 it."
> > >
> > > In
> > >
> > > https://urldefense.proofpoint.com/v2/url?u=https-3A__gerrit.openbmc-
> > > 2D
> > > project.xyz_c_openbmc_meta-2Dphosphor_-2B_25440_3_nuvoton-2Dlayer_re
> > > ci
> > > pes-2Dphosphor_ipmi_phosphor-2Dipmi-2Dflash-5F-252525.bbappend-235&d
> > > =D
> > > wIFaQ&c=ue8mO8zgC4VZ4q_aNVKt8G9MC01UFDmisvMR1k-EoDM&r=HqT4ScbSY2YNT4
> > > sF
> > > BmDErzNgMDeKfQmTiR08x2qtobg&m=pU2gA8MnD8d5MLAxqPVtD1a4cOienC3F0H-3BG
> > > 5a Z80&s=IIpKpu1IRFCg1egtL7Ol_rdHMcJKojurE_UB5RyoPQo&e=
> > >
> > > do you mean I should move these values to phosphor-ipmi-flash_git.bb ?
> >
> > The three nuvoton named values. yeah> If you put those there, that'd make sense to me.
> >
> > >
> > > thanks
> > >
> > > B.R.
> > > Medad
> > > ________________________________
> > > ________________________________
> > >  The privileged confidential information contained in this email is intended for use only by the addressees as indicated by the original sender of this email. If you are not the addressee indicated in this email or are not responsible for delivery of the email to such a person, please kindly reply to the sender indicating this fact and delete all copies of it from your computer and network server immediately. Your cooperation is highly appreciated. It is advised that any unauthorized use of confidential information of Nuvoton is strictly prohibited; and any information in this email irrelevant to the official business of Nuvoton shall be deemed as neither given nor endorsed by Nuvoton.
> > ________________________________
> > ________________________________
> >  The privileged confidential information contained in this email is intended for use only by the addressees as indicated by the original sender of this email. If you are not the addressee indicated in this email or are not responsible for delivery of the email to such a person, please kindly reply to the sender indicating this fact and delete all copies of it from your computer and network server immediately. Your cooperation is highly appreciated. It is advised that any unauthorized use of confidential information of Nuvoton is strictly prohibited; and any information in this email irrelevant to the official business of Nuvoton shall be deemed as neither given nor endorsed by Nuvoton.
> ________________________________
> ________________________________
>  The privileged confidential information contained in this email is intended for use only by the addressees as indicated by the original sender of this email. If you are not the addressee indicated in this email or are not responsible for delivery of the email to such a person, please kindly reply to the sender indicating this fact and delete all copies of it from your computer and network server immediately. Your cooperation is highly appreciated. It is advised that any unauthorized use of confidential information of Nuvoton is strictly prohibited; and any information in this email irrelevant to the official business of Nuvoton shall be deemed as neither given nor endorsed by Nuvoton.