[PATCH] cpupower Makefile change

[PATCH] cpupower Makefile change

[sriram]

The cpupower tool, when compiled against libcpupower.so fail's to run as
the linker file path's are missing during compilation. So added changes
in the Makefile to run cpupower tool, which helps us run the tool
without doing a 'make install'. 


Signed-off-by: Sriram Raghunathan <sriram@marirs.net.in>
---
 tools/power/cpupower/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/power/cpupower/Makefile
b/tools/power/cpupower/Makefile
index 2e2ba2e..3ed7c04 100644
--- a/tools/power/cpupower/Makefile
+++ b/tools/power/cpupower/Makefile
@@ -209,7 +209,7 @@ $(OUTPUT)%.o: %.c
 
 $(OUTPUT)cpupower: $(UTIL_OBJS) $(OUTPUT)libcpupower.so.$(LIB_MAJ)
 	$(ECHO) "  CC      " $@
-       $(QUIET) $(CC) $(CFLAGS) $(LDFLAGS) $(UTIL_OBJS) -lcpupower -lrt
-lpci -L$(OUTPUT) -o $@
+       $(QUIET) $(CC) $(CFLAGS) $(LDFLAGS) $(UTIL_OBJS) -lcpupower
-Wl,-rpath=./ -lrt -lpci -L$(OUTPUT) -o $@
 	$(QUIET) $(STRIPCMD) $@
 
 $(OUTPUT)po/$(PACKAGE).pot: $(UTIL_SRC)
-- 
1.8.3.2

Re: [PATCH] cpupower Makefile change

[Rafael J. Wysocki]

On Monday, December 22, 2014 10:17:37 PM sriram@marirs.net.in wrote:
> The cpupower tool, when compiled against libcpupower.so fail's to run as
> the linker file path's are missing during compilation. So added changes
> in the Makefile to run cpupower tool, which helps us run the tool
> without doing a 'make install'. 
> 
> 
> Signed-off-by: Sriram Raghunathan <sriram@marirs.net.in>

That requires an ACK from Thomas for me to apply it.

> ---
>  tools/power/cpupower/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/power/cpupower/Makefile
> b/tools/power/cpupower/Makefile
> index 2e2ba2e..3ed7c04 100644
> --- a/tools/power/cpupower/Makefile
> +++ b/tools/power/cpupower/Makefile
> @@ -209,7 +209,7 @@ $(OUTPUT)%.o: %.c
>  
>  $(OUTPUT)cpupower: $(UTIL_OBJS) $(OUTPUT)libcpupower.so.$(LIB_MAJ)
>  	$(ECHO) "  CC      " $@
> -       $(QUIET) $(CC) $(CFLAGS) $(LDFLAGS) $(UTIL_OBJS) -lcpupower -lrt
> -lpci -L$(OUTPUT) -o $@
> +       $(QUIET) $(CC) $(CFLAGS) $(LDFLAGS) $(UTIL_OBJS) -lcpupower
> -Wl,-rpath=./ -lrt -lpci -L$(OUTPUT) -o $@
>  	$(QUIET) $(STRIPCMD) $@
>  
>  $(OUTPUT)po/$(PACKAGE).pot: $(UTIL_SRC)
> 

-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.

Re: [PATCH] cpupower Makefile change

[Thomas Renninger]

On Friday, January 30, 2015 01:13:09 AM Rafael J. Wysocki wrote:
> On Monday, December 22, 2014 10:17:37 PM sriram@marirs.net.in wrote:
> > The cpupower tool, when compiled against libcpupower.so fail's to run as
> > the linker file path's are missing during compilation. So added changes
> > in the Makefile to run cpupower tool, which helps us run the tool
> > without doing a 'make install'.
> > 
> > 
> > Signed-off-by: Sriram Raghunathan <sriram@marirs.net.in>
> 
> That requires an ACK from Thomas for me to apply it.

Makes sense.

Acked-by: Thomas Renninger <trenn@suse.de>

Thanks,

         Thomas

> 
> > ---
> > 
> >  tools/power/cpupower/Makefile | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/tools/power/cpupower/Makefile
> > b/tools/power/cpupower/Makefile
> > index 2e2ba2e..3ed7c04 100644
> > --- a/tools/power/cpupower/Makefile
> > +++ b/tools/power/cpupower/Makefile
> > @@ -209,7 +209,7 @@ $(OUTPUT)%.o: %.c
> > 
> >  $(OUTPUT)cpupower: $(UTIL_OBJS) $(OUTPUT)libcpupower.so.$(LIB_MAJ)
> >  
> >  	$(ECHO) "  CC      " $@
> > 
> > -       $(QUIET) $(CC) $(CFLAGS) $(LDFLAGS) $(UTIL_OBJS) -lcpupower -lrt
> > -lpci -L$(OUTPUT) -o $@
> > +       $(QUIET) $(CC) $(CFLAGS) $(LDFLAGS) $(UTIL_OBJS) -lcpupower
> > -Wl,-rpath=./ -lrt -lpci -L$(OUTPUT) -o $@
> > 
> >  	$(QUIET) $(STRIPCMD) $@
> >  
> >  $(OUTPUT)po/$(PACKAGE).pot: $(UTIL_SRC)

Re: [PATCH] cpupower Makefile change

[Rafael J. Wysocki]

On Friday, January 30, 2015 01:27:23 AM Thomas Renninger wrote:
> On Friday, January 30, 2015 01:13:09 AM Rafael J. Wysocki wrote:
> > On Monday, December 22, 2014 10:17:37 PM sriram@marirs.net.in wrote:
> > > The cpupower tool, when compiled against libcpupower.so fail's to run as
> > > the linker file path's are missing during compilation. So added changes
> > > in the Makefile to run cpupower tool, which helps us run the tool
> > > without doing a 'make install'.
> > > 
> > > 
> > > Signed-off-by: Sriram Raghunathan <sriram@marirs.net.in>
> > 
> > That requires an ACK from Thomas for me to apply it.
> 
> Makes sense.
> 
> Acked-by: Thomas Renninger <trenn@suse.de>

OK, queued up for 3.20, thanks!


-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.

Re: [PATCH] cpupower Makefile change

[sriram]

Thanks. 

On Sat, Jan 31, 2015, at 04:38 AM, Rafael J. Wysocki wrote:
> On Friday, January 30, 2015 01:27:23 AM Thomas Renninger wrote:
> > On Friday, January 30, 2015 01:13:09 AM Rafael J. Wysocki wrote:
> > > On Monday, December 22, 2014 10:17:37 PM sriram@marirs.net.in wrote:
> > > > The cpupower tool, when compiled against libcpupower.so fail's to run as
> > > > the linker file path's are missing during compilation. So added changes
> > > > in the Makefile to run cpupower tool, which helps us run the tool
> > > > without doing a 'make install'.
> > > > 
> > > > 
> > > > Signed-off-by: Sriram Raghunathan <sriram@marirs.net.in>
> > > 
> > > That requires an ACK from Thomas for me to apply it.
> > 
> > Makes sense.
> > 
> > Acked-by: Thomas Renninger <trenn@suse.de>
> 
> OK, queued up for 3.20, thanks!
> 
> 
> -- 
> I speak only for myself.
> Rafael J. Wysocki, Intel Open Source Technology Center.