All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anand Jain <anand.jain@oracle.com>
To: dsterba@suse.cz, David Sterba <dsterba@suse.com>,
	linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 0/2] Sysfs updates
Date: Wed, 7 Aug 2019 16:29:45 +0800	[thread overview]
Message-ID: <1893f2cd-b2d3-875e-977f-ce2c8ec43852@oracle.com> (raw)
In-Reply-To: <20190806164604.GN28208@twin.jikos.cz>

On 7/8/19 12:46 AM, David Sterba wrote:
> On Tue, Aug 06, 2019 at 11:17:09PM +0800, Anand Jain wrote:
>> On 7/31/19 1:10 AM, David Sterba wrote:
>>> Export the potential debugging data in the per-filesystem directories we
>>> already have, so we can drop debugfs. The new directories depend on
>>> CONFIG_BTRFS_DEBUG so they're not affecting normal builds.
>>>
>>> David Sterba (2):
>>>     btrfs: sysfs: add debugging exports
>>>     btrfs: delete debugfs code
>>>
>>>    fs/btrfs/sysfs.c | 68 +++++++++++++++++++++++-------------------------
>>>    fs/btrfs/sysfs.h |  5 ----
>>>    2 files changed, 32 insertions(+), 41 deletions(-)
>>>
>>
>> For 2/2:
>>    Reviewed-by: Anand Jain <anand.jain@oracle.com>
>>
>> For 1/2:
>>    IMO it would be better to delay this until we really have a debug hook
>>    exposed at the sysfs.
> 
> Sorry, I don't understand what you mean.
> 

  I notice that /sysfs/fs/btrfs/<debug>|<fsid/debug> is dummy as of now,
  IMO its better to add this (1/2) patch along with the some actual trace
  which is needed. Potentially either dtrace/bfp probes will be better
  runtime debugging approach.

Thanks, Anand

  reply	other threads:[~2019-08-07  8:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-30 17:10 [PATCH 0/2] Sysfs updates David Sterba
2019-07-30 17:10 ` [PATCH 1/2] btrfs: sysfs: add debugging exports David Sterba
2019-07-30 17:10 ` [PATCH 2/2] btrfs: delete debugfs code David Sterba
2019-08-05 17:44 ` [PATCH 0/2] Sysfs updates David Sterba
2019-08-06 15:17 ` Anand Jain
2019-08-06 16:46   ` David Sterba
2019-08-07  8:29     ` Anand Jain [this message]
2019-08-07 12:42       ` David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1893f2cd-b2d3-875e-977f-ce2c8ec43852@oracle.com \
    --to=anand.jain@oracle.com \
    --cc=dsterba@suse.com \
    --cc=dsterba@suse.cz \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.