All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anand Jain <anand.jain@oracle.com>
To: David Sterba <dsterba@suse.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 0/2] Sysfs updates
Date: Tue, 6 Aug 2019 23:17:09 +0800	[thread overview]
Message-ID: <939d08f0-e851-4f00-733e-c7de15685318@oracle.com> (raw)
In-Reply-To: <cover.1564505777.git.dsterba@suse.com>

On 7/31/19 1:10 AM, David Sterba wrote:
> Export the potential debugging data in the per-filesystem directories we
> already have, so we can drop debugfs. The new directories depend on
> CONFIG_BTRFS_DEBUG so they're not affecting normal builds.
> 
> David Sterba (2):
>    btrfs: sysfs: add debugging exports
>    btrfs: delete debugfs code
> 
>   fs/btrfs/sysfs.c | 68 +++++++++++++++++++++++-------------------------
>   fs/btrfs/sysfs.h |  5 ----
>   2 files changed, 32 insertions(+), 41 deletions(-)
> 

For 2/2:
  Reviewed-by: Anand Jain <anand.jain@oracle.com>

For 1/2:
  IMO it would be better to delay this until we really have a debug hook
  exposed at the sysfs.

Thanks, Anand

  parent reply	other threads:[~2019-08-06 15:17 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-30 17:10 [PATCH 0/2] Sysfs updates David Sterba
2019-07-30 17:10 ` [PATCH 1/2] btrfs: sysfs: add debugging exports David Sterba
2019-07-30 17:10 ` [PATCH 2/2] btrfs: delete debugfs code David Sterba
2019-08-05 17:44 ` [PATCH 0/2] Sysfs updates David Sterba
2019-08-06 15:17 ` Anand Jain [this message]
2019-08-06 16:46   ` David Sterba
2019-08-07  8:29     ` Anand Jain
2019-08-07 12:42       ` David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=939d08f0-e851-4f00-733e-c7de15685318@oracle.com \
    --to=anand.jain@oracle.com \
    --cc=dsterba@suse.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.