* [TCWG CI] Failure after v6.1.8-105-gf5e58b546cbe: drm/panfrost: fix GENERIC_ATOMIC64 dependency
@ 2023-02-06 3:42 ci_notify
2023-02-06 16:43 ` Nathan Chancellor
0 siblings, 1 reply; 2+ messages in thread
From: ci_notify @ 2023-02-06 3:42 UTC (permalink / raw)
To: Arnd Bergmann; +Cc: llvm, arnd
[-- Attachment #1: Type: text/plain, Size: 5447 bytes --]
Failure after v6.1.8-105-gf5e58b546cbe: drm/panfrost: fix GENERIC_ATOMIC64 dependency:
Results changed to
-10
# build_abe binutils:
-9
# build_kernel_llvm:
-5
# build_abe qemu:
-2
# linux_n_obj:
23010
# First few build errors in logs:
# 00:31:22 ./include/linux/fortify-string.h:543:4: error: call to '__read_overflow' declared with 'error' attribute: detected read beyond size of object (1st parameter)
# 00:31:23 make[4]: *** [scripts/Makefile.build:250: drivers/infiniband/core/cma.o] Error 1
# 00:31:55 make[3]: *** [scripts/Makefile.build:500: drivers/infiniband/core] Error 2
# 00:31:55 make[2]: *** [scripts/Makefile.build:500: drivers/infiniband] Error 2
# 00:32:29 make[1]: *** [scripts/Makefile.build:500: drivers] Error 2
# 00:32:29 make: *** [Makefile:2005: .] Error 2
from
-10
# build_abe binutils:
-9
# build_kernel_llvm:
-5
# build_abe qemu:
-2
# linux_n_obj:
23021
THIS IS THE END OF INTERESTING STUFF. BELOW ARE LINKS TO BUILDS, REPRODUCTION INSTRUCTIONS, AND THE RAW COMMIT.
For latest status see comments in https://linaro.atlassian.net/browse/LLVM-647 .
Status of v6.1.8-105-gf5e58b546cbe commit for tcwg_kernel:
commit f5e58b546cbe76f049df97570cf0580aaaf3f900
Author: Arnd Bergmann <arnd@arndb.de>
Date: Tue Jan 17 17:44:43 2023 +0100
drm/panfrost: fix GENERIC_ATOMIC64 dependency
[ Upstream commit 6437a549ae178a3f5a5c03e983f291ebcdc2bbc7 ]
On ARMv5 and earlier, a randconfig build can still run into
WARNING: unmet direct dependencies detected for IOMMU_IO_PGTABLE_LPAE
Depends on [n]: IOMMU_SUPPORT [=y] && (ARM [=y] || ARM64 || COMPILE_TEST [=y]) && !GENERIC_ATOMIC64 [=y]
Selected by [y]:
- DRM_PANFROST [=y] && HAS_IOMEM [=y] && DRM [=y] && (ARM [=y] || ARM64 || COMPILE_TEST [=y] && !GENERIC_ATOMIC64 [=y]) && MMU [=y]
Rework the dependencies to always require a working cmpxchg64.
Fixes: db594ba3fcf9 ("drm/panfrost: depend on !GENERIC_ATOMIC64 when using COMPILE_TEST")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Steven Price <steven.price@arm.com>
Signed-off-by: Steven Price <steven.price@arm.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230117164456.1591901-1-arnd@kernel.org
Signed-off-by: Sasha Levin <sashal@kernel.org>
* llvm-master-arm-stable-allmodconfig
** Failure after v6.1.8-105-gf5e58b546cbe: drm/panfrost: fix GENERIC_ATOMIC64 dependency:
** https://ci.linaro.org/job/tcwg_kernel-llvm-build-llvm-master-arm-stable-allmodconfig/548/
Bad build: https://ci.linaro.org/job/tcwg_kernel-llvm-build-llvm-master-arm-stable-allmodconfig/548/artifact/artifacts
Good build: https://ci.linaro.org/job/tcwg_kernel-llvm-build-llvm-master-arm-stable-allmodconfig/547/artifact/artifacts
Reproduce current build:
<cut>
mkdir -p investigate-linux-f5e58b546cbe76f049df97570cf0580aaaf3f900
cd investigate-linux-f5e58b546cbe76f049df97570cf0580aaaf3f900
# Fetch scripts
git clone https://git.linaro.org/toolchain/jenkins-scripts
# Fetch manifests for bad and good builds
mkdir -p bad/artifacts good/artifacts
curl -o bad/artifacts/manifest.sh https://ci.linaro.org/job/tcwg_kernel-llvm-build-llvm-master-arm-stable-allmodconfig/548/artifact/artifacts/manifest.sh --fail
curl -o good/artifacts/manifest.sh https://ci.linaro.org/job/tcwg_kernel-llvm-build-llvm-master-arm-stable-allmodconfig/547/artifact/artifacts/manifest.sh --fail
# Reproduce bad build
(cd bad; ../jenkins-scripts/tcwg_kernel-build.sh ^^ true %%rr[top_artifacts] artifacts)
# Reproduce good build
(cd good; ../jenkins-scripts/tcwg_kernel-build.sh ^^ true %%rr[top_artifacts] artifacts)
</cut>
Full commit (up to 1000 lines):
<cut>
commit f5e58b546cbe76f049df97570cf0580aaaf3f900
Author: Arnd Bergmann <arnd@arndb.de>
Date: Tue Jan 17 17:44:43 2023 +0100
drm/panfrost: fix GENERIC_ATOMIC64 dependency
[ Upstream commit 6437a549ae178a3f5a5c03e983f291ebcdc2bbc7 ]
On ARMv5 and earlier, a randconfig build can still run into
WARNING: unmet direct dependencies detected for IOMMU_IO_PGTABLE_LPAE
Depends on [n]: IOMMU_SUPPORT [=y] && (ARM [=y] || ARM64 || COMPILE_TEST [=y]) && !GENERIC_ATOMIC64 [=y]
Selected by [y]:
- DRM_PANFROST [=y] && HAS_IOMEM [=y] && DRM [=y] && (ARM [=y] || ARM64 || COMPILE_TEST [=y] && !GENERIC_ATOMIC64 [=y]) && MMU [=y]
Rework the dependencies to always require a working cmpxchg64.
Fixes: db594ba3fcf9 ("drm/panfrost: depend on !GENERIC_ATOMIC64 when using COMPILE_TEST")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Steven Price <steven.price@arm.com>
Signed-off-by: Steven Price <steven.price@arm.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230117164456.1591901-1-arnd@kernel.org
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
drivers/gpu/drm/panfrost/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/panfrost/Kconfig b/drivers/gpu/drm/panfrost/Kconfig
index 079600328be1..e6403a9d66ad 100644
--- a/drivers/gpu/drm/panfrost/Kconfig
+++ b/drivers/gpu/drm/panfrost/Kconfig
@@ -3,7 +3,8 @@
config DRM_PANFROST
tristate "Panfrost (DRM support for ARM Mali Midgard/Bifrost GPUs)"
depends on DRM
- depends on ARM || ARM64 || (COMPILE_TEST && !GENERIC_ATOMIC64)
+ depends on ARM || ARM64 || COMPILE_TEST
+ depends on !GENERIC_ATOMIC64 # for IOMMU_IO_PGTABLE_LPAE
depends on MMU
select DRM_SCHED
select IOMMU_SUPPORT
</cut>
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [TCWG CI] Failure after v6.1.8-105-gf5e58b546cbe: drm/panfrost: fix GENERIC_ATOMIC64 dependency
2023-02-06 3:42 [TCWG CI] Failure after v6.1.8-105-gf5e58b546cbe: drm/panfrost: fix GENERIC_ATOMIC64 dependency ci_notify
@ 2023-02-06 16:43 ` Nathan Chancellor
0 siblings, 0 replies; 2+ messages in thread
From: Nathan Chancellor @ 2023-02-06 16:43 UTC (permalink / raw)
To: ci_notify; +Cc: Arnd Bergmann, llvm, arnd
Hi,
On Mon, Feb 06, 2023 at 03:42:06AM +0000, ci_notify@linaro.org wrote:
> Failure after v6.1.8-105-gf5e58b546cbe: drm/panfrost: fix GENERIC_ATOMIC64 dependency:
>
> Results changed to
> -10
> # build_abe binutils:
> -9
> # build_kernel_llvm:
> -5
> # build_abe qemu:
> -2
> # linux_n_obj:
> 23010
> # First few build errors in logs:
> # 00:31:22 ./include/linux/fortify-string.h:543:4: error: call to '__read_overflow' declared with 'error' attribute: detected read beyond size of object (1st parameter)
> # 00:31:23 make[4]: *** [scripts/Makefile.build:250: drivers/infiniband/core/cma.o] Error 1
> # 00:31:55 make[3]: *** [scripts/Makefile.build:500: drivers/infiniband/core] Error 2
> # 00:31:55 make[2]: *** [scripts/Makefile.build:500: drivers/infiniband] Error 2
> # 00:32:29 make[1]: *** [scripts/Makefile.build:500: drivers] Error 2
> # 00:32:29 make: *** [Makefile:2005: .] Error 2
>
> from
> -10
> # build_abe binutils:
> -9
> # build_kernel_llvm:
> -5
> # build_abe qemu:
> -2
> # linux_n_obj:
> 23021
>
> THIS IS THE END OF INTERESTING STUFF. BELOW ARE LINKS TO BUILDS, REPRODUCTION INSTRUCTIONS, AND THE RAW COMMIT.
>
> For latest status see comments in https://linaro.atlassian.net/browse/LLVM-647 .
> Status of v6.1.8-105-gf5e58b546cbe commit for tcwg_kernel:
> commit f5e58b546cbe76f049df97570cf0580aaaf3f900
> Author: Arnd Bergmann <arnd@arndb.de>
> Date: Tue Jan 17 17:44:43 2023 +0100
>
> drm/panfrost: fix GENERIC_ATOMIC64 dependency
>
> [ Upstream commit 6437a549ae178a3f5a5c03e983f291ebcdc2bbc7 ]
>
> On ARMv5 and earlier, a randconfig build can still run into
>
> WARNING: unmet direct dependencies detected for IOMMU_IO_PGTABLE_LPAE
> Depends on [n]: IOMMU_SUPPORT [=y] && (ARM [=y] || ARM64 || COMPILE_TEST [=y]) && !GENERIC_ATOMIC64 [=y]
> Selected by [y]:
> - DRM_PANFROST [=y] && HAS_IOMEM [=y] && DRM [=y] && (ARM [=y] || ARM64 || COMPILE_TEST [=y] && !GENERIC_ATOMIC64 [=y]) && MMU [=y]
>
> Rework the dependencies to always require a working cmpxchg64.
>
> Fixes: db594ba3fcf9 ("drm/panfrost: depend on !GENERIC_ATOMIC64 when using COMPILE_TEST")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Reviewed-by: Steven Price <steven.price@arm.com>
> Signed-off-by: Steven Price <steven.price@arm.com>
> Link: https://patchwork.freedesktop.org/patch/msgid/20230117164456.1591901-1-arnd@kernel.org
> Signed-off-by: Sasha Levin <sashal@kernel.org>
Not an issue with this patch, it is a compiler issue:
https://github.com/ClangBuiltLinux/linux/issues/1687
A recent change in LLVM made this failure more likely but it has been
around for a while in certain configurations. I am guessing the
bisection landed on this change because it fixes one problem while
exposing another.
Cheers,
Nathan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-02-06 16:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-06 3:42 [TCWG CI] Failure after v6.1.8-105-gf5e58b546cbe: drm/panfrost: fix GENERIC_ATOMIC64 dependency ci_notify
2023-02-06 16:43 ` Nathan Chancellor
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.