From: Sagi Grimberg <sagi@grimberg.me>
To: Ming Lei <ming.lei@redhat.com>
Cc: linux-nvme@lists.infradead.org, linux-block@vger.kernel.org,
Christoph Hellwig <hch@lst.de>, Keith Busch <kbusch@kernel.org>,
Yi Zhang <yi.zhang@redhat.com>, Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH] block: re-introduce blk_mq_complete_request_sync
Date: Fri, 9 Oct 2020 01:11:46 -0700 [thread overview]
Message-ID: <189a7d80-ff0f-e6b0-f8f0-b50dfdd028f8@grimberg.me> (raw)
In-Reply-To: <20201009043938.GC27356@T590>
>> diff --git a/drivers/nvme/host/tcp.c b/drivers/nvme/host/tcp.c
>> index 8f4f29f18b8c..629b025685d1 100644
>> --- a/drivers/nvme/host/tcp.c
>> +++ b/drivers/nvme/host/tcp.c
>> @@ -2177,7 +2177,7 @@ static void nvme_tcp_complete_timed_out(struct request *rq)
>> nvme_tcp_stop_queue(ctrl, nvme_tcp_queue_id(req->queue));
>> if (!blk_mq_request_completed(rq)) {
>> nvme_req(rq)->status = NVME_SC_HOST_ABORTED_CMD;
>> - blk_mq_complete_request(rq);
>> + blk_mq_complete_request_sync(rq);
>
> Or complete the request in the following way? Then one block layer API
> can be saved:
>
> blk_mq_complete_request_remote(rq);
> nvme_complete_rq(rq);
Not sure I follow, how does this work?
Anyways, I think that blk_mq_complete_request_sync is a clean
and useful interface. We can do it in nvme but I don't think
it would be better.
WARNING: multiple messages have this Message-ID (diff)
From: Sagi Grimberg <sagi@grimberg.me>
To: Ming Lei <ming.lei@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>, Yi Zhang <yi.zhang@redhat.com>,
linux-nvme@lists.infradead.org, linux-block@vger.kernel.org,
Keith Busch <kbusch@kernel.org>, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] block: re-introduce blk_mq_complete_request_sync
Date: Fri, 9 Oct 2020 01:11:46 -0700 [thread overview]
Message-ID: <189a7d80-ff0f-e6b0-f8f0-b50dfdd028f8@grimberg.me> (raw)
In-Reply-To: <20201009043938.GC27356@T590>
>> diff --git a/drivers/nvme/host/tcp.c b/drivers/nvme/host/tcp.c
>> index 8f4f29f18b8c..629b025685d1 100644
>> --- a/drivers/nvme/host/tcp.c
>> +++ b/drivers/nvme/host/tcp.c
>> @@ -2177,7 +2177,7 @@ static void nvme_tcp_complete_timed_out(struct request *rq)
>> nvme_tcp_stop_queue(ctrl, nvme_tcp_queue_id(req->queue));
>> if (!blk_mq_request_completed(rq)) {
>> nvme_req(rq)->status = NVME_SC_HOST_ABORTED_CMD;
>> - blk_mq_complete_request(rq);
>> + blk_mq_complete_request_sync(rq);
>
> Or complete the request in the following way? Then one block layer API
> can be saved:
>
> blk_mq_complete_request_remote(rq);
> nvme_complete_rq(rq);
Not sure I follow, how does this work?
Anyways, I think that blk_mq_complete_request_sync is a clean
and useful interface. We can do it in nvme but I don't think
it would be better.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2020-10-09 8:11 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-08 21:37 [PATCH] block: re-introduce blk_mq_complete_request_sync Sagi Grimberg
2020-10-08 21:37 ` Sagi Grimberg
2020-10-09 4:39 ` Ming Lei
2020-10-09 4:39 ` Ming Lei
2020-10-09 5:03 ` Yi Zhang
2020-10-09 5:03 ` Yi Zhang
2020-10-09 8:09 ` Sagi Grimberg
2020-10-09 8:09 ` Sagi Grimberg
2020-10-09 13:55 ` Yi Zhang
2020-10-09 13:55 ` Yi Zhang
2020-10-09 18:29 ` Sagi Grimberg
2020-10-09 18:29 ` Sagi Grimberg
2020-10-10 6:08 ` Yi Zhang
2020-10-10 6:08 ` Yi Zhang
2020-10-12 3:59 ` Chao Leng
2020-10-12 3:59 ` Chao Leng
2020-10-12 8:13 ` Ming Lei
2020-10-12 8:13 ` Ming Lei
2020-10-12 9:06 ` Chao Leng
2020-10-12 9:06 ` Chao Leng
2020-10-13 22:36 ` Sagi Grimberg
2020-10-13 22:36 ` Sagi Grimberg
2020-10-14 1:08 ` Ming Lei
2020-10-14 1:08 ` Ming Lei
2020-10-14 1:37 ` Chao Leng
2020-10-14 1:37 ` Chao Leng
2020-10-14 2:02 ` Ming Lei
2020-10-14 2:02 ` Ming Lei
2020-10-14 2:32 ` Chao Leng
2020-10-14 2:32 ` Chao Leng
2020-10-14 2:41 ` Chao Leng
2020-10-14 2:41 ` Chao Leng
2020-10-14 3:34 ` Ming Lei
2020-10-14 3:34 ` Ming Lei
2020-10-14 9:39 ` Chao Leng
2020-10-14 9:39 ` Chao Leng
2020-10-14 9:56 ` Ming Lei
2020-10-14 9:56 ` Ming Lei
2020-10-15 6:05 ` Chao Leng
2020-10-15 6:05 ` Chao Leng
2020-10-15 7:50 ` Ming Lei
2020-10-15 7:50 ` Ming Lei
2020-10-15 10:05 ` Chao Leng
2020-10-15 10:05 ` Chao Leng
2020-10-14 1:32 ` Chao Leng
2020-10-14 1:32 ` Chao Leng
2020-10-13 22:31 ` Sagi Grimberg
2020-10-13 22:31 ` Sagi Grimberg
2020-10-14 1:25 ` Chao Leng
2020-10-14 1:25 ` Chao Leng
2020-10-09 8:11 ` Sagi Grimberg [this message]
2020-10-09 8:11 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=189a7d80-ff0f-e6b0-f8f0-b50dfdd028f8@grimberg.me \
--to=sagi@grimberg.me \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=ming.lei@redhat.com \
--cc=yi.zhang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.