From: "Neftin, Sasha" <sasha.neftin@intel.com> To: Mark Pearson <markpearson@lenovo.com>, Mario Limonciello <mario.limonciello@dell.com>, Jeff Kirsher <jeffrey.t.kirsher@intel.com>, Tony Nguyen <anthony.l.nguyen@intel.com>, "intel-wired-lan@lists.osuosl.org" <intel-wired-lan@lists.osuosl.org>, David Miller <davem@davemloft.net>, Aaron Ma <aaron.ma@canonical.com> Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Netdev <netdev@vger.kernel.org>, Alexander Duyck <alexander.duyck@gmail.com>, Jakub Kicinski <kuba@kernel.org>, Aaron Brown <aaron.f.brown@intel.com>, Stefan Assmann <sassmann@redhat.com>, "darcari@redhat.com" <darcari@redhat.com>, "Yijun.Shen@dell.com" <Yijun.Shen@dell.com>, "Perry.Yuan@dell.com" <Perry.Yuan@dell.com>, "anthony.wong@canonical.com" <anthony.wong@canonical.com>, "Ruinskiy, Dima" <dima.ruinskiy@intel.com>, "Efrati, Nir" <nir.efrati@intel.com>, "Lifshits, Vitaly" <vitaly.lifshits@intel.com>, "Neftin, Sasha" <sasha.neftin@intel.com> Subject: Re: Fw: [External] Re: [PATCH v4 0/4] Improve s0ix flows for systems i219LM Date: Tue, 15 Dec 2020 15:23:01 +0200 [thread overview] Message-ID: <18c1c152-9298-a4c5-c4ed-92c9fd91ea8a@intel.com> (raw) In-Reply-To: <ae436f90-45b8-ba70-be57-d17641c4f79d@lenovo.com> On 12/14/2020 20:40, Mark Pearson wrote: > Thanks Hans > > On 14/12/2020 13:31, Mark Pearson wrote: >> >> >> ------------------------------------------------------------------------ >> *From:* Hans de Goede <hdegoede@redhat.com> >> *Sent:* December 14, 2020 13:24 >> *To:* Mario Limonciello <mario.limonciello@dell.com>; Jeff Kirsher >> <jeffrey.t.kirsher@intel.com>; Tony Nguyen <anthony.l.nguyen@intel.com>; >> intel-wired-lan@lists.osuosl.org <intel-wired-lan@lists.osuosl.org>; >> David Miller <davem@davemloft.net>; Aaron Ma <aaron.ma@canonical.com>; >> Mark Pearson <mpearson@lenovo.com> >> *Cc:* linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org>; >> Netdev <netdev@vger.kernel.org>; Alexander Duyck >> <alexander.duyck@gmail.com>; Jakub Kicinski <kuba@kernel.org>; Sasha >> Netfin <sasha.neftin@intel.com>; Aaron Brown <aaron.f.brown@intel.com>; >> Stefan Assmann <sassmann@redhat.com>; darcari@redhat.com >> <darcari@redhat.com>; Yijun.Shen@dell.com <Yijun.Shen@dell.com>; >> Perry.Yuan@dell.com <Perry.Yuan@dell.com>; anthony.wong@canonical.com >> <anthony.wong@canonical.com> >> *Subject:* [External] Re: [PATCH v4 0/4] Improve s0ix flows for systems >> i219LM >> >> Hi All, >> > <snip> >> >> ### >> >> I've added Mark Pearson from Lenovo to the Cc so that Lenovo >> can investigate this issue further. >> >> Mark, this thread is about an issue with enabling S0ix support for >> e1000e (i219lm) controllers. This was enabled in the kernel a >> while ago, but then got disabled again on vPro / AMT enabled >> systems because on some systems (Lenovo X1C7 and now also X1C8) >> this lead to suspend/resume issues. >> >> When AMT is active then there is a handover handshake for the >> OS to get access to the ethernet controller from the ME. The >> Intel folks have checked and the Windows driver is using a timeout >> of 1 second for this handshake, yet on Lenovo systems this is >> taking 2 seconds. This likely has something to do with the >> ME firmware on these Lenovo models, can you get the firmware >> team at Lenovo to investigate this further ? > Absolutely - I'll ask them to look into this again. > we need to explain why on Windows systems required 1s and on Linux systems up to 2.5s - otherwise it is not reliable approach - you will encounter others buggy system. (ME not POR on the Linux systems - is only one possible answer) > We did try to make progress with this previously - but it got a bit > stuck and hence the need for these patches....but I believe things may > have changed a bit so it's worth trying again > > Mark > Sasha
WARNING: multiple messages have this Message-ID (diff)
From: Neftin, Sasha <sasha.neftin@intel.com> To: intel-wired-lan@osuosl.org Subject: [Intel-wired-lan] Fw: [External] Re: [PATCH v4 0/4] Improve s0ix flows for systems i219LM Date: Tue, 15 Dec 2020 15:23:01 +0200 [thread overview] Message-ID: <18c1c152-9298-a4c5-c4ed-92c9fd91ea8a@intel.com> (raw) In-Reply-To: <ae436f90-45b8-ba70-be57-d17641c4f79d@lenovo.com> On 12/14/2020 20:40, Mark Pearson wrote: > Thanks Hans > > On 14/12/2020 13:31, Mark Pearson wrote: >> >> >> ------------------------------------------------------------------------ >> *From:* Hans de Goede <hdegoede@redhat.com> >> *Sent:* December 14, 2020 13:24 >> *To:* Mario Limonciello <mario.limonciello@dell.com>; Jeff Kirsher >> <jeffrey.t.kirsher@intel.com>; Tony Nguyen <anthony.l.nguyen@intel.com>; >> intel-wired-lan at lists.osuosl.org <intel-wired-lan@lists.osuosl.org>; >> David Miller <davem@davemloft.net>; Aaron Ma <aaron.ma@canonical.com>; >> Mark Pearson <mpearson@lenovo.com> >> *Cc:* linux-kernel at vger.kernel.org <linux-kernel@vger.kernel.org>; >> Netdev <netdev@vger.kernel.org>; Alexander Duyck >> <alexander.duyck@gmail.com>; Jakub Kicinski <kuba@kernel.org>; Sasha >> Netfin <sasha.neftin@intel.com>; Aaron Brown <aaron.f.brown@intel.com>; >> Stefan Assmann <sassmann@redhat.com>; darcari at redhat.com >> <darcari@redhat.com>; Yijun.Shen at dell.com <Yijun.Shen@dell.com>; >> Perry.Yuan at dell.com <Perry.Yuan@dell.com>; anthony.wong at canonical.com >> <anthony.wong@canonical.com> >> *Subject:* [External] Re: [PATCH v4 0/4] Improve s0ix flows for systems >> i219LM >> >> Hi All, >> > <snip> >> >> ### >> >> I've added Mark Pearson from Lenovo to the Cc so that Lenovo >> can investigate this issue further. >> >> Mark, this thread is about an issue with enabling S0ix support for >> e1000e (i219lm) controllers. This was enabled in the kernel a >> while ago, but then got disabled again on vPro / AMT enabled >> systems because on some systems (Lenovo X1C7 and now also X1C8) >> this lead to suspend/resume issues. >> >> When AMT is active then there is a handover handshake for the >> OS to get access to the ethernet controller from the ME. The >> Intel folks have checked and the Windows driver is using a timeout >> of 1 second for this handshake, yet on Lenovo systems this is >> taking 2 seconds. This likely has something to do with the >> ME firmware on these Lenovo models, can you get the firmware >> team at Lenovo to investigate this further ? > Absolutely - I'll ask them to look into this again. > we need to explain why on Windows systems required 1s and on Linux systems up to 2.5s - otherwise it is not reliable approach - you will encounter others buggy system. (ME not POR on the Linux systems - is only one possible answer) > We did try to make progress with this previously - but it got a bit > stuck and hence the need for these patches....but I believe things may > have changed a bit so it's worth trying again > > Mark > Sasha
next prev parent reply other threads:[~2020-12-15 13:24 UTC|newest] Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-12-14 15:34 [PATCH v4 0/4] Improve s0ix flows for systems i219LM Mario Limonciello 2020-12-14 15:34 ` [Intel-wired-lan] " Mario Limonciello 2020-12-14 15:34 ` [PATCH 1/4] e1000e: Only run S0ix flows if shutdown succeeded Mario Limonciello 2020-12-14 15:34 ` [Intel-wired-lan] " Mario Limonciello 2020-12-14 15:34 ` [PATCH 2/4] e1000e: bump up timeout to wait when ME un-configure ULP mode Mario Limonciello 2020-12-14 15:34 ` [Intel-wired-lan] " Mario Limonciello 2020-12-14 15:34 ` [PATCH 3/4] Revert "e1000e: disable s0ix entry and exit flows for ME systems" Mario Limonciello 2020-12-14 15:34 ` [Intel-wired-lan] " Mario Limonciello 2020-12-14 15:34 ` [PATCH 4/4] e1000e: Export S0ix flags to ethtool Mario Limonciello 2020-12-14 15:34 ` [Intel-wired-lan] " Mario Limonciello 2020-12-14 18:30 ` Hans de Goede 2020-12-14 18:30 ` [Intel-wired-lan] " Hans de Goede 2020-12-14 16:39 ` [PATCH v4 0/4] Improve s0ix flows for systems i219LM Alexander Duyck 2020-12-14 16:39 ` [Intel-wired-lan] " Alexander Duyck 2020-12-14 18:24 ` Hans de Goede 2020-12-14 18:24 ` [Intel-wired-lan] " Hans de Goede [not found] ` <PS2PR03MB37505A15D3C9B7505D679D7BBDC70@PS2PR03MB3750.apcprd03.prod.outlook.com> 2020-12-14 18:40 ` Fw: [External] " Mark Pearson 2020-12-14 18:40 ` [Intel-wired-lan] " Mark Pearson 2020-12-15 13:23 ` Neftin, Sasha [this message] 2020-12-15 13:23 ` Neftin, Sasha 2020-12-15 17:20 ` Limonciello, Mario 2020-12-15 17:20 ` [Intel-wired-lan] " Limonciello, Mario 2020-12-15 18:36 ` Neftin, Sasha 2020-12-15 18:36 ` [Intel-wired-lan] " Neftin, Sasha 2020-12-14 19:36 ` Limonciello, Mario 2020-12-14 19:36 ` [Intel-wired-lan] " Limonciello, Mario 2020-12-15 12:26 ` Hans de Goede 2020-12-15 12:26 ` [Intel-wired-lan] " Hans de Goede
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=18c1c152-9298-a4c5-c4ed-92c9fd91ea8a@intel.com \ --to=sasha.neftin@intel.com \ --cc=Perry.Yuan@dell.com \ --cc=Yijun.Shen@dell.com \ --cc=aaron.f.brown@intel.com \ --cc=aaron.ma@canonical.com \ --cc=alexander.duyck@gmail.com \ --cc=anthony.l.nguyen@intel.com \ --cc=anthony.wong@canonical.com \ --cc=darcari@redhat.com \ --cc=davem@davemloft.net \ --cc=dima.ruinskiy@intel.com \ --cc=intel-wired-lan@lists.osuosl.org \ --cc=jeffrey.t.kirsher@intel.com \ --cc=kuba@kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mario.limonciello@dell.com \ --cc=markpearson@lenovo.com \ --cc=netdev@vger.kernel.org \ --cc=nir.efrati@intel.com \ --cc=sassmann@redhat.com \ --cc=vitaly.lifshits@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.