* [PATCH] scripts/get_maintainers.pl: Don't blindly drop "THE REST" maintainers
@ 2017-07-17 18:18 Julien Grall
2017-07-18 9:11 ` Andrew Cooper
2017-07-26 14:27 ` Ian Jackson
0 siblings, 2 replies; 5+ messages in thread
From: Julien Grall @ 2017-07-17 18:18 UTC (permalink / raw)
To: xen-devel
Cc: sstabellini, wei.liu2, George.Dunlap, andrew.cooper3,
ian.jackson, tim, Julien Grall, jbeulich
"THE REST" maintainers should always be CCed for any modification that
don't fall under the responsability of a specific component maintainer.
However, the script get_maintainers.pl will remove "THE REST"
maintainers as soon as one maintainer of a specific component will be
present.
Fix the script once for all.
Signed-off-by: Julien Grall <julien.grall@arm.com>
---
I am getting annoyed at requesting contributors to CC "THE REST" because
the script didn't properly return the list of maintainers. This should
now be fixed.
---
scripts/get_maintainer.pl | 18 +++++++++++++++++-
1 file changed, 17 insertions(+), 1 deletion(-)
diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
index 2804a5b5df..d3076adfd8 100755
--- a/scripts/get_maintainer.pl
+++ b/scripts/get_maintainer.pl
@@ -571,11 +571,15 @@ sub get_maintainers {
# Find responsible parties
my %exact_pattern_match_hash = ();
+ # By default "THE REST" will be suppressed.
+ my $do_not_suppress_the_rest = 0;
foreach my $file (@files) {
my %hash;
my $tvi = find_first_section();
+ # Unless stated otherwise, a file is maintained by "THE REST"
+ my $file_maintained_by_the_rest = 1;
while ($tvi < @typevalue) {
my $start = find_starting_index($tvi);
my $end = find_ending_index($tvi);
@@ -633,6 +637,14 @@ sub get_maintainers {
foreach my $line (sort {$hash{$b} <=> $hash{$a}} keys %hash) {
add_categories($line);
+ my $role = get_maintainer_role($line);
+
+ # Check the role, if it is not "THE REST" then the file is not
+ # only maintained by "THE REST".
+ if ( get_maintainer_role($line) ne "supporter:THE REST" ) {
+ $file_maintained_by_the_rest = 0;
+ }
+
if ($sections) {
my $i;
my $start = find_starting_index($line);
@@ -657,6 +669,9 @@ sub get_maintainers {
print("\n");
}
}
+ # If the file is only maintained by "THE REST", then CC all of them on
+ # the patch.
+ $do_not_suppress_the_rest = 1 if $file_maintained_by_the_rest;
}
if ($keywords) {
@@ -666,7 +681,8 @@ sub get_maintainers {
}
}
- if ($email_drop_the_rest_supporter_if_supporter_found && $#email_to > 0) {
+ if ($email_drop_the_rest_supporter_if_supporter_found &&
+ !$do_not_suppress_the_rest && $#email_to > 0) {
my @email_new;
my $do_replace = 0;
foreach my $email (@email_to) {
--
2.11.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] scripts/get_maintainers.pl: Don't blindly drop "THE REST" maintainers
2017-07-17 18:18 [PATCH] scripts/get_maintainers.pl: Don't blindly drop "THE REST" maintainers Julien Grall
@ 2017-07-18 9:11 ` Andrew Cooper
2017-07-26 12:08 ` Julien Grall
2017-07-26 14:27 ` Ian Jackson
1 sibling, 1 reply; 5+ messages in thread
From: Andrew Cooper @ 2017-07-18 9:11 UTC (permalink / raw)
To: Julien Grall, xen-devel
Cc: sstabellini, wei.liu2, George.Dunlap, tim, ian.jackson, jbeulich
On 17/07/17 19:18, Julien Grall wrote:
> "THE REST" maintainers should always be CCed for any modification that
> don't fall under the responsability of a specific component maintainer.
>
> However, the script get_maintainers.pl will remove "THE REST"
> maintainers as soon as one maintainer of a specific component will be
> present.
>
> Fix the script once for all.
>
> Signed-off-by: Julien Grall <julien.grall@arm.com>
Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
This is definitely an improvement in behaviour.
You should probably get a review from someone who speaks better perl
than I do.
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] scripts/get_maintainers.pl: Don't blindly drop "THE REST" maintainers
2017-07-18 9:11 ` Andrew Cooper
@ 2017-07-26 12:08 ` Julien Grall
0 siblings, 0 replies; 5+ messages in thread
From: Julien Grall @ 2017-07-26 12:08 UTC (permalink / raw)
To: Andrew Cooper, xen-devel
Cc: sstabellini, wei.liu2, George.Dunlap, tim, ian.jackson, jbeulich
On 18/07/17 10:11, Andrew Cooper wrote:
> On 17/07/17 19:18, Julien Grall wrote:
>> "THE REST" maintainers should always be CCed for any modification that
>> don't fall under the responsability of a specific component maintainer.
>>
>> However, the script get_maintainers.pl will remove "THE REST"
>> maintainers as soon as one maintainer of a specific component will be
>> present.
>>
>> Fix the script once for all.
>>
>> Signed-off-by: Julien Grall <julien.grall@arm.com>
>
> Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
>
> This is definitely an improvement in behaviour.
>
> You should probably get a review from someone who speaks better perl
> than I do.
Anyone up to review perl? :)
Cheers,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] scripts/get_maintainers.pl: Don't blindly drop "THE REST" maintainers
2017-07-17 18:18 [PATCH] scripts/get_maintainers.pl: Don't blindly drop "THE REST" maintainers Julien Grall
2017-07-18 9:11 ` Andrew Cooper
@ 2017-07-26 14:27 ` Ian Jackson
2017-07-26 17:13 ` Julien Grall
1 sibling, 1 reply; 5+ messages in thread
From: Ian Jackson @ 2017-07-26 14:27 UTC (permalink / raw)
To: Julien Grall
Cc: sstabellini, wei.liu2, George.Dunlap, andrew.cooper3, tim,
xen-devel, jbeulich
Julien Grall writes ("[Xen-devel] [PATCH] scripts/get_maintainers.pl: Don't blindly drop "THE REST" maintainers"):
> "THE REST" maintainers should always be CCed for any modification that
> don't fall under the responsability of a specific component maintainer.
>
> However, the script get_maintainers.pl will remove "THE REST"
> maintainers as soon as one maintainer of a specific component will be
> present.
>
> Fix the script once for all.
Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
Although:
> + # By default "THE REST" will be suppressed.
> + my $do_not_suppress_the_rest = 0;
I normally find flag variables whose names contain negations to be
quite confusing.
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] scripts/get_maintainers.pl: Don't blindly drop "THE REST" maintainers
2017-07-26 14:27 ` Ian Jackson
@ 2017-07-26 17:13 ` Julien Grall
0 siblings, 0 replies; 5+ messages in thread
From: Julien Grall @ 2017-07-26 17:13 UTC (permalink / raw)
To: Ian Jackson
Cc: sstabellini, wei.liu2, George.Dunlap, andrew.cooper3, tim,
xen-devel, jbeulich
Hi Ian,
On 26/07/17 15:27, Ian Jackson wrote:
> Julien Grall writes ("[Xen-devel] [PATCH] scripts/get_maintainers.pl: Don't blindly drop "THE REST" maintainers"):
>> "THE REST" maintainers should always be CCed for any modification that
>> don't fall under the responsability of a specific component maintainer.
>>
>> However, the script get_maintainers.pl will remove "THE REST"
>> maintainers as soon as one maintainer of a specific component will be
>> present.
>>
>> Fix the script once for all.
>
> Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
>
> Although:
>
>> + # By default "THE REST" will be suppressed.
>> + my $do_not_suppress_the_rest = 0;
>
> I normally find flag variables whose names contain negations to be
> quite confusing.
I am happy to rename to "suppress_the_rest". I will send a new version.
Cheers,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-07-26 17:13 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-17 18:18 [PATCH] scripts/get_maintainers.pl: Don't blindly drop "THE REST" maintainers Julien Grall
2017-07-18 9:11 ` Andrew Cooper
2017-07-26 12:08 ` Julien Grall
2017-07-26 14:27 ` Ian Jackson
2017-07-26 17:13 ` Julien Grall
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.