[PATCH] drm/amd/display: Don't program bypass on linear regamma LUT

[PATCH] drm/amd/display: Don't program bypass on linear regamma LUT

[Harry Wentland]

Even though this is required for degamma since DCE HW only supports a
couple predefined LUTs we can just program the LUT directly for regamma.

This fixes dark screens which occurs when we program regamma to bypass
while degamma is using srgb LUT.

Signed-off-by: Harry Wentland <harry.wentland@amd.com>
---
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_color.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_color.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_color.c
index ef5fad8c5aac..e3d90e918d1b 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_color.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_color.c
@@ -139,13 +139,6 @@ int amdgpu_dm_set_regamma_lut(struct dm_crtc_state *crtc)
 	lut = (struct drm_color_lut *)blob->data;
 	lut_size = blob->length / sizeof(struct drm_color_lut);
 
-	if (__is_lut_linear(lut, lut_size)) {
-		/* Set to bypass if lut is set to linear */
-		stream->out_transfer_func->type = TF_TYPE_BYPASS;
-		stream->out_transfer_func->tf = TRANSFER_FUNCTION_LINEAR;
-		return 0;
-	}
-
 	gamma = dc_create_gamma();
 	if (!gamma)
 		return -ENOMEM;
-- 
2.17.0

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH] drm/amd/display: Don't program bypass on linear regamma LUT

[Leo Li]

On 2018-04-16 03:39 PM, Harry Wentland wrote:
> Even though this is required for degamma since DCE HW only supports a
> couple predefined LUTs we can just program the LUT directly for regamma.
> 
> This fixes dark screens which occurs when we program regamma to bypass
> while degamma is using srgb LUT.
> 
> Signed-off-by: Harry Wentland <harry.wentland@amd.com>

Thanks Harry,

Reviewed-by: Leo Li <sunpeng.li@amd.com>

> ---
>   drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_color.c | 7 -------
>   1 file changed, 7 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_color.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_color.c
> index ef5fad8c5aac..e3d90e918d1b 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_color.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_color.c
> @@ -139,13 +139,6 @@ int amdgpu_dm_set_regamma_lut(struct dm_crtc_state *crtc)
>   	lut = (struct drm_color_lut *)blob->data;
>   	lut_size = blob->length / sizeof(struct drm_color_lut);
>   
> -	if (__is_lut_linear(lut, lut_size)) {
> -		/* Set to bypass if lut is set to linear */
> -		stream->out_transfer_func->type = TF_TYPE_BYPASS;
> -		stream->out_transfer_func->tf = TRANSFER_FUNCTION_LINEAR;
> -		return 0;
> -	}
> -
>   	gamma = dc_create_gamma();
>   	if (!gamma)
>   		return -ENOMEM;
> 
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx